Split OmniboxEditController into //components- and //chrome-level classes
commit3f0c8bb4bd8b6fd918eadab160febf4871774508
authorblundell <blundell@chromium.org>
Mon, 3 Aug 2015 18:55:05 +0000 (3 11:55 -0700)
committerCommit bot <commit-bot@chromium.org>
Mon, 3 Aug 2015 18:55:53 +0000 (3 18:55 +0000)
tree82307b03ae2cd64387e648a649bdc88e68753dbe
parent804d247bcf36a83e49c672f04d11b46642c061cf
Split OmniboxEditController into //components- and //chrome-level classes

OmniboxEditController is the base class via which the rest of the omnibox
cross-platform code interacts with platform-specific implementations. As such,
it is due to be componentized and shared with iOS.

However, it also has two aspects that do not make sense for sharing with iOS:
- A GetWebContents() virtual method [//content specific]
- Knowledge of CommandUpdater [//chrome specific]

This CL splits OmniboxEditController into two:
- A //components-level class, which has the base interface minus the above-
  mentioned aspects.
- A //chrome-level class, which adds the above aspects to the base interface.

The platform-specific implementations in //chrome are changed to inherit from
ChromeOmniboxEditController.

BUG=511944

Review URL: https://codereview.chromium.org/1254173005

Cr-Commit-Position: refs/heads/master@{#341571}
23 files changed:
chrome/browser/ui/browser_focus_uitest.cc
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
chrome/browser/ui/omnibox/chrome_omnibox_client.cc
chrome/browser/ui/omnibox/chrome_omnibox_client.h
chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc [new file with mode: 0644]
chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.h [new file with mode: 0644]
chrome/browser/ui/omnibox/omnibox_controller.cc
chrome/browser/ui/omnibox/omnibox_edit_controller.cc [deleted file]
chrome/browser/ui/omnibox/omnibox_edit_model.cc
chrome/browser/ui/omnibox/omnibox_edit_unittest.cc
chrome/browser/ui/omnibox/omnibox_view.cc
chrome/browser/ui/views/location_bar/location_bar_view.cc
chrome/browser/ui/views/location_bar/location_bar_view.h
chrome/browser/ui/views/omnibox/omnibox_view_views.cc
chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
chrome/chrome_browser_ui.gypi
components/omnibox.gypi
components/omnibox/browser/BUILD.gn
components/omnibox/browser/omnibox_edit_controller.cc [new file with mode: 0644]
components/omnibox/browser/omnibox_edit_controller.h [moved from chrome/browser/ui/omnibox/omnibox_edit_controller.h with 58% similarity]