| commit | 3c803a21ef044942483510b060ba9974fb2eb8fa | |
| author | krasin <krasin@google.com> | |
| Tue, 18 Aug 2015 18:54:22 +0000 (18 11:54 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 18 Aug 2015 18:55:11 +0000 (18 18:55 +0000) | ||
| tree | 5814cf2dc15179e372b9b582d6362e73cf86c2ba | treesnapshot (tar.gz zip) |
| parent | d34f9ac72e605bc08fa1ac4607e48eeb13d98907 | commitdiff |
Fix the destruction order in chrome_launcher_unittest.
ChromeLauncherController must be deleted before ShelfItemDelegateManager,
because it has some pointers to the data owned by the item delegate manager.
This bug was found by Control Flow Integrity check,
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
BUG=chromium:516538,chromium:457523
Review URL: https://codereview.chromium.org/1295703003
Cr-Commit-Position: refs/heads/master@{#343982}
ChromeLauncherController must be deleted before ShelfItemDelegateManager,
because it has some pointers to the data owned by the item delegate manager.
This bug was found by Control Flow Integrity check,
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
BUG=chromium:516538,chromium:457523
Review URL: https://codereview.chromium.org/1295703003
Cr-Commit-Position: refs/heads/master@{#343982}
| chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc | diffblobblamehistory |