| commit | 39c62b01bacef81e1a91c219f1855b92ca18602b | |
| author | lliabraa@chromium.org <lliabraa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 11 Sep 2013 20:49:22 +0000 (11 20:49 +0000) | ||
| committer | lliabraa@chromium.org <lliabraa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 11 Sep 2013 20:49:22 +0000 (11 20:49 +0000) | ||
| tree | b07323ea2da7106067cafa019fd424877c2e73de | treesnapshot (tar.gz zip) |
| parent | 354b7abca5c7ed4e96464aa60730f7982863e126 | commitdiff |
For iOS, don't override VALID_ARCHS in Debug configuration.
When Xcode recognizes a device, it sets the active arch to the arch of
the device. Since the Debug configuration is set to only compile for the
active arch, Xcode was failing to build when an iPhone 5 was connected
because that device uses armv7s which is not in the list of VALID_ARCHS.
This CL uses the default value of VALID_ARCHS for Debug so that Xcode
will build no matter what device is connected.
This CL also moves the arch-twiddling into an OS=="ios" block to make it
clear that the configurations are only needed for iOS.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23535007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222625 0039d316-1c4b-4281-b951-d872f2087c98
When Xcode recognizes a device, it sets the active arch to the arch of
the device. Since the Debug configuration is set to only compile for the
active arch, Xcode was failing to build when an iPhone 5 was connected
because that device uses armv7s which is not in the list of VALID_ARCHS.
This CL uses the default value of VALID_ARCHS for Debug so that Xcode
will build no matter what device is connected.
This CL also moves the arch-twiddling into an OS=="ios" block to make it
clear that the configurations are only needed for iOS.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23535007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222625 0039d316-1c4b-4281-b951-d872f2087c98
| build/common.gypi | diffblobblamehistory |