Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests...
commit36c364b15726fd8c9dd05ab492ff640bfda861f4
authorthakis <thakis@chromium.org>
Sat, 30 Aug 2014 23:43:55 +0000 (30 16:43 -0700)
committerCommit bot <commit-bot@chromium.org>
Sat, 30 Aug 2014 23:46:22 +0000 (30 23:46 +0000)
tree5981f11bc463615c13bd5d5e6d7ecb6d67871a53
parent256383aa0d253e3413a295fd376d3b289d236af3
Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)

Reason for revert:
Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

InstallerStateTest.InitializeTwice (run #1):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)

InstallerStateTest.InitializeTwice (run #2):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)

Original issue's description:
> clang/win: Fix a few warnings in targets not in chromium_builder_tests.
>
> Also don't use "default" as a variable name, as it's a keyword.
> Also fix a bug where a wstring was passed to %ls.
>
> No real behavior change.
>
> BUG=82385
> R=hans@chromium.org
> TBR=cpu, vitalybuka
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09

TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/519463003

Cr-Commit-Position: refs/heads/master@{#292809}
chrome/installer/gcapi/gcapi.cc
chrome/installer/gcapi/gcapi.h
chrome/installer/gcapi/gcapi_last_run_test.cc
cloud_print/gcp20/prototype/x_privet_token.cc
cloud_print/service/win/cloud_print_service.cc
rlz/win/lib/machine_deal_test.cc
sandbox/win/sandbox_poc/pocdll/fs.cc