| commit | 3619ca8852a449d41118c6e984811ae7b75a7aa1 | |
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 9 Jul 2014 15:45:14 +0000 (9 15:45 +0000) | ||
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 9 Jul 2014 15:45:14 +0000 (9 15:45 +0000) | ||
| tree | a48250f9644dc888f4deacfced9cbf7125881191 | treesnapshot (tar.gz zip) |
| parent | 723431f4b19b84ca13e54edbcfa3d49aa53c1f02 | commitdiff |
Convert remaining WebContentsObservers loading callbacks to use RFH.
Fix several WebContentsObserver implementations that are incorrectly
caching only frame routing IDs in order to act only on that frame in
later callbacks. Frame routing IDs by themselves are not suitable for
identity comparisons, since they are only unique within a given
RenderProcessHost.
Also clean up WebContentsObservers with a redundant WebContents
field. By definition, a WebContentsObserver must know which
WebContents it's observing, so there's no need for derived classes
to maintain their own WebContents field.
BUG=none
Review URL: https://codereview.chromium.org/373623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282043 0039d316-1c4b-4281-b951-d872f2087c98
Fix several WebContentsObserver implementations that are incorrectly
caching only frame routing IDs in order to act only on that frame in
later callbacks. Frame routing IDs by themselves are not suitable for
identity comparisons, since they are only unique within a given
RenderProcessHost.
Also clean up WebContentsObservers with a redundant WebContents
field. By definition, a WebContentsObserver must know which
WebContents it's observing, so there's no need for derived classes
to maintain their own WebContents field.
BUG=none
Review URL: https://codereview.chromium.org/373623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282043 0039d316-1c4b-4281-b951-d872f2087c98
31 files changed: