| commit | 33dcb1138514fadc1d4c9769ed5899eeca814231 | |
| author | hirono <hirono@chromium.org> | |
| Wed, 4 Feb 2015 06:20:14 +0000 (3 22:20 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 4 Feb 2015 06:21:05 +0000 (4 06:21 +0000) | ||
| tree | 21910891e6e4203e473cac74d889955653c904f4 | treesnapshot (tar.gz zip) |
| parent | 073e42bb7587b90594e5799fb6a4afe08a1e1561 | commitdiff |
Fix flakiness of SelectFileDialogExtensionBrowserTest.SelectFileAndCancel.
Previously the test waits for destruction of render view host to check if the
dialog has been closed or not. But test log shows there is a race and we cannot
ensure the extension dialog has been closed even if its render view host is
closed.
The CL let the test wait for SelectionFileDialog::Listener's call instead, where
we can ensure the dialog has been closed.
BUG=453613
TEST=SelectFileDialogExtensionBrowserTest.SelectFileAndCancel
Review URL: https://codereview.chromium.org/902493002
Cr-Commit-Position: refs/heads/master@{#314510}
Previously the test waits for destruction of render view host to check if the
dialog has been closed or not. But test log shows there is a race and we cannot
ensure the extension dialog has been closed even if its render view host is
closed.
The CL let the test wait for SelectionFileDialog::Listener's call instead, where
we can ensure the dialog has been closed.
BUG=453613
TEST=SelectFileDialogExtensionBrowserTest.SelectFileAndCancel
Review URL: https://codereview.chromium.org/902493002
Cr-Commit-Position: refs/heads/master@{#314510}
| chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc | diffblobblamehistory |