Simple client side heuristics for checking username.
commit338739ef0209e8ee7941df36fd8fc25b40697fcf
authordvadym <dvadym@chromium.org>
Fri, 11 Sep 2015 13:14:08 +0000 (11 06:14 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 11 Sep 2015 13:14:56 +0000 (11 13:14 +0000)
treedc50ac59335f3a5564166c4544d0e62e979722a3
parentbd5f0ef876047d9c8d092237b6a1a64ebc3c426e
Simple client side heuristics for checking username.

Do not use text field on change password forms if it contains only small number. It's unlikely that this is username, probably it's some service information which JavaScript uses for some purpose. This will fix change password support on facebook.com.

Also this CL contains a small fix with UI bubble, namely do not to show "no username" in Save Bubble. It was already implemented for change password forms, and currently it expands this for any "no username" credentials.

BUG=530082

Review URL: https://codereview.chromium.org/1331043002

Cr-Commit-Position: refs/heads/master@{#348388}
chrome/browser/password_manager/password_manager_browsertest.cc
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
chrome/test/data/password/password_form.html
components/password_manager/core/browser/password_form_manager.cc
components/password_manager/core/browser/password_form_manager.h
components/password_manager/core/browser/password_form_manager_unittest.cc
components/password_manager/core/browser/password_manager.cc