Standardize usage of virtual/override/final specifiers.
commit30a1b15432dd20cf910f96ec35e27a94f769640e
authordcheng <dcheng@chromium.org>
Wed, 29 Oct 2014 21:27:50 +0000 (29 14:27 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 29 Oct 2014 21:28:20 +0000 (29 21:28 +0000)
treec9f5ffdb5c802fe2a26a22d499b700b49fe8f509
parent6913b7737d6124633109d6e3da31689d7ffef838
Standardize usage of virtual/override/final specifiers.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=caitkp@chromium.org

Review URL: https://codereview.chromium.org/684513002

Cr-Commit-Position: refs/heads/master@{#301931}
183 files changed:
components/autofill/content/browser/content_autofill_driver_unittest.cc
components/autofill/content/browser/request_autocomplete_manager_unittest.cc
components/autofill/content/browser/wallet/wallet_client_unittest.cc
components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc
components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
components/autofill/core/browser/autocomplete_history_manager.h
components/autofill/core/browser/autocomplete_history_manager_unittest.cc
components/autofill/core/browser/autofill_external_delegate_unittest.cc
components/autofill/core/browser/autofill_manager_unittest.cc
components/autofill/core/browser/autofill_merge_unittest.cc
components/autofill/core/browser/autofill_metrics_unittest.cc
components/autofill/core/browser/autofill_xml_parser_unittest.cc
components/autofill/core/browser/credit_card_field_unittest.cc
components/autofill/core/browser/personal_data_manager_unittest.cc
components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc
components/autofill/core/browser/webdata/autofill_table_unittest.cc
components/autofill/core/browser/webdata/web_data_service_unittest.cc
components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc
components/bookmarks/browser/bookmark_node_data_unittest.cc
components/bookmarks/browser/bookmark_utils_unittest.cc
components/captive_portal/captive_portal_detector_unittest.cc
components/component_updater/test/component_patcher_unittest.h
components/component_updater/test/component_updater_ping_manager_unittest.cc
components/component_updater/test/crx_downloader_unittest.cc
components/component_updater/test/request_sender_unittest.cc
components/component_updater/test/update_checker_unittest.cc
components/constrained_window/constrained_window_views.cc
components/constrained_window/constrained_window_views_unittest.cc
components/copresence/handlers/audio/audio_directive_handler_unittest.cc
components/copresence/handlers/audio/audio_directive_list_unittest.cc
components/copresence/mediums/audio/audio_manager_impl.h
components/copresence/mediums/audio/audio_manager_unittest.cc
components/copresence/mediums/audio/audio_player_impl.h
components/copresence/mediums/audio/audio_player_unittest.cc
components/copresence/mediums/audio/audio_recorder_impl.h
components/copresence/mediums/audio/audio_recorder_unittest.cc
components/copresence/rpc/http_post_unittest.cc
components/crash/app/breakpad_linux.cc
components/crash/browser/crash_handler_host_linux.h
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_unittest.cc
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs_unittest.cc
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc
components/dom_distiller/content/dom_distiller_viewer_source_unittest.cc
components/dom_distiller/core/distilled_content_store_unittest.cc
components/dom_distiller/core/distilled_page_prefs_unittests.cc
components/dom_distiller/core/distiller_unittest.cc
components/dom_distiller/core/distiller_url_fetcher_unittest.cc
components/dom_distiller/core/dom_distiller_service_unittest.cc
components/dom_distiller/core/dom_distiller_store_unittest.cc
components/dom_distiller/core/task_tracker_unittest.cc
components/dom_distiller/core/viewer_unittest.cc
components/dom_distiller/standalone/content_extractor.cc
components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc
components/enhanced_bookmarks/enhanced_bookmark_utils_unittest.cc
components/error_page/renderer/net_error_helper_core_unittest.cc
components/feedback/feedback_common_unittest.cc
components/feedback/feedback_uploader_unittest.cc
components/gcm_driver/gcm_account_mapper_unittest.cc
components/gcm_driver/gcm_channel_status_request_unittest.cc
components/gcm_driver/gcm_client_impl_unittest.cc
components/gcm_driver/gcm_delayed_task_controller_unittest.cc
components/gcm_driver/gcm_driver_desktop_unittest.cc
components/gcm_driver/gcm_stats_recorder_impl_unittest.cc
components/google/core/browser/google_url_tracker_unittest.cc
components/history/core/browser/url_database_unittest.cc
components/invalidation/gcm_network_channel_unittest.cc
components/invalidation/p2p_invalidator_unittest.cc
components/invalidation/push_client_channel_unittest.cc
components/invalidation/registration_manager_unittest.cc
components/invalidation/sync_invalidation_listener_unittest.cc
components/invalidation/sync_system_resources_unittest.cc
components/keyed_service/content/browser_context_dependency_manager.h
components/keyed_service/content/browser_context_keyed_base_factory.h
components/leveldb_proto/proto_database_impl_unittest.cc
components/login/screens/screen_context_unittest.cc
components/metrics/gpu/gpu_metrics_provider_unittest.cc
components/metrics/metrics_log_unittest.cc
components/metrics/metrics_reporting_scheduler_unittest.cc
components/metrics/metrics_service_unittest.cc
components/metrics/serialization/serialization_utils_unittest.cc
components/nacl/browser/nacl_file_host_unittest.cc
components/nacl/browser/nacl_validation_cache_unittest.cc
components/nacl/browser/pnacl_host_unittest.cc
components/nacl/browser/pnacl_translation_cache_unittest.cc
components/nacl/loader/nacl_ipc_adapter_unittest.cc
components/nacl/loader/nacl_validation_query_unittest.cc
components/nacl/loader/nonsfi/nonsfi_listener.h
components/nacl/loader/nonsfi/nonsfi_main.cc
components/nacl/loader/nonsfi/nonsfi_sandbox.h
components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc
components/nacl/zygote/nacl_fork_delegate_linux.h
components/navigation_interception/intercept_navigation_resource_throttle_unittest.cc
components/network_time/network_time_tracker_unittest.cc
components/omnibox/autocomplete_result_unittest.cc
components/omnibox/base_search_provider_unittest.cc
components/omnibox/keyword_provider_unittest.cc
components/os_crypt/os_crypt_unittest.cc
components/ownership/mock_owner_key_util.h
components/ownership/owner_key_util_impl.h
components/ownership/owner_key_util_impl_unittest.cc
components/ownership/owner_settings_service.h
components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
components/password_manager/content/renderer/credential_manager_client_browsertest.cc
components/password_manager/core/browser/login_database_unittest.cc
components/password_manager/core/browser/password_autofill_manager_unittest.cc
components/password_manager/core/browser/password_form_manager_unittest.cc
components/password_manager/core/browser/password_generation_manager_unittest.cc
components/password_manager/core/browser/password_manager_unittest.cc
components/password_manager/core/browser/password_store_default_unittest.cc
components/password_manager/core/browser/password_store_unittest.cc
components/policy/core/browser/configuration_policy_pref_store_test.h
components/policy/core/browser/configuration_policy_pref_store_unittest.cc
components/policy/core/browser/managed_bookmarks_tracker_unittest.cc
components/policy/core/common/async_policy_provider_unittest.cc
components/policy/core/common/cloud/cloud_policy_core_unittest.cc
components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc
components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc
components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc
components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc
components/policy/core/common/cloud/external_policy_data_updater_unittest.cc
components/policy/core/common/cloud/policy_header_io_helper_unittest.cc
components/policy/core/common/cloud/policy_header_service_unittest.cc
components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc
components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc
components/policy/core/common/config_dir_policy_loader_unittest.cc
components/policy/core/common/configuration_policy_provider_test.h
components/policy/core/common/forwarding_policy_provider_unittest.cc
components/policy/core/common/policy_statistics_collector_unittest.cc
components/precache/content/precache_manager_unittest.cc
components/precache/core/precache_database_unittest.cc
components/precache/core/precache_url_table_unittest.cc
components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc
components/renderer_context_menu/views/toolkit_delegate_views.h
components/search/search_unittest.cc
components/search_engines/default_search_manager_unittest.cc
components/search_engines/default_search_policy_handler_unittest.cc
components/search_engines/search_host_to_urls_map_unittest.cc
components/search_engines/template_url_fetcher_unittest.cc
components/search_engines/template_url_parser_unittest.cc
components/search_engines/template_url_prepopulate_data_unittest.cc
components/search_engines/template_url_service_sync_unittest.cc
components/search_engines/template_url_service_unittest.cc
components/search_provider_logos/logo_cache_unittest.cc
components/sessions/content/content_serialized_navigation_driver.h
components/signin/core/browser/account_tracker_service_unittest.cc
components/signin/core/browser/mutable_profile_oauth2_token_service_unittest.cc
components/signin/core/browser/signin_error_controller_unittest.cc
components/signin/core/browser/webdata/token_service_table_unittest.cc
components/storage_monitor/media_storage_util_unittest.cc
components/storage_monitor/media_transfer_protocol_device_observer_linux.h
components/storage_monitor/media_transfer_protocol_device_observer_linux_unittest.cc
components/storage_monitor/storage_monitor_linux.h
components/storage_monitor/storage_monitor_linux_unittest.cc
components/storage_monitor/test_media_transfer_protocol_manager_linux.h
components/storage_monitor/test_storage_monitor.h
components/suggestions/blacklist_store_unittest.cc
components/suggestions/image_manager_unittest.cc
components/suggestions/suggestions_service_unittest.cc
components/suggestions/suggestions_store_unittest.cc
components/sync_driver/data_type_manager_impl_unittest.cc
components/sync_driver/device_info_data_type_controller_unittest.cc
components/sync_driver/device_info_sync_service_unittest.cc
components/sync_driver/generic_change_processor_unittest.cc
components/sync_driver/non_blocking_data_type_controller_unittest.cc
components/sync_driver/non_ui_data_type_controller_unittest.cc
components/sync_driver/sync_prefs_unittest.cc
components/sync_driver/ui_data_type_controller_unittest.cc
components/timers/alarm_timer.h
components/translate/core/browser/translate_script_unittest.cc
components/user_manager/empty_user_info.h
components/user_manager/user_info_impl.h
components/variations/net/variations_http_header_provider_unittest.cc
components/variations/variations_associated_data_unittest.cc
components/variations/variations_seed_processor_unittest.cc
components/variations/variations_seed_simulator_unittest.cc
components/visitedlink/test/visitedlink_perftest.cc
components/visitedlink/test/visitedlink_unittest.cc
components/web_modal/web_contents_modal_dialog_manager_unittest.cc
components/webdata/common/web_database_migration_unittest.cc