| commit | 2f5c6cafb187ea63f5edd2314280dd66bc5d7855 | |
| author | vabr <vabr@chromium.org> | |
| Wed, 5 Nov 2014 11:53:26 +0000 (5 03:53 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 5 Nov 2014 11:53:43 +0000 (5 11:53 +0000) | ||
| tree | 5c8b0798efdae596b994fbf1421ff08a4baa5477 | treesnapshot (tar.gz zip) |
| parent | 72eaef099698d09dbf9f3fe3cf5de2e98259239e | commitdiff |
Reland "Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions"
This is a reland of https://codereview.chromium.org/688633004.
Patch set 1 here = the landed patch set (2) of the relanded CL, just automatically rebased on ToT
Patch set 2 here = fix of the crash, as outlined in http://crbug.com/429607#c7
Patch set 3 here = Comments from jww@ (https://codereview.chromium.org/688633004#msg12) addressed
Original CL description:
****************************************************************
Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.
But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.
This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.
****************************************************************
BUG=429607, 400186, 377422, 118601
TBR=gcasto@chromium.org,jww@chromium.org
Review URL: https://codereview.chromium.org/701073002
Cr-Commit-Position: refs/heads/master@{#302781}
This is a reland of https://codereview.chromium.org/688633004.
Patch set 1 here = the landed patch set (2) of the relanded CL, just automatically rebased on ToT
Patch set 2 here = fix of the crash, as outlined in http://crbug.com/429607#c7
Patch set 3 here = Comments from jww@ (https://codereview.chromium.org/688633004#msg12) addressed
Original CL description:
****************************************************************
Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.
But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.
This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.
****************************************************************
BUG=429607, 400186, 377422, 118601
TBR=gcasto@chromium.org,jww@chromium.org
Review URL: https://codereview.chromium.org/701073002
Cr-Commit-Position: refs/heads/master@{#302781}