Revert 256580 "This CL adds methods to manipulate RTP header ext..."
commit2ebbe125d9513a73981fe78645f132c243fbe2d2
authorcpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 12 Mar 2014 18:42:00 +0000 (12 18:42 +0000)
committercpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 12 Mar 2014 18:42:00 +0000 (12 18:42 +0000)
treeb74f684dcf9715b2fc9e203f43b36eea1cce92d9
parenta8030a22c88436615550267e26b539382dd5fe8b
Revert 256580 "This CL adds methods to manipulate RTP header ext..."

This made the Asan bot unhappy

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BLSan%20Tests%20%282%29&number=396

P2PSocketHostTest.TestInvalidTurnChannelMessages (run #1):
[ RUN      ] P2PSocketHostTest.TestInvalidTurnChannelMessages
=================================================================
==13684==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000cc54404 at pc 0x278fe5c bp 0x7fff34be4350 sp 0x7fff34be4348
READ of size 1 at 0x00000cc54404 thread T0
    #0 0x278fe5b in IsRtpPacket content/browser/renderer_host/p2p/socket_host.cc:54
    #1 0x278fe5b in content::packet_processing_helpers::GetRtpPacketStartPositionAndLength(char*, int, int*, int*) content/browser/renderer_host/p2p/socket_host.cc:304
    #2 0x1f5a542 in content::P2PSocketHostTest_TestInvalidTurnChannelMessages_Test::TestBody() content/browser/renderer_host/p2p/socket_host_unittest.cc:208
    #3 0x2c38e7a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #4 0x2c38e7a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #5 0x2c3afca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #6 0x2c3bd93 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #7 0x2c4ce4a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #8 0x2c4c430 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #9 0x2c4c430 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #10 0x2bcad1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #11 0x2bcad1c in base::TestSuite::Run() base/test/test_suite.cc:213
    #12 0x2bbebbb in Run base/callback.h:401
    #13 0x2bbebbb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #14 0x198401e in main content/test/run_all_unittests.cc:14
    #15 0x7f28c9fa576c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226
    #16 0x4b322c in _start (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x4b322c)

0x00000cc54404 is located 60 bytes to the left of global variable 'kRtpMsgWith2ByteExtnHeader' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54440) of size 20
0x00000cc54404 is located 0 bytes to the right of global variable 'kTurnChannelMsgWithZeroLength' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54400) of size 4
SUMMARY: AddressSanitizer: global-buffer-overflow content/browser/renderer_host/p2p/socket_host.cc:54 IsRtpPacket
Shadow bytes around the buggy address:
  0x000081982830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x000081982840: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x000081982850: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
  0x000081982860: 00 00 04 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9
  0x000081982870: 00 00 00 04 f9 f9 f9 f9 00 f9 f9 f9 f9 f9 f9 f9
=>0x000081982880:[04]f9 f9 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9
  0x000081982890: 00 00 00 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9
  0x0000819828a0: f9 f9 f9 f9 00 00 00 00 00 00 00 f9 f9 f9 f9 f9
  0x0000819828b0: 00 00 f9 f9 f9 f9 f9 f9 00 00 00 f9 f9 f9 f9 f9
  0x0000819828c0: 03 f9 f9 f9 f9 f9 f9 f9 00 00 05 f9 f9 f9 f9 f9
  0x0000819828d0: 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00

> This CL adds methods to manipulate RTP header extension, particularly
> AbsoulteSendTime extension. If there is matching extension ID present
> in RTP packet, we will update with the current time.
>
> R=solenberg@chromium.org, juberti@chromium.org, sergeyu@chromium.org
>
> BUG=
>
> Review URL: https://codereview.chromium.org/159353002

TBR=mallinath@chromium.org

Review URL: https://codereview.chromium.org/197933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256584 0039d316-1c4b-4281-b951-d872f2087c98
content/browser/renderer_host/p2p/socket_host.cc
content/browser/renderer_host/p2p/socket_host.h
content/browser/renderer_host/p2p/socket_host_tcp.cc
content/browser/renderer_host/p2p/socket_host_tcp.h
content/browser/renderer_host/p2p/socket_host_udp.cc
content/browser/renderer_host/p2p/socket_host_unittest.cc [deleted file]
content/content_tests.gypi
third_party/libjingle/libjingle.gyp