| commit | 2ea9490c373bdf90284814d57b694bae2dc1a948 | |
| author | bzanotti <bzanotti@chromium.org> | |
| Tue, 26 May 2015 17:40:38 +0000 (26 10:40 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 26 May 2015 17:41:11 +0000 (26 17:41 +0000) | ||
| tree | ecc44725497fd33026e899ed243daf537b3c6136 | treesnapshot (tar.gz zip) |
| parent | d621865988ad21c28cf0542a129444324c759935 | commitdiff |
Refactoring of GaiaAuthFetcher
CreateGaiaFetcher is systematically used in the same way. This CL
changes the method into CreateAndStartGaiaFetcher that also starts the
created fetcher.
The dispatching of fetched requests is also uncoupled from the
net::URLFetcher callback.
This refactoring allows subclasses of GaiaAuthFetcher to stop depending
on net::URLFetcher and use their own mechanism for network requests.
This is achieved by simply overriding CreateAndStartGaiaFetcher and
calling DispatchFetchedRequest directly.
BUG=
Review URL: https://codereview.chromium.org/1156913003
Cr-Commit-Position: refs/heads/master@{#331389}
CreateGaiaFetcher is systematically used in the same way. This CL
changes the method into CreateAndStartGaiaFetcher that also starts the
created fetcher.
The dispatching of fetched requests is also uncoupled from the
net::URLFetcher callback.
This refactoring allows subclasses of GaiaAuthFetcher to stop depending
on net::URLFetcher and use their own mechanism for network requests.
This is achieved by simply overriding CreateAndStartGaiaFetcher and
calling DispatchFetchedRequest directly.
BUG=
Review URL: https://codereview.chromium.org/1156913003
Cr-Commit-Position: refs/heads/master@{#331389}
| google_apis/gaia/gaia_auth_fetcher.cc | diffblobblamehistory | |
| google_apis/gaia/gaia_auth_fetcher.h | diffblobblamehistory |