| commit | 29b787f010e8e53cf0f473dbe52c6a17da476391 | |
| author | droger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 11 Feb 2014 20:02:18 +0000 (11 20:02 +0000) | ||
| committer | droger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 11 Feb 2014 20:02:18 +0000 (11 20:02 +0000) | ||
| tree | e49d0c28d22f8c5f46aca68dac142abe2e596599 | treesnapshot (tar.gz zip) |
| parent | 0d97e147adaf3ba0e258921808a016e40a1a0898 | commitdiff |
Refactor TranslateAcceptLanguages as a BrowserContextKeyedService
This CL refactors TranslateAcceptLanguages as a BrowserContextKeyedService,
and moves it into the Translate component.
The choice of BrowserContextKeyedService seems obvious since there is one
accept languages list per profile.
The existing code is simplified, since the handling of profiles and notifications
is deferred to the BrowserContextKeyedService code and can be removed.
Note that there is now one TranslateAcceptLanguages instance per profile (it
was a singleton owned by TranslateManager previously).
BUG=335076
Review URL: https://codereview.chromium.org/149753006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250480 0039d316-1c4b-4281-b951-d872f2087c98
This CL refactors TranslateAcceptLanguages as a BrowserContextKeyedService,
and moves it into the Translate component.
The choice of BrowserContextKeyedService seems obvious since there is one
accept languages list per profile.
The existing code is simplified, since the handling of profiles and notifications
is deferred to the BrowserContextKeyedService code and can be removed.
Note that there is now one TranslateAcceptLanguages instance per profile (it
was a singleton owned by TranslateManager previously).
BUG=335076
Review URL: https://codereview.chromium.org/149753006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250480 0039d316-1c4b-4281-b951-d872f2087c98
13 files changed: