Revert 210950 "Revert 210945 "Misc. cleanup:""
commit28b05ef0bb80c9d2598585fd9d623432620252a0
authorcpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 10 Jul 2013 22:28:32 +0000 (10 22:28 +0000)
committercpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 10 Jul 2013 22:28:32 +0000 (10 22:28 +0000)
tree4f5d7594be802896206207197c09888dbf973322
parent5d39f4be80b957ae98f3a7315d575f0103dae8fb
Revert 210950 "Revert 210945 "Misc. cleanup:""

Didn't see a fix checked in aftert the failure.

> Revert 210945 "Misc. cleanup:"
>
> Broke
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/47879
>
>
> > Misc. cleanup:
> >
> > * Remove unneeded #include
> > * Shorten/simplify code
> > * Avoid non-const refs (use pointers instead)
> > * Explicitly declare destructors
> > * Avoid using type names ("set") in typedefs
> > * In debugger_api.cc, scope helpers privately to the specific class that uses
> >   them, since the file is huge and the many classes make usage of file-scope
> >   functions less clear
> > * #if-guard a member that's only used by views
> >
> > BUG=none
> > TEST=none
> > R=mpcomplete@chromium.org
> >
> > Review URL: https://codereview.chromium.org/18402008
>
> TBR=pkasting@chromium.org
>
> Review URL: https://codereview.chromium.org/18293018

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/18467014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210951 0039d316-1c4b-4281-b951-d872f2087c98
chrome/browser/extensions/api/debugger/debugger_api.cc
chrome/browser/extensions/extension_infobar_delegate.cc
chrome/browser/extensions/extension_infobar_delegate.h
chrome/browser/extensions/tab_helper.cc
chrome/browser/extensions/theme_installed_infobar_delegate.cc