| commit | 2894a51ff90c782801890c921cf0da83f08477ec | |
| author | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 26 Jun 2014 19:03:56 +0000 (26 19:03 +0000) | ||
| committer | rdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 26 Jun 2014 19:03:56 +0000 (26 19:03 +0000) | ||
| tree | 858f98e99f3247a87a79c92da044a7ffa479bdea | treesnapshot (tar.gz zip) |
| parent | fe8d3628a9662d55fbb90d958cb535f652eff650 | commitdiff |
Resubmit: Refactor external_install_ui
Third time's the charm.
Previous: https://codereview.chromium.org/309643007/
---------------------------
Refactors ExternalInstallUI to have determinate lifetimes.
This is likely the first of multiple patches targeting this area of code; the
next one will concentrate on pulling the related logic out of ExtensionService.
Adds unittests for accepting/declining external installs.
BUG=378042
Review URL: https://codereview.chromium.org/315903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280067 0039d316-1c4b-4281-b951-d872f2087c98
Third time's the charm.
Previous: https://codereview.chromium.org/309643007/
---------------------------
Refactors ExternalInstallUI to have determinate lifetimes.
This is likely the first of multiple patches targeting this area of code; the
next one will concentrate on pulling the related logic out of ExtensionService.
Adds unittests for accepting/declining external installs.
BUG=378042
Review URL: https://codereview.chromium.org/315903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280067 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/extensions/extension_service.cc | diffblobblamehistory | |
| chrome/browser/extensions/extension_service.h | diffblobblamehistory | |
| chrome/browser/extensions/extension_service_unittest.cc | diffblobblamehistory | |
| chrome/browser/extensions/external_install_error.cc | [new file with mode: 0644] | blob |
| chrome/browser/extensions/external_install_error.h | [new file with mode: 0644] | blob |
| chrome/browser/extensions/external_install_manager.cc | [new file with mode: 0644] | blob |
| chrome/browser/extensions/external_install_manager.h | [new file with mode: 0644] | blob |
| chrome/browser/extensions/external_install_ui.cc | [deleted file] | blobblamehistory |
| chrome/browser/extensions/external_install_ui.h | [deleted file] | blobblamehistory |
| chrome/chrome_browser_extensions.gypi | diffblobblamehistory |