| commit | 283f0a5701a15772af2d2103bf52010e4b3cf999 | |
| author | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 13 Jun 2014 00:53:13 +0000 (13 00:53 +0000) | ||
| committer | tdanderson@chromium.org <tdanderson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 13 Jun 2014 00:53:13 +0000 (13 00:53 +0000) | ||
| tree | ed5449c7ac31955edec497d7aeb52292de2e0824 | treesnapshot (tar.gz zip) |
| parent | 45c6f6872735c63916e122feba77523f3904e169 | commitdiff |
Views which cannot process events cannot be tooltip targets
The check for CanProcessEventsWithinSubtree() needs
to be made on |this| before the loop (along with
HitTestRect()) instead of inside the loop on the
children. Otherwise it would be possible to return
a view for which CanProcessEventsWithinSubtree()
returns false.
BUG=382873, 378530
TEST=Added coverage in ViewTest.CanProcessEventsWithinSubtree
Review URL: https://codereview.chromium.org/327843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276873 0039d316-1c4b-4281-b951-d872f2087c98
The check for CanProcessEventsWithinSubtree() needs
to be made on |this| before the loop (along with
HitTestRect()) instead of inside the loop on the
children. Otherwise it would be possible to return
a view for which CanProcessEventsWithinSubtree()
returns false.
BUG=382873, 378530
TEST=Added coverage in ViewTest.CanProcessEventsWithinSubtree
Review URL: https://codereview.chromium.org/327843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276873 0039d316-1c4b-4281-b951-d872f2087c98
| ui/views/view.cc | diffblobblamehistory | |
| ui/views/view_unittest.cc | diffblobblamehistory |