| commit | 28274b27a18a29c8a5d3bdda150f3c47e6a28584 | |
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | |
| Fri, 20 Feb 2015 01:07:21 +0000 (19 17:07 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 20 Feb 2015 01:08:08 +0000 (20 01:08 +0000) | ||
| tree | 9ce60dbb42bf5a6b33ed22b6fb32facea1430bef | treesnapshot (tar.gz zip) |
| parent | 9b589eef280cf8ca934903d0613157ad8b5c0379 | commitdiff |
Revert of Add more targets to "gn check" (patchset #3 id:40001 of https://codereview.chromium.org/940613002/)
Reason for revert:
This broken win8 gn bots because of an illegal include.
ERROR at //device/usb/usb_service_impl.cc:21:11: Include not allowed.
#include "device/core/device_monitor_win.h"
e.g.
https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4896/steps/gn%20check/logs/stdio
Original issue's description:
> Add more targets to "gn check"
>
> R=dpranke
> TBR=armansito@chromium.org (bluetooth)
>
> Committed: https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac
> Cr-Commit-Position: refs/heads/master@{#317160}
TBR=dpranke@chromium.org,armansito@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/941893002
Cr-Commit-Position: refs/heads/master@{#317204}
Reason for revert:
This broken win8 gn bots because of an illegal include.
ERROR at //device/usb/usb_service_impl.cc:21:11: Include not allowed.
#include "device/core/device_monitor_win.h"
e.g.
https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4896/steps/gn%20check/logs/stdio
Original issue's description:
> Add more targets to "gn check"
>
> R=dpranke
> TBR=armansito@chromium.org (bluetooth)
>
> Committed: https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac
> Cr-Commit-Position: refs/heads/master@{#317160}
TBR=dpranke@chromium.org,armansito@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/941893002
Cr-Commit-Position: refs/heads/master@{#317204}