Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (patchset...
commit27be78b94c43bb98d5b1cbd2cc1a4816872596ad
authorrdevlin.cronin <rdevlin.cronin@chromium.org>
Wed, 22 Oct 2014 19:20:06 +0000 (22 12:20 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 22 Oct 2014 19:20:29 +0000 (22 19:20 +0000)
tree23d9aff45e7b03fab445befb489381024a9480d0
parente488fae2874552fbc0dafc3d49dcbb486ac9c12f
Revert of [DevTools] Migrate DevToolsTracingHandler to generated handler. (patchset #6 id:130001 of https://codereview.chromium.org/635733003/)

Reason for revert:
Broke compile, e.g. obj/content/gen/content/browser/devtools/protocol/content_browser.devtools_protocol_handler_impl.o
gen/content/browser/devtools/protocol/devtools_protocol_handler_impl.cc:951:7: error: no viable conversion from 'std::string' (aka 'basic_string<char>') to 'const std::string *' (aka 'const basic_string<char> *')
      in_categories,
      ^~~~~~~~~~~~~
../../content/browser/devtools/protocol/tracing_handler.h:40:26: note: passing argument to parameter 'categories' here
      const std::string* categories,
                         ^
1 error generated.
ninja: build stopped: subcommand failed.

Original issue's description:
> [DevTools] Migrate DevToolsTracingHandler to generated handler.
>
> This patch also adds SendRawMessage, which is used for performance
> in tracing handler.
>
> BUG=405566
>
> Committed: https://crrev.com/f7762cb9261c8e2e15f2cf2b36f5408c75d72bdd
> Cr-Commit-Position: refs/heads/master@{#300711}

TBR=caseq@chromium.org,vkuzkokov@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405566

Review URL: https://codereview.chromium.org/675473005

Cr-Commit-Position: refs/heads/master@{#300726}
12 files changed:
content/browser/devtools/devtools_http_handler_impl.cc
content/browser/devtools/devtools_protocol.h
content/browser/devtools/devtools_tracing_handler.cc [new file with mode: 0644]
content/browser/devtools/devtools_tracing_handler.h [copied from content/browser/devtools/protocol/tracing_handler.h with 53% similarity]
content/browser/devtools/protocol/devtools_protocol_client.cc
content/browser/devtools/protocol/devtools_protocol_client.h
content/browser/devtools/protocol/devtools_protocol_handler_generator.py
content/browser/devtools/protocol/tracing_handler.cc
content/browser/devtools/protocol/tracing_handler.h
content/browser/devtools/render_view_devtools_agent_host.cc
content/browser/devtools/render_view_devtools_agent_host.h
content/content_browser.gypi