| commit | 26b57c28c3d5d0b540095a0e081bf303163ea76b | |
| author | brucedawson <brucedawson@chromium.org> | |
| Wed, 5 Nov 2014 21:56:56 +0000 (5 13:56 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 5 Nov 2014 21:57:13 +0000 (5 21:57 +0000) | ||
| tree | 33af12ba3cd7f6296c42c58c9cd1c97ac14b097e | treesnapshot (tar.gz zip) |
| parent | 8290aa0050bc527c740ae84e0267f79abc9cb0ce | commitdiff |
Fixed detection of WS_OVERLAPPED windows, bug introduced in change 6561311.
WS_OVERLAPPED is not a flag, it is zero. Code was added that detects it
as a flag, using '&'. This bug was detected by VC++'s /analyze, giving
this warning:
src\ui\views\win\hwnd_message_handler.cc(874) : warning C6313:
Incorrect operator: zero-valued flag cannot be tested with bitwise-and.
BUG=427616
Review URL: https://codereview.chromium.org/706643002
Cr-Commit-Position: refs/heads/master@{#302880}
WS_OVERLAPPED is not a flag, it is zero. Code was added that detects it
as a flag, using '&'. This bug was detected by VC++'s /analyze, giving
this warning:
src\ui\views\win\hwnd_message_handler.cc(874) : warning C6313:
Incorrect operator: zero-valued flag cannot be tested with bitwise-and.
BUG=427616
Review URL: https://codereview.chromium.org/706643002
Cr-Commit-Position: refs/heads/master@{#302880}
| ui/views/win/hwnd_message_handler.cc | diffblobblamehistory |