| commit | 1ea0de3d15fbfc0018ebf473f4d77787d6420c41 | |
| author | dmichael <dmichael@chromium.org> | |
| Fri, 26 Sep 2014 21:10:12 +0000 (26 14:10 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 26 Sep 2014 21:10:28 +0000 (26 21:10 +0000) | ||
| tree | 4a67846079e800b207fec975ed8963aa2361455e | treesnapshot (tar.gz zip) |
| parent | b308a1ce85cf3206b10c9e896a2478608a80295b | commitdiff |
Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #5 id:80001 of https://codereview.chromium.org/589213003/)
Reason for revert:
Still causing a crash in Canary
Original issue's description:
> PPAPI: Never re-enter JavaScript for PostMessage.
>
> Blocking renderer->plugin messages can be interrupted by any message
> from the plugin->renderer (even async ones). So while handline a blocking
> message, such as HandleInputEvent or HandleBlockingMessage, it's currently
> possible to re-enter JavaScript. This patch makes that impossible by
> queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
> while any renderer->plugin sync message is on the stack.
>
> BUG=384528
>
> Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
> Cr-Commit-Position: refs/heads/master@{#296311}
>
> Committed: https://crrev.com/3fe4ceee750b2cd130bd402de3d371d8518c3eba
> Cr-Commit-Position: refs/heads/master@{#296807}
TBR=raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384528
Review URL: https://codereview.chromium.org/605393002
Cr-Commit-Position: refs/heads/master@{#297030}
Reason for revert:
Still causing a crash in Canary
Original issue's description:
> PPAPI: Never re-enter JavaScript for PostMessage.
>
> Blocking renderer->plugin messages can be interrupted by any message
> from the plugin->renderer (even async ones). So while handline a blocking
> message, such as HandleInputEvent or HandleBlockingMessage, it's currently
> possible to re-enter JavaScript. This patch makes that impossible by
> queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
> while any renderer->plugin sync message is on the stack.
>
> BUG=384528
>
> Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
> Cr-Commit-Position: refs/heads/master@{#296311}
>
> Committed: https://crrev.com/3fe4ceee750b2cd130bd402de3d371d8518c3eba
> Cr-Commit-Position: refs/heads/master@{#296807}
TBR=raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384528
Review URL: https://codereview.chromium.org/605393002
Cr-Commit-Position: refs/heads/master@{#297030}
12 files changed: