Revert 239759 "The comment in base64.h implies that base::Base64..."
commit1d4b7c7ca38a12faaf5b8878428f57b4896c1496
authorvadimt@chromium.org <vadimt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 11 Dec 2013 00:03:33 +0000 (11 00:03 +0000)
committervadimt@chromium.org <vadimt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 11 Dec 2013 00:03:33 +0000 (11 00:03 +0000)
tree0292489017b8ce80fab92daf4dafe2f4a54fbd3e
parent9a07c2959da5398a6dd9176e1bbf31f6ab6dc89a
Revert 239759 "The comment in base64.h implies that base::Base64..."

> The comment in base64.h implies that base::Base64Encode() can return false, but
> this cannot happen in practice. Fix the comment.
>
> The implementation of Base64Encode() attempts to check for the return value
> MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> value. Remove the check.
>
> Remove unneeded integer cast.
>
> Change the return type to void.
>
> BUG=323357
> TEST=base_unittests, compile all
> TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
>
> Review URL: https://codereview.chromium.org/86913002

TBR=ricea@chromium.org

Review URL: https://codereview.chromium.org/101113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239921 0039d316-1c4b-4281-b951-d872f2087c98
65 files changed:
base/base64.cc
base/base64.h
base/base64_unittest.cc
chrome/browser/bookmarks/bookmark_html_writer.cc
chrome/browser/chromeos/settings/device_settings_cache.cc
chrome/browser/devtools/adb/android_rsa.cc
chrome/browser/extensions/api/developer_private/developer_private_api.cc
chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
chrome/browser/extensions/api/extension_action/extension_action_api.cc
chrome/browser/extensions/api/identity/web_auth_flow.cc
chrome/browser/extensions/api/networking_private/networking_private_service_client.cc
chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
chrome/browser/extensions/extension_protocols.cc
chrome/browser/extensions/install_signer.cc
chrome/browser/internal_auth.cc
chrome/browser/managed_mode/managed_user_registration_utility.cc
chrome/browser/media/desktop_streams_registry.cc
chrome/browser/metrics/metrics_log.cc
chrome/browser/metrics/metrics_log_serializer.cc
chrome/browser/metrics/variations/variations_http_header_provider.cc
chrome/browser/metrics/variations/variations_service.cc
chrome/browser/metrics/variations/variations_service_unittest.cc
chrome/browser/sync/profile_sync_service_harness.cc
chrome/browser/ui/ash/screenshot_taker.cc
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
chrome/browser/ui/certificate_dialogs.cc
chrome/browser/ui/webui/print_preview/print_preview_handler.cc
chrome/common/metrics/caching_permuted_entropy_provider.cc
chrome/test/chromedriver/chrome_launcher.cc
chrome/test/chromedriver/chrome_launcher_unittest.cc
chrome/test/chromedriver/net/websocket.cc
components/policy/core/common/cloud/resource_cache.cc
content/browser/devtools/renderer_overrides_handler.cc
content/common/page_state_serialization_unittest.cc
content/shell/browser/webkit_test_controller.cc
content/shell/renderer/webkit_test_runner.cc
extensions/common/extension.cc
google_apis/cup/client_update_protocol.cc
google_apis/gaia/oauth_request_signer.cc
jingle/notifier/listener/push_notifications_send_update_task.cc
jingle/notifier/listener/push_notifications_send_update_task_unittest.cc
net/base/keygen_handler_win.cc
net/cert/x509_certificate.cc
net/http/http_auth_gssapi_posix.cc
net/http/http_auth_handler_basic.cc
net/http/http_auth_handler_ntlm.cc
net/http/http_auth_sspi_win.cc
net/test/spawned_test_server/base_test_server.cc
net/third_party/mozilla_security_manager/nsKeygenHandler.cpp
net/websockets/websocket_basic_handshake_stream.cc
net/websockets/websocket_handshake_handler.cc
remoting/base/rsa_key_pair.cc
remoting/host/pin_hash.cc
remoting/host/token_validator_factory_impl.cc
remoting/protocol/auth_util.cc
remoting/protocol/authenticator_test_base.cc
remoting/protocol/pairing_registry.cc
remoting/protocol/v2_authenticator.cc
sync/internal_api/public/base/unique_position_unittest.cc
sync/internal_api/sync_encryption_handler_impl.cc
sync/protocol/proto_value_conversions.cc
sync/syncable/syncable_util.cc
sync/tools/null_invalidation_state_tracker.cc
sync/util/cryptographer.cc
sync/util/nigori.cc