Android infobar cleanup:
commit1c31e29c9a6f257ee3130fae93ae21968d71c881
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 22 Nov 2013 00:02:56 +0000 (22 00:02 +0000)
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 22 Nov 2013 00:02:56 +0000 (22 00:02 +0000)
treedacf9dbb89d79bec97aaa99d3a75154a89cb7de6
parent813309539da53c41e84e19d2ecec4c67a3953b28
Android infobar cleanup:

* Don't return values callers don't use
* Rename a temp in anticipation of refactor patch
* Use Pass() where PassAs<>() is not necessary
* Minor comment/whitespace changes
* Don't NULL-check web_contents() when we're owned (should never be NULL)
* Don't bother storing delegate pointers on infobar subclasses, just downcast
  the base class' pointer (matches other platforms)
* Remove unnecessary DCHECKs (either other code performs them or they will no
  longer be necesssary in the refactored world)
* Remove unnecessary temps
* Speed up vector manipulation by not creating a bunch of objects we then
  overwrite
* DCHECK(expected, actual)

BUG=none
TEST=none
R=miguelg@chromium.org

Review URL: https://codereview.chromium.org/77773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236640 0039d316-1c4b-4281-b951-d872f2087c98
chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc
chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h
chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc
chrome/browser/ui/android/infobars/confirm_infobar.cc
chrome/browser/ui/android/infobars/confirm_infobar.h
chrome/browser/ui/android/infobars/infobar_android.cc
chrome/browser/ui/android/infobars/infobar_android.h
chrome/browser/ui/android/infobars/infobar_container_android.cc
chrome/browser/ui/android/infobars/translate_infobar.cc
chrome/browser/ui/android/infobars/translate_infobar.h