Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug
commit1b4ec385671074ce4b857344acc11346c1f2da47
authorjvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 7 Mar 2014 02:32:24 +0000 (7 02:32 +0000)
committerjvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 7 Mar 2014 02:32:24 +0000 (7 02:32 +0000)
tree89f20f56428dd0d359c94a53f7a5f3e10c09ec44
parenteea0e65bde30b8aa4d2719c66804f2c1a8c347f1
Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug

Debug metadata is not part of the PNaCl stable bitcode format
so is stripped before deployment. In order to make debugging
easier (no separate translation), allow a separate debug URL
in the NMF file which can point to the unstripped
LLVM-formatted pexe which should still have debug metadata.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765
TEST=browser_tests --gtest_filter=*PnaclDebugURL

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254212

R=bradnelson@chromium.org, bradnelson@google.com, dmichael@chromium.org

Review URL: https://codereview.chromium.org/181153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255499 0039d316-1c4b-4281-b951-d872f2087c98
16 files changed:
chrome/browser/chrome_content_browser_client.cc
chrome/test/data/nacl/nacl_test_data.gyp
chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html [new file with mode: 0644]
chrome/test/data/nacl/pnacl_debug_url/pnacl_has_debug.nmf [new file with mode: 0644]
chrome/test/data/nacl/pnacl_debug_url/pnacl_has_debug_flag_off.nmf [new file with mode: 0644]
chrome/test/data/nacl/pnacl_debug_url/pnacl_no_debug.nmf [new file with mode: 0644]
chrome/test/nacl/nacl_browsertest.cc
components/nacl/renderer/ppb_nacl_private_impl.cc
ppapi/api/private/ppb_nacl_private.idl
ppapi/c/private/ppb_nacl_private.h
ppapi/native_client/src/trusted/plugin/json_manifest.cc
ppapi/native_client/src/trusted/plugin/json_manifest.h
ppapi/native_client/src/trusted/plugin/plugin.cc
ppapi/native_client/src/trusted/plugin/pnacl_options.cc
ppapi/native_client/src/trusted/plugin/pnacl_options.h
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c