Use EXPECT_FALSE instead of EXPECT_EQ for comparing false
commit1b1e6a36deac29e74ca8b04e4d679542758d015c
authorvivek.vg@samsung.com <vivek.vg@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 14 Aug 2014 15:12:02 +0000 (14 15:12 +0000)
committervivek.vg@samsung.com <vivek.vg@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 14 Aug 2014 15:13:24 +0000 (14 15:13 +0000)
tree206e03aa2bd029dfde7c252290dc5d28c1e85a4c
parentf612609d2e8eb16da48252374dfd692738e2cd4d
Use EXPECT_FALSE instead of EXPECT_EQ for comparing false

Using EXPECT_EQ(false, condition_expr) assertion gets the following error with gcc 4.8.x toolchain on linux
when building unit test:

error: converting ‘false’ to pointer type for argument 1 of ‘char testing::
internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null]

It is a mysterious problem occurred in gtest. Only EXPECT_EQ(false, condition_expr) cause the compile error, while EXPECT_EQ(true, condition_expr) can work well.

BUG=139326
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/474773003

Cr-Commit-Position: refs/heads/master@{#289586}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289586 0039d316-1c4b-4281-b951-d872f2087c98
components/copresence/handlers/audio/audio_directive_handler_unittest.cc