| commit | 1aabf094f4abea01c44d60c22a05cbf9230bfcee | |
| author | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sun, 26 May 2013 03:24:51 +0000 (26 03:24 +0000) | ||
| committer | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sun, 26 May 2013 03:24:51 +0000 (26 03:24 +0000) | ||
| tree | 4266b2a6292658f46ab1de8f818d450cdc6f4194 | treesnapshot (tar.gz zip) |
| parent | 1fb9e7ebc8d70d2cccd621f88c1653c8d66d0e2c | commitdiff |
Revert 202152 "RulesRegistryWithCache::ProcessChangedRules speed-up"
> RulesRegistryWithCache::ProcessChangedRules speed-up
>
> Postpone rules->value conversion:
> Currently the rules are converted to base::Value on the rules registry thread before ProcessChangedRules finishes, and then a task is posted to UI which will trigger writing that to a rule store on yet another thread.
> This CL postpones the conversion to the task running on UI thread.
>
> This change cuts down the running time for AddRules to 75%, but of course this is cheating, since the work only gets done later. The point is, however, that network requests are not blocked until the rules are written.
>
> BUG=236368
>
> Review URL: https://chromiumcodereview.appspot.com/14851011
TBR=vabr@chromium.org
Review URL: https://codereview.chromium.org/15647003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202342 0039d316-1c4b-4281-b951-d872f2087c98
> RulesRegistryWithCache::ProcessChangedRules speed-up
>
> Postpone rules->value conversion:
> Currently the rules are converted to base::Value on the rules registry thread before ProcessChangedRules finishes, and then a task is posted to UI which will trigger writing that to a rule store on yet another thread.
> This CL postpones the conversion to the task running on UI thread.
>
> This change cuts down the running time for AddRules to 75%, but of course this is cheating, since the work only gets done later. The point is, however, that network requests are not blocked until the rules are written.
>
> BUG=236368
>
> Review URL: https://chromiumcodereview.appspot.com/14851011
TBR=vabr@chromium.org
Review URL: https://codereview.chromium.org/15647003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202342 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc | diffblobblamehistory | |
| chrome/browser/extensions/api/declarative/rules_registry_with_cache.h | diffblobblamehistory |