Fixes possible use after free in SessionService
commit1a14f497bd17d41d0e0ffceb1fb23dea507b8eae
authorsky <sky@chromium.org>
Tue, 26 Aug 2014 21:44:26 +0000 (26 14:44 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 26 Aug 2014 21:45:27 +0000 (26 21:45 +0000)
tree33ca52b4a65e4bd27705f1b816f2d72448dc0a67
parent5312633de2202a2c1018c9ed56a951e384107db7
Fixes possible use after free in SessionService

SessionService::GetLastSession used a base::Unretained but there was
no guarantee that the SessionService would be valid by the time the
callback was processed.

BUG=399655
TEST=covered by test now
R=marja@chromium.org

Review URL: https://codereview.chromium.org/500143002

Cr-Commit-Position: refs/heads/master@{#291985}
chrome/browser/sessions/base_session_service.cc
chrome/browser/sessions/base_session_service.h
chrome/browser/sessions/session_service.cc
chrome/browser/sessions/session_service.h
chrome/browser/sessions/session_service_test_helper.cc
chrome/browser/sessions/session_service_test_helper.h
chrome/browser/sessions/session_service_unittest.cc