| commit | 158d56d4d3cde4faef91cf265a6b078da08a59c5 | |
| author | droger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 19 Feb 2014 21:18:39 +0000 (19 21:18 +0000) | ||
| committer | droger@chromium.org <droger@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 19 Feb 2014 21:18:39 +0000 (19 21:18 +0000) | ||
| tree | f10ef5ecfb7babd27316b8f6526e60ae82a08a34 | treesnapshot (tar.gz zip) |
| parent | 4ea213e8c8a22163dccf69ef96f29e01b69c4b78 | commitdiff |
TranslateManager is no longer a singleton
There is now a TranslateManager per tab.
TranslateManager is owned by TranslateTabHelper.
This changes simplifies all the tracking of WebContents objects,
since there is now one and only one WebContents per TranslateManager.
This allows to get rid of all the |web_contents| parameters as well as the
PendingRequest type.
Users of the TranslateManager now get a manager from a WebContents
object, through the associated TranslateTabHelper.
BUG=332736
TBR=brettw
Review URL: https://codereview.chromium.org/166963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252098 0039d316-1c4b-4281-b951-d872f2087c98
There is now a TranslateManager per tab.
TranslateManager is owned by TranslateTabHelper.
This changes simplifies all the tracking of WebContents objects,
since there is now one and only one WebContents per TranslateManager.
This allows to get rid of all the |web_contents| parameters as well as the
PendingRequest type.
Users of the TranslateManager now get a manager from a WebContents
object, through the associated TranslateTabHelper.
BUG=332736
TBR=brettw
Review URL: https://codereview.chromium.org/166963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252098 0039d316-1c4b-4281-b951-d872f2087c98