gpu: Fix dependency cycle between service_sources and config_sources.
commit15525c4fa7633018873aa4fec407a14c5cf64840
authortfarina <tfarina@chromium.org>
Tue, 28 Apr 2015 19:04:16 +0000 (28 12:04 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 28 Apr 2015 19:04:55 +0000 (28 19:04 +0000)
treefd85c6b087a7c9a2c08494970703058bce25a992
parentcd4ff3af3ba883510a0fe1f802c35210c44247cb
gpu: Fix dependency cycle between service_sources and config_sources.

ERROR Dependency cycle:
  //gpu/command_buffer/service:service_sources ->
  //gpu/config:config_sources ->
  //gpu/command_buffer/service:service_sources

The problem was that gpu/command_buffer/service already include from
gpu/config, but gpu/config were also including from
gpu/command_buffer/service for gpu_switches.h, creating the above
dependency cycle.

By moving the required switch down to gpu/config, we broke this
dependency cycle.

With that 'gn check' passes for gpu/config with the following command
lines:

$ gn gen out-gn/Debug
$ gn check out-gn/Debug //gpu/config/*

gpu/command_buffer/service needs more work to pass 'gn check' though.

BUG=367595,376000
TEST=see above
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/1103403002

Cr-Commit-Position: refs/heads/master@{#327344}
19 files changed:
content/browser/gpu/gpu_data_manager_impl_private.cc
content/browser/gpu/gpu_data_manager_impl_private_unittest.cc
content/gpu/gpu_main.cc
gpu/command_buffer/service/BUILD.gn
gpu/command_buffer/service/feature_info.cc
gpu/command_buffer/service/feature_info_unittest.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc
gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc
gpu/command_buffer/service/gpu_switches.cc
gpu/command_buffer/service/gpu_switches.h
gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc
gpu/config/BUILD.gn
gpu/config/gpu_switches.cc [new file with mode: 0644]
gpu/config/gpu_switches.h [new file with mode: 0644]
gpu/config/gpu_util.cc
gpu/gpu.gyp
gpu/gpu_config.gypi