permissions: switch from explicitly passing queue controller to callbacks
commit152f7f2870e2745de968e9dc21b1ee34099b967c
authorlalitm <lalitm@google.com>
Wed, 16 Sep 2015 17:30:31 +0000 (16 10:30 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 16 Sep 2015 17:31:17 +0000 (16 17:31 +0000)
tree7c967ab3dc3224659fffe2fd8e2a66074015e6ca
parent592f75b3055eae9e909d6993d2b1977977aeabbc
permissions: switch from explicitly passing queue controller to callbacks

Explicitly passing a raw QueueController object is extremely bad design
as it leads to inflexibility plus questions about lifetimes and ownership
of the pointer.

Moreover, with the new multiple permissions work, queue controller is
disappearing so using a callback means its replacement can be dropped
in without any modifications to the delegates.

This CL depends on https://codereview.chromium.org/1343553003/

This CL is also a part of a group of CLs:
(1) https://codereview.chromium.org/1332293002 (this)
(2) https://codereview.chromium.org/1337903002
(3) https://codereview.chromium.org/1332063003

BUG=516626

Review URL: https://codereview.chromium.org/1332293002

Cr-Commit-Position: refs/heads/master@{#349151}
13 files changed:
chrome/browser/geolocation/geolocation_infobar_delegate.cc
chrome/browser/geolocation/geolocation_infobar_delegate.h
chrome/browser/media/midi_permission_infobar_delegate.cc
chrome/browser/media/midi_permission_infobar_delegate.h
chrome/browser/media/protected_media_identifier_infobar_delegate.cc
chrome/browser/media/protected_media_identifier_infobar_delegate.h
chrome/browser/notifications/notification_permission_infobar_delegate.cc
chrome/browser/notifications/notification_permission_infobar_delegate.h
chrome/browser/permissions/permission_infobar_delegate.cc
chrome/browser/permissions/permission_infobar_delegate.h
chrome/browser/permissions/permission_queue_controller.cc
chrome/browser/storage/durable_storage_permission_infobar_delegate.cc
chrome/browser/storage/durable_storage_permission_infobar_delegate.h