| commit | 123af01f7de4b4cf96742913ea8139e06d9ce41f | |
| author | michaelpg@chromium.org <michaelpg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 8 Aug 2014 18:18:44 +0000 (8 18:18 +0000) | ||
| committer | michaelpg@chromium.org <michaelpg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 8 Aug 2014 18:20:01 +0000 (8 18:20 +0000) | ||
| tree | 30273da3d0ab42e4d786af6b44917b5e34c633c2 | treesnapshot (tar.gz zip) |
| parent | da4d4fb02cb4849277880d95db38361de09b3885 | commitdiff |
When accessing chrome://settings/overlayName or chrome://help/channel-change-page,
uber.onContentFrameLoaded is mistakenly called *after* the overlay is opened. This function
always brings the navigation frame to the foreground, so it should be called before any overlay
might be opened. The overlay being opened will then cause the navigation frame to recede
into the background.
This was inadvertently broken in r287989 (issue 423533003).
BUG=401903
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/452113002
Cr-Commit-Position: refs/heads/master@{#288394}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288394 0039d316-1c4b-4281-b951-d872f2087c98
uber.onContentFrameLoaded is mistakenly called *after* the overlay is opened. This function
always brings the navigation frame to the foreground, so it should be called before any overlay
might be opened. The overlay being opened will then cause the navigation frame to recede
into the background.
This was inadvertently broken in r287989 (issue 423533003).
BUG=401903
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/452113002
Cr-Commit-Position: refs/heads/master@{#288394}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288394 0039d316-1c4b-4281-b951-d872f2087c98