1. Handle the case of empty embedder_extension_id in guestview.h.
commit0e99fdc7b34f98bfcd1f7f2cf969912e0de50934
authorhanxi@chromium.org <hanxi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 30 Apr 2014 05:10:33 +0000 (30 05:10 +0000)
committerhanxi@chromium.org <hanxi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 30 Apr 2014 05:10:33 +0000 (30 05:10 +0000)
tree2b4113926d98fa9ae7d4cf02c5bc5adba8bfc100
parent9236621deac25ca36370c7a4b8d81eb8768a746c
1. Handle the case of empty embedder_extension_id in    guestview.h.

2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
   . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
        -- FromWebContents<T>(...)
        -- From<T>(...).
   . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.

3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).

BUG=351824

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266297

Review URL: https://codereview.chromium.org/237533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267079 0039d316-1c4b-4281-b951-d872f2087c98
31 files changed:
chrome/browser/chrome_content_browser_client.cc
chrome/browser/extensions/api/declarative/declarative_api.cc
chrome/browser/extensions/api/webview/webview_api.h
chrome/browser/extensions/menu_manager.cc
chrome/browser/geolocation/chrome_geolocation_permission_context.cc
chrome/browser/guest_view/OWNERS [moved from chrome/browser/guestview/OWNERS with 100% similarity]
chrome/browser/guest_view/ad_view/ad_view_constants.cc [moved from chrome/browser/guestview/adview/adview_constants.cc with 83% similarity]
chrome/browser/guest_view/ad_view/ad_view_constants.h [moved from chrome/browser/guestview/adview/adview_constants.h with 63% similarity]
chrome/browser/guest_view/ad_view/ad_view_guest.cc [moved from chrome/browser/guestview/adview/adview_guest.cc with 66% similarity]
chrome/browser/guest_view/ad_view/ad_view_guest.h [moved from chrome/browser/guestview/adview/adview_guest.h with 75% similarity]
chrome/browser/guest_view/guest_view.h [new file with mode: 0644]
chrome/browser/guest_view/guest_view_base.cc [moved from chrome/browser/guestview/guestview.cc with 56% similarity]
chrome/browser/guest_view/guest_view_base.h [moved from chrome/browser/guestview/guestview.h with 66% similarity]
chrome/browser/guest_view/guest_view_constants.cc [moved from chrome/browser/guestview/guestview_constants.cc with 90% similarity]
chrome/browser/guest_view/guest_view_constants.h [moved from chrome/browser/guestview/guestview_constants.h with 76% similarity]
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc [moved from chrome/browser/guestview/webview/context_menu_content_type_webview.cc with 91% similarity]
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.h [moved from chrome/browser/guestview/webview/context_menu_content_type_webview.h with 80% similarity]
chrome/browser/guest_view/web_view/javascript_dialog_helper.cc [moved from chrome/browser/guestview/webview/javascript_dialog_helper.cc with 90% similarity]
chrome/browser/guest_view/web_view/javascript_dialog_helper.h [moved from chrome/browser/guestview/webview/javascript_dialog_helper.h with 88% similarity]
chrome/browser/guest_view/web_view/plugin_permission_helper.cc [moved from chrome/browser/guestview/webview/plugin_permission_helper.cc with 94% similarity]
chrome/browser/guest_view/web_view/plugin_permission_helper.h [moved from chrome/browser/guestview/webview/plugin_permission_helper.h with 88% similarity]
chrome/browser/guest_view/web_view/web_view_constants.cc [moved from chrome/browser/guestview/webview/webview_constants.cc with 98% similarity]
chrome/browser/guest_view/web_view/web_view_constants.h [moved from chrome/browser/guestview/webview/webview_constants.h with 93% similarity]
chrome/browser/guest_view/web_view/web_view_find_helper.cc [moved from chrome/browser/guestview/webview/webview_find_helper.cc with 97% similarity]
chrome/browser/guest_view/web_view/web_view_find_helper.h [moved from chrome/browser/guestview/webview/webview_find_helper.h with 96% similarity]
chrome/browser/guest_view/web_view/web_view_guest.cc [moved from chrome/browser/guestview/webview/webview_guest.cc with 93% similarity]
chrome/browser/guest_view/web_view/web_view_guest.h [moved from chrome/browser/guestview/webview/webview_guest.h with 94% similarity]
chrome/browser/guest_view/web_view/web_view_permission_types.h [moved from chrome/browser/guestview/webview/webview_permission_types.h with 80% similarity]
chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc
chrome/browser/renderer_context_menu/render_view_context_menu.cc
chrome/chrome_browser.gypi