| commit | 0e3ca13df86c7740ebc5313159abb0ac34298408 | |
| author | afakhry <afakhry@chromium.org> | |
| Wed, 27 May 2015 21:28:43 +0000 (27 14:28 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 27 May 2015 21:30:57 +0000 (27 21:30 +0000) | ||
| tree | 007fc39bc7763e56bdabdeeda93e4b2700b7afa2 | treesnapshot (tar.gz zip) |
| parent | 6d71bf68f4d9f1408372acd220dcf3a50bfd277e | commitdiff |
Unify Accelerator Creation Code
Currently, we have 2 places where Accelerators are created with
inconsistent code (focus_manager.cc and accelerator_filter.cc). This
needs to be unified.
More over, we need to take into account the EF_COMMAND_DOWN flag when
calculating the modifiers of the accelerator on all platforms, since
this flag means something on all of them (Windows Key on MS keyboards,
Search on Chromebooks, Command on Apple keyboards).
BUG=
Review URL: https://codereview.chromium.org/1155013004
Cr-Commit-Position: refs/heads/master@{#331651}
Currently, we have 2 places where Accelerators are created with
inconsistent code (focus_manager.cc and accelerator_filter.cc). This
needs to be unified.
More over, we need to take into account the EF_COMMAND_DOWN flag when
calculating the modifiers of the accelerator on all platforms, since
this flag means something on all of them (Windows Key on MS keyboards,
Search on Chromebooks, Command on Apple keyboards).
BUG=
Review URL: https://codereview.chromium.org/1155013004
Cr-Commit-Position: refs/heads/master@{#331651}