mac: Improve performance of throbber animations.
commit0a9e5cb05b9bfbed5a5539fecab41a73c28e1c46
authorandresantoso@chromium.org <andresantoso@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Tue, 4 Mar 2014 07:26:30 +0000 (4 07:26 +0000)
committerandresantoso@chromium.org <andresantoso@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Tue, 4 Mar 2014 07:26:30 +0000 (4 07:26 +0000)
tree12c7e32c4dbf9b872982ccb68582f7c5e8e3ece7
parentee51d304e5c875c12f7a2f7fbed3dd40fadcc5ce
mac: Improve performance of throbber animations.

Don't recreate the icon/throbber view everytime we switch states between
waiting, loading, loaded and crashed states.
We now reuse the same view to show throbbers, favicon and also the toast
animation when the tab crashed.
Enable layer based throbbers with the hope that the earlier performance
regressions are addressed with this.
I was not able to repro the regressions locally, but Chris was able to on
a Mac mini running 10.8.

BUG=19268
NOTRY=true

Review URL: https://codereview.chromium.org/178753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254708 0039d316-1c4b-4281-b951-d872f2087c98
13 files changed:
chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm
chrome/browser/ui/cocoa/sprite_view.h
chrome/browser/ui/cocoa/sprite_view.mm
chrome/browser/ui/cocoa/sprite_view_unittest.mm
chrome/browser/ui/cocoa/tabs/tab_controller.h
chrome/browser/ui/cocoa/tabs/tab_controller.mm
chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
chrome/browser/ui/cocoa/tabs/throbber_view.h [deleted file]
chrome/browser/ui/cocoa/tabs/throbber_view.mm [deleted file]
chrome/browser/ui/cocoa/tabs/throbber_view_unittest.mm [deleted file]
chrome/chrome_browser_ui.gypi
chrome/chrome_tests_unit.gypi