| commit | 0a30be1d88f00f510af35144e708bbe797e706d8 | |
| author | jonross <jonross@chromium.org> | |
| Tue, 17 Feb 2015 22:25:24 +0000 (17 14:25 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 17 Feb 2015 22:26:10 +0000 (17 22:26 +0000) | ||
| tree | a51fde2e3d55c838ab801bae00f565943bf03e05 | treesnapshot (tar.gz zip) |
| parent | edbe84670e56798b194943dd567a9c38e1d41a6b | commitdiff |
Properly set ShelfAlignment during login
ShelfLayoutManager has three methods from which the ShelfAlignment can be
applied. For supressed user sessions the shelf is forced to the bottom, however
this was only addressing locked screens, and adding new users.
When the first login occurs a different state transition takes place, where the
SessionState becomes active while the user session is still supressed.
ShelfLayoutManager was not applying alignment changes made during this time.
Update ShelfLayoutManager to unify the logic for overriding the user set
ShelfAlignment. Update this logic to account for having to apply alignment
during the initial login.
Manual testing was also done for: logging in; locking screen; unlocking screen;
adding a new user; switching users.
TEST=ShelfLayoutManagerTest.SideAlignmentInteractionWithLockScreen, ShelfLayoutManagerTest.SideAlignmentInteractionWithAddUserScreen, ShelfLayoutManagerTest.SideAlignmentInteractionWithLoginScreen
BUG=456199
Review URL: https://codereview.chromium.org/909293002
Cr-Commit-Position: refs/heads/master@{#316673}
ShelfLayoutManager has three methods from which the ShelfAlignment can be
applied. For supressed user sessions the shelf is forced to the bottom, however
this was only addressing locked screens, and adding new users.
When the first login occurs a different state transition takes place, where the
SessionState becomes active while the user session is still supressed.
ShelfLayoutManager was not applying alignment changes made during this time.
Update ShelfLayoutManager to unify the logic for overriding the user set
ShelfAlignment. Update this logic to account for having to apply alignment
during the initial login.
Manual testing was also done for: logging in; locking screen; unlocking screen;
adding a new user; switching users.
TEST=ShelfLayoutManagerTest.SideAlignmentInteractionWithLockScreen, ShelfLayoutManagerTest.SideAlignmentInteractionWithAddUserScreen, ShelfLayoutManagerTest.SideAlignmentInteractionWithLoginScreen
BUG=456199
Review URL: https://codereview.chromium.org/909293002
Cr-Commit-Position: refs/heads/master@{#316673}