| commit | 0942685d61d6a040a82bffd24728b5ac12b94e27 | |
| author | miket@chromium.org <miket@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 11 Sep 2012 22:39:07 +0000 (11 22:39 +0000) | ||
| committer | miket@chromium.org <miket@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 11 Sep 2012 22:39:07 +0000 (11 22:39 +0000) | ||
| tree | 582becb1a972155217e5d08e4afde171e3e3992f | treesnapshot (tar.gz zip) |
| parent | 26dae7de0ce12e5ada8bdc2c956e46de9c13d80a | commitdiff |
Make sure that a given app/extension requests only its own resources.
All ApiResources of a given type live in a single pool. Until now, one
app could send arbitrary resource IDs in and get another app's resources
if it were lucky. Now we check that an app is getting back only its own
resources.
Note that this CL could have been shorter if I hadn't decided to break
out the owner_extension_id in ApiResource's constructor. I decided to
do this anyway because the other way to get that information (asking
ApiResourceEventNotifier) violated the Law of Demeter, or even if it
was a technical non-violation, I didn't feel good about relying on
the incidental fact that AREN knew the extension ID.
Ben for OWNERS
TBR=ben@chromium.org
BUG=142521
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10919201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98
All ApiResources of a given type live in a single pool. Until now, one
app could send arbitrary resource IDs in and get another app's resources
if it were lucky. Now we check that an app is getting back only its own
resources.
Note that this CL could have been shorter if I hadn't decided to break
out the owner_extension_id in ApiResource's constructor. I decided to
do this anyway because the other way to get that information (asking
ApiResourceEventNotifier) violated the Law of Demeter, or even if it
was a technical non-violation, I didn't feel good about relying on
the incidental fact that AREN knew the extension ID.
Ben for OWNERS
TBR=ben@chromium.org
BUG=142521
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10919201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98
27 files changed: