Fix many issues with the CVV challenge code path.
commit08bcc8139a0843bc963fe77ba58866b75080ecf2
authordbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Mon, 21 Oct 2013 04:07:13 +0000 (21 04:07 +0000)
committerdbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Mon, 21 Oct 2013 04:07:13 +0000 (21 04:07 +0000)
treec356b3a8fab3a08931d7a176829ea33b2f704057
parenta80d5a6f9bd68fdce82a7bf5c2b350b345bd018b
Fix many issues with the CVV challenge code path.

So far I've fixed the:
- height issue while showing the challenge
- generated card bubble DCHECK() from an empty backing card
- validation issues during the challenge

Still need to:
- clarify what sets the height of the overlay while sending the CVV

BUG=306304
R=estade@chromium.org

Review URL: https://codereview.chromium.org/27415006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229736 0039d316-1c4b-4281-b951-d872f2087c98
12 files changed:
chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
chrome/browser/ui/autofill/generated_credit_card_bubble_controller.h
chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc
chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.cc [new file with mode: 0644]
chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h [new file with mode: 0644]
chrome/browser/ui/views/autofill/autofill_dialog_views.cc
chrome/browser/ui/views/autofill/autofill_dialog_views.h
chrome/chrome_tests.gypi
chrome/chrome_tests_unit.gypi