Move infobar constants and the code that uses them from components/ to chrome/.
commit07622896891ccc5e8279be55bae52c6323f025ff
authorpkasting <pkasting@chromium.org>
Fri, 12 Dec 2014 03:34:22 +0000 (11 19:34 -0800)
committerCommit bot <commit-bot@chromium.org>
Fri, 12 Dec 2014 03:34:40 +0000 (12 03:34 +0000)
treed14263e37c072929a54b8523d317fbe0771cb9a2
parent41ec9ff4ad115e94ed3e9b2d96c42e5f6eb07f2c
Move infobar constants and the code that uses them from components/ to chrome/.

Both the infobar and the infobar container were making use of various infobar
constants that were declared in components/ but (usually) defined in chrome/.
This was a symptom of having put code in the component that really probably
belonged in the embedder.

This CL hoists the relevant logic to a new cross-platform
InfoBarContainerDelegate class defined on the chrome side, which implements some
of the methods of InfoBarContainer::Delegate.  Platforms then subclass this to
implement the remaining, platform-specific bits.

This means that the constants in question now live solely in chrome/, avoiding a
bunch of link-time nastiness when trying to build the components code
separately.

BUG=382924
TEST=none
TBR=finnur

Review URL: https://codereview.chromium.org/793783003

Cr-Commit-Position: refs/heads/master@{#308046}
24 files changed:
chrome/browser/extensions/extension_infobar_delegate.cc
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm
chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.h
chrome/browser/ui/cocoa/infobars/infobar_container_cocoa.mm
chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
chrome/browser/ui/cocoa/infobars/infobar_utilities.mm
chrome/browser/ui/infobar_container_delegate.cc [new file with mode: 0644]
chrome/browser/ui/infobar_container_delegate.h [new file with mode: 0644]
chrome/browser/ui/views/frame/browser_view.cc
chrome/browser/ui/views/frame/browser_view.h
chrome/browser/ui/views/infobars/extension_infobar.cc
chrome/browser/ui/views/infobars/infobar_background.cc
chrome/browser/ui/views/infobars/infobar_view.cc
chrome/chrome_browser_ui.gypi
components/infobars.gypi
components/infobars/core/BUILD.gn
components/infobars/core/infobar.cc
components/infobars/core/infobar.h
components/infobars/core/infobar_android.cc [deleted file]
components/infobars/core/infobar_container.cc
components/infobars/core/infobar_container.h
components/infobars/test/infobar_test.cc