| commit | 01e503372e63fc9de2ccd1debab9f27a414e8a9d | |
| author | jsbell@chromium.org <jsbell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 23 Jan 2014 04:26:18 +0000 (23 04:26 +0000) | ||
| committer | jsbell@chromium.org <jsbell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 23 Jan 2014 04:26:18 +0000 (23 04:26 +0000) | ||
| tree | ae88613cd39da8bf67be7246a1a3e111b0d64251 | treesnapshot (tar.gz zip) |
| parent | 32c1c06ac8b3b25af2dd1b172dbb61e2238b826a | commitdiff |
IndexedDB: Ignore stale Success if handle was passed in UpgradeNeeded
To ack messages sent from the browser to a renderer thread after the
thread is terminated, the IPC message filter has a special "stale
message" handler that closes connections. r237142 changed OnSuccess
to only include a valid connection handle if it was not already
sent in OnUpgradeNeeded, but the stale handler would try and
close the invalid handle. This was caught by a CHECK on the browser
(to terminate a potentially rogue renderer).
The fix is to simply not try and close the invalid handle.
R=dgrogan@chromium.org
BUG=331586
Review URL: https://codereview.chromium.org/134953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246523 0039d316-1c4b-4281-b951-d872f2087c98
To ack messages sent from the browser to a renderer thread after the
thread is terminated, the IPC message filter has a special "stale
message" handler that closes connections. r237142 changed OnSuccess
to only include a valid connection handle if it was not already
sent in OnUpgradeNeeded, but the stale handler would try and
close the invalid handle. This was caught by a CHECK on the browser
(to terminate a potentially rogue renderer).
The fix is to simply not try and close the invalid handle.
R=dgrogan@chromium.org
BUG=331586
Review URL: https://codereview.chromium.org/134953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246523 0039d316-1c4b-4281-b951-d872f2087c98
| content/child/indexed_db/indexed_db_message_filter.cc | diffblobblamehistory |