Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset...
commit012bebf20cabd5a81179a185b87bd75f632edb66
authorphoglund <phoglund@chromium.org>
Wed, 25 Feb 2015 10:44:12 +0000 (25 02:44 -0800)
committerCommit bot <commit-bot@chromium.org>
Wed, 25 Feb 2015 10:45:05 +0000 (25 10:45 +0000)
tree7a646cba1f905e158881d2a10e37f906c9db8254
parentc4616ff5326e03d4dd04bb3c34471a4bde4afb52
Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #1 id:1 of https://codereview.chromium.org/951953002/)

Reason for revert:
Speculative revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4683/steps/browser_tests%20on%20Mac-10.6/logs/DevToolsSanityTest.TestReattachAfterCrash became very flaky on Mac OS X 10.6 about when this patch was introduced. This is the only devtools change near to the start of the flakiness.

The errors are:
DevToolsSanityTest.TestReattachAfterCrash (run #1):
[ RUN      ] DevToolsSanityTest.TestReattachAfterCrash
[32422:28675:0224/105826:WARNING:data_reduction_proxy_config.cc(211)] SPDY proxy OFF at startup
HTTP server started on http://127.0.0.1:64960...
sending server_data: {"host": "127.0.0.1", "port": 64960} (36 bytes)
[32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1)
[32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2

Original issue's description:
> [DevTools] Check request_id in DevToolsUIBindings::IndexPath
>
> If request_id is reused before the previous job with the same id is finished the old job won't be stopped in ~DevToolsUIBindings.
>
> BUG=
>
> Committed: https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19
> Cr-Commit-Position: refs/heads/master@{#317799}

TBR=dgozman@chromium.org,vkuzkokov@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/956873002

Cr-Commit-Position: refs/heads/master@{#318019}
chrome/browser/devtools/devtools_ui_bindings.cc