Standardize usage of virtual/override/final specifiers in google_apis/.
commit00742d0a34d5aae0f59baedc1173702f22d2aeae
authordcheng <dcheng@chromium.org>
Tue, 23 Dec 2014 01:34:08 +0000 (22 17:34 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 23 Dec 2014 01:35:03 +0000 (23 01:35 +0000)
tree9d3db372b251fba4aa90bc77ad31b352ea31cb83
parent19c1d109fa46723cc3844acfaf2631fa7ed11d19
Standardize usage of virtual/override/final specifiers in google_apis/.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463
TBR=rogerta@chromoium.org

Review URL: https://codereview.chromium.org/802413003

Cr-Commit-Position: refs/heads/master@{#309513}
22 files changed:
google_apis/drive/base_requests_server_unittest.cc
google_apis/drive/base_requests_unittest.cc
google_apis/drive/drive_api_requests_unittest.cc
google_apis/drive/gdata_wapi_requests_unittest.cc
google_apis/gaia/account_tracker_unittest.cc
google_apis/gaia/gaia_oauth_client_unittest.cc
google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc
google_apis/gaia/oauth2_token_service_request_unittest.cc
google_apis/gaia/oauth2_token_service_unittest.cc
google_apis/gaia/ubertoken_fetcher_unittest.cc
google_apis/gcm/base/mcs_message_unittest.cc
google_apis/gcm/base/socket_stream_unittest.cc
google_apis/gcm/engine/checkin_request_unittest.cc
google_apis/gcm/engine/connection_factory_impl_unittest.cc
google_apis/gcm/engine/connection_handler_impl_unittest.cc
google_apis/gcm/engine/gcm_store_impl_unittest.cc
google_apis/gcm/engine/gservices_settings_unittest.cc
google_apis/gcm/engine/heartbeat_manager_unittest.cc
google_apis/gcm/engine/mcs_client_unittest.cc
google_apis/gcm/engine/registration_request_unittest.cc
google_apis/gcm/engine/unregistration_request_unittest.cc
google_apis/google_api_keys_unittest.cc