Limit constrained windows to the size of the parent view.
commit0026387d76bcab8405a73038c5734b05f0f786fe
authorrfevang@chromium.org <rfevang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 6 Sep 2013 05:08:43 +0000 (6 05:08 +0000)
committerrfevang@chromium.org <rfevang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 6 Sep 2013 05:08:43 +0000 (6 05:08 +0000)
tree88d8c1ac8280954b7e253c1c3663e4548054920f
parent4e7cca2801c90284b97d4809e3861798f178dcf4
Limit constrained windows to the size of the parent view.

Constrained windows would get drawn partially outside the browser
window, obscuring some of the contents. This CL limits their size so
everything is in view. This mimics the behavior of the old style
dialogs.

This CL also changes the size request to use the current preferred size
of the view, instead of reusing the existing size. Some dialogs (like
the print preview) changes their size preferences when the browser
window size changes, so the old size might not be optimal any more.

Additionally, added a GetMinimumSize to the bubble frame view, as
previously GetPreferredSize would get used, effectively undoing the
additional restrictions placed based on Window sizes.

BUG=272760,274236,276150

Review URL: https://chromiumcodereview.appspot.com/22903022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221573 0039d316-1c4b-4281-b951-d872f2087c98
18 files changed:
chrome/browser/chromeos/login/webui_login_view.cc
chrome/browser/chromeos/login/webui_login_view.h
chrome/browser/extensions/extension_host.cc
chrome/browser/extensions/extension_host.h
chrome/browser/printing/print_preview_test.cc
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
chrome/browser/ui/gtk/apps/native_app_window_gtk.cc
chrome/browser/ui/gtk/apps/native_app_window_gtk.h
chrome/browser/ui/views/apps/native_app_window_views.cc
chrome/browser/ui/views/apps/native_app_window_views.h
chrome/browser/ui/views/constrained_window_views.cc
chrome/browser/ui/views/constrained_window_views_unittest.cc [new file with mode: 0644]
chrome/browser/ui/views/frame/browser_view_layout.cc
chrome/chrome_tests_unit.gypi
components/web_modal/web_contents_modal_dialog_host.h
ui/views/bubble/bubble_frame_view.cc
ui/views/bubble/bubble_frame_view.h