| commit | 1c740ce3e3fdf495d734a4d5773f14cb58206dff | |
| author | Juan Galvez <jjgalvez@illinois.edu> | |
| Fri, 17 Aug 2018 20:45:07 +0000 (17 15:45 -0500) | ||
| committer | Evan Ramos <evan@hpccharm.com> | |
| Fri, 17 Aug 2018 22:20:38 +0000 (17 17:20 -0500) | ||
| tree | fbbd82d442f6ad7117913dcc576797f1fd7c4642 | treesnapshot (tar.gz zip) |
| parent | ad5bb9e38e2081747857f455317b8dc206f395e0 | commitdiff |
netlrts: close charmrun socket on abort
On abort, the socket that sends messages to charmrun was not
explicitly closed before exit. On Windows, this has the effect
that abort messages are often not printed, and instead charmrun
exits with:
"Charmrun> error on request socket to node x '127.0.0.1'
Not sure if it's also necessary to wait for data to be sent
after closing the socket (maybe with SO_LINGER option), but my
testing on Windows suggests that this fix is enough.
Change-Id: I15489b1e39b34b159931312c17c8f195bc96d793
On abort, the socket that sends messages to charmrun was not
explicitly closed before exit. On Windows, this has the effect
that abort messages are often not printed, and instead charmrun
exits with:
"Charmrun> error on request socket to node x '127.0.0.1'
Not sure if it's also necessary to wait for data to be sent
after closing the socket (maybe with SO_LINGER option), but my
testing on Windows suggests that this fix is enough.
Change-Id: I15489b1e39b34b159931312c17c8f195bc96d793
| src/arch/netlrts/machine.C | diffblobblamehistory |