| commit | bf597b89288b6271f56031d5a20bfaf59f146d4c | |
| author | Bryce Harrington <bryce@bryceharrington.org> | |
| Tue, 16 Oct 2018 16:13:23 +0000 (16 09:13 -0700) | ||
| committer | Bryce Harrington <bryce@bryceharrington.org> | |
| Tue, 16 Oct 2018 16:53:00 +0000 (16 09:53 -0700) | ||
| tree | 3fadc2bab3aa23645951c4f7411d844dbd22f973 | treesnapshot (tar.gz zip) |
| parent | 868998a0f4373cef190232f5bdf817e64548023f | commitdiff |
Revert "Correctly decode Adobe CMYK JPEGs in PDF export"
From further testing and investigation it appears that many PDF viewers
already have a workaround to invert Adobe CMYK JPEGs, so our generated
PDFs display incorrectly with those viewers due to double-inversion.
Further investigation will be needed to find a better solution that
doesn't cause regression for some PDF viewers; perhaps PDF viewers that
lack this inversion workaround should be changed to include it. For now
we'll drop the patch to avoid shipping the regression in 1.16.0.
This reverts commit b207a932a2d3740984319dffd58a0791580597cd.
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=97612
Fixes: https://gitlab.freedesktop.org/cairo/cairo/issues/156
From further testing and investigation it appears that many PDF viewers
already have a workaround to invert Adobe CMYK JPEGs, so our generated
PDFs display incorrectly with those viewers due to double-inversion.
Further investigation will be needed to find a better solution that
doesn't cause regression for some PDF viewers; perhaps PDF viewers that
lack this inversion workaround should be changed to include it. For now
we'll drop the patch to avoid shipping the regression in 1.16.0.
This reverts commit b207a932a2d3740984319dffd58a0791580597cd.
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=97612
Fixes: https://gitlab.freedesktop.org/cairo/cairo/issues/156
| src/cairo-image-info-private.h | diffblobblamehistory | |
| src/cairo-image-info.c | diffblobblamehistory | |
| src/cairo-pdf-surface.c | diffblobblamehistory |