| commit | 5a4a86c27f733645a2276d0a3bd2494e73b3dc88 | |
| author | Bryce Harrington <bryce@bryceharrington.org> | |
| Wed, 13 Jun 2018 00:06:13 +0000 (12 17:06 -0700) | ||
| committer | Bryce Harrington <bryce@bryceharrington.org> | |
| Wed, 13 Jun 2018 22:21:50 +0000 (13 15:21 -0700) | ||
| tree | 29165607d879160f4d189aa450070493b6c1f54e | treesnapshot (tar.gz zip) |
| parent | 9b0355a591125a8d7fe20daa82504759e6d472e7 | commitdiff |
type1-subset: Fix incorrect null ptr check from find_token() (CID #1160662)
subrs was already tested for NULL prior to this, and will never be NULL
at this point. Meanwhile, find_token()'s return is unchecked (it can
return NULL and is checked in all other calls). Quite clearly, this is
a copy-paste error from the prior find_token call, and the intent was to
check array_start not subrs.
Coverity ID: #1160662
Signed-off-by: Bryce Harrington <bryce@bryceharrington.org>
Reviewed-By: Uli Schlachter <psychon@znc.in>
subrs was already tested for NULL prior to this, and will never be NULL
at this point. Meanwhile, find_token()'s return is unchecked (it can
return NULL and is checked in all other calls). Quite clearly, this is
a copy-paste error from the prior find_token call, and the intent was to
check array_start not subrs.
Coverity ID: #1160662
Signed-off-by: Bryce Harrington <bryce@bryceharrington.org>
Reviewed-By: Uli Schlachter <psychon@znc.in>
| src/cairo-type1-subset.c | diffblobblamehistory |