cabal-install: Fix non-reinstallable package set (backport #9092) (#9141)
commit8078074921546c2cfaa8612419933670c8141040
authorKleidukos <29253044+Kleidukos@users.noreply.github.com>
Thu, 20 Jul 2023 16:12:35 +0000 (20 16:12 +0000)
committerKleidukos <29253044+Kleidukos@users.noreply.github.com>
Thu, 20 Jul 2023 16:12:35 +0000 (20 16:12 +0000)
treeca5185d6f60f03d862a90efb2b39ea242392891b
parent529f850457b481cb17acf939976838c6ed59c3df
cabal-install: Fix non-reinstallable package set (backport #9092) (#9141)
cabal-install: Fix non-reinstallable package set

In #9064 we discovered that `ghc-boot` was added to the
non-reinstallable package set due to #8051 despite there being no
reason why it can't be built from its source distribution. This
revealed the fact that there is quite some ambiguity around what
constitutes a non-reinstallable package.

In #9064 we worked out a hopefully-more-clear picture of
non-reinstallability. Here we update the commentary to describe this
concept and update the lists to reflect the new definition.

Closes #9064.

(cherry picked from commit 2e32a44f217eb7b0e9e906f45f7aa084228319e5)

# Conflicts:
# cabal-install/src/Distribution/Client/Dependency.hs

* Fix tests

(cherry picked from commit 249374d16b328736a01a4c7e84fa42fbad7422e7)

# Conflicts:
# cabal-install/tests/UnitTests/Distribution/Solver/Modular/Solver.hs

* Fix conflicts
cabal-install/src/Distribution/Client/Dependency.hs
cabal-install/tests/UnitTests/Distribution/Solver/Modular/Solver.hs