| commit | 46df8ba712470ef8f80ef1256861b1e0a37a0976 | |
| author | Javier Sagredo <javier.sagredo@iohk.io> | |
| Fri, 15 Dec 2023 16:11:08 +0000 (15 17:11 +0100) | ||
| committer | Mikolaj <281893+Mikolaj@users.noreply.github.com> | |
| Thu, 18 Jan 2024 18:42:25 +0000 (18 18:42 +0000) | ||
| tree | ee4d9b4a63d6ac0c6c3602ed895a1431b5c4a433 | treesnapshot (tar.gz zip) |
| parent | 28e2926e40e04eb0b6ca4377e2e394400f6263d6 | commitdiff |
Fix extra-prog-path propagation in the codebase.
Extra prog paths were being handled in many different ways all thorugh
the codebase. This PR introduces a unified way to look at them.
Aiming for traceability, the addition of extra paths is now traced via
`logExtraProgramSearchPath`. All appearances of
`modifyProgramSearchPath` are replaced with `appendProgramSearchPath`
which traces the added paths.
`progInvokePathEnv` was only being set by GHC for some paths to
executables in components and only under certain circumstances. Now
every `ghcInvocation` sets the extra paths directly into `pkgInvokeEnv`.
In particular this fixes PATH issues when running MinGW cabal in
PowerShell, as usually for other OSes the system path contains most of
the expected directories.
Extra prog paths were being handled in many different ways all thorugh
the codebase. This PR introduces a unified way to look at them.
Aiming for traceability, the addition of extra paths is now traced via
`logExtraProgramSearchPath`. All appearances of
`modifyProgramSearchPath` are replaced with `appendProgramSearchPath`
which traces the added paths.
`progInvokePathEnv` was only being set by GHC for some paths to
executables in components and only under certain circumstances. Now
every `ghcInvocation` sets the extra paths directly into `pkgInvokeEnv`.
In particular this fixes PATH issues when running MinGW cabal in
PowerShell, as usually for other OSes the system path contains most of
the expected directories.
23 files changed: