From cb25d51b05445e0774a388c8fc93c5d37776a580 Mon Sep 17 00:00:00 2001 From: warner Date: Sun, 24 Sep 2006 06:12:32 +0100 Subject: [PATCH] changes/p4poller.py: make some minor stylistic changes --- ChangeLog | 5 +++++ buildbot/changes/p4poller.py | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 35fc8b9..429416d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-09-23 Brian Warner + + * buildbot/changes/p4poller.py (P4Source): some minor stylistic + changes: set self.loop in __init__, remove unused volatile= + 2006-09-21 Brian Warner * buildbot/scripts/sample.cfg: update to use new BuildStep classes diff --git a/buildbot/changes/p4poller.py b/buildbot/changes/p4poller.py index 1a1623d..8b0c602 100644 --- a/buildbot/changes/p4poller.py +++ b/buildbot/changes/p4poller.py @@ -40,7 +40,6 @@ class P4Source(base.ChangeSource, util.ComparableMixin): parent = None # filled in when we're added last_change = None loop = None - volatile = ['loop'] working = False def __init__(self, p4port=None, p4user=None, p4passwd=None, @@ -75,9 +74,9 @@ class P4Source(base.ChangeSource, util.ComparableMixin): self.split_file = split_file self.pollinterval = pollinterval self.histmax = histmax + self.loop = LoopingCall(self.checkp4) def startService(self): - self.loop = LoopingCall(self.checkp4) base.ChangeSource.startService(self) # Don't start the loop just yet because the reactor isn't running. -- 2.11.4.GIT