From b9cf37ec576a54e0611958b363bda2c4cdd168c1 Mon Sep 17 00:00:00 2001
From: "Dustin J. Mitchell" <dustin@zmanda.com>
Date: Wed, 3 Jun 2009 02:04:05 -0400
Subject: [PATCH] fixes #493 - use POST method; thanks to Minesh Patel
 (mpatel20 on SourceForge)

---
 buildbot/status/web/base.py    | 8 ++++----
 buildbot/status/web/build.py   | 2 +-
 buildbot/status/web/builder.py | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/buildbot/status/web/base.py b/buildbot/status/web/base.py
index 90403c1..98f9185 100644
--- a/buildbot/status/web/base.py
+++ b/buildbot/status/web/base.py
@@ -71,11 +71,11 @@ def make_name_user_passwd_form(useUserPasswd):
 
 def make_stop_form(stopURL, useUserPasswd, on_all=False, label="Build"):
     if on_all:
-        data = """<form action="%s" class='command stopbuild'>
+        data = """<form method="post" action="%s" class='command stopbuild'>
           <p>To stop all builds, fill out the following fields and
           push the 'Stop' button</p>\n""" % stopURL
     else:
-        data = """<form action="%s" class='command stopbuild'>
+        data = """<form method="post" action="%s" class='command stopbuild'>
           <p>To stop this build, fill out the following fields and
           push the 'Stop' button</p>\n""" % stopURL
     data += make_name_user_passwd_form(useUserPasswd)
@@ -86,11 +86,11 @@ def make_stop_form(stopURL, useUserPasswd, on_all=False, label="Build"):
 
 def make_force_build_form(forceURL, useUserPasswd, on_all=False):
     if on_all:
-        data = """<form action="%s" class="command forcebuild">
+        data = """<form method="post" action="%s" class="command forcebuild">
           <p>To force a build on all Builders, fill out the following fields
           and push the 'Force Build' button</p>""" % forceURL
     else:
-        data = """<form action="%s" class="command forcebuild">
+        data = """<form method="post" action="%s" class="command forcebuild">
           <p>To force a build, fill out the following fields and
           push the 'Force Build' button</p>""" % forceURL
     return (data
diff --git a/buildbot/status/web/build.py b/buildbot/status/web/build.py
index a2cfd17..7e67ff4 100644
--- a/buildbot/status/web/build.py
+++ b/buildbot/status/web/build.py
@@ -193,7 +193,7 @@ class StatusResourceBuild(HtmlResource):
                          "after this build was started <b>will</b> be \n"
                          "included in a rebuild.</p>\n")
             rebuildURL = urllib.quote(req.childLink("rebuild"))
-            data += ('<form action="%s" class="command rebuild">\n'
+            data += ('<form method="post" action="%s" class="command rebuild">\n'
                      % rebuildURL)
             data += make_name_user_passwd_form(self.isUsingUserPasswd(req))
             data += make_row("Reason for re-running build:",
diff --git a/buildbot/status/web/builder.py b/buildbot/status/web/builder.py
index 4825f7c..97fed91 100644
--- a/buildbot/status/web/builder.py
+++ b/buildbot/status/web/builder.py
@@ -45,7 +45,7 @@ class StatusResourceBuilder(HtmlResource, OneLineMixin):
         if self.builder_control is not None:
             stopURL = path_to_build(req, build) + '/stop'
             data += '''
-<form action="%s" class="command stopbuild" style="display:inline">
+<form method="post" action="%s" class="command stopbuild" style="display:inline">
   <input type="submit" value="Stop Build" />
 </form>''' % stopURL
         return data
@@ -120,7 +120,7 @@ class StatusResourceBuilder(HtmlResource, OneLineMixin):
         if control is not None:
             pingURL = path_to_builder(req, b) + '/ping'
             data += """
-            <form action="%s" class='command pingbuilder'>
+            <form method="post" action="%s" class='command pingbuilder'>
             <p>To ping the buildslave(s), push the 'Ping' button</p>
 
             <input type="submit" value="Ping Builder" />
-- 
2.11.4.GIT