1 2007-09-29 Brian Warner <warner@lothar.com>
3 * buildbot/scripts/sample.cfg: use buildstep instances in
4 f.addStep, to demonstrate the (correct) modern usage.
5 * docs/examples/hello.cfg: bring this up to date. Closes #79.
6 * docs/examples/twisted_master.cfg: add a big warning about how
8 * docs/examples/glib_master.cfg: delete this one entirely, it is
9 ancient and not a very useful example anyways
11 * buildbot/status/web/base.py (HtmlResource.render): keep track of
12 HTTPChannels, so we can shut them down at reconfig time (when the
13 WebStatus goes away). Closes #102.
14 * buildbot/status/web/baseweb.py (WebStatus.__init__): same
15 (WebStatus.registerChannel): same
16 (WebStatus.stopService): do .loseConnection() here
18 * buildbot/test/test_webparts.py (Webparts.testPages): reload the
19 WebStatus, make sure all pages are still retrievable. I thought
20 this would exercise a bug, but it turns out that it was firefox
21 caching connections (and continuing to talk to the old WebStatus
22 even though I'd loaded a new one).
23 * buildbot/status/web/baseweb.py (WebStatus): add some comments
24 (WebStatus.__repr__): include id() in the repr
26 * buildbot/status/tinderbox.py (TinderboxMailNotifier): allow
27 this to specify an errorparser. From Ted Mielczarek and the
28 mozilla crew. Closes #94.
30 * buildbot/changes/bonsaipoller.py (BonsaiParser): "Make
31 bonsaipoller ignore funkyness in xml output for empy log
32 messages", from Axel Hecht. Closes #90.
33 * buildbot/test/test_bonsaipoller.py
34 (TestBonsaiPoller.testMergeEmptyLogMsg): same
36 * buildbot/status/tinderbox.py (TinderboxMailNotifier.buildStarted):
37 respect 'builders' arg, from Ben Hearsum. Closes #89.
39 * buildbot/scripts/runner.py (stop): increase the timeout from 5
40 seconds to 10, to give heavily loaded machines a better chance to
41 finish shutting down. Addresses (partially) #68.
42 * buildbot/scripts/logwatcher.py (LogWatcher.TIMEOUT_DELAY): same,
44 * buildbot/scripts/reconfig.py (Reconfigurator.run): same
45 * buildbot/scripts/startup.py (Follower._failure): update message
47 * buildbot/changes/bonsaipoller.py: apply changes from the Mozilla
48 team, to fix some bugs and avoid the use of blocking urlopen().
50 * buildbot/test/test_bonsaipoller.py: same
52 2007-09-28 Brian Warner <warner@lothar.com>
54 * buildbot/buildslave.py (BuildSlave): add notify_on_missing=
55 argument, to send email about buildslaves which are disconnected
56 for more than an hour. Closes #64.
57 * buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
59 * docs/buildbot.texinfo (When Buildslaves Go Missing): document it
60 (MailNotifier): add docs for this too
63 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): make this page
64 respect branch= queryargs, by restricting the builds displayed to
65 those matching the given branch names
66 * buildbot/status/web/waterfall.py (BuildTopBox): same
68 * buildbot/test/test_web.py (WaterfallSteps.test_urls.FakeRequest):
69 fix a test failure by adding .prepath to this fake object
71 * buildbot/status/web/*: big set of changes to WebStatus, cleaning
72 up generation of relative URLs. With luck, this should play with
73 reverse proxies much better now.
74 * buildbot/test/test_webparts.py: new test for most of the subpages
75 * buildbot/test/test_web.py (base_config): add enough of a config
76 to exercise more Waterfall code
78 2007-09-27 Brian Warner <warner@lothar.com>
80 * buildbot/status/web/build.py (StatusResourceBuild.body): use a
81 relative URL to the buildbot welcome page, rather than
83 * buildbot/status/web/builder.py (StatusResourceBuilder.body): same
85 * buildbot/status/web/base.py (HtmlResource.title): change the
86 default title of all Buildbot-generated page to "Buildbot"
87 * buildbot/status/web/builder.py (StatusResourceBuilder.getTitle):
88 change the title to include the Builder name
89 * buildbot/status/web/build.py (StatusResourceBuild.getTitle):
90 same, and also show the build number
91 (StatusResourceBuild.rebuild): after using the 'Rebuild' button,
92 redirect the browser to the Builder page
94 2007-09-26 Brian Warner <warner@lothar.com>
96 * buildbot/status/web/baseweb.py (OneBoxPerBuilder.body): fix URL
97 problem with the build links
99 2007-09-25 Brian Warner <warner@lothar.com>
101 * buildbot/status/web/base.py (HtmlResource.render): fix addSlash
102 to emit relative URLs instead of using URLPath,
104 * docs/buildbot.texinfo (WebStatus): provide an example
106 * buildbot/status/web/baseweb.py (OneBoxPerBuilder): new status
107 page, shows a simple table with one row per Builder. Still pretty
108 ugly, but functional.
109 * buildbot/status/web/index.html: reference it
111 * buildbot/status/web/waterfall.py (Spacer): make this *not*
112 inherit from builder.Event, so that show_events=false doesn't hide
113 spacers, since that would make the waterfall weirdly compressed.
115 * buildbot/status/web/waterfall.py (HELP): put the View button in
116 its own section, so it doesn't get visually confused with the
118 (WaterfallStatusResource.body): make the '[help]' links more
119 visually distinct from each other, and add a link to the Welcome
121 * buildbot/status/web/slaves.py (BuildSlavesResource): handle
122 unused buildslaves without exploding
124 * buildbot/status/web/waterfall.py
125 (WaterfallStatusResource.body.with_args): don't use req.URLPath,
126 it gives us absolute paths that break proxies
127 * buildbot/status/web/base.py (HtmlResource.path_to_root): fix
128 this, it was giving bad results when the Waterfall is behind a
131 * buildbot/scripts/runner.py (upgradeMaster): first phase of the
132 new 'upgrade-master' command, which will bring an old buildmaster
133 directory up-to-date. Right now the only thing it does is populate
134 public_html/ if it wasn't already there. Still to do: check the
135 other files, add documentation.
136 * buildbot/test/test_runner.py (Create.testUpgradeMaster): test it
137 (Create.failUnlessSameFiles): use sets.Set() for 2.3 compatibility
139 2007-08-13 Brian Warner <warner@lothar.com>
141 * buildbot/changes/changes.py (Change.get_HTML_box): add a tooltip
142 that contains the checkin comments when you hover over the entry
143 in the 'changes' column of the waterfall. Thanks to Frederic Leroy
146 * buildbot/status/web/waterfall.py (WaterfallStatusResource): improve
149 * buildbot/status/web/about.py (AboutBuildbot): add an 'about'
150 page with versions of python, buildbot, and twisted
151 * buildbot/status/web/baseweb.py (WebStatus.setupUsualPages): same
152 * buildbot/status/web/index.html: add links to most pages
153 * docs/buildbot.texinfo (Buildbot Web Resources): update docs
155 * buildbot/status/web/robots.txt: put a robots.txt in new installs
156 which discourages robot access to all large dynamically-generated
157 pages. The intention is that the index page and the 'about' page
158 are the only ones which should be crawlable.
159 * buildbot/scripts/runner.py (Maker.public_html): same
161 * setup.py: ship index.html and robots.txt in source distributions
163 * buildbot/status/web/waterfall.py: add 'refresh' query arg, to
164 activate automatic reloading of the page (using a meta Refresh:
166 (WaterfallHelp): new page to explain all the nifty query arguments
167 you can use on the Waterfall, along with forms to set them for
168 you. From this page, you can add filters for builder=, branch=,
169 show_events=, as well as turning on reload=.
170 (WaterfallStatusResource.buildGrid): new query args: last_time=,
171 first_time=, show_time=, num_events= . The old show= is still
172 accepted, but the new builder= is preferred. We ignore empty
173 branch= arguments, to make the WaterfallHelp form easier to
175 (WaterfallStatusResource.head): new method to add text to the
177 * buildbot/status/web/base.py (HtmlResource.content): use head()
178 * buildbot/status/web/baseweb.py (OneLinePerBuild.body): ignore
179 empty branch= arguments
180 (OneLinePerBuildOneBuilder.body): same
182 2007-08-12 Brian Warner <warner@lothar.com>
184 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
185 new query args: 'last_time' is a timestamp of the top-most event
186 on the display, 'first_time' is a timestamp for the bottom-most
187 event. 'show_time' is the difference between them, and overrides
188 'first_time'. 'num_events' puts an upper limit on the number of
189 timestamps that will be displayed on the left hand edge.
190 (WaterfallStatusResource.body): add a 'next page' link to the
191 bottom, which shows the events that come just after those shown on
192 the current page. This is a first step towards #67, but we need
193 some more controls before we can close that one.
195 * buildbot/buildslave.py (BuildSlave): these are now MultiService
196 instances too, and live as children of the BotMaster. The main
197 advantage of this approach is that BuildSlaves can know when they
198 are being removed (so they can shut off the upcoming
199 when-do-we-email-an-admin-because-we-lost-our-slave timer).
200 * buildbot/interfaces.py (IBuildSlave): marker interface so we can
201 identify which service children are BuildSlaves
202 * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
203 Checker updates here, but delegate the rest to..
204 (BotMaster.loadConfig_Slaves): .. here, which looks at the
205 BotMaster's service children to identify the old slaves. I think
206 the previous approach of using master.slaves was broken in the
207 face of config updates that modified BuildSlave instances but did
208 not completely replace them.
209 * docs/buildbot.texinfo (Developer's Appendix): note the change to
210 the Service hierarchy
212 * buildbot/status/web/slaves.py (BuildSlavesResource): new status
213 page (at URL /buildslaves/) to view status of all buildslaves at
214 once, including how long it's been since we last heard from them,
215 and which Builders use them.
217 * buildbot/status/web/baseweb.py: fix title of one-line-per-build
220 * buildbot/interfaces.py (IStatus.getSlaveNames): new method to
223 * buildbot/buildslave.py (BuildSlave.messageReceivedFromSlave):
224 use the BuildSlave to keep track of the last time we've heard from
225 the buildslave. This is updated upon receipt of any message from
226 any SlaveBuilder (which generally means when RemoteCommands are
227 giving us status updates, as BuildSteps run). In the future this
228 will include slave pings too.
229 * buildbot/process/base.py
230 (Build.setupBuild): give each BuildStep a reference to the BuildSlave
231 * buildbot/process/buildstep.py:
232 (BuildStep.setBuildSlave): accept that reference
233 (BuildStep.runCommand): pass the reference on to the RemoteCommand
234 (RemoteCommand.remote_update): update the timestamp
235 (RemoteCommand.remote_complete): same
236 * buildbot/test/runutils.py (StepTester.makeStep): match the change
237 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
238 * buildbot/interfaces.py (ISlaveStatus.lastMessageReceived): new
239 interface to retrieve this timestamp
240 * buildbot/status/builder.py (SlaveStatus): track a copy of the
244 * buildbot/status/web/baseweb.py (OneLineMixin.make_line): tighten
246 (OneLinePerBuild.body): use a <ul> instead of <div>s
247 (OneLinePerBuildOneBuilder.body): same
249 * contrib/darcs_buildbot.py (makeChange): handle moved files too,
250 by adding the file's new name to the list of changed files. This
251 ought to be sufficient for things like isFileImportant and trial
252 tests that only exercise tests for files that have been modified.
255 * buildbot/status/web/xmlrpc.py (XMLRPCServer): add preliminary
256 XMLRPC server to the WebStatus page. This only has two methods
257 right now (getAllBuildsInInterval and getBuild), but we'll be
258 adding more in the future. This server is extracted from the
261 * buildbot/status/web/baseweb.py (OneLinePerBuild): refactor using
262 generateFinishedBuilds, and improve the data displayed.
263 * buildbot/status/web/build.py (StatusResourceBuild): rearrange
264 the per-Build page, add some information like ETA and got_revision
265 * buildbot/status/web/builder.py (StatusResourceBuilder): same,
266 adding a list of recently completed builds
267 * buildbot/status/web/base.py (css_classes): factor this out
269 * buildbot/interfaces.py (IStatus.generateFinishedBuilds): define
270 new method, to make status display classes easier to write,
271 especially the WebStatus 'one_line_per_build' page.
272 (IBuilderStatus.generateFinishedBuilds): same
273 * buildbot/status/builder.py (BuilderStatus.generateFinishedBuilds):
274 (Status.generateFinishedBuilds): implement it
276 * buildbot/process/factory.py (GNUAutoconf.__init__): allow
277 'source' to be a BuildStep instance, since BuildFactory accepts
279 (CPAN.__init__): same
280 (Distutils.__init__): same
281 (Trial.__init__): same
283 * buildbot/interfaces.py (IBuildStatus.getProperty): note that
284 this might raise KeyError
286 2007-08-07 Brian Warner <warner@lothar.com>
288 * buildbot/slave/commands.py (P4): use 'p4user' to construct the
289 'Owner:' field of the view, rather than 'p4logname', since
290 p4logname comes from the buildslave's environment and seems
291 unlikely to ever do the right thing. Thanks to Wade Brainerd for
292 the patch. Closes #40.
294 * buildbot/buildslave.py (BuildSlave.__init__): add max_builds=,
295 which imposes a per-slave limit on how many builds are allowed to
296 run simultaneously. This has a the same scope than the SlaveLock,
297 but is different because max_builds= gives the buildmaster the
298 freedom to assign the build to a different slave, whereas the
299 SlaveLock doesn't get tested until after the build is irrevocably
300 assigned to a slave. Therefore using max_builds= will improve
301 utilization in the presence of multiple buildslaves that are
302 attached to the same Builder. This completes the incorporation of
303 Dustin Mitchell's patches, and closes ticket #48. Thanks Dustin!
304 * buildbot/process/builder.py (SlaveBuilder.buildFinished): when
305 any Builder finishes, potentially trigger *all* Builders, since
306 max_builds= may have stalled someone else while waiting for the
308 * buildbot/scripts/sample.cfg: mention max_builds=
309 * buildbot/test/test_run.py (ConcurrencyLimit): test it
310 * docs/buildbot.texinfo (Buildslave Specifiers): document it
312 * buildbot/test/test_run.py (CanStartBuild._do_test2): tests which
313 inherit from RunMixin do not need to call master.stopService()
314 themselves, since RunMixin.tearDown does that. The double call
315 fails on Twisted-2.0.x, which didn't happen to protect against it.
316 * buildbot/test/test_slaves.py (BuildSlave.test_track_builders): same
318 * buildbot/buildslave.py (BuildSlave.addSlaveBuilder): third patch
319 from #48, this one to have the BuildSlave objects track
320 SlaveBuilders, so they'll be able to use that knowledge to
321 influence their canStartBuild() response.
322 * buildbot/process/builder.py (SlaveBuilder.attached): call it
323 (SlaveBuilder.detached): same
324 * buildbot/test/test_slaves.py (BuildSlave): test it
326 * buildbot/buildslave.py (BuildSlave.canStartBuild): incorporate
327 the second of Dustin's #48 patches, this one adding a method to
328 the BuildSlave that allows it to decide whether it is willing to
329 participate in a build or not.
330 (SlaveBuilder.isAvailable): use canStartBuild() to decide
332 * buildbot/test/test_run.py (CanStartBuild): test for it
334 * all: incorporate the first of four patches by Dustin Mitchell
335 from ticket #48, working towards improving control over slave
336 concurrency. The first patch is to use a long-lived BuildSlave
337 object per slave, on which other behavior can be added later. I've
338 modified his patch considerably.
339 * buildbot/buildslave.py (BuildSlave): move class out of
340 slave/__init__.py (where it would get loaded by the slave as well
341 as the master, making dependencies trickier), and merge it with
342 BotPerspective. Now these BuildSlave instances are created once in
343 the master.cfg file, and not destroyed until they are either
344 removed from the config file or changed so
345 much (name/password/class changes) that we cannot continue to use
346 the old one. This affects config files: they must use
347 'from buildbot.buildslave import BuildSlave' instead of using
348 'from buildbot.slave import BuildSlave'.
349 * buildbot/master.py: move BotPerspective out
350 (BuildMaster.loadConfig_Slaves): examine old and new slaves,
351 add or remove as necessary, update the rest using data from
353 * buildbot/slave/__init__.py: move BuildSlave out
354 * buildbot/test/test*.py: import BuildSlave from the new place
355 * buildbot/scripts/sample.cfg: update to match
356 * docs/buildbot.texinfo: update to match
357 * buildbot/process/builder.py: update comments to match
359 2007-08-02 Brian Warner <warner@lothar.com>
361 * buildbot/status/web/baseweb.py (OneLinePerBuild): improve
362 one-line-per-build pages a bit, add a header, refactor slightly
364 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): cleanup
365 the TimeOutError timer, patch by Dustin Mitchell.
367 2007-08-01 Brian Warner <warner@lothar.com>
369 * buildbot/status/web/baseweb.py (OneLinePerBuild): make this
370 mostly work (branch= is still ignored, we need a useful header)
371 (OneLinePerBuildOneBuilder.body): this too
373 * buildbot/status/web/builder.py (StatusResourceBuilder.force):
374 bring this up-to-date w.r.t. recent refactorings, and fix
375 redirections to bounce the browser to the top page after hitting
376 the 'force' button. This needs to be improved, but at least it now
377 redirects to a valid page.
378 (StatusResourceBuilder.ping): same
379 (StatusResourceBuilder.getChild): same, although I think this code
380 might be dead anyways
382 * buildbot/status/web/waterfall.py (WaterfallStatusResource): add
383 a branch= query argument, to filter the display down to builds and
384 changes that involve the given branch. You can add multiple
385 branch= arguments to see multiple branches (using a logical OR).
386 Note that there is no way to include the default branch (i.e.
387 None, i.e. trunk) yet, there is still work to be done to allow for
388 simple+uniform names of branches (i.e. removing the VC-specific
389 details of how branches are implemented, so calling the branch
390 'beta4' even though the SVN checkout step requires
392 * buildbot/status/builder.py (BuilderStatus.eventGenerator): same
393 * buildbot/changes/changes.py (ChangeMaster.eventGenerator): same
394 * buildbot/interfaces.py (IEventSource.eventGenerator): same
395 * docs/buildbot.texinfo (Buildbot Web Resources): document it
397 * all: bring import statements up-to-date: don't import
398 __future__, assume cPickle and cStringIO are always available.
399 Also remove #!/usr/bin/python lines from non-scripts, my editor
400 has been a bit over-enthusiastic about stuffing them into new .py
403 * buildbot/status/web/index.html: put a link to the waterfall page
404 on the index, otherwise first-time users of WebStatus aren't going
405 to see anything very interesting.
407 * buildbot/interfaces.py (IEventSource): document this interface.
408 Thanks to Dustin Mitchell for the patch. Closes #60.
409 * buildbot/status/builder.py (BuilderStatus): same
410 * buildbot/changes/changes.py (ChangeMaster): same
412 * buildbot/status/web/waterfall.py (WaterfallStatusResource.buildGrid):
413 add a query arg of 'show_events=true' to display non-build events,
414 like slaves attaching/detaching and reconfig events, or
415 'show_events=false' to hide them. The default is 'true'.
416 * docs/buildbot.texinfo (Buildbot Web Resources): document it
418 * web-parts: merge in web-parts branch. Lots of changes. The new
419 functionality is to add buildbot.status.html.WebStatus, which is a
420 superset of the Waterfall that adds new status pages and serves
421 regular files from BASEDIR/public_html/ , which is now the preferred
422 place to put robots.txt, buildbot.css, and index.html .
423 * buildbot/scripts/runner.py: the 'create-master' command now
424 creates public_html/ too, and populates it with a couple of
426 * buildbot/status/web: split waterfall code into smaller pieces
428 2007-07-31 Brian Warner <warner@lothar.com>
430 * buildbot/scripts/startup.py (launch): import twistd.run in a
431 different way to hush pyflakes
432 * buildbot/process/builder.py: remove unused import
434 2007-07-30 Brian Warner <warner@lothar.com>
436 * buildbot/interfaces.py (ISourceStamp): cleanup patch by Dustin
437 Mitchell: pass SourceStamps around rather than branch/version/etc
438 tuples. Thanks Dustin! Closes #70.
439 * buildbot/sourcestamp.py (SourceStamp): insist that .changes is a
440 tuple rather than a list, to avoid surprising mutations
441 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
442 * buildbot/status/mail.py (MailNotifier.buildMessage): same
443 * buildbot/status/builder.py (BuildStatus.getSourceStamp): same
444 * buildbot/test/test_status.py (Subscription): same
445 * buildbot/test/test_control.py (Force): same
446 * buildbot/test/test_buildreq.py (Request.testMerge): same
448 2007-07-29 Brian Warner <warner@lothar.com>
450 * buildbot/scripts/sample.cfg: remove the spurious 'builders'
451 variable, since it wasn't used and is confusing in the presence of
452 c['builders'] (which *is* used). Thanks to Thomas Vander Stichele
455 * buildbot/status/web/waterfall.py (WaterfallStatusResource): update
456 the Buildbot home-page link to point at buildbot.net instead of
457 sourceforge, and add a current-version query parameter so we can
458 get some statistics on which versions are in use out there.
460 2007-07-28 Brian Warner <warner@lothar.com>
462 * buildbot/master.py (BuildMaster.loadConfig): replace c['sources']
463 with c['change_source'], leaving c['sources'] for backwards
464 compatibility (but deprecated), scheduled for removal in 0.8.0
465 * docs/buildbot.texinfo: same
466 * buildbot/test/test_config.py: verify that c['sources'] still works
467 * buildbot/test/test_*.py: replace c['sources'] with c['change_source']
468 * buildbot/scripts/sample.cfg: update to match
470 * buildbot/changes/mail.py (MaildirSource): parse with python's
471 stdlib 'email' module, which has been available since python2.2,
472 and drop use of the 'rfc822' module, which has been depreceated
474 * buildbot/test/test_maildir.py: same: use parse_file() not parse
476 * buildbot/test/test_maildir.py (MaildirTest.testMaildir): oops,
477 this needs to match the renaming in test/mail/msg*
479 * README (SETTING UP A BUILD MASTER): fix capitalization-typo.
482 * buildbot/test/test_mailparse.py: rename sample emails a bit
483 * buildbot/test/mail/msg*: same
485 * buildbot/changes/mail.py (SVNCommitEmailMaildirSource): add a
486 parser for the "commit-email.pl" script that is shipped with SVN,
487 written by Justin Mason. Thanks! Closes SF#1072845.
488 * buildbot/test/mail/svn-commit.*: sample messages
489 * buildbot/test/test_mailparse.py (TestSVNCommitEmail): test it
490 * docs/buildbot.texinfo (SVNCommitEmailMaildirSource): docs
492 2007-07-27 Brian Warner <warner@lothar.com>
494 * buildbot/changes/mail.py: refactor: move parsing into a method
495 named 'parse', each parser type gets a separate subclass. Remove
496 the old 'sep' argument (hardcode it to '/'), fix usage of prefix=
497 to be a simple leading-substring match. Add a warning to the logs
498 if prefix= does not end in a slash, since that's probably a
499 mistake. Fix both places where a prefix= mismatch would skip all
500 subsequent files in the same email, instead of just skipping the
501 one that didn't match.
502 * buildbot/test/test_mailparse.py: match changes
504 * docs/buildbot.texinfo (Getting Source Code Changes): refactor
505 docs on email-based ChangeSources
507 * docs/buildbot.texinfo (Getting Source Code Changes): move all
508 the changesource types up a level, removing the one-entry menu in
511 * buildbot/master.py (BuildMaster.loadConfig_Slaves): rename
512 c['bots'] to c['slaves'], and use buildbot.slave.BuildSlave
513 instances instead of tuples. Closes #63.
514 * buildbot/slave/__init__.py (BuildSlave): define marker class
515 * buildbot/scripts/sample.cfg: use c['slaves'] in sample config
516 * docs/buildbot.texinfo (Buildslave Specifiers): document c['slaves']
517 * buildbot/test/test_*.py: update tests to match
518 * buildbot/test/test_config.py (ConfigTest.testBots): verify that
519 the c['bots'] backwards-compatibility handler works
521 2007-07-26 Brian Warner <warner@lothar.com>
523 * buildbot/changes/hgbuildbot.py (hook): add an in-process
524 Mercurial change-sending hook, contributed by Frederic Leroy.
525 Thanks! Addresses #50.
526 * docs/buildbot.texinfo (MercurialHook): document it
528 * buildbot/changes/hgbuildbot.py: change the way imports are done,
529 to make it compatible with at least hg-0.9.1 and the current 0.9.4
531 2007-07-17 Brian Warner <warner@lothar.com>
533 * buildbot/process/buildstep.py (BuildStep.getLog): add a
534 convenience method to retrieve a log added with
535 addLog()/addCompleteLog()/etc or logfiles= . I should have added
538 2007-07-03 Brian Warner <warner@lothar.com>
540 * buildbot/slave/commands.py (ShellCommand._startCommand): when
541 logging the environment variables, put one variable on each line,
542 rather than having one really long line with all of them. This
543 should make them a bit more readable and not trigger the
544 horizontal scrollbar (when viewing it in a web browser) quite so
545 much. Thanks to Albert Hofkamp for the patch.
547 * buildbot/steps/shell.py (ShellCommand): allow workdir= to be a
548 WithProperties instance. Thanks to Axel Hecht for the patch.
550 * buildbot/test/test_properties.py (Interpolate.testWorkdir): test it
551 * docs/buildbot.texinfo (Build Properties): document it
552 * buildbot/slave/commands.py (ShellCommand._startCommand): create the
553 workdir if it didn't already exist.
555 * docs/buildbot.texinfo (Scheduler Types): correct the description
556 of Dependent schedulers. Thanks to Greg Ward for the patch.
558 * buildbot/steps/source.py (SVN.startVC): when applying a patch,
559 add "[patch]" to the step's display. Thanks to Dustin Mitchell for
560 the patch. Closes #49.
562 * buildbot/slave/commands.py (rmdirRecursive): chmod everything to
563 0700 before removing it, to deal with situations where a build will
564 leave files around without write permissions and the 'copy' or
565 'clobber' VC checkout modes need to blow away the tree first.
566 Thanks to Steve Milner for the suggestion and the patch (which I
567 mangled horribly). Closes #29.
568 * buildbot/test/test_slavecommand.py (Utilities.test_rmdirRecursive):
571 * buildbot/test/runutils.py (RunMixin.disappearSlave): oops, add
572 an allowReconnect= argument to let callers control whether they
573 want this don't-let-it-reconnect behavior, since some tests care.
574 Factor out the .continueTrying=False lines from those callers.
575 * buildbot/test/test_slaves.py: same
576 * buildbot/test/test_run.py: same
578 2007-07-02 Brian Warner <warner@lothar.com>
580 * buildbot/test/runutils.py (RunMixin.disappearSlave): once a
581 slave has been disappeared, don't let it reconnect. This was
582 causing an intermittent failure in test_slaves.py, when the slave
583 that was supposed to be gone managed to come back by the end of
584 the test and affect the count.
585 * buildbot/test/test_slaves.py (Slave.testFallback2): minor
587 * buildbot/process/builder.py (SlaveBuilder.__repr__): added some
588 diagnostic messages to track down this problem
589 (Builder.startBuild): same
591 * buildbot/process/builder.py (Builder.maybeStartBuild): choose
592 the slave randomly rather than always taking the first one. Thanks
593 to Pike for the patch. Closes #36.
594 * buildbot/test/test_slaves.py: match the change. to avoid huge
595 changes to the tests, I added a CHOOSE_SLAVES_RANDOMLY flag which
596 enables/disables the round-robin-ness (enabled by default), and
597 some unit tests disable it.
598 * docs/buildbot.texinfo (Buildmaster Architecture): document it
600 * buildbot/slave/bot.py (BuildSlave.__init__): rename the 'host'
601 argument to 'buildmaster_host', to make it more obvious that this
602 points to the buildmaster. Thanks to Bob Proulx for the
604 * buildbot/scripts/runner.py (slaveTAC): same
605 * buildbot/test/test_runner.py (Create.testSlave): match the change
607 * contrib/hg_buildbot.py: patch from Frederic Leroy to make this
610 2007-06-17 Brian Warner <warner@lothar.com>
612 * buildbot/test/test_config.py (Factories.testAllSteps): make sure
613 we can round-trip all of our current step classes by calling
614 getStepFactory() and using the results to make a clone of the
617 * buildbot/steps/maxq.py: fix import errors. Guess this hasn't been
620 * buildbot/process/factory.py (BuildFactory.addStep): To simplify
621 the config file, we're moving to using actual instances instead of
622 the (class, kwargs) 'step specification' tuples. BuildFactory
623 still keeps a list of tuples internally, but when real instances
624 are passed in to addStep(), they are asked for their class and
625 kwargs using the new BuildStep.getStepFactory method. BuildFactory
626 accepts both instances and the tuple form, and converts instances
627 to the tuple form, but the instance form is preferred because it
628 gives the Steps a chance to do argument validation. Closes: #11.
630 * buildbot/process/buildstep.py (BuildStep.__init__): record the
631 factory information necessary to implement getStepFactory. The
632 addFactoryArguments() method can be used to include arguments that
633 aren't passed to the BuildStep base class constructor.
634 (BuildStep.setBuild):
635 (BuildStep.setDefaultWorkdir): new methods to take parameters that
636 are needed for live BuildSteps but not to construct the specification
637 tuples that are stashed in the factory.
639 * buildbot/process/base.py (Build.setupBuild): pass 'build' and
640 'workdir' into new BuildSteps by using methods instead of
641 arguments. This makes the constructor for BuildSteps a lot
644 * buildbot/steps/*.py: update to match this change. Basically this
645 means adding calls to addFactoryArguments() in the __init__
646 methods to capture the arguments that aren't passed through to the
648 * buildbot/steps/shell.py (ShellCommand.setDefaultWorkdir): copy
649 the new workdir (if any) into the RemoteShellCommands arguments.
650 * buildbot/steps/source.py: allow workdir= to be optional,
651 implement setDefaultWorkdir() since we don't inherit from
652 (CVS): finally remove old clobber=/export=/copydir= arguments,
653 in favor of the mode= argument that's been around forever now.
654 * buildbot/steps/transfer.py: remove build= argument
656 * buildbot/test/*.py: update to match, generally by turning all
657 build= arguments into subsequent calls to s.setBuild()
658 * buildbot/test/test_config.py (Factories): verify that we can
659 use either BuildStep instances or class/kwarg tuples in both
660 BuildFactory.addStep and BuildFactory.__init__
662 * docs/buildbot.texinfo (Build Steps): document the new approach,
663 mention compatibility with the old approach, update all examples
664 to use the new style.
666 2007-06-16 Brian Warner <warner@lothar.com>
668 * buildbot/changes/svnpoller.py: when the poll fails, don't kill
669 the LoopingCall, just eat the failure so that we'll poll again
670 next time. This should allow us to tolerate (e.g.) sf.net SVN
671 failures more gracefully. Many thanks to Dustin Mitchell for the
674 2007-05-17 Brian Warner <warner@lothar.com>
676 * buildbot/status/words.py: refactor the IRC status bot into
677 separate 'Contact' and 'Channel' classes. The base Contact class
678 contains the interaction code: commands and responses. The
679 IRCContact subclass (and IrcStatusBot 'Channel') handle the
680 IRC-specific aspects. The plan is to write other subclasses for
681 other IM protocols like AIM and Jabber.
683 2007-04-16 Brian Warner <warner@lothar.com>
685 * CREDITS: update list of contributors. Thank you all!
687 2007-04-13 Brian Warner <warner@lothar.com>
689 * buildbot/status/mail.py (MailNotifier): add the project name to
690 the subject line and message body, to make it easier to
691 distinguish email coming from different buildmasters. Thanks to
692 Benoit Sigoure for the patch.
693 * buildbot/test/test_status.py (Mail): update to match
695 2007-03-24 Brian Warner <warner@lothar.com>
697 * buildbot/steps/transfer.py: open all files in 'b' binary mode to
698 avoid text-conversion problems between DOS/windows and unix.
699 Thanks to Phil Thompson for the patch. Fixes SF#1674927.
701 2007-03-03 Brian Warner <warner@lothar.com>
703 * buildbot/status/html.py (_hush_pyflakes): hush a pyflakes
704 warning about the use of Waterfall here
706 2007-03-01 Brian Warner <warner@lothar.com>
708 * buildbot/interfaces.py (IStatus.getBuilder): mention exceptions
710 2007-02-28 Brian Warner <warner@lothar.com>
712 * buildbot/changes/p4poller.py (P4Source): apply change from Scott
713 Lamb to use a more optimal form of 'p4 changes', to reduce server
714 load. He reports that this optimization was added to p4d release
715 2005.2, but it should work in all versions. Closes #27.
716 * buildbot/test/test_p4poller.py: match it
718 2007-02-27 Brian Warner <warner@lothar.com>
720 * buildbot/status/web/*.py: move all web status stuff into a
721 separate directory, in anticipation of splitting it into smaller
722 pieces and adding more files. html.py was getting way too big.
723 * buildbot/status/classic.css: move it too
724 * setup.py: add the new sub-package
725 * buildbot/test/test_web.py: match the changes
726 * MANIFEST.in: handle the move of classic.css
728 2007-02-07 Brian Warner <warner@lothar.com>
730 * contrib/OS-X/*: add some launchd .plist files for automatically
731 starting a buildmaster or buildslave under OS-X (10.4 or later).
732 Thanks to Mark Pauley for these.
734 2007-02-06 Brian Warner <warner@lothar.com>
736 * docs/buildbot.texinfo (Requirements): update requirements to
737 stop claiming compatibility with python-2.2 or twisted-1.3.x .
739 * README: mention python-2.5 and twisted-2.5 compatibility
741 * buildbot/clients/debug.py: hush pyflakes warnings by removing a
743 * buildbot/scripts/startup.py: same, by removing twisted-1.3.0
745 * buildbot/status/builder.py: same, by requiring cStringIO
746 * buildbot/status/words.py: same, remove twisted-1.3.0 compat
747 * buildbot/test/test_vc.py: same
748 * buildbot/test/test_web.py:
749 * buildbot/test/test_steps.py: same, remove unused import
751 * buildbot/status/html.py (StatusResourceBuild.body): oops, close
754 * buildbot/master.py (BuildMaster.loadConfig): warn the user if we
755 see any Builders that don't have Schedulers to drive them
757 * buildbot/master.py (BotPerspective.__repr__): fit bitrot, the
758 attributes this uses went away
760 * contrib/bb_applet.py (MyApplet.filled): add a small prefs
761 dialog, to allow you to reset the buildmaster and force
762 connect/disconnect. Correctly handle losing the buildmaster
763 connection (by switching the display to the hexnut, at which point
764 you can use the 'Connect' menu item to reconnect).
766 * buildbot/steps/source.py (Source.start): if we're using a patch,
767 add it as a LogFile to the checkout/update step. This will turn
768 into a link on the waterfall page.
770 * buildbot/scripts/tryclient.py (Try.createJob): implement --diff
771 option, to take the patch from a pre-made file rather than
772 generating it from the local tree. Thanks to Robert Helmer for the
773 idea. Closes #15 (the Trac ticket on the new http://buildbot.net/).
774 * buildbot/scripts/runner.py (TryOptions): add --diff,
775 --patchlevel, and --baserev options
776 * buildbot/scheduler.py (Try_Jobdir.parseJob): treat a baserev of ""
777 as None, meaning HEAD.
778 * buildbot/sourcestamp.py (SourceStamp): update docstring to
779 indicate that baserev=None means HEAD
780 * docs/buildbot.texinfo (try --diff): document it
782 * buildbot/test/test_steps.py (BuildStep): remove use of
783 reactor.iterate(), although the technique I replaced it with is a
784 gross polling hack that must be cleaned up properly some day. This
785 was the last use of reactor.iterate in the entire tree, yay.
787 2007-02-05 Brian Warner <warner@lothar.com>
789 * buildbot/status/mail.py (MailNotifier.__init__): assert that 'mode'
790 is one of the three known values, otherwise we emit some confusing
791 messages later on. Thanks to Grig Gheorghiu for the catch.
793 2007-01-30 Brian Warner <warner@lothar.com>
795 * buildbot/changes/bonsaipoller.py (BonsaiParser.__init__): Ben
796 Hearsum contributed a patch to let BonsaiPoller work with results
797 that contain non-ascii characters. Closes SF#1632641.
799 2007-01-27 Brian Warner <warner@lothar.com>
801 * Makefile (release): produce both .tar.gz and .zip source bundles.
804 2007-01-23 Brian Warner <warner@lothar.com>
806 * buildbot/changes/freshcvsmail.py: hush a pyflakes warning
807 * buildbot/changes/monotone.py: same
809 * buildbot/changes/maildir.py: combine several files into one,
810 clean up maildir.py to use Services properly.
811 * buildbot/changes/maildirtwisted.py: remove
812 * buildbot/changes/maildirgtk.py: remove, it wasn't used by
814 * buildbot/changes/mail.py: match the change
815 * buildbot/scheduler.py: same, since Try_Jobdir uses a maildir
816 * buildbot/test/test_maildir.py: remove use of reactor.iterate()
818 * buildbot/slave/commands.py (command_version): bump to "2.3" to
819 indicate that the buildslave knows about the 'bzr' command
821 2007-01-22 Brian Warner <warner@lothar.com>
823 * buildbot/process/builder.py (Builder.fireTestEvent): don't use
824 'with', it will become a reserved work in python2.6 .
826 * contrib/bb_applet.py: add a simple gnome-panel applet, to
827 display a terse summary of buildbot status.
828 * docs/hexnut32.png, docs/hexnut48.png, docs/hexnut64.png: add
829 some icons, small versions of the Blender object that lives in
830 docs/images/icon.blend
832 * buildbot/steps/source.py (Bzr): add Bazaar-ng support
833 * buildbot/slave/commands.py (Bzr): same
834 * buildbot/scripts/tryclient.py (BzrExtractor): same
835 (SourceStampExtractor.dovc): modify this to allow non-zero exit
836 status, since 'bzr diff' does that
837 * buildbot/test/test_vc.py (Bzr): same
838 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
842 2007-01-20 Brian Warner <warner@lothar.com>
844 * contrib/darcs_buildbot.py: tidy up the progress messages
846 2007-01-17 Brian Warner <warner@lothar.com>
848 * contrib/darcs_buildbot.py: enhance to handle multiple patches
849 being pushed at a time. This keeps state in the repository in a
850 small file named .darcs_buildbot-lastchange, but that shouldn't
851 interfere with normal repository operations. Fixes SF#1534049.
852 * buildbot/clients/sendchange.py (Sender): make a single Sender
853 capable of sending Changes with different usernames.
855 2006-12-11 Brian Warner <warner@lothar.com>
857 * buildbot/changes/freshcvsmail.py: mark this file as deprecated,
858 scheduled for removal in 0.7.7 . The FCMaildirSource was moved to
859 buildbot.changes.mail a long time ago, but I forgot to add the
860 DeprecationWarning until now.
862 * buildbot/process/maxq.py: remove this, the functionality now
863 lives in buildbot.steps.maxq
865 * buildbot/clients/debug.py: remove an unnecessary gnome.ui import
866 * buildbot/clients/gtkPanes.py: remove unused import
868 * buildbot/slave/trial.py: remove an unused/incomplete/buggy file,
869 that was meant to provide a special Reporter to run inside trial
870 and give the buildslave lots of machine-readable status. We never
871 finished this project.
873 * buildbot/changes/bonsaipoller.py: remove unused imports
874 * buildbot/changes/svnpoller.py: same
875 * buildbot/process/builder.py: same
876 * buildbot/process/buildstep.py: same
877 * buildbot/slave/bot.py: hush pyflakes warning
878 * buildbot/status/tests.py: remove unused imports
879 * buildbot/status/tinderbox.py: same
880 * buildbot/steps/python_twisted.py: same
882 * buildbot/process/step.py: remove this file, these names were
883 deprecated in 0.7.5 and are now being removed.
884 * buildbot/process/step_twisted.py: same
885 * buildbot/test/test_steps.py (ReorgCompatibility): remove test
887 * buildbot/twcompat.py: remove the empty file, yay it is gone
889 * buildbot/twcompat.py (waitForDeferred): remove the monkeypatch,
890 tw-2.0.0 and newer have the method we need.
891 (getProcessOutputAndValue): same
892 (which): remove this method, tw-2.0.0 t.p.procutils has it
894 * buildbot/twcompat.py (implements): remove this method
895 * buildbot/*: import implements() from zope.interface directly
897 * buildbot/status/mail.py: stop falling back to importing
898 twisted.protocols.smtp.sendmail, now that we don't need tw-1.3.0
901 * buildbot/twcompat.py (Interface): remove this import
902 * buildbot/*: import Interface from zope.interface directly
904 * buildbot/twcompat.py (providedBy): remove this method
905 * buildbot/*: turn all uses of providedBy(obj, iface) into
906 iface.providedBy(obj)
908 * buildbot/twcompat.py (maybeWait): remove this method, now that
909 we no longer maintain compatibility with Twisted<=1.3.0 .
910 Twisted-2.0.0 and later allow trial methods to return Deferreds
912 * buildbot/test/*: remove all uses of maybeWait
914 * buildbot/__init__.py (version): bump to 0.7.5+ while between
916 * docs/buildbot.texinfo: same
918 2006-12-10 Brian Warner <warner@lothar.com>
920 * buildbot/__init__.py (version): Releasing buildbot-0.7.5
921 * docs/buildbot.texinfo: set version to match
923 2006-12-10 Brian Warner <warner@lothar.com>
925 * README (REQUIREMENTS): update for release
926 * NEWS: update for release
927 * buildbot/slave/commands.py (command_version): mention that this
928 version (2.2) was released with buildbot-0.7.5
930 * buildbot/test/test_config.py (StartService.testStartService):
931 inhibit the usual read-config-on-startup behavior, since otherwise
932 the log.err that gets recorded causes the test to fail
934 * buildbot/status/builder.py (LogFile.finish): forget about all
935 subscribers once the log has finished, since after that point
936 we're never going to use them again. This might help free up some
939 * buildbot/clients/debug.py: update to use gtk.main_quit() rather
940 than the old/deprecated gtk.mainquit()
942 2006-12-09 Brian Warner <warner@lothar.com>
944 * buildbot/steps/transfer.py (_FileWriter.__del__): handle errors
945 better when we can't open the masterdst file
947 * buildbot/scripts/startup.py (Follower._failure): add missing
948 import statement for BuildSlaveDetectedError
950 * buildbot/steps/transfer.py (FileUpload): cleanup
951 (FileDownload): same. Add tests for slave version, add mode=.
952 * buildbot/slave/commands.py (SlaveFileUploadCommand): same
953 (SlaveFileDownloadCommand): same
954 * buildbot/test/test_transfer.py: enhance tests
955 * buildbot/test/runutils.py (makeBuildStep): create a fake form of
958 2006-12-08 Brian Warner <warner@lothar.com>
960 * buildbot/scripts/runner.py (sendchange): halt the reactor on
961 both success *and* failure. Without this, the 'buildbot
962 sendchange' command would hang if it could not contact the
963 buildmaster or deliver the Change, which would generally cause the
964 user's commit/record/checkin command to hang too. Thanks to
965 Christian Unger for the catch.
967 2006-12-06 Brian Warner <warner@lothar.com>
969 * NEWS: update with items for the next release
971 * docs/buildbot.texinfo (Adding LogObservers): add a somewhat
972 whimsical example pulled from a punch-drunk email I sent out late
974 (Transferring Files): document some of the other parameters
975 (Adding LogObservers): update to 0.7.5 buildbot.steps.*
976 (SVNPoller): rename svnpoller.SvnSource to SVNPoller
977 * buildbot/test/test_svnpoller.py: same
978 * buildbot/changes/svnpoller.py (SVNPoller): same
980 2006-11-26 Brian Warner <warner@lothar.com>
982 * docs/buildbot.texinfo (Build Properties): remind users that
983 WithProperties must appear in a command= list, not as a top-level
985 * buildbot/steps/shell.py (ShellCommand.start): and assert that
986 we're sending a list or a single string to the RemoteShellCommand
988 * buildbot/scheduler.py (Nightly): Improve docs slightly.
990 * buildbot/scripts/startup.py (start): skip the whole
991 watch-the-logfile thing under windows, since it needs os.fork()
993 * buildbot/scripts/runner.py (restart): remove the old message
994 that got printed after the buildbot was restarted.. it most cases
995 it didn't get printed at the right time anyways
997 2006-11-25 Brian Warner <warner@lothar.com>
999 * buildbot/scripts/runner.py: enhance 'start' and 'restart' to
1000 follow twistd.log and print lines until the process has started
1001 started properly. For the buildmaster, this means until the config
1002 file has been parsed and accepted. For the buildslave, this means
1003 until we've connected to the master. We give up after 5 seconds in
1004 any case. Helpful error messages and troubleshooting suggestions
1005 are printed when we don't see a successful startup. This closes the
1006 remainder of SF#1517975.
1007 * buildbot/scripts/startup.py: moved app startup code to here
1008 * buildbot/scripts/logwatcher.py: utility class to follow log
1009 * buildbot/scripts/reconfig.py: rewrite to use LogWatcher
1010 * buildbot/slave/bot.py: announce our BuildSlaveness to the log
1011 so the LogWatcher can tell the difference between a buildmaster
1014 2006-11-24 Brian Warner <warner@lothar.com>
1016 * docs/examples/twisted_master.cfg: update to match the version
1017 in use on twistedmatrix.com
1018 (IRC): re-enable IRC bot. The 'irc.us.freenode.net' hostname I
1019 was using before stopped working, but 'irc.freenode.net' works
1022 * buildbot/scripts/runner.py (run): oops, forgot to enable the new
1025 * buildbot/clients/base.py (TextClient.not_connected): upon
1026 UnauthorizedLogin failures, remind the user to connect to the
1027 PBListener port instead of the slaveport.
1028 (TextClient.disconnected): shut down more quietly
1029 * docs/buildbot.texinfo (statuslog): add another reminder
1031 * buildbot/scripts/runner.py (Options.subCommands): rename
1032 'buildbot sighup DIR' to 'buildbot reconfig DIR', but keep
1033 'sighup' as an alias.
1034 * buildbot/scripts/reconfig.py (Reconfigurator): enhance the
1035 reconfig command to follow twistd.log and print all of the lines
1036 from the start of the config-file reload to its completion. This
1037 should make it a lot easier to discover bugs in the config file.
1038 Use --quiet to disable this behavior. This addresses half of
1039 SF#1517975, the other half will be to add this same utility to
1040 'buildbot start' and 'buildbot restart'.
1041 * docs/buildbot.texinfo (Loading the Config File): same
1044 * buildbot/interfaces.py (IBuilderControl.forceBuild): remove this
1045 method, it has been deprecated for a long time. Use
1046 IBuilderControl.requestBuild instead.
1047 * buildbot/process/builder.py (BuilderControl.forceBuild): remove
1048 * buildbot/master.py (BotPerspective.perspective_forceBuild): same
1049 * buildbot/slave/bot.py (Bot.debug_forceBuild): same
1050 * buildbot/test/test_control.py (Force.testForce): same
1051 * buildbot/test/test_run.py: use requestBuild instead
1053 * buildbot/clients/debug.py: replace 'Force Build' button with
1054 'Request Build' (which just adds one to the queue), add Ping
1055 Builder, add branch/revision fields to Request Build.
1056 * buildbot/clients/debug.glade: same
1057 * buildbot/master.py: update interface to match. This creates an
1058 incompatibility between new debugclients and old buildmasters.
1060 * buildbot/process/builder.py (Builder._attached): delay the call
1061 to maybeStartBuild for a reactor turn, to avoid starting a build
1062 in the middle of a reconfig (say, if the new Builder uses a new
1063 slave which is already connected).
1065 2006-11-23 Brian Warner <warner@lothar.com>
1067 * buildbot/test/test_transfer.py: appease pyflakes
1068 * buildbot/test/test_steps.py: same
1070 * buildbot/test/test_bonsaipoller.py: remove the 'import *' that
1071 keeps pyflakes from finding undefined names
1073 * buildbot/master.py (BuildMaster.loadConfig_Builders): changing a
1074 Builder no longer induces a disconnect/reconnect cycle. This means
1075 that any builds currently in progress will not be interrupted, and
1076 any builds which are queued in the Builder will not be lost. This
1077 is implemented by having the new Builder extract the state (i.e.
1078 all pending Builds and any desired SlaveBuilders) from the old
1080 (BotPerspective): refactor. The BotPerspective no longer keeps
1081 track of all the Builders that want to use this slave; instead, it
1082 asks the BotMaster each time it needs this list. This removes
1083 addBuilder and removeBuilder. Clean up attached() to acquire all
1084 the slave's information in a more atomic fashion. updateSlave() is
1085 now the way to make sure the slave is using the right set of
1086 Builders: just call it after everything else has been
1088 (BotMaster): refactor, removing addBuilder/removeBuilder and
1089 replacing them with an all-at-once setBuilders() call.
1091 * buildbot/test/test_slaves.py (Reconfig): new test case to
1092 exercise this functionality
1093 * buildbot/steps/dummy.py (Wait): new dummy BuildStep for the test
1094 * buildbot/slave/commands.py (WaitCommand): same
1096 * docs/buildbot.texinfo (Loading the Config File): document the
1099 * buildbot/process/builder.py (SlaveBuilder): refactor. Allow the
1100 SlaveBuilder to have its parent Builder changed.
1101 (SlaveBuilder.isAvailable): new method to give access to state,
1102 which is now a private attribute
1103 (SlaveBuilder.buildStarted,buildFinished): new methods to inform
1104 the SlaveBuilder about how it is being used. These methods update
1105 its internal state. buildFinished() is now the place that invokes
1106 maybeStartBuild() on its parent Builder.
1107 (Builder.consumeTheSoulOfYourPredecessor): new method to allow a
1108 new Builder to take over for an old one, transferring state from
1110 (Buider): refactor the way that SlaveBuilders are used to match,
1111 giving them a bit more autonomy.
1112 (Builder.buildFinished): this no longer calls maybeStartBuild():
1113 instead the SlaveBuilder calls it on whoever its parent Builder is
1114 at the time. This way, when an old Builder is replaced by a new
1115 one, and there was a build in progress during the transition, when
1116 that build finishes, it will be the new Builder that is told about
1117 the newly available slave so it can start a new build.
1119 * buildbot/process/base.py (Build.startBuild._release_slave): when
1120 the Build finishes, tell the SlaveBuilder that they've been
1123 * buildbot/status/builder.py (SlaveStatus): add some new setter
1124 methods for use by BotPerspective, to keep some attributes more
1127 * buildbot/slave/bot.py (Bot.remote_getDirs): this is no longer
1128 called by the buildmaster.
1129 (Bot.setBuilderList): instead, we locally announce any leftover
1130 directories based upon which Builders we were told about. The
1131 master doesn't really care; it's the local admin who may or may not
1132 wish to delete them.
1135 * contrib/svn_buildbot.py: use /usr/bin/python, not /usr/bin/env,
1136 to allow use of python2.4 or whatever. This tool still requires
1139 2006-11-19 Brian Warner <warner@lothar.com>
1141 * NEWS (IStatusLog.readlines): more news items
1143 2006-11-18 Brian Warner <warner@lothar.com>
1145 * NEWS: start collecting items for the next release.
1147 2006-11-04 Brian Warner <warner@lothar.com>
1149 * buildbot/changes/bonsaipoller.py: apply updates from Ben
1150 Hearsum. Closes SF#1590310.
1151 * buildbot/test/test_bonsaipoller.py: and tests
1153 * buildbot/status/tinderbox.py
1154 (TinderboxMailNotifier.buildMessage): send out a "testfailed"
1155 status when the build results in WARNINGS. Patch from Dave
1156 Liebreich. Closes SF#1587352.
1158 * buildbot/slave/commands.py (LogFileWatcher.poll): overcome a
1159 linux-vs-osx behavior difference w.r.t. reading from files that
1160 have reached EOF. This should fix LogFileWatcher on OS-X. Thanks
1161 to Mark Rowe for the patch.
1163 2006-10-15 Brian Warner <warner@lothar.com>
1165 * buildbot/interfaces.py (IStatus.getURLForThing): oops, the
1166 method name was misspelled in the interface definition. Thanks to
1167 Roy Rapoport for the catch.
1169 2006-10-13 Brian Warner <warner@lothar.com>
1171 * docs/buildbot.texinfo (Adding LogObservers): update sample code
1172 to match the great Steps renaming
1174 * buildbot/steps/transfer.py (FileUpload.start): Fix stupid error.
1175 Maybe I should run my own unit tests before recording a big
1176 change. Good thing I've got a buildbot to remind me.
1178 2006-10-12 Brian Warner <warner@lothar.com>
1180 * buildbot/steps/transfer.py: rework __init__ and args setup
1181 * buildbot/slave/commands.py (SlaveFileDownloadCommand): minor
1183 * buildbot/slave/commands.py (SlaveFileDownloadCommand.setup):
1184 when opening the target file, only catch IOError (to report via
1185 stderr/rc!=0), let the others be reported as normal exceptions
1187 2006-10-08 Brian Warner <warner@lothar.com>
1189 * contrib/svn_watcher.py: fix security holes by using proper argv
1190 arrays and subprocess.Popen() rather than commands.getoutput().
1191 Thanks to Nick Mathewson for the patch. Note that svn_watcher.py
1192 is deprecated in favor of buildbot/changes/svnpoller.py, and will
1193 probably be removed by the next release.
1196 2006-10-04 Brian Warner <warner@lothar.com>
1198 * buildbot/steps/python.py (PyFlakes.createSummary): skip any
1199 initial lines that weren't emitted by pyflakes. When the pyflakes
1200 command is run under a Makefile, 'make' will echo the command it
1201 runs to stdio, and that was getting logged as a "misc" warning.
1202 * buildbot/test/test_steps.py (Python.testPyFlakes2): test it
1203 * buildbot/test/test_steps.py (testPyFlakes3): another test
1205 2006-10-01 Brian Warner <warner@lothar.com>
1207 * buildbot/status/html.py (HtmlResource.render): if we get a
1208 unicode object from our content() method, encode it into utf-8
1209 like we've been claiming to all along. This allows the comments
1210 and author names from svnpoller.py to be delivered properly.
1212 * buildbot/changes/svnpoller.py (SvnSource.create_changes):
1213 de-unicodify filenames before creating the Change, because the
1214 rest of buildbot is unlikely to handle them well. Leave the 'who'
1215 field as a unicode object.. I don't think there's anything that
1216 will break very soon, and it will probably nudge us towards
1217 accepting unicode everywhere sooner or later. Stop using the
1218 "date" field that comes out of SVN, since it is using the
1219 repository's clock (and timezone) and what we care about is the
1220 buildmaster's (otherwise Changes from the future show up later
1221 than the builds they triggered).
1222 * buildbot/test/test_svnpoller.py (Everything.test1): match the
1225 * buildbot/changes/svnpoller.py (SvnSource): added Niklaus Giger's
1226 Suvbersion repository polling ChangeSource. I've hacked it up
1227 considerably: any bugs are entirely my own fault. Thank you
1229 * buildbot/test/test_svnpoller.py: tests for it
1230 * docs/buildbot.texinfo (SvnSource): document it
1232 2006-09-30 Brian Warner <warner@lothar.com>
1234 * buildbot/scheduler.py (Periodic): submit a reason= to the
1235 BuildSet to indicate which Scheduler triggered the build. Thanks
1236 to Mateusz Loskot for the suggestion.
1238 * buildbot/test/test_scheduler.py (Scheduling.testPeriodic1): test it
1240 * buildbot/changes/p4poller.py (P4Source): some minor stylistic
1241 changes: set self.loop in __init__, remove unused volatile=
1243 * docs/buildbot.texinfo (.buildbot config directory): add more
1244 docs on the .buildbot/options keys used by "buildbot try"
1245 * buildbot/scripts/tryclient.py (Try.createJob): remove dead code
1246 (Try.deliverJob): same
1248 * buildbot/changes/bonsaipoller.py (BonsaiParser): more updates
1250 (BonsaiPoller): same
1252 * buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
1253 close the filehandle when we stop watching the file. Before, the
1254 filehandle was only closed when the LogFileWatcher was
1255 garbage-collected, which could be quite a while in the future. If
1256 it was still open by the time the next build started, windows will
1257 refuse to let the new build delete the old build/ directory. Fixes
1258 SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
1259 #twisted for the catch.
1261 2006-09-29 Brian Warner <warner@lothar.com>
1263 * buildbot/status/tinderbox.py (TinderboxMailNotifier): updates
1266 2006-09-25 Brian Warner <warner@lothar.com>
1268 * setup.py: the new buildbot.steps module wasn't being installed.
1269 Thanks to Jose Dapena Paz for the catch, fixes SF#1560631.
1270 (testmsgs): add the extra stuff from buildbot/test/* so you can
1271 run unit tests on an installed copy of buildbot, not just from
1274 * contrib/svn_buildbot.py (ChangeSender.getChanges): the first *4*
1275 columns of 'svnlook changed' output contain status information, so
1276 strip [:4] instead of [:6]. Depending upon what the status flags
1277 were, this would sometimes lead to mangled filenames. Thanks to
1278 Riccardo Magliocchetti for the patch. Closes SF#1545146.
1280 * buildbot/steps/source.py (Monotone): initial Monotone support,
1281 contributed by Nathaniel Smith. Still needs docs and tests, but
1282 this code has been in use on the Monotone buildbot for a long
1284 * buildbot/slave/commands.py (Monotone): slave-side support
1285 * buildbot/changes/monotone.py (MonotoneSource): polling change
1288 * buildbot/changes/bonsaipoller.py (BonsaiPoller): Ben also
1289 contributed a Change Source that polls a Bonsai server (a
1290 kind of web-based viewcvs CGI script).
1292 * buildbot/status/tinderbox.py (TinderboxMailNotifier): Ben
1293 Hearsum contributed a status plugin which sends email in the same
1294 format that Tinderbox does: this allows a number of tinderbox
1295 tools to be driven by Buildbot instead. Thanks Ben!
1297 2006-09-24 Brian Warner <warner@lothar.com>
1299 * buildbot/changes/mail.py (parseBonsaiMail): fix the parser.
1300 Thanks to Robert Helmer for the patch.
1302 * buildbot/process/base.py (Build.setupSlaveBuilder): tell our
1303 BuildStatus about the buildslave name at the *beginning* of the
1304 build, rather than at the end. Thanks to Alexander Lorenz for the
1306 * buildbot/status/html.py (StatusResourceBuild.body): always
1307 include the slavename in the build page, not just when the build
1309 * buildbot/status/mail.py (MailNotifier.buildMessage): include the
1310 slavename in the email message
1312 2006-09-21 Brian Warner <warner@lothar.com>
1314 * buildbot/scripts/sample.cfg: update to use new BuildStep classes
1316 * docs/examples/glib_master.cfg: same
1317 * docs/examples/hello.cfg: same
1318 * docs/examples/twisted_master.cfg: same, update to current usage
1320 2006-09-19 Brian Warner <warner@lothar.com>
1322 * buildbot/steps/python.py (PyFlakes): refactor, add summary logs
1323 (PyFlakes.createSummary): make it compatible with python-2.2
1325 * buildbot/test/test_steps.py (Python.testPyFlakes): add a test
1326 for at least the output-parsing parts of PyFlakes
1328 2006-09-18 Brian Warner <warner@lothar.com>
1330 * buildbot/steps/python.py: oops, fix import of StringIO
1332 2006-09-17 Brian Warner <warner@lothar.com>
1334 * buildbot/test/test_vc.py (VCBase._do_vctest_update_retry_1): it
1335 turns out that SVN-1.4.0 doesn't fail to update once you've
1336 replaced a file with a directory, unlike older versions of SVN and
1337 pretty much every other VC tool we support. Since what we really
1338 care about is that the update succeeds anyway, stop checking that
1339 the tree got clobbered and just assert that the build succeeded.
1340 (VCBase.printLogs): add a utility function for debugging
1342 * buildbot/process/step.py: oops, added extra imports by mistake
1344 * buildbot/changes/p4poller.py (P4Source._process_describe): do an
1345 rstrip() on the first line coming out of the 'p4 describe'
1346 process, to remove the stray ^M that Wade Brainerd reports seeing
1347 in the 'when' field. Fixes SF#1555985.
1349 * buildbot/master.py (BuildMaster.loadConfig): improve the error
1350 message logged when c['schedulers'] is not right
1351 * buildbot/scheduler.py (Scheduler.__init__): improve error
1352 message when a Scheduler() is created with the wrong arguments
1353 * buildbot/test/test_config.py (ConfigTest.testSchedulerErrors):
1354 verify that these error messages are emitted
1356 * buildbot/process/buildstep.py: rename step.py to buildstep.py .
1357 The idea is that all the base classes (like BuildStep and
1358 RemoteCommand and LogObserver) live in b.p.buildstep, and b.p.step
1359 will be a leftover backwards-compatibility file that only contains
1360 aliases for the steps that were moved out to buildbot.steps.*
1361 * lots: change imports to match
1362 * buildbot/process/step.py: add a DeprecationWarning if it ever
1365 2006-09-12 Brian Warner <warner@lothar.com>
1367 * buildbot/scheduler.py (Scheduler.__init__): make sure that
1368 builderNames= is actually a sequence, since if you happen to give
1369 it a single builder-specification dictionary instead, it won't get
1370 caught by the existing assert. Thanks to Brett Neely for the
1373 * buildbot/steps/python.py (BuildEPYDoc, PyFlakes): add new steps. No
1375 * docs/buildbot.texinfo (Python BuildSteps): document them
1376 (sendchange): include a link to PBChangeSource, since you need one
1378 * buildbot/steps/shell.py: clean up test-case-name line, remove some
1380 * buildbot/steps/dummy.py: same
1382 2006-09-08 Brian Warner <warner@lothar.com>
1384 * buildbot/steps/transfer.py (FileUpload,FileDownload): new
1385 BuildStep which lets you transfer files from the master to the
1386 slave or vice versa. Thanks to Albert Hofkamp for the original
1387 patch. Fixes SF#1504631.
1388 * buildbot/slave/commands.py (SlaveFileUploadCommand): slave-side
1390 (SlaveFileDownloadCommand): same
1391 * docs/buildbot.texinfo (Transferring Files): document it
1392 * buildbot/test/test_transfer.py: test it
1393 * buildbot/test/runutils.py (StepTester): new utility class for
1394 testing BuildSteps and RemoteCommands without Builds or Bots or PB
1395 * buildbot/test/test_steps.py (CheckStepTester): validate that the
1398 * buildbot/interfaces.py (IStatusLog.readlines): make it easier to
1399 walk through StatusLogs one line at a time, mostly for the benefit
1400 of ShellCommand.createSummary methods. You can either walk through
1401 STDOUT or STDERR, but the default is STDOUT.
1403 * buildbot/status/builder.py (LogFile.readlines): implement it.
1404 Note that this is not yet memory-efficient, it just pulls the
1405 whole file into RAM and then splits it up with a StringIO.
1406 Eventually this should be a generator that only pulls chunks from
1408 * buildbot/test/test_status.py (Log.testReadlines): test it
1410 * docs/buildbot.texinfo: update to match changes
1411 * buildbot/process/factory.py: stop using old definitions
1412 * buildbot/process/process_twisted.py: same
1413 * buildbot/test/test_*.py: same
1415 * buildbot/process/step_twisted.py: move definition to..
1416 * buildbot/steps/python_twisted.py: .. here, unfortunately python's
1417 relative-import mechanisms prevent this from being named 'twisted'
1418 or 'python/twisted' as I would have preferred.
1420 * buildbot/process/maxq.py: move definition to..
1421 * buildbot/steps/maxq.py: .. here, leave a compatibility import
1423 * buildbot/process/step.py: split the user-visible BuildSteps into
1424 separate files, all under buildbot/steps/
1425 * buildbot/steps/source.py: this holds VC-checkout steps like SVN
1426 * buildbot/steps/shell.py: this holds ShellCommand and friends
1427 * buildbot/steps/dummy.py: this holds the testing steps like Dummy
1429 2006-09-05 Brian Warner <warner@lothar.com>
1431 * lots: run pyflakes, removed a lot of unused imports, changed the
1432 form of some conditional imports to remove false pyflakes
1433 warnings. There are still a number of warnings left, mostly from
1434 imports that are done for their side-effects.
1435 * buildbot/test/test_vc.py: import twisted.python.failure, since it
1438 2006-08-26 Brian Warner <warner@lothar.com>
1440 * buildbot/test/test_locks.py (Unit.testLater): make the tests
1441 compatible with twisted-1.3.0, for some reason I just can't seem
1442 to let go of the past.
1444 2006-08-25 Brian Warner <warner@lothar.com>
1446 * buildbot/status/mail.py (MailNotifier.__init__): fix typo in docs
1448 * buildbot/process/step.py (LoggingBuildStep.startCommand): set up
1449 all logfiles= in startCommand(), rather than in start() . This
1450 makes it easier to have the 'stdio' log come before any secondary
1451 logfiles, which I feel makes the waterfall display more
1453 (LoggingBuildStep.setupLogfiles): move the addLog/cmd.useLog code
1454 from ShellCommand up into LoggingBuildStep
1455 (LoggingBuildStep.__init__): move the handling of logfiles= from
1456 ShellCommand up to LoggingBuildStep, because startCommand is
1457 provided by LoggingBuildStep, whereas start() was specific to
1458 subclasses like ShellCommand and Source. This removes code
1459 duplication in those subclasses.
1460 (ShellCommand.__init__): same
1461 (ShellCommand.checkForOldSlaveAndLogfiles): split out the check
1462 for a slave that's too old to understand logfiles= into a separate
1463 method, so it can live in ShellCommand. The rest of
1464 setupLogfiles() can live in LoggingBuildStep.
1466 2006-08-24 Brian Warner <warner@lothar.com>
1468 * buildbot/locks.py (BaseLock): you can now configure Locks to
1469 allow multiple simultaneous owners. They still default to
1470 maxCount=1. Fixes SF#1434997. Thanks to James Knight (foom) for
1472 * docs/buildbot.texinfo (Interlocks): document the new options
1473 * buildbot/test/test_locks.py: add a bunch of new unit tests
1474 * buildbot/process/base.py (Build.acquireLocks): locks now offer
1475 waitUntilMaybeAvailable, not waitUntilAvailable
1476 * buildbot/process/step.py (BuildStep.acquireLocks): same
1477 * buildbot/master.py (BotMaster.getLockByID): real locks now use
1478 the whole lockid in their constructor, not just the name. Also,
1479 keep track of which real locks we've handed out by the full
1480 lockid, not just class+name, otherwise changing just the maxCount=
1481 in the master.cfg file would not actually cause a behavioral
1484 2006-08-23 Brian Warner <warner@lothar.com>
1486 * buildbot/__init__.py (version): bump to 0.7.4+ while between
1488 * docs/buildbot.texinfo: same
1490 2006-08-23 Brian Warner <warner@lothar.com>
1492 * buildbot/__init__.py (version): Releasing buildbot-0.7.4
1493 * docs/buildbot.texinfo: set version to match
1494 * NEWS: update for 0.7.4
1495 * buildbot/slave/commands.py (command_version): mention that this
1496 version (2.1) was released with buildbot-0.7.4
1498 2006-08-22 Brian Warner <warner@lothar.com>
1502 * CREDITS: new file, list of people who have helped. Thanks!
1503 * MANIFEST.in: ship it
1505 * MANIFEST.in: stop shipping the old PyCon-2003 paper.. with the
1506 new diagrams, the user's manual is more informative than it was.
1507 Start shipping the .html user's manual (and generated .png
1509 * Makefile: update 'release' target to match
1511 * buildbot/test/test_web.py (GetURL.testBrokenStuff): delete this
1512 test.. I think the web-parts effort will render it pointless well
1513 before it ever actually starts to work.
1515 2006-08-20 Brian Warner <warner@lothar.com>
1517 * buildbot/changes/pb.py (PBChangeSource): fix and simplify
1518 meaning of the prefix= argument. It is now just a string which is
1519 stripped from the beginning of the filename. If prefix= is set but
1520 not found on any given filename, that filename is ignored. If all
1521 filenames in a Change are ignored, the Change is dropped. This is
1522 much simpler than the previous sep= nonsense, and I should have
1523 implemented it this way from the beginning. Effectively resolves
1524 SF#1217699 and SF#1381867. Thanks to Gary Granger and Marius
1525 Gedminas for the catch and suggested fixes.
1526 (ChangePerspective.perspective_addChange): implement the actual
1528 * buildbot/test/test_changes.py (TestChangePerspective): test it
1529 * docs/buildbot.texinfo (PBChangeSource): document it, explain
1530 how to properly use prefix=
1531 * docs/examples/twisted_master.cfg (source): update prefix= by
1532 adding the trailing slash
1535 * docs/examples/twisted_master.cfg: update to actual practice
1537 * buildbot/test/test_web.py (WaterfallSteps.test_urls): oops,
1538 update test case to match new link text.. the HREF has both a
1539 class= setting and an enclosing [] pair that I didn't match in the
1542 * docs/buildbot.texinfo (ShellCommand.command=): explain why a
1543 list of strings is preferred over a single string with embedded
1545 (ShellCommand.description=): explain that either single strings or
1546 a list of strings is acceptable, and why you might prefer one over
1547 the other. Add an example. Fixes SF#1524659, thanks to Paul
1548 Winkler for the catch.
1549 (Build Steps): update to use f.addStep() rather than using s()
1550 and the constructor list
1552 * buildbot/process/step.py (ShellCommand): accept either a single
1553 string or a list of strings in both description= and
1555 * buildbot/test/test_steps.py (Steps.test_description): test it
1556 * buildbot/test/runutils.py (makeBuildStep): support for that test
1558 * contrib/CSS/*.css: add some contributed CSS stylesheets, to make
1559 the Waterfall display a bit less ugly. Thanks to John O'Duinn for
1560 collecting the files and creating the patch.
1562 * docs/buildbot.texinfo (BuildStep URLs): document new feature:
1563 per-step URLs that will be displayed on the waterfall display,
1564 for things like the HTML output of code-coverage tools, when
1565 the results are hosted elsewhere.
1566 * buildbot/interfaces.py (IBuildStepStatus.getURLs): document the
1567 way to retrieve these URLs
1568 * buildbot/status/builder.py (BuildStepStatus.getURLs): implement
1569 the method to retrieve these URLs. Also provide backwards
1570 compatibility for saved BuildStepStatus instances that didn't have
1572 * buildbot/process/step.py (BuildStep.addURL): method to set these
1573 URLs from within a BuildStep
1574 * buildbot/status/html.py (StepBox.getBox): emit links to the URLs
1575 (StepBox.getBox): give these external links a distinct CSS class
1576 named "BuildStep external" so a .css file can display them
1579 * buildbot/test/test_web.py (WaterfallSteps): test that we really
1581 * buildbot/test/test_steps.py (Steps): test that we can all the
1582 URLs. Also add a bunch of other tests on methods that can be
1583 called from within BuildSteps
1584 * buildbot/test/runutils.py (makeBuildStep): add utility function
1586 2006-08-13 Brian Warner <warner@lothar.com>
1588 * docs/buildbot.texinfo (BuildStep LogFiles): document them
1590 2006-08-10 Brian Warner <warner@lothar.com>
1592 * docs/buildbot.texinfo (Index of master.cfg keys): add another
1593 index, this one of things like c['sources'] and c['schedulers']
1594 (indices): it looks like my clever idea of putting the @fooindex
1595 commands in between the @node and the @subsection (to make the
1596 HREF anchor jump to slightly above the section title, which works
1597 much better in html) confused texinfo horribly, so I'm moving the
1598 index tags back to be just after the @subsection marker. I also
1599 added extra lines between the @node/@section paragraph and the
1600 index tags, since I think maybe texinfo wants to see these be
1601 separate paragraphs.
1603 * docs/Makefile (images): make sure images get built when
1604 rendering the manual
1605 * docs/images/Makefile: same
1607 * buildbot/scripts/runner.py: rename 'buildbot master' to
1608 'buildbot create-master', and 'buildbot slave' to 'buildbot
1610 * docs/buildbot.texinfo: same
1613 * docs/buildbot.texinfo: reimplement the "useful classes" index
1614 with actual texinfo indices. The .info rendering is a bit
1615 weird-looking but it works well, and the HTML rendering is quite
1616 nice. This also puts the index targets in the regular flow of the
1617 text, which is easier to maintain.
1619 2006-08-06 Brian Warner <warner@lothar.com>
1621 * buildbot/slave/commands.py (ShellCommand.__init__): patch from
1622 Kevin Turner to prefer the environ= argument be a list rather than
1623 a string. If it is a list, it will be joined with a platform-local
1624 os.pathsep delimiter, and then prepended to any existing
1625 $PYTHONPATH value. This works better in cross-platform (i.e.
1626 windows buildslaves) environments when you need to push multiple
1627 directories onto the front of the path.
1628 (SlaveShellCommand): documented the new magic
1629 * docs/buildbot.texinfo (ShellCommand): documented the new magic
1630 in a user-visible form
1632 * buildbot/test/test_vc.py (BaseHelper.dovc): patch from Kevin
1633 Turner to prefer lists over strings when creating/running VC
1634 commands during unit tests. This is clearly necessary to survive
1635 vcexe containing spaces, like "C:\Program Files\darcs.exe". I
1636 renamed the wq() function to qw() though, since that's how it's
1637 spelled in perl. Eventually I'd prefer all commands to be
1638 specified with lists.
1640 * buildbot/slave/commands.py (LogFileWatcher): handle logfiles
1641 which are deleted (or not yet created) correctly. Also add
1642 failsafe code to not explode if the file-watching poller doesn't
1643 get started. Thanks to JP Calderone for the catch and the poller
1645 * buildbot/test/test_shell.py (SlaveSide._testLogFiles): add test
1647 * buildbot/test/emitlogs.py: same
1649 * NEWS: summarize recent changes
1651 * docs/buildbot.texinfo (Debug options): suggest an .ssh/options
1652 clause to avoid the "host key mismatch" warning
1654 * buildbot/process/step_twisted.py (Trial.start): if the
1655 buildslave is too old to understand logfiles=, fall back to
1656 running 'cat _trial_temp/test.log' like before.
1657 (Trial.commandComplete): same. this takes advantage of the
1658 LoggingBuildStep refactoring to stall commandComplete long enough
1659 to run a second RemoteShellCommand.
1661 * buildbot/process/step.py (LoggingBuildStep.startCommand):
1662 refactor command-completion handling, to allow methods like
1663 commandComplete/createSummary/evaluateCommand to return Deferreds.
1664 (LoggingBuildStep._commandComplete): delete the refactored method
1665 (ShellCommand.setupLogfiles): if the buildslave is too old to
1666 understand logfiles=, put a warning message both into twistd.log
1667 and into the otherwise empty user-visible LogFiles.
1669 * buildbot/process/step.py (LoggedRemoteCommand.useLog): allow
1670 callers to provide the slave-side logfile name, rather than
1671 forcing it to come from the local name of the LogFile.
1672 (BuildStep.getSlaveName): new method
1674 * buildbot/process/base.py (Build.getSlaveName): new method, so
1675 steps can find out which buildslave they're running on
1677 * buildbot/test/test_steps.py (Version.checkCompare): oops, update
1678 to match the s/cvs_ver/command_version/ change
1680 2006-08-05 Brian Warner <warner@lothar.com>
1682 * buildbot/slave/commands.py (command_version): replace the CVS
1683 auto-updated cvs_ver keyword with a manually-updated variable,
1684 since CVS is no longer the master repository. Add a description of
1685 the remote API change starting in this version (2.1), specifically
1686 the fact that SlaveShellCommand now accepts 'initial_stdin',
1687 'keep_stdin_open', and 'logfiles'.
1689 2006-07-31 Brian Warner <warner@lothar.com>
1691 * docs/buildbot.texinfo (System Architecture): Finally add lots of
1692 diagrams to describe how the whole system fits together. The
1693 images themselves are kept in SVG files, with ascii-art versions
1694 in corresponding .txt files. Texinfo knows how to interpolate the
1695 text version into .info files, reference the .png versions from
1696 .html files, and include .eps versions in the .ps format.
1697 * docs/images/Makefile: tools to create .png and .eps
1698 * docs/images/*.svg: created pictures with Inkscape.
1699 * .darcs-boring: ignore the generated .eps and .png files
1701 2006-07-24 Brian Warner <warner@lothar.com>
1703 * buildbot/master.py (BuildMaster.loadConfig): check for duplicate
1704 Scheduler names, since they cause setServiceParent to explode
1706 * buildbot/test/test_config.py (ConfigTest._testSchedulers_7): test it
1708 2006-07-20 Brian Warner <warner@lothar.com>
1710 * buildbot/scripts/sample.cfg: simplify the sample BuildFactory,
1711 which runs the buildbot unit tests
1713 * docs/buildbot.texinfo (Index of Useful Classes): add a table of
1714 classes that are useful in master.cfg
1716 2006-07-15 Brian Warner <warner@lothar.com>
1718 * Makefile (some-apidocs): new target to build only some epydocs
1720 * setup.py: minor comment.. does the classifiers= argument prevent
1721 the setup.py script from working on python2.2/2.3?
1723 * buildbot/scripts/sample.cfg: update manhole example, arrange into
1726 * buildbot/twcompat.py: fix minor typo in comments
1728 * buildbot/manhole.py: move all Manhole-related code out to this
1729 module. Implement SSH-based manholes (with TwistedConch), and move
1730 to conch's nifty line-editing syntax-coloring REPL shell instead
1731 of the boring non-editing monochromatic (and deprecated) old
1733 * buildbot/master.py: remove all Manhole-related code
1734 (BuildMaster.loadConfig._add): make sure the old manhole is
1735 removed before we add the new one
1736 * docs/buildbot.texinfo (Debug options): document new Manhole options
1738 * buildbot/twcompat.py (_which): fix some epydoc issues
1739 * buildbot/status/html.py (Waterfall.__init__): same
1741 2006-06-29 Brian Warner <warner@lothar.com>
1743 * buildbot/interfaces.py: get Interface from b.twcompat to hush
1744 deprecation warnings under newer Twisteds (by using
1745 zope.interface.Interface instead of old twisted.python.components
1747 * buildbot/slave/interfaces.py: same
1749 2006-06-28 Brian Warner <warner@lothar.com>
1751 * buildbot/slave/commands.py (SVN): add --non-interactive to all
1752 svn commands, so it will fail immediately instead of hanging while
1753 it waits for a username/password to be typed in.
1755 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): add minor
1756 log message if the step was shut down
1758 * buildbot/scripts/runner.py (SlaveOptions.longdesc): remove
1759 obsolete reference to mktap.
1761 2006-06-20 Brian Warner <warner@lothar.com>
1763 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): update
1764 test to include new 'logfiles' argument sent from master to slave
1766 2006-06-19 Brian Warner <warner@lothar.com>
1768 * buildbot/process/step_twisted.py (Trial): track Progress from
1769 _trial_temp/test.log too
1771 * buildbot/process/step.py (OutputProgressObserver): generalize
1772 the earlier StdioProgressObserver into an OutputProgressObserver
1773 that can track LogFiles other than stdio.
1774 (LoggingBuildStep.__init__): same
1776 * buildbot/process/step_twisted.py (Trial): use logfiles= to track
1777 _trial_temp/test.log, not a separate 'cat' command. TODO: this
1778 will fail under windows because of os.sep issues. It might have
1779 worked before if 'cat' was doing cygwin path conversion.
1781 * buildbot/slave/commands.py (LogFileWatcher.__init__): note the
1782 creation of LogFileWatchers
1783 (ShellCommand._startCommand): and record the files that were
1784 watched in the 'headers' section of the ShellCommand output
1786 * buildbot/process/step.py (RemoteShellCommand.__init__): duh, you
1787 need to actually pass it to the slave if you want it to work.
1788 (ShellCommand): document it a bit
1790 * buildbot/test/test_shell.py: new test to validate LogFiles
1791 * buildbot/test/runutils.py (SlaveCommandTestBase): updates to
1793 * buildbot/test/emitlogs.py: enhance to wait for a line on stdin
1794 before printing the last batch of lines, to test that the polling
1795 logic is working properly
1797 * buildbot/process/step.py (LoggedRemoteCommand): improve LogFile
1798 handling, making it possible to track multiple logs for a single
1799 RemoteCommand. The previous single logfile is now known as the
1801 (LoggedRemoteCommand.remoteUpdate): accept key='log' updates
1802 (RemoteShellCommand.__init__): accept logfiles=
1803 (LoggingBuildStep.startCommand): stdio_log is now one of many
1804 (ShellCommand): added logfiles= argument, as well as a class-level
1805 .logfiles attribute, which will be merged together to figure out
1806 which logfiles should be tracked. The latter maybe be useful for
1807 subclasses of ShellCommand which know they will aways produce
1808 secondary logfiles in the same location.
1810 * buildbot/slave/commands.py (ShellCommandPP): add writeStdin()
1811 and closeStdin() methods, preparing to make it possible to write
1812 to a ShellCommand's stdin at any time, not just at startup. These
1813 writes are buffered if the child process hasn't started yet.
1814 (LogFileWatcher): new helper class to watch arbitrary logfiles
1815 while a ShellCommand runs. This class polls the file every two
1816 seconds, and sends back 10k chunks to the buildmaster.
1817 (ShellCommand): rename stdin= to initialStdin=, and add
1818 keepStdinOpen= and logfiles= to arguments. Set up LogFileWatchers
1820 (ShellCommand.addLogfile): LogFile text is sent in updates with a
1821 key of "log" and a value of (logname, data).
1822 (SlaveShellCommand): add 'initial_stdin', 'keep_stdin_open', and
1823 'logfiles' to the master-visible args dictionary.
1824 (SourceBase.doPatch): match s/stdin/initialStdin/ change
1827 * buildbot/test/test_vc.py (Patch.testPatch): same
1830 * buildbot/test/emit.py: write to a logfile in the current
1831 directory. We use this to figure out what was used as a basedir
1832 rather than looking to see which copy of emit.py gets run, so that
1833 we can run the commands from inside _trial_temp rather than inside
1835 * buildbot/test/subdir/emit.py: same
1836 * buildbot/test/runutils.py (FakeSlaveBuilder): take a 'basedir'
1837 argument rather than running from buildbot/test/
1838 (SlaveCommandTestBase.setUpBuilder): explicitly set up the Builder
1839 rather than using an implicit setUp()
1840 * buildbot/test/test_slavecommand.py (ShellBase.setUp): same
1841 (ShellBase.testShell1, etc): use explicit path to emit.py instead
1842 of assuming that we're running in buildbot/test/ (and that '.' is
1845 * buildbot/slave/commands.py (Command.doStart): refactor Command
1846 startup/completion a bit: now the SlaveBuilder calls doStart(),
1847 which is not meant for overridding by subclasses, and doStart()
1848 calls start(), which is. Likewise the SlaveBuilder calls
1849 doInterrupt(), and subclasses override interrupt(). This also puts
1850 responsibility for maintaining .running in Command rather than in
1852 (Command.doInterrupt): same
1853 (Command.commandComplete): same, this is called when the deferred
1854 returned by start() completes.
1855 * buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
1856 (SlaveBuilder.remote_interruptCommand): same
1857 (SlaveBuilder.stopCommand): same
1859 2006-06-16 Brian Warner <warner@lothar.com>
1861 * buildbot/test/test_shell.py: new test file to contain everything
1862 relating to ShellCommand
1863 (SlaveSide.testLogFiles): (todo) test for the upcoming "watch
1864 multiple logfiles in realtime" feature, not yet implemented
1865 * buildbot/test/emitlogs.py: support file for testLogFiles
1866 * docs/buildbot.texinfo (ShellCommand): document the feature
1868 * buildbot/test/test_steps.py (BuildStep.setUp): rmtree refactoring
1870 * buildbot/test/runutils.py (SlaveCommandTestBase): utility class
1871 for tests which exercise SlaveCommands in isolation.
1873 * buildbot/test/test_slavecommand.py: Move some utilities like
1874 SignalMixin and FakeSlaveBuilder from here ..
1875 * buildbot/test/runutils.py: .. to here, so they can be used by
1876 other test classes too
1877 * buildbot/test/test_vc.py: more SignalMixin refactoring
1878 * buildbot/test/test_control.py: same
1879 * buildbot/test/test_run.py: and some rmtree refactoring
1881 2006-06-15 Brian Warner <warner@lothar.com>
1883 * buildbot/test/test_vc.py (P4.testCheckoutBranch): rename from
1884 'testBranch' to match other VC tests and have the tests run in
1885 roughly increasing order of dependency
1887 * buildbot/test/test_steps.py (LogObserver): new test to verify
1888 LogObservers can be created at various times and still get
1889 connected up properly
1891 * buildbot/test/runutils.py (setupBuildStepStatus): utility method
1892 to create BuildStepStatus instances that actually work.
1894 * buildbot/process/step.py (LogObserver): add outReceived and
1895 errReceived base methods, to be overridden
1897 * buildbot/status/builder.py (BuildStatus.addStepWithName): change
1898 API to take a name instead of a step, reducing the coupling
1899 somewhat. This returns the BuildStepStatus object so it can be
1900 passed to the new Step, instead of jamming it directly into the
1902 * buildbot/process/step.py (BuildStep.setStepStatus): add a setter
1904 * buildbot/process/base.py (Build.setupBuild): use both methods
1905 * buildbot/test/test_web.py (Logfile.setUp): rearrange the setup
1906 process a bit to match
1908 2006-06-14 Brian Warner <warner@lothar.com>
1910 * docs/buildbot.texinfo (Adding LogObservers): add some limited
1911 docs on writing new LogObserver classes
1912 (Writing New Status Plugins): brief docs on how Status Plugins fit
1915 * buildbot/process/step_twisted.py (TrialTestCaseCounter):
1916 implement a LogObserver that counts how many unit tests have been
1918 (Trial.__init__): wire it in
1919 * buildbot/test/test_twisted.py (Counter): unit test for it
1921 * buildbot/process/step_twisted.py (HLint.commandComplete): update
1922 to new cmd.logs['stdio'] scheme
1923 (Trial.commandComplete): same
1924 (BuildDebs.commandComplete): same
1926 * buildbot/process/step.py (LoggedRemoteCommand): use a dict of
1927 LogFiles, instead of just a single one. The old single logfile is
1928 now called "stdio". LoggedRemoteCommand no longer creates a
1929 LogFile for you (the code to do that was broken anyway). If you
1930 don't create a "stdio" LogFile, then stdout/stderr will be
1932 (LogObserver): implement "LogObservers", which a BuildStep can add
1933 to parse the output of a command in real-time. The primary use is
1934 to provide more useful information to the Progress code, allowing
1935 better ETA estimates.
1936 (LogLineObserver): utility subclass which feeds complete lines to
1937 the parser instead of bytes.
1938 (BuildStep.progressMetrics): this is safer as a tuple
1939 (BuildStep.setProgress): utility method, meant to be called by
1941 (BuildStep.addLogObserver): new method, to be called at any time
1942 during the BuildStep (even before any LogFiles have been created),
1943 to attach (or schedule for eventual attachment) a LogObserver to a
1945 (StdioProgressObserver): new LogObserver which replaces the old
1946 "output" progress gatherer
1947 (LoggingBuildStep.__init__): same
1948 (LoggingBuildStep.startCommand): set up the "stdio" LogFile
1949 (LoggingBuildStep._commandComplete): must use logs['stdio']
1950 instead of the old single ".log" attribute.
1951 * buildbot/status/builder.py (LogFile): remove old logProgressTo
1952 functionality, now subsumed into StdioProgressObserver
1953 * buildbot/test/test_status.py (Subscription._testSlave_2): the
1954 log name changed from "output" to "stdio".
1957 * buildbot/interfaces.py (ILogFile): add the Interface used from
1958 the BuildStep towards the LogFile
1959 (ILogObserver): and the one provided by a LogObserver
1960 * buildbot/status/builder.py (LogFile): implement it
1962 * buildbot/interfaces.py (LOG_CHANNEL_*): move STDOUT / STDERR /
1963 HEADER constants here ..
1964 * buildbot/status/builder.py (STDOUT): .. from here
1966 2006-06-13 Brian Warner <warner@lothar.com>
1968 * buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
1969 compatibility with python2.2, which doesn't have the 'substr in
1971 (TestP4Poller.makeTime): utility function to construct the
1972 timestamp using the same strptime() approach as p4poller does. It
1973 turns out that time.mktime() behaves slightly differently under
1974 python2.2, probably something to do with the DST flag, and that
1975 causes the test to fail under python2.2. (changing the mktime()
1976 arguments to have dst=0 instead of -1 caused it to fail under
1977 python2.3. Go figure.)
1978 (TestP4Poller._testCheck3): use our makeTime() instead of mktime()
1980 2006-06-12 Brian Warner <warner@lothar.com>
1982 * buildbot/process/step.py (P4): merge in patch SF#1473939, adding
1983 proper Perforce (P4) support. Many many thanks to Scott Lamb for
1984 contributing such an excellent patch, including docs and unit
1985 tests! This makes it *so* much easier to apply. I had to update
1986 test_vc.py to handle some recent refactorings, but everything else
1987 applied smoothly. The only remaining thing I'd like to fix would
1988 be to remove the hard-wired port 1666 used by p4d, and allow it to
1989 claim any unused port. This would allow two copies of the test
1990 suite to run on the same host at the same time, as well as
1991 allowing the test suite to run while a real (production) p4d was
1992 running on the same host. Oh, and maybe we should add a warning to
1993 step.P4 that gets emitted if the slave is too old to provide the
1994 'p4' SlaveCommand. Otherwise it looks great. (closes: SF#1473939).
1995 * buildbot/slave/commands.py (P4): same
1996 (P4Sync): same, some minor updates
1997 * buildbot/changes/p4poller.py: same
1998 * docs/buildbot.texinfo: same
1999 * buildbot/test/test_p4poller.py: same
2000 * buildbot/test/test_vc.py (P4): same
2002 * setup.py: add Trove classifiers for PyPI
2004 2006-06-08 Brian Warner <warner@allmydata.com>
2006 * buildbot/status/client.py
2007 (RemoteBuilder.remote_getCurrentBuilds): oops, I screwed up when
2008 changing this from getCurrentBuild() to getCurrentBuilds(). Each
2009 build needs to be IRemote'd separately, rather than IRemote'ing
2010 the whole list at once. I can't wait until newpb's serialization
2011 adapters make this unnecessary.
2013 2006-06-06 Brian Warner <warner@lothar.com>
2015 * buildbot/process/step.py (WithProperties): make this inherit
2016 from ComparableMixin, so that reloading an unchanged config file
2017 doesn't cause us to spuriously reload any Builders which use them.
2018 * buildbot/test/test_config.py (ConfigTest.testWithProperties):
2021 2006-06-03 Brian Warner <warner@lothar.com>
2023 * contrib/windows/{setup.py, buildbot_service.py}: add support for
2024 running py2exe on windows, contributed by Mark Hammond. Addresses
2025 SF#1401121, but I think we still need to include
2026 buildbot/scripts/sample.cfg
2027 * setup.py: include buildbot_service.py as a script under windows
2028 * buildbot/status/html.py: when sys.frozen (i.e. we're running in
2029 a py2exe application), get the icon/css datafiles from a different
2032 * buildbot/status/mail.py (MailNotifier.buildMessage): don't
2033 double-escape the build URL. Thanks to Olivier Bonnet for the
2034 patch. Fixes SF#1452801.
2036 2006-06-02 Brian Warner <warner@lothar.com>
2038 * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
2039 first six columns of 'svnlook' output, not just the first column,
2040 since property changes appear in the other five. Thanks to Olivier
2041 Bonnet for the patch. Fixes SF#1398174.
2043 2006-06-01 Brian Warner <warner@lothar.com>
2045 * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
2046 the fake build, so that title= has something to be set to
2048 * buildbot/status/html.py (BuildBox.getBox): set the 'title='
2049 attribute of the "Build #NN" link in the yellow start-the-build
2050 box to the build's reason. This means that you get a little
2051 tooltip explaining why the build was done when you hover over the
2052 yellow box. Thanks to Zandr Milewski for the suggestion.
2054 * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
2055 (Box.setETA): handle ETA=None (by stopping the timer)
2056 (Box.update): make the [soon] text less different than the usual
2057 text, so the rest of the text doesn't flop around so much. It
2058 would be awfully nice to figure out how to center this stuff.
2059 (ThreeRowBuilder.stepETAUpdate): more debugging printouts
2061 * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
2062 by default, so that any ShellCommand which fails marks the overall
2063 build as a failure. I should have done this from the beginning.
2064 Add flunkOnFailure=False to the arguments if you want to turn off
2067 2006-05-30 Brian Warner <warner@lothar.com>
2069 * buildbot/clients/gtkPanes.py: add a third row: now it shows
2070 last-build/current-build/current-step. Show what step is currently
2071 running. Show ETA for both the overall build and the current step.
2072 Update GTK calls to modern non-deprecated forms. There's still a
2073 lot of dead code and debug noise to remove.
2075 * buildbot/process/step_twisted.py (Trial): set the step name, so it
2076 shows up properly in status displays
2078 2006-05-28 Brian Warner <warner@lothar.com>
2080 * buildbot/test/test_properties.py (Run.testInterpolate): on the
2081 build we use to verify that WithProperties works:
2083 ** set flunkOnFailure=True so that build failures get noticed
2084 ** set workdir='.' so that the build succeeds, otherwise it is trying
2085 to touch 'build/something', and 'build/' doesn't exist because
2086 usually that's created by a Source step
2087 ** set timeout=10, because Twisted-1.3.0 has a race condition that
2088 this test somehow triggers, in which the 'touch' process becomes
2089 a zombie and we wait for th etimeout before giving up on it.
2091 * buildbot/test/runutils.py (RunMixin.logBuildResults): utility method
2092 to log the Build results and step logs to the twisted log.
2093 (RunMixin.failUnlessBuildSucceeded): use logBuildResults to record
2094 what went wrong if a build was expected to succeed but didn't.
2096 * buildbot/process/step_twisted.py (Trial): set the default
2097 trialMode to '--reporter=bwverbose', which specifies verbose
2098 black-and-white text. Back in twisted-1.3/2.0 days we had to use
2099 '-to', but those are completely missing in modern Twisteds.
2101 * buildbot/scripts/sample.cfg: make the sample Manhole config use
2102 a localhost-only port, to encourage better security
2104 * docs/buildbot.texinfo (Change Sources): mention
2107 * .darcs-boring: add a Darcs boringfile
2109 * README (REQUIREMENTS): stop claiming compatibility with
2112 * contrib/darcs_buildbot.py: write a darcs-commit-hook change
2115 2006-05-27 Brian Warner <warner@lothar.com>
2117 * buildbot/__init__.py: bump to 0.7.3+ while between releases
2118 * docs/buildbot.texinfo: same
2120 2006-05-23 Brian Warner <warner@lothar.com>
2122 * buildbot/__init__.py (version): Releasing buildbot-0.7.3
2123 * docs/buildbot.texinfo: set version to match
2124 * NEWS: update for 0.7.3
2126 * docs/buildbot.texinfo (Change Sources): mention hg_buildbot.py,
2127 give a quick mapping from VC system to possible ChangeSources
2128 (Build Properties): add 'buildername'
2130 * buildbot/process/base.py (Build.setupStatus): oops, set
2131 'buildername' and 'buildnumber' properties
2132 * buildbot/test/test_properties.py (Interpolate.testBuildNumber):
2135 2006-05-22 Brian Warner <warner@lothar.com>
2137 * docs/buildbot.texinfo (Build Properties): explain the syntax of
2138 property interpolation better
2140 * README (INSTALLATION): remove old '-v' argument from recommended
2143 * docs/buildbot.texinfo (ShellCommand): add docs for description=
2144 and descriptionDone= arguments. Thanks to Niklaus Giger for the
2147 * buildbot/slave/commands.py (SVN.parseGotRevision._parse): use
2148 'svnversion' instead of grepping the output of 'svn info', much
2149 simpler and avoids CR/LF problems on windows. Thanks to Olivier
2150 Bonnet for the suggestion.
2151 (SVN.parseGotRevision): oops, older verisons of 'svnversion'
2152 require the WC_PATH argument, so run 'svnversion .' instead.
2154 * buildbot/interfaces.py (IChangeSource): methods in Interfaces
2155 aren't supposed to have 'self' in their argument list
2157 2006-05-21 Brian Warner <warner@lothar.com>
2159 * buildbot/process/step.py (ShellCommand.start): make
2160 testInterpolate pass. I was passing the uninterpolated command to
2161 the RemoteShellCommand constructor
2162 (ShellCommand._interpolateProperties): oops, handle non-list
2163 commands (i.e. strings with multiple words separated by spaces in
2164 them) properly, instead of forgetting about them.
2166 * buildbot/test/test_properties.py (Run.testInterpolate): new test
2167 to actually try to use build properties in a real build. This test
2169 * buildbot/test/runutils.py (RunMixin.requestBuild): utility methods
2170 to start and evaluate builds
2172 * buildbot/test/test__versions.py: add a pseudo-test to record
2173 what version of Twisted/Python/Buildbot are running. This should
2174 show up at the beginning of _trial_tmp/test.log, and exists to help
2175 debug other problems.
2177 * buildbot/status/html.py (Waterfall): add 'robots_txt=' argument,
2178 a filename to be served as 'robots.txt' to discourage web spiders.
2179 Adapted from a patch by Tobi Vollebregt, thanks!
2180 * buildbot/test/test_web.py (Waterfall._test_waterfall_5): test it
2181 (Waterfall.test_waterfall): tweak the way that filenames are put
2182 into the config file, to accomodate windows pathnames better.
2184 * docs/buildbot.texinfo (HTML Waterfall): document it
2186 * buildbot/process/process_twisted.py
2187 (QuickTwistedBuildFactory.__init__): recent versions of Twisted
2188 changed the build process. The new setup.py no longer takes the
2190 (FullTwistedBuildFactory.__init__): same
2191 (TwistedReactorsBuildFactory.__init__): same
2193 * contrib/hg_buildbot.py: wrote a commit script for mercurial, to
2194 be placed in the [hooks] section of the central repository (the
2195 one that everybody pushes changes to).
2197 2006-05-20 Brian Warner <warner@lothar.com>
2199 * buildbot/slave/commands.py (Darcs.doVCFull): when writing the
2200 .darcs-context file, use binary mode. I think this was causing a
2201 Darcs failure under windows.
2203 2006-05-19 Brian Warner <warner@lothar.com>
2205 * buildbot/scripts/tryclient.py (CVSExtractor.getBaseRevision):
2206 use a timezone string of +0000 and gmtime, since this timestamp is
2207 sent to a buildmaster and %z is broken.
2209 * buildbot/test/test_vc.py (CVSHelper.getdate): use no timezone
2210 string and localtime, since this timestamp will only be consumed
2211 locally, and %z is broken.
2213 * buildbot/slave/commands.py (CVS.parseGotRevision): use +0000 and
2214 gmtime, since this timestamp is returned to the buildmaster, and
2217 2006-05-18 Brian Warner <warner@lothar.com>
2219 * NEWS: update in preparation for next release
2221 * buildbot/test/test_vc.py (VCS_Helper): factor out all the
2222 setup-repository and do-we-have-the-vc-tools code into a separate
2223 "helper" class, which sticks around in a single module-level
2224 object. This seems more likely to continue to work in the future
2225 than having it hide in the TestCase and hope that TestCases stick
2226 around for a long time.
2228 * buildbot/test/test_vc.py (MercurialSupport.vc_create): 'hg
2229 addremove' has been deprecated in recent versions of mercurial, so
2230 use 'hg add' instead
2232 2006-05-07 Brian Warner <warner@lothar.com>
2234 * buildbot/scheduler.py (Try_Jobdir.messageReceived): when
2235 operating under windows, move the file before opening it, since
2236 you can't rename a file that somebody has open.
2238 * buildbot/process/base.py (Build.setupBuild): if something goes
2239 wrong while creating a Step, log the name and arguments, since the
2240 error message when you get the number of arguments wrong is really
2243 2006-05-06 Brian Warner <warner@lothar.com>
2245 * buildbot/process/step_twisted.py (Trial.setupEnvironment): more
2246 bugs in twisted-specific code not covered by my unit tests, this
2247 time use 'cmd' argument instead of self.cmd
2249 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
2250 fix stupid braino: either use startwith or find()==0, not both.
2251 (TwistedReactorsBuildFactory.__init__): another dumb typo
2253 * buildbot/test/test_slavecommand.py (ShellBase.testInterrupt1):
2254 mark this test as TODO under windows, since process-killing seems
2255 dodgy there. We'll come back to this later and try to fix it
2258 * buildbot/test/test_vc.py (CVSSupport.getdate): use localtime,
2259 and don't include a timezone
2260 (CVSSupport.vc_try_checkout): stop trying to strip the timezone.
2261 This should avoid the windows-with-verbose-timezone-name problem
2263 (Patch.testPatch): add a test which runs 'patch' with less
2264 overhead than the full VCBase.do_patch sequence, to try to isolate
2265 a windows test failure. This one uses slave.commands.ShellCommand
2266 and 'patch', but none of the VC code.
2268 * buildbot/slave/commands.py (getCommand): use which() to find the
2269 executables for 'cvs', 'svn', etc. This ought to help under
2272 * buildbot/test/test_vc.py (VCBase.do_getpatch): Delete the
2273 working directory before starting. If an earlier test failed, the
2274 leftover directory would mistakenly flunk a later test.
2275 (ArchCommon.registerRepository): fix some tla-vs-baz problems.
2276 Make sure that we use the right commandlines if which("tla") picks
2277 up "tla.exe" (as it does under windows).
2278 (TlaSupport.do_get): factor out this tla-vs-baz difference
2279 (TlaSupport.vc_create): more tla-vs-baz differences
2281 * buildbot/test/test_slavecommand.py
2282 (ShellBase.testShellMissingCommand): stop trying to assert
2283 anything about the error message: different shells on different
2284 OSes with different languages makes it hard, and it really isn't
2285 that interesting of a thing to test anyway.
2287 * buildbot/test/test_vc.py (CVSSupport.capable): skip CVS tests if
2288 we detect cvs-1.10 (which is the version shipped with OS-X 10.3
2289 "Panther"), because it has a bug which flunks a couple tests in
2290 weird ways. I've checked that cvs-1.12.9 (as shipped with debian)
2291 is ok. OS-X 10.4 "Tiger" ships with cvs-1.11, but I haven't been
2292 able to test that yet.
2294 2006-04-30 Brian Warner <warner@lothar.com>
2296 * buildbot/test/test_vc.py (VCBase.runCommand): set $LC_ALL="C" to
2297 make sure child commands emit messages in english, so our regexps
2298 will match. Thanks to Nikaus Giger for identifying the problems.
2299 (VCBase._do_vctest_export_1): mode="export" is not responsible
2300 for setting the "got_revision" property, since in many cases it is
2301 not convenient to determine.
2302 (SVNSupport.capable): when running 'svn --version' to check for
2303 ra_local, we want error messages in english
2304 * buildbot/test/test_slavecommand.py
2305 (ShellBase.testShellMissingCommand): set $LC_ALL="C" to get bash
2306 to emit the error message in english
2308 * buildbot/slave/commands.py (SourceBase.setup): stash a copy of
2309 the environment with $LC_ALL="C" so that Commands which need to
2310 parse the output of their child processes can obtain it in
2312 (SVN.parseGotRevision): call "svn info" afterwards instead of
2313 watching the output of the "svn update" or "svn checkout".
2314 (Darcs.parseGotRevision): use $LC_ALL="C" when running the command
2315 (Arch.parseGotRevision): same
2316 (Bazaar.parseGotRevision): same
2317 (Mercurial.parseGotRevision): same
2319 * buildbot/scripts/tryclient.py (SourceStampExtractor.dovc): set
2320 $LC_ALL="C" when running commands under 'buildbot try', too
2322 * buildbot/test/__init__.py: remove the global os.environ()
2323 setting, instead we do it just for the tests that run commands and
2324 need to parse their output.
2326 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir):
2327 remove the overly-short .timeout on this test, because non-DNotify
2328 platforms must fall back to polling which happens at 10 second
2329 intervals, so a 5 second timeout would never succeed.
2331 2006-04-24 Brian Warner <warner@lothar.com>
2333 * docs/buildbot.texinfo (Installing the code): update trial
2334 invocation, SF#1469116 by Niklaus Giger.
2335 (Attributes of Changes): updated branch-name examples to be
2336 a bit more realistic, SF#1475240 by Stephen Davis.
2338 * contrib/windows/buildbot2.bat: utility wrapper for windows
2339 developers, contributed by Nick Trout (after a year of neglect..
2340 sorry!). SF#1194231.
2342 * buildbot/test/test_vc.py (*.capable): store the actual VC
2343 binary's pathname in VCS[vcname], so it can be retrieved later
2344 (CVSSupport.vc_try_checkout): incorporate Niklaus Giger's patch to
2345 strip out non-numeric timezone information, specifically the funky
2346 German string that his system produced that confuses CVS.
2347 (DarcsSupport.vc_create): use dovc() instead of vc(), this should
2348 allow Darcs tests to work on windows
2349 * buildbot/scripts/tryclient.py (SourceStampExtractor): use
2350 procutils.which() everywhere, to allow tryclient to work under
2351 windows. Also from Niklaus Giger, SF#1463394.
2353 * buildbot/twcompat.py (which): move the replacement for a missing
2354 twisted.python.procutils.which from test_vc.py to here, so it can
2355 be used in other places too (specifically tryclient.py)
2357 2006-04-23 Brian Warner <warner@lothar.com>
2359 * buildbot/status/html.py (StatusResourceBuild.body): replace the
2360 bare buildbotURL/projectName line with a proper DIV, along with a
2361 CSS class of "title", from Stefan Seefeld (SF#1461675).
2362 (WaterfallStatusResource.body0): remove the redundant 'table'
2363 class from the table
2364 (WaterfallStatusResource.body): same. Also add class="LastBuild"
2365 to the top-row TR, and class="Activity" to the second-row TR,
2366 rather than putting them in the individual TD nodes.
2368 * buildbot/test/test_vc.py (VCBase.checkGotRevision): test
2369 'got_revision' build property for all VC systems that implement
2370 accurate ones: SVN, Darcs, Arch, Bazaar, Mercurial.
2372 * buildbot/slave/commands.py (SourceBase._handleGotRevision): try
2373 to determine which revision we actually obtained
2374 (CVS.parseGotRevision): implement this for CVS, which just means
2375 to grab a timestamp. Not ideal, and it depends upon the buildslave
2376 having a clock that is reasonably well syncronized with the server,
2377 but it's better than nothing.
2378 (SVN.parseGotRevision): implement it for SVN, which is accurate
2379 (Darcs.parseGotRevision): same
2380 (Arch.parseGotRevision): same
2381 (Bazaar.parseGotRevision): same
2382 (Mercurial.parseGotRevision): same
2384 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate):
2385 keep a record of all non-stdout/stderr/header/rc status updates,
2386 for the benefit of RemoteCommands that send other useful things,
2388 (Source.commandComplete): put any 'got_revision' status values
2389 into a build property of the same name
2392 * buildbot/process/step_twisted.py (Trial): update to deal with
2393 new ShellCommand refactoring
2395 * docs/buildbot.texinfo (Build Properties): document new feature
2396 that allows BuildSteps to get/set Build-wide properties like which
2397 revision was requested and/or checked out.
2399 * buildbot/interfaces.py (IBuildStatus.getProperty): new method
2400 * buildbot/status/builder.py (BuildStatus.getProperty): implement
2401 it. Note that this bumps the persistenceVersion of the saved Build
2402 object, so add the necessary upgrade-old-version logic to include
2403 an empty properties dict.
2405 * buildbot/process/base.py (Build.setProperty): implement it
2406 (Build.getProperty): same
2407 (Build.startBuild): change build startup to set 'branch',
2408 'revision', and 'slavename' properties at the right time
2410 * buildbot/process/step.py (BuildStep.__init__): change setup to
2411 require 'build' argument in a better way
2412 (LoggingBuildStep): split ShellCommand into two pieces, for better
2413 subclassing elsewhere. LoggingBuildStep is a BuildStep which runs
2414 a single RemoteCommand that sends stdout/stderr status text. It
2415 also provides the usual commandComplete / createSummary /
2416 evaluateCommand / getText methods to be overridden...
2417 (ShellCommand): .. whereas ShellCommand is specifically for
2418 running RemoteShellCommands. Other shell-like BuildSteps (like
2419 Source) can inherit from LoggingBuildStep instead of ShellCommand
2420 (WithProperties): marker class to do build-property interpolation
2421 (Source): inherit from LoggingBuildStep instead of ShellCommand
2424 * buildbot/test/test_properties.py: test new functionality
2426 2006-04-21 Brian Warner <warner@lothar.com>
2428 * buildbot/test/test_vc.py: rename testBranch to
2429 testCheckoutBranch to keep the tests in about the right
2432 2006-04-18 Brian Warner <warner@lothar.com>
2434 * docs/buildbot.texinfo (PBListener): improve cross-references
2435 between PBListener and 'buildbot statusgui', thanks to John Pye
2438 2006-04-17 Brian Warner <warner@lothar.com>
2440 * buildbot/twcompat.py (maybeWait): handle SkipTest properly when
2441 running under Twisted-1.3.0, otherwise skipped tests are reported
2444 * all: use isinstance() instead of 'type(x) is foo', suggested by
2447 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
2448 oops, fix a brain-fade from the other week, when making the
2449 addStep changes. I changed all the __init__ upcalls to use the
2450 wrong superclass name.
2451 (FullTwistedBuildFactory.__init__): same
2452 (TwistedDebsBuildFactory.__init__): same
2453 (TwistedReactorsBuildFactory.__init__): same
2454 (TwistedBuild.isFileImportant): use .startswith for clarity,
2455 thanks to Neal Norwitz for the suggestions.
2457 * contrib/viewcvspoll.py: script to poll a viewcvs database for
2458 changes, then deliver them over PB to a remote buildmaster.
2460 * contrib/svnpoller.py: added script by John Pye to poll a remote
2461 SVN repository (by running 'svn log') from a cronjob, and run
2462 'buildbot sendchange' to deliver the changes to a remote
2464 * contrib/svn_watcher.py: added script by Niklaus Giger (a
2465 modification of svnpoller.py), same purpose, but this one loops
2466 internally (rather than expecting to run from a cronjob) and works
2468 * contrib/README.txt: same
2470 2006-04-11 Brian Warner <warner@lothar.com>
2472 * all: fix a number of incorrect names and missing imports, thanks
2473 to Anthony Baxter for the patch.
2474 * buildbot/status/html.py (WaterfallStatusResource.statusToHTML):
2475 remove unused buggy method.
2476 * buildbot/status/builder.py (BuildStatus.saveYourself): rmtree
2477 comes from shutil, not "shutils"
2478 * buildbot/process/step.py (TreeSize.evaluateCommand): fix bad name
2479 (Arch.checkSlaveVersion): same
2480 * buildbot/process/step_twisted.py (Trial.commandComplete): same, in
2482 * buildbot/process/step_twisted2.py: add some missing imports
2483 * buildbot/twcompat.py (_deferGenerator): fix cut-and-paste error,
2484 this code used to live in twisted.internet.defer
2486 2006-04-10 Brian Warner <warner@lothar.com>
2488 * buildbot/process/step.py (Mercurial): add Mercurial support
2489 * buildbot/slave/commands.py (Mercurial): same
2490 * buildbot/scripts/tryclient.py (MercurialExtractor): same
2491 * buildbot/test/test_vc.py (Mercurial): same, checkout over HTTP is
2492 not yet tested, but 'try' support *is* covered
2493 * docs/buildbot.texinfo (Mercurial): document it
2495 * buildbot/process/step.py (LoggedRemoteCommand.remoteUpdate): add
2496 some debugging messages (turned off)
2497 * buildbot/test/test_vc.py: improve debug messages
2499 2006-04-07 Brian Warner <warner@lothar.com>
2501 * buildbot/test/test_vc.py (which): define our own which() in case
2502 we can't import twisted.python.procutils, because procutils doesn't
2503 exist in Twisted-1.3
2505 * docs/buildbot.texinfo (Interlocks): fix some typos, mention use
2506 of SlaveLocks for performance tests
2508 * docs/examples/twisted_master.cfg: update to match current usage
2510 * buildbot/changes/p4poller.py (P4Source): add new arguments:
2511 password, p4 binary, pollinterval, maximum history to check.
2512 Patch from an anonymous sf.net contributor, SF#1219384.
2513 * buildbot/process/step.py (P4Sync.__init__): add username,
2514 password, and client arguments.
2515 * buildbot/slave/commands.py (P4Sync): same
2517 2006-04-05 Brian Warner <warner@lothar.com>
2519 * buildbot/process/factory.py (BuildFactory.addStep): new method
2520 to add steps to a BuildFactory. Use it instead of f.steps.append,
2521 and you can probably avoid using the s() convenience function.
2522 Patch from Neal Norwitz, sf.net #1412605.
2523 (other): update all factories to use addStep
2524 * buildbot/process/process_twisted.py: update all factories to use
2527 2006-04-03 Brian Warner <warner@lothar.com>
2529 * buildbot/test/test_vc.py: modified find-the-VC-command logic to
2530 work under windows too. Adapted from a patch by Niklaus Giger,
2531 addresses SF#1463399.
2533 * buildbot/test/__init__.py: set $LANG to 'C', to insure that
2534 spawned commands emit parseable results in english and not some
2535 other language. Patch from Niklaus Giger, SF#1463395.
2537 * README (INSTALLATION): discourage users from running unit tests on
2538 a "network drive", patch from Niklaus Giger, SF#1463394.
2540 2006-03-22 Brian Warner <warner@lothar.com>
2542 * contrib/svn_buildbot.py: rearrange, add an easy-to-change
2543 function to turn a repository-relative pathname into a (branch,
2544 branch-relative-filename) tuple. Change this function to handle
2545 the branch naming policy used by your Subversion repository.
2546 Thanks to AllMyData.com for sponsoring this work.
2548 2006-03-16 Brian Warner <warner@lothar.com>
2550 * buildbot/scripts/sample.cfg: add python-mode declaration for
2551 vim. Thanks to John Pye for the patch.
2553 * docs/buildbot.texinfo (Launching the daemons): fix @reboot job
2554 command line, mention the importance of running 'crontab' as the
2555 buildmaster/buildslave user. Thanks to John Pye for the catch.
2557 2006-03-13 Brian Warner <warner@lothar.com>
2559 * buildbot/status/words.py (IRC): add an optional password=
2560 argument, which will be sent to Nickserv in an IDENTIFY message at
2561 login, to claim the nickname. freenode requires this before the
2562 bot can sent (or reply to) private messages. Thanks to Clement
2563 Stenac for the patch.
2564 * docs/buildbot.texinfo (IRC Bot): document it
2566 * buildbot/status/builder.py (LogFile.merge): don't write chunks
2567 larger than chunkSize. Fixes SF#1349253.
2568 * buildbot/test/test_status.py (Log.testLargeSummary): test it
2569 (Log.testConsumer): update to match new internal chunking behavior
2571 2006-03-12 Brian Warner <warner@lothar.com>
2573 * buildbot/test/test_vc.py: remove the last use of waitForDeferred
2575 * buildbot/test/test_maildir.py (MaildirTest): rename the
2576 'timeout' method, as it collides with trial's internals
2578 * buildbot/scripts/runner.py: add 'buildbot restart' command
2579 (stop): don't sys.exit() out of here, otherwise restart can't work
2580 * docs/buildbot.texinfo (Shutdown): document it
2582 * buildbot/buildset.py (BuildSet.__init__): clean up docstring
2583 * buildbot/status/html.py (Waterfall.__init__): same
2584 * buildbot/process/builder.py (Builder.startBuild): same
2585 * buildbot/process/base.py (BuildRequest): same
2586 * buildbot/sourcestamp.py (SourceStamp): same
2587 * buildbot/scheduler.py (Nightly): same
2589 * buildbot/__init__.py (version): bump to 0.7.2+ while between
2591 * docs/buildbot.texinfo: same
2593 2006-02-17 Brian Warner <warner@lothar.com>
2595 * buildbot/__init__.py (version): Releasing buildbot-0.7.2
2596 * docs/buildbot.texinfo: set version number to match
2597 * NEWS: update for 0.7.2
2599 2006-02-16 Brian Warner <warner@lothar.com>
2601 * docs/buildbot.texinfo (Build Dependencies): add cindex tag
2603 2006-02-09 Brian Warner <warner@lothar.com>
2605 * docs/buildbot.texinfo (How Different VC Systems Specify Sources):
2606 add text to explain per-build branch parameters
2607 * NEWS: mention --umask
2609 2006-02-08 Brian Warner <warner@lothar.com>
2611 * buildbot/scripts/runner.py (Maker.makeSlaveTAC): remove unused
2613 (SlaveOptions.optParameters): add --umask, to make it possible to
2614 make buildslave-generated files (including build products) be
2617 * buildbot/slave/bot.py (BuildSlave.startService): same
2619 2006-01-23 Brian Warner <warner@lothar.com>
2621 * buildbot/status/builder.py: urllib.quote() all URLs that include
2622 Builder names, so that builders can include characters like '/'
2623 and ' ' without completely breaking the resulting HTML. Thanks to
2624 Kevin Turner for the patch.
2625 * buildbot/status/html.py: same
2626 * buildbot/test/test_web.py (GetURL.testBuild): match changes
2628 * NEWS: update in preparation for upcoming release
2630 2006-01-18 Brian Warner <warner@lothar.com>
2632 * docs/examples/twisted_master.cfg: update to match the Twisted
2633 buildbot: remove python2.2, switch to exarkun's buildslaves,
2634 disable the .deb builder until we figure out how to build twisted
2635 .debs from SVN, add some ktrace debugging to the OS-X build
2636 process and remove the qt build, remove threadless builders,
2637 change freebsd builder to use landonf's buildslave.
2639 2006-01-12 Brian Warner <warner@lothar.com>
2641 * buildbot/master.py (Manhole.__init__): let port= be a strports
2642 specification string, but handle a regular int for backwards
2643 compatibility. This allows "tcp:12345:interface=127.0.0.1" to be
2644 used in master.cfg to limit connections to just the local host.
2645 (BuildMaster.loadConfig): same for c['slavePortnum']
2646 * buildbot/scheduler.py (Try_Userpass.__init__): same
2647 * buildbot/status/client.py (PBListener.__init__): same
2648 * buildbot/status/html.py (Waterfall.__init__): same, for both
2649 http_port and distrib_port. Include backwards-compatibility checks
2650 so distrib_port can be a filename string and still mean unix:/foo
2651 * docs/buildbot.texinfo (Setting the slaveport): document it
2652 (Debug options): same
2653 (HTML Waterfall): same
2656 * buildbot/test/test_config.py (ConfigTest): test it
2658 * buildbot/master.py (BuildMaster.loadConfig): wait for the
2659 slaveport's disownServiceParent deferred to fire before opening
2660 the new one. Fixes an annoying bug in the unit tests.
2662 2006-01-03 Brian Warner <warner@lothar.com>
2664 * buildbot/master.py (BuildMaster): remove the .schedulers
2665 attribute, replacing it with an allSchedulers() method that looks
2666 for all IService children that implement IScheduler. Having only
2667 one parent/child relationship means fewer opportunities for bugs.
2668 (BuildMaster.allSchedulers): new method
2669 (BuildMaster.loadConfig_Schedulers): update to use allSchedulers,
2670 also fix ugly bug that caused any config-file reload to
2671 half-forget about the earlier Schedulers, causing an exception
2672 when a Change arrived and was handed to a half-connected
2673 Scheduler. The exception was in scheduler.py line 54ish:
2674 self.parent.submitBuildSet(bs)
2675 exceptions.AttributeError: 'NoneType' object has no attribute
2677 (BuildMaster.addChange): update to use allSchedulers()
2679 * buildbot/scheduler.py (BaseScheduler.__implements__): fix this
2680 to work properly with twisted-1.3.0, where you must explicitly
2681 include the __implements__ from parent classes
2682 (BaseScheduler.__repr__): make it easier to distinguish distinct
2684 (BaseUpstreamScheduler.__implements__): same
2686 * buildbot/status/builder.py (Status.getSchedulers): update to
2688 * buildbot/test/test_run.py (Run.testMaster): same
2689 * buildbot/test/test_dependencies.py (Dependencies.findScheduler): same
2690 * buildbot/test/test_config.py (ConfigTest.testSchedulers): same,
2691 make sure Scheduler instances are left alone when an identical
2692 config file is reloaded
2693 (ConfigElements.testSchedulers): make sure Schedulers are properly
2696 * Makefile (TRIALARGS): my local default Twisted version is now
2697 2.1.0, update the trial arguments accordingly
2699 2005-12-22 Brian Warner <warner@lothar.com>
2701 * docs/examples/twisted_master.cfg: merge changes from pyr: add
2704 * buildbot/scheduler.py (BaseScheduler.addChange): include a dummy
2705 addChange in the parent class, although I suspect this should be
2706 fixed better in the future.
2708 2005-11-26 Brian Warner <warner@lothar.com>
2710 * buildbot/scheduler.py (AnyBranchScheduler.addChange): don't
2711 explode when branch==None, thanks to Kevin Turner for the catch
2712 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch): test
2715 * buildbot/__init__.py (version): bump to 0.7.1+ while between
2717 * docs/buildbot.texinfo: same
2719 2005-11-26 Brian Warner <warner@lothar.com>
2721 * buildbot/__init__.py (version): Releasing buildbot-0.7.1
2722 * docs/buildbot.texinfo: set version number to match
2724 2005-11-26 Brian Warner <warner@lothar.com>
2726 * NEWS: update for 0.7.1
2728 * buildbot/status/builder.py (BuildStepStatus.unsubscribe): make
2729 sure that unsubscribe works even if we never sent an ETA update.
2730 Also, don't explode on duplicate unsubscribe.
2731 (BuildStepStatus.addLog): make the convenience "return self"-added
2732 watcher automatically unsubscribe when the Step finishes.
2733 (BuildStatus.unsubscribe): same handle-duplicate-unsubscribe
2734 (BuildStatus.stepStarted): same auto-unsubscribe
2735 (BuilderStatus.buildStarted): same auto-unsubscribe
2737 * buildbot/interfaces.py (IStatusReceiver.buildStarted): document
2739 (IStatusReceiver.stepStarted): same
2740 (IStatusReceiver.logStarted): same
2742 * buildbot/test/test_run.py (Status): move the Status test..
2743 * buildbot/test/test_status.py (Subscription): .. to here
2745 2005-11-25 Brian Warner <warner@lothar.com>
2747 * NEWS: more updates
2749 * buildbot/locks.py: fix the problem in which loading a master.cfg
2750 file that changes some Builders (but not all of them) can result
2751 in having multiple copies of the same Lock. Now, the real Locks
2752 are kept in a table inside the BotMaster, and the Builders/Steps
2753 use "LockIDs", which are still instances of MasterLock and
2754 SlaveLock. The real Locks are instances of the new RealMasterLock
2755 and RealSlaveLock classes.
2756 * buildbot/master.py (BotMaster.getLockByID): new method to
2757 convert LockIDs into real Locks.
2758 * buildbot/process/base.py (Build.startBuild): convert LockIDs
2759 into real Locks before building
2760 * buildbot/process/step.py (BuildStep.startStep): same
2761 * buildbot/test/test_locks.py (Locks.testLock1a): add a test which
2762 exercises the problem
2765 * docs/buildbot.texinfo (Scheduler Types): give a few hints about
2766 what Schedulers are available
2768 * buildbot/scheduler.py (Nightly): add new Scheduler based upon
2769 work by Dobes Vandermeer and hacked mercilessly by me. This offers
2770 'cron'-style build scheduling at certain times of day, week,
2772 * buildbot/test/test_scheduler.py (Scheduling.testNightly): test it
2774 * buildbot/scheduler.py (Scheduler): change fileIsImportant
2775 handling: treat self.fileIsImportant more as an attribute that
2776 contains a callable than as a method. If the attribute is None,
2777 don't call it and assume all filenames are important. It is still
2778 possible to provide a fileIsImportant method in a subclass,
2780 (AnyBranchScheduler): handle fileIsImportant=None, previously it
2782 * buildbot/test/test_scheduler.py (Scheduling.testAnyBranch2):
2783 test using AnyBranchScheduler with fileIsImportant=None
2785 2005-11-24 Brian Warner <warner@lothar.com>
2787 * buildbot/test/test_config.py (StartService): don't claim a fixed
2788 port number, instead set slavePort=0 on the first pass, figure out
2789 what port was allocated, then switch to a config file that uses
2792 * buildbot/master.py (BuildMaster.loadConfig): close the old
2793 slaveport before opening the new one, because unit tests might
2794 replace slavePort=0 with the same allocated portnumber, and if we
2795 don't wait for the old port to close first, we get a "port already
2796 in use" error. There is a tiny race condition here, but the only
2797 threat is from other programs that bind (statically) to the same
2798 port number we happened to be allocated, and only if those
2799 programs use SO_REUSEADDR, and only if they get control in between
2802 * Makefile (TRIALARGS): update to handle Twisted > 2.1.0
2804 * buildbot/master.py (BuildMaster.loadConfig_Sources): remove all
2805 deleted ChangeSources before adding any new ones
2806 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): fix
2807 compare_attrs, to make sure that a config-file reload does not
2808 unnecessarily replace an unmodified ChangeSource instance
2809 * buildbot/test/test_config.py (ConfigTest.testSources): update
2811 * buildbot/scheduler.py (AnyBranchScheduler): fix branches=[] to
2812 mean "don't build anything", and add a warning if it gets used
2813 because it isn't actually useful.
2815 * contrib/svn_buildbot.py: update example usage to match the port
2816 number that gets used by the PBChangeSource
2817 * buildbot/scripts/sample.cfg: add example of PBChangeSource
2819 2005-11-22 Brian Warner <warner@lothar.com>
2821 * NEWS: start collecting items for next release
2823 * buildbot/process/step.py (SVN.computeSourceRevision): assume
2824 revisions are strings
2825 (P4Sync.computeSourceRevision): same
2827 * buildbot/status/html.py (StatusResourceBuild.body): add a link
2828 to the Buildbot's overall status page
2829 (StatusResourceBuilder.body): same
2831 2005-11-15 Brian Warner <warner@lothar.com>
2833 * buildbot/master.py (BuildMaster.loadConfig): serialize the
2834 config-file loading, specifically to make sure old StatusTargets
2835 are finished shutting down before new ones start up (thus
2836 resolving a bug in which changing the Waterfall object would fail
2837 because both new and old instances were claiming the same
2838 listening port). Also load new Schedulers after all the new
2839 Builders are set up, in case they fire off a new build right away.
2840 * buildbot/test/test_config.py (StartService): test it
2842 * buildbot/status/mail.py (MailNotifier.buildMessage): oops, add
2843 the branch name to the mail body
2845 * buildbot/changes/pb.py (PBChangeSource.compare_attrs): add this.
2846 Without it, a config-file reload fails to update an existing
2848 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): add
2849 username/passwd to compare_attrs, for the same reason
2850 * buildbot/status/html.py (Waterfall): add favicon to
2851 compare_attrs, same reason
2853 2005-11-05 Brian Warner <warner@lothar.com>
2855 * buildbot/scripts/tryclient.py (createJobfile): stringify the
2856 baserev before stuffing it in the jobfile. This resolves problems
2857 under SVN (and probably Arch) where revisions are expressed as
2858 numbers. I'm inclined to use string-based revisions everywhere in
2859 the future, but this fix should be safe for now. Thanks to Steven
2860 Walter for the patch.
2862 * buildbot/changes/changes.py (ChangeMaster.saveYourself): use
2863 binary mode when opening pickle files, to make windows work
2864 better. Thanks to Dobes Vandermeer for the catch.
2865 * buildbot/status/builder.py (BuildStatus.saveYourself): same
2866 (BuilderStatus.getBuildByNumber): same
2867 (Status.builderAdded): same
2868 * buildbot/master.py (BuildMaster.loadChanges): same
2870 * buildbot/util.py (Swappable): delete unused leftover code
2872 * buildbot/process/step.py (SVN): when building on a non-default
2873 branch, add the word "[branch]" to the VC step's description, so
2874 it is obvious that we're not building the usual stuff. Likewise,
2875 when we are building a specific revision, add the text "rNNN" to
2876 indicate what that revision number is. Thanks to Brad Hards and
2877 Nathaniel Smith for the suggestion.
2878 (Darcs.startVC): same
2879 (Arch.startVC): same
2880 (Bazaar.startVC): same
2882 * buildbot/process/factory.py (GNUAutoconf.__init__): fix a silly
2883 typo, caught by Mark Dillavou, closes SF#1216636.
2885 * buildbot/test/test_status.py (Log.TODO_testDuplicate): add notes
2886 about a test to add some day
2888 * docs/examples/twisted_master.cfg: update: bot1 can now handle
2889 the 'full-2.3' build, and the 'reactors' build is now run under
2890 python-2.4 because the buildslave no longer has gtk/etc bindings
2891 for earlier versions.
2893 2005-11-03 Brian Warner <warner@lothar.com>
2895 * buildbot/interfaces.py (IBuilderControl.resubmitBuild): new
2896 method, takes an IBuildStatus and rebuilds it. It might make more
2897 sense to add this to IBuildControl instead, but that instance goes
2898 away completely once the build has finished, and resubmitting
2899 builds can take place weeks later.
2900 * buildbot/process/builder.py (BuilderControl.resubmitBuild): same
2901 * buildbot/status/html.py (StatusResourceBuild): also stash an
2902 IBuilderControl so we can use resubmitBuild.
2903 (StatusResourceBuild.body): render "resubmit" button if we can.
2904 Also add hrefs for each BuildStep
2905 (StatusResourceBuild.rebuild): add action for "resubmit" button
2906 (StatusResourceBuilder.getChild): give it an IBuilderControl
2908 * buildbot/status/builder.py (Status.getURLForThing): change the
2909 URL for BuildSteps to have a "step-" prefix, so the magic URLs
2910 that live as targets of buttons like "stop" and "rebuild" can't
2912 * buildbot/status/builder.py (Status.getURLForThing): same
2913 * buildbot/status/html.py (StatusResourceBuild.getChild): same
2914 (StepBox.getBox): same
2915 * buildbot/test/test_web.py (GetURL): same
2918 * buildbot/process/step.py (SVN.__init__): put svnurl/baseURL
2919 exclusivity checks after Source.__init__ upcall, so misspelled
2920 arguments will be reported more usefully
2921 (Darcs.__init__): same
2923 2005-10-29 Brian Warner <warner@lothar.com>
2925 * docs/examples/twisted_master.cfg: don't double-fire the 'quick'
2926 builder. Move the Try scheduler off to a separate port.
2928 2005-10-27 Brian Warner <warner@lothar.com>
2930 * buildbot/clients/gtkPanes.py
2931 (TwoRowClient.remote_builderRemoved): disappearing Builders used
2932 to cause the app to crash, now they don't.
2934 * buildbot/clients/debug.py: display the buildmaster's location
2935 in the window's title bar
2937 2005-10-26 Brian Warner <warner@lothar.com>
2939 * buildbot/status/mail.py (MailNotifier): urllib.escape the URLs
2940 in case they have spaces or whatnot. Patch from Dobes Vandermeer.
2941 * buildbot/test/test_status.py (MyStatus.getURLForThing): fix it
2943 * buildbot/status/html.py (td): put a single non-breaking space
2944 inside otherwise empty <td> elements, as a workaround for buggy
2945 browsers which would optimize them away (along with any associated
2946 styles, like the kind that create the waterfall grid borders).
2947 Patch from Frerich Raabe.
2949 * buildbot/process/step_twisted.py (Trial): expose the trialMode=
2950 argv-list as an argument, defaulting to ["-to"], which is
2951 appropriate for the Trial that comes with Twisted-2.1.0 and
2952 earlier. The Trial in current Twisted SVN wants
2953 ["--reporter=bwverbose"] instead. Also expose trialArgs=, which
2954 defaults to an empty list.
2955 * buildbot/process/process_twisted.py (TwistedTrial.trialMode):
2956 match it, now that trialMode= is a list instead of a single string
2958 * buildbot/__init__.py (version): bump to 0.7.0+ while between
2960 * docs/buildbot.texinfo: same
2962 2005-10-24 Brian Warner <warner@lothar.com>
2964 * buildbot/__init__.py (version): Releasing buildbot-0.7.0
2965 * docs/buildbot.texinfo: set version number to match
2967 2005-10-24 Brian Warner <warner@lothar.com>
2969 * README: update for 0.7.0
2971 * docs/buildbot.texinfo: move the freshcvs stuff out of the README
2973 * buildbot/clients/debug.glade: add 'branch' box to fake-commit
2974 * buildbot/clients/debug.py (DebugWidget.do_commit): same. Don't
2975 send the branch= argument unless the user really provided one, to
2976 retain compatibility with older buildmasters that don't accept
2978 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
2981 * docs/buildbot.texinfo: update lots of stuff
2983 * buildbot/scripts/runner.py (sendchange): add a --branch argument
2984 to the 'buildbot sendchange' command
2985 * buildbot/clients/sendchange.py (Sender.send): same
2986 * buildbot/changes/pb.py (ChangePerspective): same
2987 * buildbot/test/test_changes.py (Sender.testSender): test it
2989 * buildbot/process/step.py (SVN.__init__): change 'base_url' and
2990 'default_branch' argument names to 'baseURL' and 'defaultBranch',
2991 for consistency with other BuildStep arguments that use camelCase.
2992 Well, at least more of them use camelCase (like flunkOnWarnings)
2993 than don't.. I wish I'd picked one style and stuck with it
2994 earlier. Annoying, but it's best done before the release, since
2995 these arguments didn't exist at all in 0.6.6 .
2997 * buildbot/test/test_vc.py (SVN.testCheckout): same
2998 (Darcs.testPatch): same
2999 * docs/buildbot.texinfo (SVN): document the change
3000 (Darcs): same, add some build-on-branch docs
3001 * docs/examples/twisted_master.cfg: match change
3003 * buildbot/process/step.py (BuildStep): rename
3004 slaveVersionNewEnough to slaveVersionIsOlderThan, because that's
3005 how it is normally used.
3006 * buildbot/test/test_steps.py (Version.checkCompare): same
3008 * buildbot/process/step.py (CVS.startVC): refuse to build
3009 update/copy -style builds on a non-default branch with an old
3010 buildslave (<=0.6.6) that doesn't know how to do it properly. The
3011 concern is that it will do a VC 'update' in an existing tree when
3012 it is supposed to be switching branches (and therefore clobbering
3013 the tree to do a full checkout), thus building the wrong source.
3014 This used to be a warning, but I think the confusion it is likely
3015 to cause warrants making it an error.
3016 (SVN.startVC): same, also make mode=export on old slaves an error
3017 (Darcs.startVC): same
3018 (Git.startVC): improve error message for non-Git-enabled slaves
3019 (Arch.checkSlaveVersion): same. continue to emit a warning when a
3020 specific revision is built on a slave that doesn't pay attention
3021 to args['revision'], because for slowly-changing trees it will
3022 probably do the right thing, and because we have no way to tell
3023 whether we're asking it to build the most recent version or not.
3024 * buildbot/interfaces.py (BuildSlaveTooOldError): new exception
3026 * buildbot/scripts/runner.py (SlaveOptions.postOptions): assert
3027 that 'master' is in host:portnum format, to catch errors sooner
3029 2005-10-23 Brian Warner <warner@lothar.com>
3031 * buildbot/process/step_twisted.py (ProcessDocs.createSummary):
3032 when creating the list of warning messages, include the line
3033 immediately after each WARNING: line, since that's usually where
3034 the file and line number wind up.
3036 * docs/examples/twisted_master.cfg: OS-X slave now does QT, add a
3041 2005-10-22 Brian Warner <warner@lothar.com>
3043 * buildbot/status/html.py (HtmlResource): incorporate valid-HTML
3044 patch from Brad Hards
3045 * buildbot/status/classic.css: same
3046 * buildbot/test/test_web.py (Waterfall): match changes
3048 * buildbot/test/test_steps.py (BuildStep.setUp): set
3049 nextBuildNumber so the test passes
3050 * buildbot/test/test_status.py (MyBuilder): same
3052 * buildbot/status/html.py (StatusResourceBuild.body): revision
3053 might be numeric, so stringify it before html-escapifying it
3054 (CurrentBox.getBox): add a "waiting" state, and show a countdown
3055 timer for the upcoming build
3056 * buildbot/status/classic.css: add background-color attributes for
3057 offline/waiting/building classes
3059 * buildbot/status/builder.py (BuildStatus): derive from
3060 styles.Versioned, fix upgrade of .sourceStamp attribute. Also set
3061 the default (i.e. unknown) .slavename to "???" instead of None,
3062 since even unknown slavenames need to be printed eventually.
3063 (BuilderStatus): also derive from styles.Versioned . More
3064 importantly, determine .nextBuildNumber at creation/unpickling
3065 time by scanning the directory of saved BuildStatus instances and
3066 choosing one larger than the highest-numbered one found. This
3067 should fix the problem where random errors during upgrades cause
3068 the buildbot to forget about earlier builds. .nextBuildNumber is
3069 no longer stored in the pickle.
3070 (Status.builderAdded): if we can't unpickle the BuilderStatus,
3071 at least log the error. Also call Builder.determineNextBuildNumber
3072 once the basedir is set.
3074 * buildbot/master.py (BuildMaster.loadChanges): do
3075 styles.doUpgrade afterwards, in case I decide to make Changes
3076 derived from styles.Versioned some day and forget to make this
3080 * buildbot/test/test_runner.py (Options.testForceOptions): skip
3081 when running under older pythons (<2.3) in which the shlex module
3082 doesn't have a 'split' function.
3084 * buildbot/process/step.py (ShellCommand.start): make
3085 errorMessages= be a list of strings to stuff in the log before the
3086 command actually starts. This makes it easier to flag multiple
3087 warning messages, e.g. when the Source steps have to deal with an
3089 (CVS.startVC): handle slaves that don't handle multiple branches
3090 by switching into 'clobber' mode
3091 (SVN.startVC): same. Also reject branches without base_url
3092 (Darcs.startVC): same. Also reject revision= in older slaves
3093 (Arch.checkSlaveVersion): same (just the multiple-branches stuff)
3094 (Bazaar.startVC): same, and test for baz separately than for arch
3096 * buildbot/slave/commands.py (cvs_ver): document new features
3098 * buildbot/process/step.py (BuildStep.slaveVersion): document it
3099 (BuildStep.slaveVersionNewEnough): more useful utility method
3100 * buildbot/test/test_steps.py (Version): start testing it
3102 * buildbot/status/words.py (IrcStatusBot.command_FORCE): note that
3103 the 'force' command requires python2.3, for the shlex.split method
3105 * docs/examples/twisted_master.cfg: remove old freshcvs stuff,
3106 since we don't use it anymore. The Twisted buildbot uses a
3109 2005-10-21 Brian Warner <warner@lothar.com>
3111 * buildbot/process/process_twisted.py: rework all BuildFactory
3112 classes to take a 'source' step as an argument, instead of
3113 building up the SVN instance in the factory.
3114 * docs/examples/twisted_master.cfg: enable build-on-branch by
3115 providing a base_url and default_branch
3117 * buildbot/status/words.py (IrcStatusBot.command_FORCE): add
3118 control over --branch and --revision, not that they are always
3120 * buildbot/status/html.py (StatusResourceBuilder.force): same
3121 (StatusResourceBuild.body): display SourceStamp components
3123 * buildbot/scripts/runner.py (ForceOptions): option parser for the
3124 IRC 'force' command, so it can be shared with an eventual
3125 command-line-tool 'buildbot force' mode.
3126 * buildbot/test/test_runner.py (Options.testForceOptions): test it
3128 2005-10-20 Brian Warner <warner@lothar.com>
3130 * buildbot/status/mail.py (MailNotifier.buildMessage): reformat
3132 * docs/examples/twisted_master.cfg: update to use Schedulers
3134 * buildbot/scripts/sample.cfg: update with Schedulers
3136 * buildbot/interfaces.py (IBuilderControl.requestBuildSoon): new
3137 method specifically for use by HTML "force build" button and the
3138 IRC "force" command. Raises an immediate error if there are no
3140 (IBuilderControl.requestBuild): make this just submit a build, not
3141 try to check for existing slaves or set up any when-finished
3142 Deferreds or anything.
3143 * buildbot/process/builder.py (BuilderControl): same
3144 * buildbot/status/html.py (StatusResourceBuilder.force): same
3145 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
3146 * buildbot/test/test_slaves.py: same
3147 * buildbot/test/test_web.py: same
3149 2005-10-19 Brian Warner <warner@lothar.com>
3151 * docs/examples/twisted_master.cfg: re-sync with reality: bring
3152 back python2.2 tests, turn off OS-X threadedselect-reactor tests
3154 2005-10-18 Brian Warner <warner@lothar.com>
3156 * buildbot/status/html.py: provide 'status' argument to most
3157 StatusResourceFOO objects
3158 (StatusResourceBuild.body): href-ify the Builder name, add "Steps
3159 and Logfiles" section to make the Build page into a more-or-less
3160 comprehensive source of status information about the build
3162 * buildbot/status/mail.py (MailNotifier): include the Build's URL
3163 * buildbot/status/words.py (IrcStatusBot.buildFinished): same
3165 2005-10-17 Brian Warner <warner@lothar.com>
3167 * buildbot/process/process_twisted.py (TwistedTrial): update Trial
3168 arguments to accomodate Twisted >=2.1.0 . I will have to figure
3169 out what to do about other projects: the correct options for
3170 recent Twisteds will not work for older ones.
3172 2005-10-15 Brian Warner <warner@lothar.com>
3174 * buildbot/status/builder.py (Status.getURLForThing): add method
3175 to provide a URL for arbitrary IStatusFoo objects. The idea is to
3176 use this in email/IRC status clients to make them more useful, by
3177 providing the end user with hints on where to learn more about the
3178 object being reported on.
3179 * buildbot/test/test_web.py (GetURL): tests for it
3181 2005-10-14 Brian Warner <warner@lothar.com>
3183 * buildbot/test/test_config.py (ConfigTest._testSources_1): oops,
3184 fix bug resulting from deferredResult changes
3186 2005-10-13 Brian Warner <warner@lothar.com>
3188 * buildbot/test/test_changes.py: remove use of deferredResult
3189 * buildbot/test/test_config.py: same
3190 * buildbot/test/test_control.py: same
3191 * buildbot/test/test_status.py: same
3192 * buildbot/test/test_vc.py: this is the only remaining use, since
3193 it gets used at module level. This needs to be replaced by some
3194 sort of class-level run-once routine.
3196 * buildbot/status/words.py (IrcStatusBot.command_WATCH): fix typo
3198 * lots: implement multiple slaves per Builder, which means multiple
3199 current builds per Builder. Some highlights:
3200 * buildbot/interfaces.py (IBuilderStatus.getState): return a tuple
3201 of (state,currentBuilds) instead of (state,currentBuild)
3202 (IBuilderStatus.getCurrentBuilds): replace getCurrentBuild()
3203 (IBuildStatus.getSlavename): new method, so you can tell which
3204 slave got used. This only gets set when the build completes.
3205 (IBuildRequestStatus.getBuilds): new method
3207 * buildbot/process/builder.py (SlaveBuilder): add a .state
3208 attribute to track things like ATTACHING and IDLE and BUILDING,
3210 (Builder): .. the .slaves attribute here, which has been turned
3211 into a simple list of available slaves. Added a separate
3212 attaching_slaves list to track ones that are not yet ready for
3214 (Builder.fireTestEvent): put off the test-event callback for a
3215 reactor turn, to make tests a bit more consistent.
3216 (Ping): cleaned up the slaveping a bit, now it disconnects if the
3217 ping fails due to an exception. This needs work, I'm worried that
3218 a code error could lead to a constantly re-connecting slave.
3219 Especially since I'm trying to move to a distinct remote_ping
3220 method, separate from the remote_print that we currently use.
3221 (BuilderControl.requestBuild): return a convenience Deferred that
3222 provides an IBuildStatus when the build finishes.
3223 (BuilderControl.ping): ping all connected slaves, only return True
3224 if they all respond.
3226 * buildbot/slave/bot.py (BuildSlave.stopService): stop trying to
3227 reconnect when we shut down.
3229 * buildbot/status/builder.py: implement new methods, convert
3230 one-build-at-a-time methods to handle multiple builds
3231 * buildbot/status/*.py: do the same in all default status targets
3232 * buildbot/status/html.py: report the build's slavename in the
3233 per-Build page, report all buildslaves on the per-Builder page
3235 * buildbot/test/test_run.py: update/create tests
3236 * buildbot/test/test_slaves.py: same
3237 * buildbot/test/test_scheduler.py: remove stale test
3239 * docs/buildbot.texinfo: document the new builder-specification
3240 'slavenames' parameter
3242 2005-10-12 Brian Warner <warner@lothar.com>
3244 * buildbot/buildset.py (BuildSet): fix bug where BuildSet did not
3245 report failure correctly, causing Dependent builds to run when
3246 they shouldn't have.
3247 * buildbot/status/builder.py (BuildSetStatus): same
3248 * buildbot/test/test_buildreq.py (Set.testBuildSet): verify it
3249 (Set.testSuccess): test the both-pass case too
3250 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3251 fix this test: it was ending too early, masking the failure before
3252 (Logger): specialized StatusReceiver to make sure the dependent
3253 builds aren't even started, much less completed.
3255 2005-10-07 Brian Warner <warner@lothar.com>
3257 * buildbot/slave/bot.py (SlaveBuilder.activity): survive
3258 bot.SlaveBuilder being disowned in the middle of a build
3260 * buildbot/status/base.py (StatusReceiverMultiService): oops, make
3261 this inherit from StatusReceiver. Also upcall in __init__. This
3262 fixes the embarrasing crash when the new buildSetSubmitted method
3263 is invoked and Waterfall/etc don't implement their own.
3264 * buildbot/test/test_run.py: add a TODO note about a test to catch
3265 just this sort of thing.
3267 * buildbot/process/builder.py (Builder.attached): remove the
3268 already-attached warning, this situation is normal. Add some
3269 comments explaining it.
3271 2005-10-02 Brian Warner <warner@lothar.com>
3273 * buildbot/changes/maildir.py (Maildir.start): Tolerate
3274 OverflowError when setting up dnotify, because some 64-bit systems
3275 have problems with signed-vs-unsigned constants and trip up on the
3276 DN_MULTISHOT flag. Patch from Brad Hards.
3278 2005-09-06 Fred Drake <fdrake@users.sourceforge.net>
3280 * buildbot/process/step.py (BuildStep, ShellCommand): Add
3281 progressMetrics, description, descriptionDone to the 'parms' list,
3282 and make use the 'parms' list from the implementation class
3283 instead of only BuildStep to initialize the parameters. This
3284 allows buildbot.process.factory.s() to initialize all the parms,
3285 not just those defined in directly by BuildStep.
3287 2005-09-03 Brian Warner <warner@lothar.com>
3289 * NEWS: start adding items for the next release
3291 * docs/examples/twisted_master.cfg: (sync with reality) turn off
3292 python2.2 tests, change 'Quick' builder to only use python2.3
3294 2005-09-02 Fred Drake <fdrake@users.sourceforge.net>
3296 * buildbot/status/html.py (StatusResourceBuilder.body): only show
3297 the "Ping Builder" button if the build control is available; the
3298 user sees an exception otherwise
3300 * docs/buildbot.texinfo (PBChangeSource): fix a typo
3302 2005-09-01 Brian Warner <warner@lothar.com>
3304 * buildbot/interfaces.py (IBuilderStatus.getState): update
3305 signature, point out that 'build' can be None
3306 (IBuildStatus.getETA): point out ETA can be none
3308 * buildbot/status/html.py (CurrentBox.getBox): tolerate build/ETA
3310 * buildbot/status/words.py (IrcStatusBot.emit_status): same
3312 2005-08-31 Brian Warner <warner@lothar.com>
3314 * buildbot/status/base.py (StatusReceiver.builderChangedState):
3315 update to match correct signature: removed 'eta' argument
3316 * buildbot/status/mail.py (MailNotifier.builderChangedState): same
3318 2005-08-30 Brian Warner <warner@lothar.com>
3320 * buildbot/status/builder.py (LogFile): remove the assertion that
3321 blows up when you try to overwrite an existing logfile, instead
3322 just emit a warning. This case gets hit when the buildmaster is
3323 killed and doesn't get a chance to write out the serialized
3324 BuilderStatus object, so the .nextBuildNumber attribute gets out
3327 * buildbot/scripts/runner.py (sendchange): add --revision_file to
3328 the 'buildbot sendchange' arguments, for the Darcs context file
3329 * docs/buildbot.texinfo (sendchange): document it
3331 * buildbot/status/html.py: add pending/upcoming builds to CurrentBox
3332 * buildbot/interfaces.py (IScheduler.getPendingBuildTimes): new method
3333 (IStatus.getSchedulers): new method
3334 * buildbot/status/builder.py (BuilderStatus): track pendingBuilds
3335 (Status.getSchedulers): implement
3336 * buildbot/process/builder.py (Builder): maintain
3337 BuilderStatus.pendingBuilds
3338 * buildbot/scheduler.py (Scheduler.getPendingBuildTimes): new method
3339 (TryBase.addChange): Try schedulers should ignore Changes
3341 * buildbot/scripts/tryclient.py (getTopdir): implement getTopdir
3342 for 'try' on CVS/SVN
3343 * buildbot/test/test_runner.py (Try.testGetTopdir): test case
3345 * buildbot/scripts/tryclient.py (Try): make jobdir-style 'try'
3346 report status properly.
3347 (Try.createJob): implement unique buildset IDs
3349 * buildbot/status/client.py (StatusClientPerspective): add a
3350 perspective_getBuildSets method for the benefit of jobdir-style
3352 * docs/buildbot.texinfo (try): more docs
3353 * buildbot/test/test_scheduler.py (Scheduling.testGetBuildSets):
3356 2005-08-18 Brian Warner <warner@lothar.com>
3358 * buildbot/scripts/tryclient.py (Try): make 'try' status reporting
3359 actually work. It's functional but still kind of clunky. Also, it
3360 only works with the pb-style.. needs to be made to work with the
3363 * buildbot/status/client.py (RemoteBuildSet): new class
3364 (RemoteBuildRequest): same
3365 (RemoteBuild.remote_waitUntilFinished): return the RemoteBuild
3366 object, not the internal BuildStatus object.
3367 (RemoteBuild.remote_subscribe): new method to subscribe to builds
3368 outside of the usual buildStarted() return value.
3369 (BuildSubscriber): support class for RemoteBuild.remote_subscribe
3371 * buildbot/scheduler.py (Try_Jobdir): convey buildsetID properly
3372 (Try_Userpass_Perspective.perspective_try): return a remotely
3373 usable BuildSetStatus object
3375 * buildbot/interfaces.py (IBuildStatus): remove obsolete
3376 isStarted()/waitUntilStarted()
3378 2005-08-16 Brian Warner <warner@lothar.com>
3380 * buildbot/status/builder.py: implement IBuildSetStatus and
3381 IBuildRequestStatus, wire them into place.
3382 * buildbot/buildset.py: same. Add ID, move wait-until-finished
3383 methods into the BuildSetStatus object.
3384 * buildbot/interfaces.py: same
3385 (IStatus.getBuildSets): new method to get pending BuildSets
3386 (IStatusReceiver.buildsetSubmitted): new method which hears about
3388 * buildbot/master.py (BuildMaster.submitBuildSet): same
3389 * buildbot/process/base.py (BuildRequest): same, replace
3390 waitUntilStarted with subscribe/unsubscribe
3391 * buildbot/process/builder.py (BuilderControl.forceBuild): use
3392 subscribe instead of waitUntilStarted
3393 * buildbot/status/base.py (StatusReceiver.buildsetSubmitted): stub
3395 * buildbot/status/client.py (StatusClientPerspective.builderRemoved):
3397 * buildbot/test/test_buildreq.py: update for new code
3398 * buildbot/test/test_control.py (Force.testRequest): same
3401 * buildbot/slave/commands.py (Darcs.doVCFull): fix get-revision
3402 for Darcs to not use the tempfile module, so it works under
3403 python-2.2 too. We really didn't need the full cleverness of that
3404 module, since the slave has exclusive control of its own builddir.
3406 2005-08-15 Brian Warner <warner@lothar.com>
3408 * buildbot/scripts/tryclient.py (CVSExtractor): implement 'try'
3409 for CVS trees. It doesn't work for non-trunk branches,
3411 * buildbot/test/test_vc.py (CVS.testTry): test it, but skip the
3414 * Makefile: make it easier to test against python2.2
3416 * buildbot/test/test_vc.py (VCBase.tearDown): provide for
3417 tearDown2, so things like Arch can unregister archives as they're
3418 shutting down. The previous subclass-override-tearDown technique
3419 resulted in a nested maybeWait() and test failures under
3422 * buildbot/scripts/tryclient.py (getSourceStamp): extract branches
3423 where we can (Arch), add a branch= argument to set the branch used
3425 (BazExtractor): extract the branch too
3426 (TlaExtractor): same
3427 * buildbot/scripts/runner.py (TryOptions): add --branch
3428 * docs/buildbot.texinfo (try): document --branch/try_branch
3430 * buildbot/slave/commands.py (Darcs): implement get-revision for
3431 Darcs, so that 'try' will work. This requires the tempfile module
3434 * buildbot/test/test_vc.py: rewrite tests, getting better coverage
3435 of revisions, branches, and 'try' in the process.
3437 2005-08-11 Brian Warner <warner@lothar.com>
3439 * buildbot/master.py (DebugPerspective.perspective_pokeIRC): fix
3440 this, it got broken at some point in the last few releases
3441 * buildbot/status/words.py (IrcBuildRequest): reply was broken
3442 (IrcStatusBot.emit_status): handle new IBuilderStatus.getState,
3443 specifically the removal of ETA information from the tuple
3445 * buildbot/locks.py: use %d for id() instead of %x, avoid a silly
3448 * docs/buildbot.texinfo (try): document both --builder and
3449 'try_builders' in .buildbot/options
3450 * buildbot/scripts/runner.py (TryOptions): add --builder,
3451 accumulate the values into opts['builders']
3452 * buildbot/scripts/tryclient.py (Try.__init__): set builders
3453 * buildbot/test/test_runner.py (Try): add some quick tests to make
3454 sure 'buildbot try --options' and .buildbot/options get parsed
3455 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3456 use --builder control
3458 * docs/buildbot.texinfo (try): add --port argument to PB style
3460 * buildbot/scripts/tryclient.py (SourceStampExtractor): return an
3461 actual SourceStamp. Still need to extract a branch name, somehow.
3462 (Try): finish implementing the try client side, still need a UI
3463 for specifying which builders to use
3464 (Try.getopt): factor our options/config-file reading
3465 * buildbot/test/test_scheduler.py (Scheduling.testTryUserpass):
3467 * buildbot/test/test_vc.py: match SourceStampExtractor change
3469 * buildbot/scripts/runner.py (Options.opt_verbose): --verbose
3470 causes the twisted log to be sent to stderr
3472 * buildbot/scheduler.py (Try_Userpass): implement the PB style
3474 2005-08-10 Brian Warner <warner@lothar.com>
3476 * buildbot/scripts/runner.py: Add 'buildbot try' command, jobdir
3477 style is 90% done, still missing status reporting or waiting for
3478 the buildsets to finish, and it is completely untested.
3480 * buildbot/trybuild.py: delete file, move contents to ..
3481 * buildbot/scripts/tryclient.py (getSourceStamp): .. here
3482 * buildbot/test/test_vc.py: match the move
3484 * buildbot/scheduler.py (Try_Jobdir): implement the jobdir style
3485 of the TryScheduler, no buildsetID or status-tracking support yet
3486 * buildbot/test/test_scheduler.py (Scheduling.testTryJobdir): test it
3488 * buildbot/changes/maildir.py (Maildir.setBasedir): make it
3489 possible to set the basedir after __init__ time, so it is easier
3490 to use as a Service-child of the BuildMaster instance
3492 * buildbot/changes/maildirtwisted.py (MaildirService): make a form
3493 that delivers messages to its Service parent instead of requiring
3494 a subclass to be useful. This turns out to be much easier to build
3497 * buildbot/scripts/tryclient.py (createJob): utility code to
3498 create jobfiles, will eventually be used by 'buildbot try'
3500 2005-08-08 Brian Warner <warner@lothar.com>
3502 * docs/buildbot.texinfo (try): add docs on the
3503 as-yet-unimplemented Try scheduler
3505 * buildbot/test/test_buildreq.py: move Scheduling tests out to ..
3506 * buildbot/test/test_scheduler.py: .. here
3507 (Scheduling.testTryJobdir): add placeholder test for 'try'
3509 * buildbot/test/test_status.py (Log.testMerge3): update to match new
3510 addEntry merging (>=chunkSize) behavior
3511 (Log.testConsumer): update to handle new callLater(0) behavior
3513 * buildbot/test/test_web.py: rearrange tests a bit, add test for
3514 both the MAX_LENGTH bugfix and the resumeProducing hang.
3516 * buildbot/status/builder.py (LogFileProducer.resumeProducing):
3517 put off the actual resumeProducing for a moment with
3518 reactor.callLater(0). This works around a twisted-1.3.0 bug which
3519 causes large logfiles to hang midway through.
3521 * buildbot/process/step.py (BuildStep.addCompleteLog): break the
3522 logfile up into chunks, both to avoid NetstringReceiver.MAX_LENGTH
3523 and to improve memory usage when streaming the file out to a web
3525 * buildbot/status/builder.py (LogFile.addEntry): change > to >= to
3526 make this work cleanly
3528 2005-08-03 Brian Warner <warner@lothar.com>
3530 * buildbot/trybuild.py: new file for 'try' utilities
3531 (getSourceStamp): run in a tree, find out the baserev+patch
3532 * buildbot/test/test_vc.py (VCBase.do_getpatch): test it,
3533 implemented for SVN and Darcs, still working on Arch. I don't know
3534 how to make CVS work yet.
3536 * docs/buildbot.texinfo: document the 'buildbot' command-line
3537 tool, including the not-yet-implemented 'try' feature, and the
3538 in-flux .buildbot/ options directory.
3540 2005-07-20 Brian Warner <warner@lothar.com>
3542 * buildbot/locks.py: added temporary id() numbers to Lock
3543 descriptions, to track down a not-really-sharing-the-Lock bug
3545 * buildbot/test/runutils.py: must import errno, cut-and-paste bug
3547 * buildbot/test/test_slavecommand.py (ShellBase.failUnlessIn):
3548 needed for python2.2 compatibility
3549 * buildbot/test/test_vc.py: python2.2 compatibility: generators
3550 are from the __future__
3552 2005-07-19 Brian Warner <warner@lothar.com>
3554 * buildbot/master.py (BuildMaster.loadConfig): give a better error
3555 message when schedulers use unknown builders
3557 * buildbot/process/builder.py (Builder.compareToSetup): make sure
3558 SlaveLock('name') and MasterLock('name') are distinct
3560 * buildbot/master.py (BuildMaster.loadConfig): oops, sanity-check
3561 c['schedulers'] in such a way that we can actually accept
3563 * buildbot/test/test_config.py: check it
3565 * buildbot/scheduler.py (Dependent.listBuilderNames): oops, add
3566 utility method to *all* the Schedulers
3567 (Periodic.listBuilderNames): same
3569 * docs/buildbot.texinfo (Interlocks): update chapter to match
3572 * buildbot/master.py (BuildMaster.loadConfig): Add sanity checks
3573 to make sure that c['sources'], c['schedulers'], and c['status']
3574 are all lists of the appropriate objects, and that the Schedulers
3575 all point to real Builders
3576 * buildbot/interfaces.py (IScheduler, IUpstreamScheduler): add
3577 'listBuilderNames' utility method to support this
3578 * buildbot/scheduler.py: implement the utility method
3579 * buildbot/test/test_config.py (ConfigTest.testSchedulers): test it
3581 * docs/buildbot.texinfo: add some @cindex entries
3583 * buildbot/test/test_vc.py (Arch.createRepository): set the tla ID
3584 if it wasn't already set: most tla commands will fail unless one
3586 (Arch.createRepository): and disable bazaar's revision cache, since
3587 they cause test failures (the multiple repositories we create all
3588 interfere with each other through the cache)
3590 * buildbot/test/test_web.py (WebTest): remove use of deferredResult,
3591 bring it properly up to date with twisted-2.0 test guidelines
3593 * buildbot/master.py (BuildMaster): remove references to old
3594 'interlock' module, this caused a bunch of post-merge test
3596 * buildbot/test/test_config.py: same
3597 * buildbot/process/base.py (Build): same
3599 * buildbot/test/test_slaves.py: stubs for new test case
3601 * buildbot/scheduler.py: add test-case-name tag
3602 * buildbot/test/test_buildreq.py: same
3604 * buildbot/slave/bot.py (SlaveBuilder.__init__): remove some
3605 unnecessary init code
3606 (Bot.remote_setBuilderList): match it
3608 * docs/buildbot.texinfo (@settitle): don't claim version 1.0
3610 * buildbot/changes/mail.py (parseSyncmail): update comment
3612 * buildbot/test/test_slavecommand.py: disable Shell tests on
3613 platforms that don't suport IReactorProcess
3615 * buildbot/status/builder.py (LogFile): remove the 't' mode from
3616 all places where we open logfiles. It causes OS-X to open the file
3617 in some weird mode that that prevents us from mixing reads and
3618 writes to the same filehandle, which we depend upon to implement
3619 _generateChunks properly. This change doesn't appear to break
3620 win32, on which "b" and "t" are treated differently but a missing
3621 flag seems to be interpreted as "t".
3623 2005-07-18 Brian Warner <warner@lothar.com>
3625 * buildbot/slave/commands.py (ShellCommand): overhaul
3626 error-handling code, to try and make timeout/interrupt work
3627 properly, and make win32 happier
3628 * buildbot/test/test_slavecommand.py: clean up, stop using
3629 reactor.iterate, add tests for timeout and interrupt
3630 * buildbot/test/sleep.py: utility for a new timeout test
3632 * buildbot/twcompat.py: copy over twisted 1.3/2.0 compatibility
3633 code from the local-usebranches branch
3635 2005-07-17 Brian Warner <warner@lothar.com>
3637 * buildbot/process/process_twisted.py
3638 (TwistedReactorsBuildFactory): change the treeStableTimer to 5
3639 minutes, to match the other twisted BuildFactories, and don't
3640 excuse failures in c/qt/win32 reactors any more.
3642 * docs/examples/twisted_master.cfg: turn off the 'threadless' and
3643 'freebsd' builders, since the buildslaves have been unavailable
3646 2005-07-13 Brian Warner <warner@lothar.com>
3648 * buildbot/test/test_vc.py (VCBase.do_branch): test the new
3649 build-on-branch feature
3651 * buildbot/process/step.py (Darcs.__init__): add base_url and
3652 default_branch arguments, just like SVN
3653 (Arch.__init__): note that the version= argument is really the
3656 * buildbot/slave/commands.py (SourceBase): keep track of the
3657 repository+branch that was used for the last checkout in
3658 SRCDIR/.buildbot-sourcedata . If the contents of this file do not
3659 match, we clobber the directory and perform a fresh checkout
3660 rather than trying to do an in-place update. This should protect
3661 us against trying to get to branch B by doing an update in a tree
3662 obtained from branch A.
3663 (CVS.setup): add CVS-specific sourcedata: root, module, and branch
3664 (SVN.setup): same, just the svnurl
3665 (Darcs.setup): same, just the repourl
3666 (Arch.setup): same, arch coordinates (url), version, and
3667 buildconfig. Also pull the buildconfig from the args dictionary,
3668 which we weren't doing before, so the build-config was effectively
3670 (Arch.sourcedirIsUpdateable): don't try to update when we're
3671 moving to a specific revision: arch can't go backwards, so it is
3672 safer to just clobber the tree and checkout a new one at the
3674 (Bazaar.setup): same sourcedata as Arch
3676 * buildbot/test/test_dependencies.py (Dependencies.testRun_Fail):
3677 use maybeWait, to work with twisted-1.3.0 and twcompat
3678 (Dependencies.testRun_Pass): same
3680 * buildbot/test/test_vc.py: rearrange, cleanup
3682 * buildbot/twcompat.py: add defer.waitForDeferred and
3683 utils.getProcessOutputAndValue, so test_vc.py (which uses them)
3684 can work under twisted-1.3.0 .
3686 * buildbot/test/test_vc.py: rewrite. The sample repositories are
3687 now created at setUp time. This increases the runtime of the test
3688 suite considerably (from 91 seconds to 151), but it removes the
3689 need for an offline tarball, which should solve a problem I've
3690 seen where the test host has a different version of svn than the
3691 tarball build host. The new code also validates that mode=update
3692 really picks up recent commits. This approach will also make it
3693 easier to test out branches, because the code which creates the VC
3694 branches is next to the code which uses them. It will also make it
3695 possible to test some change-notification hooks, by actually
3696 performing a VC commit and watching to see the ChangeSource get
3699 2005-07-12 Brian Warner <warner@lothar.com>
3701 * docs/buildbot.texinfo (SVN): add branches example
3702 * docs/Makefile (buildbot.ps): add target for postscript manual
3704 * buildbot/test/test_dependencies.py: s/test_interlocks/test_locks/
3705 * buildbot/test/test_locks.py: same
3707 * buildbot/process/step.py (Darcs): comment about default branches
3709 * buildbot/master.py (BuildMaster.loadConfig): don't look for
3710 c['interlocks'] in the config file, complain if it is present.
3711 Scan all locks in c['builders'] to make sure the Locks they use
3713 * buildbot/test/test_config.py: remove old c['interlocks'] test,
3714 add some tests to check for non-uniquely-named Locks
3715 * buildbot/test/test_vc.py (Patch.doPatch): fix factory.steps,
3716 since the unique-Lock validation code requires it now
3718 * buildbot/locks.py: fix test-case-name
3720 * buildbot/interlock.py: remove old file
3722 2005-07-11 Brian Warner <warner@lothar.com>
3724 * buildbot/test/test_interlock.py: rename to..
3725 * buildbot/test/test_locks.py: .. something shorter
3727 * buildbot/slave/bot.py (BuildSlave.stopService): newer Twisted
3728 versions (after 2.0.1) changed internet.TCPClient to shut down the
3729 connection in stopService. Change the code to handle this
3732 * buildbot/process/base.py (Build): handle whole-Build locks
3733 * buildbot/process/builder.py (Builder.compareToSetup): same
3734 * buildbot/test/test_interlock.py: make tests work
3736 * buildbot/process/step.py (BuildStep.startStep): complain if a
3737 Step tries to claim a lock that's owned by its own Build
3738 (BuildStep.releaseLocks): typo
3740 * buildbot/locks.py (MasterLock): use ComparableMixin so config
3741 file reloads don't replace unchanged Builders
3743 * buildbot/test/test_config.py (ConfigTest.testInterlocks):
3744 rewrite to cover new Locks instead of old c['interlocks']
3745 * buildbot/test/runutils.py (RunMixin.connectSlaves): remember
3749 * buildbot/test/test_dependencies.py (Dependencies.setUp): always
3750 start the master and connect the buildslave
3752 * buildbot/process/step.py (FailingDummy.done): finish with a
3753 FAILURE status rather than raising an exception
3755 * buildbot/process/base.py (BuildRequest.mergeReasons): don't try to
3756 stringify a BuildRequest.reason that is None
3758 * buildbot/scheduler.py (BaseUpstreamScheduler.buildSetFinished):
3760 * buildbot/status/builder.py (BuildSetStatus): implement enough to
3761 allow scheduler.Dependent to work
3762 * buildbot/buildset.py (BuildSet): set .reason and .results
3764 * buildbot/test/test_interlock.py (Locks.setUp): connect both
3765 slaves, to make the test stop hanging. It still fails, of course,
3766 because I haven't even started to implement Locks.
3768 * buildbot/test/runutils.py (RunMixin.connectSlaves): new utility
3770 * docs/buildbot.texinfo (Build-Dependencies): redesign the feature
3771 * buildbot/interfaces.py (IUpstreamScheduler): new Interface
3772 * buildbot/scheduler.py (BaseScheduler): factor out common stuff
3773 (Dependent): new class for downstream build dependencies
3774 * buildbot/test/test_dependencies.py: tests (still failing)
3776 * buildbot/buildset.py (BuildSet.waitUntilSuccess): minor notes
3778 2005-07-07 Brian Warner <warner@lothar.com>
3780 * buildbot/test/runutils.py (RunMixin): factored this class out..
3781 * buildbot/test/test_run.py: .. from here
3782 * buildbot/test/test_interlock.py: removed old c['interlock'] tests,
3783 added new buildbot.locks tests (which all hang right now)
3784 * buildbot/locks.py (SlaveLock, MasterLock): implement Locks
3785 * buildbot/process/step.py: claim/release per-BuildStep locks
3787 * docs/Makefile: add 'buildbot.html' target
3789 * buildbot/process/step.py (CVS.__init__): allow branch=None to be
3790 interpreted as "HEAD", so that all VC steps can accept branch=None
3791 and have it mean the "default branch".
3793 * docs/buildbot.texinfo: add Schedulers, Dependencies, and Locks
3795 2005-07-07 Brian Warner <warner@lothar.com>
3797 * docs/examples/twisted_master.cfg: update to match current usage
3799 * docs/buildbot.texinfo (System Architecture): comment out the
3800 image, it doesn't exist yet and just screws up the HTML manual.
3802 2005-07-05 Brian Warner <warner@lothar.com>
3804 * debian/.cvsignore: oops, missed one. Removing leftover file.
3806 2005-06-17 Brian Warner <warner@lothar.com>
3808 * buildbot/test/test_vc.py (VCSupport.__init__): svn --version
3809 changed its output in 1.2.0, don't mistakenly think that the
3810 subversion we find isn't capable of supporting our tests.
3812 * debian/*: remove the debian/ directory and its contents, to make
3813 life easier for the proper Debian maintainer
3815 * Makefile (release): same
3817 2005-06-07 Brian Warner <warner@lothar.com>
3819 * everything: create a distinct SourceStamp class to replace the
3820 ungainly 4-tuple, let it handle merging instead of BuildRequest.
3821 Changed the signature of Source.startVC to include the revision
3822 information (instead of passing it through self.args). Implement
3823 branches for SVN (now only Darcs/Git is missing support). Add more
3826 2005-06-06 Brian Warner <warner@lothar.com>
3828 * everything: rearrange build scheduling. Create a new Scheduler
3829 object (configured in c['schedulers'], which submit BuildSets to a
3830 set of Builders. Builders can now use multiple slaves. Builds can
3831 be run on alternate branches, either requested manually or driven
3832 by changes. This changed some of the Status classes. Interlocks
3833 are out of service until they've been properly split into Locks
3834 and Dependencies. treeStableTimer, isFileImportant, and
3835 periodicBuild have all been moved from the Builder to the
3837 (BuilderStatus.currentBigState): removed the 'waiting' and
3838 'interlocked' states, removed the 'ETA' argument.
3840 2005-05-24 Brian Warner <warner@lothar.com>
3842 * buildbot/pbutil.py (ReconnectingPBClientFactory): Twisted-1.3
3843 erroneously abandons the connection (in clientConnectionFailed)
3844 for non-UserErrors, which means that if we lose the connection due
3845 to a network problem or a timeout, we'll never try to reconnect.
3846 Fix this by not upcalling to the buggy parent method. Note:
3847 twisted-2.0 fixes this, but the function only has 3 lines so it
3848 makes more sense to copy it than to try and detect the buggyness
3849 of the parent class. Fixes SF#1207588.
3851 * buildbot/changes/changes.py (Change.branch): doh! Add a
3852 class-level attribute to accomodate old Change instances that were
3853 pickled before 0.6.5 (where .branch was added for new Changes).
3854 This fixes the exception that occurs when you try to look at an
3855 old Change (through asHTML).
3857 * buildbot/__init__.py (version): bump to 0.6.6+ while between
3860 2005-05-23 Brian Warner <warner@lothar.com>
3862 * buildbot/__init__.py (version): release 0.6.6
3864 2005-05-23 Brian Warner <warner@lothar.com>
3866 * NEWS: update for 0.6.6 release
3867 * debian/changelog: same
3869 * buildbot/scripts/runner.py (start): put the basedir in sys.path
3870 before starting: this was done by twistd back when we spawned it,
3871 now that we're importing the pieces and running them in the
3872 current process, we have to do it ourselves. This allows
3873 master.cfg to import files from the same directory without
3874 explicitly manipulating PYTHONPATH. Thanks to Thomas Vander
3875 Stichele for the catch.
3876 (Options.opt_version): Add a --version command (actually, just make
3877 the existing --version command emit Buildbot's version too)
3879 * buildbot/status/builder.py (HTMLLogFile.upgrade): oops! second
3880 fix to make this behave like other LogFiles, this time to handle
3881 existing LogFiles on disk. (add the missing .upgrade method)
3882 * buildbot/test/test_status.py (Log.testHTMLUpgrade): test it
3884 2005-05-21 Brian Warner <warner@lothar.com>
3886 * buildbot/test/test_runner.py (Create.testMaster): match the
3887 rawstring change in runner.py:masterTAC
3889 * buildbot/test/test_config.py (ConfigTest.testIRC): skip unless
3890 TwistedWords is installed
3891 * buildbot/test/test_status.py: same, with TwistedMail
3893 * buildbot/master.py: remove old IRC/Waterfall imports (used by
3894 some old, deprecated, and removed config keys). This should enable
3895 you to use the base buildbot functionality with Twisted-2.0.0 when
3896 you don't also have TwistedWeb and TwistedWords installed
3898 2005-05-20 Brian Warner <warner@lothar.com>
3900 * buildbot/scripts/runner.py (run): call sendchange(), not
3901 do_sendchange(): thus 'buildbot sendchange' was broken in 0.6.5
3902 (run): call stop("HUP"), not "-HUP", 'buildbot stop' was broken.
3903 (stop): don't wait for process to die when sending SIGHUP
3904 (masterTAC): use a rawstring for basedir=, otherwise '\' in the
3905 directory name gets interpreted, which you don't want
3908 * buildbot/__init__.py (version): bump to 0.6.5+ while between
3911 2005-05-18 Brian Warner <warner@lothar.com>
3913 * buildbot/__init__.py (version): Releasing buildbot-0.6.5
3915 2005-05-18 Brian Warner <warner@lothar.com>
3917 * README: update for 0.6.5
3918 * debian/changelog: same
3920 * buildbot/changes/changes.py: rename tag= to branch=, since
3921 that's how we're using it, and my design for the upcoming "build a
3922 specific branch" feature wants it. also, tag= was too CVS-centric
3923 * buildbot/changes/mail.py (parseSyncmail): same
3924 * buildbot/process/base.py (Build.isBranchImportant): same
3925 * buildbot/test/test_mailparse.py (Test3.testMsgS4): same
3926 * docs/buildbot.texinfo (Attributes of Changes): same
3928 * NEWS: update tag=, update for upcoming release
3930 2005-05-17 Brian Warner <warner@lothar.com>
3932 * buildbot/scripts/runner.py (stop): actually poll once per
3933 second, instead of re-killing the poor daemon once per second.
3934 Sleep briefly (0.1s) before the first poll, since there's a good
3935 chance we can avoid waiting the full second if the daemon shuts
3936 down quickly. Also remove the sys.exit() at the end.
3937 (start): remove the unneighborly sys.exit()
3939 * Makefile: improve permission-setting to not kick Arch so badly
3941 * buildbot/scripts/runner.py (SlaveOptions.optParameters): set a
3942 default --keepalive=600, since it doesn't hurt very much, and it's
3943 a hassle to discover that you need it.
3944 * buildbot/test/test_runner.py (Create.testSlave): test it
3946 * buildbot/status/words.py (IrcStatusBot.buildFinished): Teach the
3947 IRC bot about EXCEPTION
3949 * buildbot/status/client.py (PBListener): upcall more correctly
3951 * buildbot/process/base.py (Build.allStepsDone): if a step caused
3952 an exception mark the overall build with EXCEPTION, not SUCCESS
3954 * buildbot/scripts/runner.py (makefile_sample): remove the leading
3956 * buildbot/status/mail.py (MailNotifier): oops, forgot to upcall
3957 * Makefile: update some release-related stuff
3959 * buildbot/slave/commands.py (ShellCommand.kill): if somehow this
3960 gets called when there isn't actually an active process, just end
3961 the Command instead of blowing up. I don't know how it gets into
3962 this state, but the twisted win32 buildslave will sometimes hang,
3963 and when it shakes its head and comes back, it thinks it's still
3964 running a Command. The next build causes this command to be
3965 interrupted, but the lack of self.process.pid breaks the interrupt
3968 * NEWS: document changes since the last release
3970 * buildbot/scripts/runner.py (start): change 'buildbot start' to
3971 look for Makefile.buildbot instead of a bare Makefile . The
3972 'buildbot start' does not install this file, so you have to
3973 manually copy it if you want to customize startup behavior.
3974 (createMaster): change 'buildbot master' command to create
3975 Makefile.sample instead of Makefile, to create master.cfg.sample
3976 instead of master.cfg (requiring you to copy it before the
3977 buildmaster can be started). Both sample files are kept up to
3978 date, i.e. they are overwritten if they have been changed. The
3979 'buildbot.tac' file is *not* overwritten, but if the new contents
3980 don't match the old, a 'buildbot.tac.new' file is created and the
3981 user is warned. This seems to be a much more sane way to handle
3982 startup files. Also, don't sys.exit(0) when done, so we can run
3983 unit tests against it.
3984 (createSlave): same. Don't overwrite the sample info/ files.
3985 * buildbot/scripts/sample.mk: remove. the contents were pulled
3986 into runner.py, since they need to match the behavior of start()
3990 * docs/buildbot.texinfo (Launching the daemons): document it
3991 * buildbot/test/test_runner.py (Create): test it
3993 * buildbot/test/test_vc.py (SetupMixin.failUnlessIn): Add a
3994 version that can handle string-in-string tests, because otherwise
3995 python-2.2 fails the tests. It'd be tremendous if Trial's test
3996 took two strings under 2.2 too.
3998 * everything: fixed all deprecation warnings when running against
3999 Twisted-2.0 . (at least all the ones in buildbot code, there are a
4000 few that come from Twisted itself). This involved putting most of
4001 the Twisted-version specific code in the new buildbot.twcompat
4002 module, and creating some abstract base classes in
4003 buildbot.changes.base and buildbot.status.base (which might be
4004 useful anyway). __implements__ is a nuisance and requires an ugly
4005 'if' clause everywhere.
4007 * buildbot/test/test_status.py (Mail.testMail): add a 0.1 second
4008 delay before finishing the test: it seems that smtp.sendmail
4009 doesn't hang up on the server, so we must wait a moment so it can
4010 hang up on us. This removes the trial warning about an unclean
4013 2005-05-16 Brian Warner <warner@lothar.com>
4015 * buildbot/process/step.py (Source): add 'retry' argument. It is a
4016 tuple of (delay, repeats).
4017 * buildbot/test/test_vc.py (Retry): test it
4018 * docs/buildbot.texinfo (Source Checkout): document it
4019 * buildbot/slave/commands.py (SourceBase): add 'retry' parameter.
4020 (SourceBase.maybeDoVCRetry): If 'retry' is set, failures in
4021 doVCFull() are handled by re-trying the checkout (after a delay)
4022 some number of times.
4023 (ShellCommand._startCommand): make header lines easier to read
4025 * buildbot/test/test_web.py (WebTest.tearDown): factor out master
4027 (WebTest.test_logfile): make sure master gets shut down, silences
4028 some "unclean reactor" test errors
4030 * buildbot/test/test_changes.py (Sender.tearDown): spin the
4031 reactor once after shutdown, something in certain versions of
4032 Twisted trigger a test failure. 1.3.0 is ok, 2.0.0 fails, 2.0.1pre
4033 fails, svn-trunk is ok.
4035 * buildbot/test/test_slavecommand.py (Shell.testShellZ): add a
4036 second win32 error message
4038 * buildbot/test/test_run.py (Status.testSlave): be smarter about
4039 validating the ETA, so the tests don't fail on slow systems
4041 2005-05-15 Brian Warner <warner@lothar.com>
4043 * buildbot/status/builder.py (HTMLLogFile): make this behave like
4044 the new LogFile class, so upgrading works properly
4045 (LogFileProducer.resumeProducing): survive resumeProducing after
4046 we've exhausted the chunkGenerator
4048 * buildbot/test/test_web.py (WebTest.test_logfile): validate HTML
4050 * buildbot/test/test_status.py (Log.testAdd): validate hasContents
4051 (Log.testUpgrade): same
4053 * docs/buildbot.texinfo (Maintenance): describe how to delete old
4054 Builds and logs with a cron job.
4056 * buildbot/status/builder.py (LogFile): revamp LogFiles. Got rid
4057 of the old non-offline LogFile, added code to upgrade these to
4058 new-style contents-live-on-disk instances at load time (in a way
4059 that doesn't invalidate the old Build pickles, so upgrading to
4060 0.6.5 is not a one-way operation). Got rid of everything related
4062 (LogFile.__init__): create LogFiles with the parent step status,
4063 the log's name, and a builder-relative filename where it can keep
4064 the contents on disk.
4065 (LogFile.hasContents): new method, clients are advised to call it
4066 before getText or getChunks and friends. If it returns False, the
4067 log's contents have been deleted and getText() will raise an
4069 (LogFile.getChunks): made it a generator
4070 (LogFile.subscribeConsumer): new method, takes a Twisted-style
4071 Consumer (except one that takes chunks instead of strings). This
4072 enables streaming of very large logfiles without storing the whole
4074 (BuildStatus.generateLogfileName): create names like
4075 12-log-compile-output, with a _0 suffix if required to be unique
4076 (BuildStatus.upgradeLogfiles): transform any old-style (from 0.6.4
4077 or earlier) logfiles into new-style ones
4078 (BuilderStatus): remove everything related to 'stub' builds. There
4079 is now only one build cache, and we don't strip logs from old
4081 (BuilderStatus.getBuildByNumber): check self.currentBuild too,
4082 since we no longer fight to keep it in the cache
4084 * buildbot/status/html.py (TextLog.render_GET): use a
4085 ChunkConsumer to stream the log entries efficiently.
4086 (ChunkConsumer): wrapper which consumes chunks and writes
4089 * buildbot/test/test_twisted.py (Parse.testParse): use a
4090 LogFile-like object instead of a real one
4092 * buildbot/test/test_status.py (MyLog): handle new LogFile code
4093 (Log.testMerge3): validate more merge behavior
4094 (Log.testChunks): validate LogFile.getChunks
4095 (Log.testUpgrade): validate old-style LogFile upgrading
4096 (Log.testSubscribe): validate LogFile.subscribe
4097 (Log.testConsumer): validate LogFile.subscribeConsumer
4099 * buildbot/interfaces.py (IStatusLogStub): remove
4100 (IStatusLog.subscribeConsumer): new method
4101 (IStatusLog.hasContents): new method
4102 (IStatusLogConsumer): describes things passed to subscribeConsumer
4104 * buildbot/status/html.py (StepBox.getBox): Don't offer an href to
4105 the log contents if it does not have any contents.
4106 (StatusResourceBuildStep.body): same
4107 (StatusResourceBuildStep.getChild): give a 404 for empty logs
4109 2005-05-14 Brian Warner <warner@lothar.com>
4111 * buildbot/test/test_web.py (WebTest.test_logfile): add 5-second
4112 timeouts to try and make the windows metabuildslave not hang
4114 2005-05-13 Mike Taylor <bear@code-bear.com>
4116 * buildbot/slave/commands.py (rmdirRecursive): added a check
4117 to ensure the path passed into rmdirRecursive actually exists.
4118 On win32 a non-existant path would generate an exception.
4120 2005-05-13 Brian Warner <warner@lothar.com>
4122 * buildbot/slave/commands.py (rmdirRecursive): replacement for
4123 shutil.rmtree which behaves correctly on windows in the face of
4124 files that you have to chmod before deleting. Thanks to Bear at
4125 the OSAF for the routine.
4126 (SourceBase.doClobber): use rmdirRecursive
4128 2005-05-12 Brian Warner <warner@lothar.com>
4130 * buildbot/status/builder.py (OfflineLogFile.getChunks): have this
4131 method generate chunks instead of returning a big list. This
4132 allows the same method to be used for both old LogFile and new
4134 (OfflineLogFile.getText): use the generator
4135 (OfflineLogFile.subscribe): same
4136 * buildbot/status/html.py (TextLog.resumeProducing): same
4137 * buildbot/interfaces.py (IStatusLog.getChunks): document it
4139 * buildbot/test/test_web.py (WebTest.test_logfile): Add a test to
4140 point out that OfflineLogFile does not currently work with
4141 html.Waterfall . Fixing this is high-priority.
4143 * buildbot/scripts/runner.py (start): add --logfile=twistd.log, since
4144 apparently windows defaults to using stdout
4146 * buildbot/test/test_slavecommand.py (Shell.testShellZ): log a
4147 better message on failure so I can figure out the win32 problem
4149 * buildbot/slave/commands.py (ShellCommand._startCommand): update
4150 log messages to include more useful copies of the command being
4151 run, the argv array, and the child command's environment.
4152 (Git.doVCFull): update cg-close usage, patch from Brandon Philips.
4154 2005-05-11 Brian Warner <warner@lothar.com>
4156 * setup.py: oops, install debug.glade so 'buildbot debugclient'
4158 * Makefile: update the deb-snapshot version
4160 * docs/buildbot.texinfo: move all .xhtml docs into a new
4161 .texinfo-format document, adding a lot of material in the process.
4162 This is starting to look like a real user's manual. Removed all
4163 the Lore-related files: *.xhtml, *.css, template.tpl .
4164 * docs/Makefile: simple makefile to run 'makeinfo'
4165 * buildbot/scripts/sample.cfg: rearrange slightly
4166 * MANIFEST.in: include .info and .textinfo, don't include *.xhtml
4168 2005-05-10 Brian Warner <warner@lothar.com>
4170 * buildbot/scripts/runner.py (start): Twisted-1.3.0 used a
4171 different name for the internal twistw module, handle it.
4173 * MANIFEST.in: we deleted plugins.tml, so stop shipping it
4174 * setup.py: .. and stop trying to install it
4176 * buildbot/process/step.py (Git): added support for 'cogito' (aka
4177 'git'), the new linux kernel VC system (http://kernel.org/git/).
4178 Thanks to Brandon Philips for the patch.
4179 * buildbot/slave/commands.py (Git): same
4181 2005-05-06 Brian Warner <warner@lothar.com>
4183 * buildbot/status/builder.py (OfflineLogFile): replace the default
4184 LogFile with a form that appends its new contents to a disk file
4185 as they arrive. The complete log data is never kept in RAM. This
4186 is the first step towards handling very large (100MB+) logfiles
4187 without choking quite so badly. (The other half is
4188 producer/consumer on the HTML pages).
4189 (BuildStepStatus.addLog): use OfflineLogFile by default
4190 (BuildStatus.getLogfileName): helper code to give the
4191 OfflineLogFile a filename to work with
4193 * buildbot/test/test_status.py (Results.testAddResults): update
4194 tests to handle new asserts
4195 * buildbot/test/test_vc.py (Patch.doPatch): same
4196 * buildbot/test/test_steps.py (BuildStep.setUp): same
4198 2005-05-05 Brian Warner <warner@lothar.com>
4200 * buildbot/scripts/runner.py (start): if there is no Makefile,
4201 launch the app by importing twistd's internals and calling run(),
4202 rather than spawning a new twistd process. This stands a much
4203 better chance of working under windows.
4204 (stop): kill the process with os.kill instead of spawning
4205 /bin/kill, again to reduce the number of external programs which
4206 windows might not have in the PATH. Also wait up to 5 seconds for
4207 the process to go away, allowing things like 'buildbot stop;
4208 buildbot start' to be reliable in the face of slow shutdowns.
4210 * buildbot/master.py (Dispatcher.__getstate__): remove old
4211 .tap-related methods
4212 (BuildMaster.__getstate__): same
4214 * buildbot/slave/bot.py (makeService): same
4215 (Options.longdesc): same
4216 * buildbot/scripts/runner.py: copy over some old mktap option text
4218 * buildbot/scripts/runner.py (masterTAC): stop using mktap.
4219 'buildbot master' now creates a buildbot.tac file, so there is no
4220 longer a create-instance/save/reload sequence. mktap is dead, long
4222 * buildbot/scripts/sample.mk: use twistd -y, not -f
4223 * buildbot/test/test_config.py: remove mktap-based test
4224 * buildbot/bb_tap.py, buildbot/plugins.tml: delete old files
4225 * README: don't reference mktap
4227 * docs/source.xhtml: document some of the attributes that Changes
4230 * docs/steps.xhtml (Bazaar): document the Bazaar checkout step
4232 * general: merge in Change(tag=) patch from Thomas Vander Stichele.
4233 [org.apestaart@thomas--buildbot/buildbot--cvstag--0-dev--patch-2]
4234 * buildbot/changes/changes.py (Change)
4235 * buildbot/changes/mail.py (parseSyncmail)
4236 * buildbot/test/test_mailparse.py (Test3.getNoPrefix)
4238 * buildbot/process/base.py (Build.isTagImportant)
4242 2005-05-04 Brian Warner <warner@lothar.com>
4244 * buildbot/clients/sendchange.py (Sender.send): tear down the PB
4245 connection after sending the change, so that unit tests don't
4246 complain about sockets being left around
4248 * buildbot/status/html.py (WaterfallStatusResource.body): fix
4249 exception in phase=0 rendering
4250 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4252 * buildbot/changes/dnotify.py (DNotify.__init__): remove debug msg
4254 * buildbot/master.py (BuildMaster.loadConfig): finally remove
4255 deprecated config keys: webPortnum, webPathname, irc, manholePort,
4256 and configuring builders with tuples.
4257 * buildbot/test/test_config.py: stop testing compatibility with
4258 deprecated config keys
4259 * buildbot/test/test_run.py: same
4261 2005-05-03 Brian Warner <warner@lothar.com>
4263 * contrib/arch_buildbot.py: survive if there are no logfiles
4264 (username): just use a string, os.getlogin isn't reliable
4266 * buildbot/scripts/runner.py (sendchange): oops, fix the command
4267 so 'buildbot sendchange' actually works. The earlier test only
4268 covered the internal (non-reactor-running) form.
4270 * contrib/arch_buildbot.py: utility that can run as an Arch hook
4271 script to notify the buildmaster about changes
4273 * buildbot/scripts/runner.py (sendchange): new command to send a
4274 change to a buildbot.changes.pb.PBChangeSource receiver.
4275 * buildbot/test/test_changes.py (Sender): test it
4277 * buildbot/master.py (BuildMaster.startService): mark .readConfig
4278 after any reading of the config file, not just when we do it in
4279 startService. This makes some tests a bit cleaner.
4281 * buildbot/changes/pb.py: add some log messages
4283 * buildbot/process/base.py (Build.startBuild): fix a bug that
4284 caused an exception when the build terminated in the very first
4286 (Build.stepDone): let steps return a status of EXCEPTION. This
4287 terminates the build right away, and sets the build's overall
4288 status to EXCEPTION too.
4289 * buildbot/process/step.py (BuildStep.failed): return a status of
4290 EXCEPTION when that is what has happened.
4292 * buildbot/process/step.py (Arch.computeSourceRevision): finally
4293 implement this, allowing Arch-based projects to get precise
4294 checkouts instead of always using the latest code
4295 (Bazaar): create variant of Arch to let folks use baz instead of
4296 tla. Requires a new buildslave too.
4297 * buildbot/slave/commands.py (Arch): add 'revision' argument
4298 (Bazaar): create variant of Arch that uses baz instead of tla.
4299 Remove the code that extracts the archive name from the
4300 register-archive output, since baz doesn't provide it, and require
4301 the user provide both the archive name and its location.
4302 * buildbot/test/test_vc.py (VC.testBazaar): added tests
4304 2005-05-02 Brian Warner <warner@lothar.com>
4306 * buildbot/scripts/sample.cfg: improve docs for c['buildbotURL'],
4307 thanks to Nick Trout.
4309 * buildbot/scripts/runner.py (Maker.makefile): chmod before edit,
4310 deals better with source Makefile coming from a read-only CVS
4311 checkout. Thanks to Nick Trout for the catch.
4313 * buildbot/__init__.py (version): bump to 0.6.4+ while between
4316 2005-04-28 Brian Warner <warner@lothar.com>
4318 * buildbot/__init__.py (version): Releasing buildbot-0.6.4
4320 * debian/changelog: update for 0.6.4
4322 2005-04-28 Brian Warner <warner@lothar.com>
4324 * README.w32: add a checklist of steps for getting buildbot
4326 * MANIFEST.in: include it in the tarball
4330 * buildbot/master.py (BuildMaster.upgradeToVersion3): deal with
4331 broken .tap files from 0.6.3 by getting rid of .services,
4332 .namedServices, and .change_svc at load time.
4334 2005-04-27 Brian Warner <warner@lothar.com>
4336 * NEWS: update in preparation for new release
4338 * buildbot/test/test_config.py (Save.testSave): don't pull in
4339 twisted.scripts.twistd, we don't need it and it isn't for windows
4342 * buildbot/changes/changes.py (ChangeMaster.saveYourself):
4343 accomodate win32 which can't do atomic-rename
4345 2005-04-27 Brian Warner <warner@lothar.com>
4347 * buildbot/test/test_run.py (Disconnect.testBuild2): crank up some
4348 timeouts to help the slow metabuildbot not flunk them so much
4349 (Disconnect.testBuild3): same
4350 (Disconnect.testBuild4): same
4351 (Disconnect.testInterrupt): same
4353 * buildbot/master.py (BuildMaster.loadChanges): fix change_svc
4354 setup, it was completely broken for new buildmasters (those which
4355 did not have a 'change.pck' already saved. Thanks to Paul Warren
4356 for catching this (embarrassing!) bug.
4357 (Dispatcher.__getstate__): don't save our registered avatar
4358 factories, since they'll be re-populated when the config file is
4360 (BuildMaster.__init__): add a dummy ChangeMaster, used only by
4361 tests (since the real mktap-generated BuildMaster doesn't save
4363 (BuildMaster.__getstate__): don't save any service children,
4364 they'll all be re-populated when the config file is re-read.
4365 * buildbot/test/test_config.py (Save.testSave): test for this
4367 2005-04-26 Brian Warner <warner@lothar.com>
4369 * buildbot/buildbot.png: use a new, smaller (16x16) icon image,
4370 rendered with Blender.. looks a bit nicer.
4371 * buildbot/docs/images/icon.blend: add the Blender file for it
4373 * buildbot/slave/commands.py (ShellCommand._startCommand): prepend
4374 'cmd.exe' (or rather os.environ['COMSPEC']) to the argv list when
4375 running under windows. This appears to be the best way to allow
4376 BuildSteps to do something normal like 'trial -v buildbot.test' or
4377 'make foo' and still expect it to work. The idea is to make the
4378 BuildSteps look as much like what a developer would type when
4379 compiling or testing the tree by hand. This approach probably has
4380 problems when there are spaces in the arguments, so if you've got
4381 windows buildslaves, you'll need to pay close attention to your
4384 * buildbot/status/html.py (WaterfallStatusResource.body): add the
4385 timezone to the timestamp column.
4386 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4388 * buildbot/scripts/runner.py (loadOptions): do something sane for
4389 windows, I think. We use %APPDATA%/buildbot instead of
4390 ~/.buildbot, but we still search everywhere from the current
4391 directory up to the root for a .buildbot/ subdir. The "is it under
4392 $HOME" security test was replaced with "is it owned by the current
4393 user", which is only performed under posix.
4394 * buildbot/test/test_runner.py (Options.testFindOptions): update
4395 tests to match. The "is it owned by the current user" check is
4396 untested. The test has been re-enabled for windows.
4398 * buildbot/test/test_slavecommand.py (Shell.checkOutput): replace
4399 any "\n" in the expected output with the platform-specific line
4400 separator. Make this separator "\r\n" on PTYs under unix, they
4401 seem to do that and I don't know why
4403 * buildbot/test/test_runner.py (Options.optionsFile): disable on
4404 windows for now, I don't know what ~/.buildbot/ should mean there.
4406 * buildbot/test/test_run.py (BuilderNames.testGetBuilderNames):
4407 win32 compatibility, don't use "/tmp"
4408 (Basedir.testChangeBuilddir): remove more unixisms
4410 2005-04-26 Brian Warner <warner@lothar.com>
4412 * buildbot/test/test_control.py (Force.rmtree): python2.2
4413 compatibility, apparently its shutil.rmtree ignore_errors=
4414 argument is ignored.
4415 * buildbot/test/test_run.py (Run.rmtree): same
4416 (RunMixin.setUp): same
4418 * buildbot/test/test_runner.py (make): python2.2 has os.sep but
4421 * buildbot/test/test_twisted.py (Parse.failUnlessIn): 2.2 has no
4422 'substring in string' operator, must use string.find(substr)!=-1
4423 * buildbot/test/test_vc.py (Patch.failUnlessIn): same
4424 * buildbot/test/test_web.py (WebTest.failUnlessIn): same
4426 * buildbot/scripts/runner.py (loadOptions): add code to search for
4427 ~/.buildbot/, a directory with things like 'options', containing
4428 defaults for various 'buildbot' subcommands. .buildbot/ can be in
4429 the current directory, your $HOME directory, or anywhere
4430 inbetween, as long as you're somewhere inside your home directory.
4431 (debugclient): look in ~/.buildbot/options for master and passwd
4432 (statuslog): look in ~/.buildbot/options for 'masterstatus'
4433 * buildbot/test/test_runner.py (Options.testFindOptions): test it
4435 * buildbot/status/client.py (makeRemote): new approach to making
4436 IRemote(None) be None, which works under Twisted-2.0
4437 * buildbot/test/test_status.py (Client.testAdaptation): test it
4439 * buildbot/status/builder.py (Status.builderAdded): when loading a
4440 pickled BuilderStatus in from disk, set its name after loading.
4441 The config file might have changed its name (but not its
4442 directory) while it wasn't looking.
4444 * buildbot/process/builder.py (Builder.attached): always return a
4445 Deferred, even if the builder was already attached
4446 * buildbot/test/test_run.py (Basedir.testChangeBuilddir): test it
4448 2005-04-25 Brian Warner <warner@lothar.com>
4450 * buildbot/status/words.py (IrcStatusBot.buildFinished): fix a
4451 category-related exception when announcing a build has finished
4453 * buildbot/status/html.py (StatusResourceChanges.body): oops, don't
4454 reference no-longer-existent changemaster.sources
4455 * buildbot/test/test_web.py (WebTest.test_waterfall): test for it
4457 * buildbot/__init__.py (version): bump to 0.6.3+ while between
4460 2005-04-25 Brian Warner <warner@lothar.com>
4462 * buildbot/__init__.py (version): Releasing buildbot-0.6.3
4464 * debian/changelog: update for 0.6.3
4466 2005-04-25 Brian Warner <warner@lothar.com>
4468 * MANIFEST.in: make sure debug.glade is in the tarball
4470 * README (REQUIREMENTS): list necessary Twisted-2.0 packages
4472 * NEWS: update for the imminent 0.6.3 release
4474 * buildbot/status/html.py (HtmlResource.content): make the
4475 stylesheet <link> always point at "buildbot.css".
4476 (StatusResource.getChild): map "buildbot.css" to a static.File
4477 containing whatever css= argument was provided to Waterfall()
4478 (Waterfall): provide the "classic" css as the default.
4479 * docs/waterfall.classic.css: move default CSS from here ..
4480 * buildbot/status/classic.css: .. to here
4482 * MANIFEST.in: make sure classic.css is included in the tarball
4483 * setup.py: and that it is installed too, under buildbot/status/
4485 * buildbot/master.py (BuildMaster): oops, set .change_svc=None at
4486 the module level, because buildbot.tap files from 0.6.2 don't have
4487 it in their attribute dictionary.
4489 * buildbot/slave/bot.py (Bot.startService): make sure the basedir
4490 really exists at startup, might save some confusion somewhere.
4492 2005-04-24 Thomas Vander Stichele <thomas at apestaart dot org>
4494 * docs/waterfall.classic.css:
4495 add a stylesheet that's almost the same as the "classic"
4498 * buildbot/status/builder.py:
4499 add EXCEPTION as a result - this is a problem for the bot
4500 maintainer, not a build problem for the changers
4501 * buildbot/process/step.py:
4502 use EXCEPTION instead of FAILURE for exceptions
4503 * buildbot/status/html.py:
4504 add build_get_class to get a class out of a build/buildstep
4505 finish naming the classes
4506 split out sourceNames to changeNames and builderNames so we
4507 can style them separately
4508 * docs/config.xhtml:
4509 finish documenting classes as they are right now
4511 * buildbot/status/html.py:
4512 name the classes as we agreed on IRC
4513 * docs/config.xhtml:
4516 * buildbot/status/html.py:
4517 same for cssclass->class_
4519 * buildbot/status/html.py:
4520 as decided on IRC, use class_ for the "class" attribute to not
4521 conflict with the class keyword, and clean up the messy **{} stuff.
4523 * buildbot/status/mail.py:
4524 put back "builders" argument, and fix docstring, because the
4525 code *ignores* builders listed in this argument
4527 * buildbot/process/builder.py:
4528 remove FIXME notes - category is now indeed a cvar of BuilderStatus
4530 * docs/config.xhtml:
4531 describe the category argument for builders
4533 * buildbot/status/builder.py:
4534 Fix a silly bug due to merging
4536 * buildbot/process/builder.py:
4537 remove category from the process Builder ...
4538 * buildbot/status/builder.py:
4539 ... and add it to BuilderStatus instead.
4540 Set category on unpickled builder statuses, they might not have it.
4541 * buildbot/master.py:
4542 include category when doing builderAdded
4543 * buildbot/status/mail.py:
4544 return None instead of self for builders we are not interested in.
4545 * buildbot/test/test_run.py:
4546 fix a bug due to only doing deferredResult on "dummy" waiting
4547 * buildbot/test/test_status.py:
4548 add checks for the Mail IStatusReceiver returning None or self
4550 * buildbot/status/html.py:
4551 fix testsuite by prefixing page title with BuildBot
4553 * buildbot/status/builder.py:
4554 have .category in builder status ...
4555 * buildbot/process/builder.py:
4556 ... and set it from Builder
4557 * buildbot/status/html.py:
4558 make .css a class variable
4559 * buildbot/test/test_status.py:
4560 write more tests to cover our categories stuff ...
4561 * buildbot/status/mail.py:
4562 ... and fix the bug that this uncovered
4564 * buildbot/changes/mail.py:
4565 * buildbot/changes/pb.py:
4566 * buildbot/master.py:
4567 * buildbot/process/base.py:
4568 * buildbot/process/factory.py:
4569 * buildbot/process/interlock.py:
4570 * buildbot/process/step.py:
4571 * buildbot/process/step_twisted.py:
4572 * buildbot/slave/commands.py:
4573 * buildbot/status/builder.py:
4574 * buildbot/status/client.py:
4575 * buildbot/status/html.py:
4576 * buildbot/status/mail.py:
4577 * buildbot/status/progress.py:
4578 * buildbot/test/test_changes.py:
4579 * buildbot/test/test_config.py:
4580 * buildbot/test/test_control.py:
4581 * buildbot/test/test_interlock.py:
4582 * buildbot/test/test_maildir.py:
4583 * buildbot/test/test_mailparse.py:
4584 * buildbot/test/test_run.py:
4585 * buildbot/test/test_slavecommand.py:
4586 * buildbot/test/test_status.py:
4587 * buildbot/test/test_steps.py:
4588 * buildbot/test/test_twisted.py:
4589 * buildbot/test/test_util.py:
4590 * buildbot/test/test_vc.py:
4591 * buildbot/test/test_web.py:
4593 add test-case-name at the top of a whole set of files
4595 * buildbot/status/builder.py:
4596 keep order of addition when getting builder names
4597 * buildbot/status/words.py:
4598 * buildbot/test/test_run.py:
4599 add test for getBuilderNames
4601 * buildbot/process/base.py:
4602 * buildbot/process/step.py:
4603 * buildbot/status/builder.py:
4604 * buildbot/status/html.py:
4605 make buildbot css-able
4606 replace the color code for purple with purple, don't understand
4607 why it wasn't purple to start with
4609 * buildbot/status/words.py:
4610 ok, so it doesn't look like BuilderStatus.remote is still valid.
4611 Use what waterfall uses instead.
4613 * buildbot/interfaces.py:
4614 * buildbot/status/builder.py:
4615 * buildbot/status/html.py:
4616 * buildbot/status/mail.py:
4617 * buildbot/status/words.py:
4618 * buildbot/test/test_run.py:
4619 use categories everywhere and make it be a list. More sensible
4620 for the future. Also make words actually respect this in
4623 * buildbot/interfaces.py:
4624 add category argument to getBuilderNames
4625 * buildbot/process/builder.py:
4626 * buildbot/status/builder.py:
4627 * buildbot/status/html.py:
4628 * buildbot/status/mail.py:
4629 * buildbot/status/words.py:
4630 * buildbot/test/test_run.py:
4631 move from specifying builders by name to specifying the category
4633 * buildbot/status/html.py:
4634 * buildbot/status/words.py:
4635 add "builders=" to __init__ of status clients so they can
4636 limit themselves to the given list of builders to report on
4638 * buildbot/status/html.py: set the title to the product name
4640 2005-04-23 Thomas Vander Stichele <thomas at apestaart dot org>
4642 * buildbot/interfaces.py:
4643 * buildbot/status/builder.py:
4644 more documentation. Hm, not sure if ChangeLog entries make sense
4647 2005-04-23 Brian Warner <warner@lothar.com>
4649 * buildbot/test/test_vc.py (SetupMixin.do_vc): increase timeouts
4651 * buildbot/test/test_slavecommand.py (Shell): increase timeouts
4653 * buildbot/scripts/runner.py: make 'statuslog' and 'statusgui' be
4654 the sub-commands that log buildmaster status to stdout and to a
4655 GUI window, respectively.
4657 * buildbot/clients/gtkPanes.py: overhaul. basic two-row
4658 functionality is working again, but all the step-status and ETA
4659 stuff is missing. Commented out a lot of code pending more
4662 * buildbot/status/client.py: make sure that IRemote(None) is None
4664 * buildbot/changes/changes.py: import defer, oops
4665 (ChangeMaster): remove the .sources list, rely upon the fact that
4666 MultiServices can be treated as sequences of their children. This
4667 cleans up the add/remove ChangeSource routines a lot, as we keep
4668 exactly one list of the current sources instead of three.
4670 * buildbot/master.py (BuildMaster.__init__): remove .sources, set
4671 up an empty ChangeMaster at init time.
4672 (BuildMaster.loadChanges): if there are changes to be had from
4673 disk, replace self.change_svc with the new ones. If not, keep
4674 using the empty ChangeMaster set up in __init__.
4675 (BuildMaster.loadConfig_Sources): use list(self.change_svc)
4676 instead of a separate list, makes the code a bit cleaner.
4677 * buildbot/test/test_config.py (ConfigTest.testSimple): match it
4678 (ConfigTest.testSources): same, also wait for loadConfig to finish.
4679 Extend the test to make sure we can get rid of the sources when
4682 2005-04-22 Brian Warner <warner@lothar.com>
4684 * buildbot/scripts/runner.py (Maker.mkinfo): create the info/admin
4685 and info/host files when making the slave directory
4687 * buildbot/test/test_run.py (RunMixin.shutdownSlave): remove the
4688 whendone= argument, just return the Deferred and let the caller do
4689 what they want with it.
4690 (Disconnect.testBuild1): wait for shutdownSlave
4691 (Basedir.testChangeBuilddir): new test to make sure changes to the
4692 builddir actually get propagated to the slave
4694 * buildbot/slave/bot.py (SlaveBuilder.setBuilddir): use an
4695 explicit method, rather than passing the builddir in __init__ .
4696 Make sure to update self.basedir too, this was broken before.
4697 (Bot.remote_setBuilderList): use b.setBuilddir for both new
4698 builders and for ones that have just had their builddir changed.
4699 (BotFactory): add a class-level .perspective attribute, so
4700 BuildSlave.waitUntilDisconnected won't get upset when the
4701 connection hasn't yet been established
4702 (BuildSlave.__init__): keep track of the bot.Bot instance, so
4703 tests can reach through it to inspect the SlaveBuilders
4705 * buildbot/process/base.py (Build.buildException): explain the
4706 log.err with a log.msg
4707 * buildbot/process/builder.py (Builder.startBuild): same
4708 (Builder._startBuildFailed): improve error message
4710 * buildbot/pbutil.py (RBCP.failedToGetPerspective): if the failure
4711 occurred because we lost the brand-new connection, retry instead
4712 of giving up. If not, it's probably an authorization failure, and
4713 it makes sense to stop trying. Make sure we log.msg the reason
4714 that we're log.err'ing the failure, otherwise test failures are
4715 really hard to figure out.
4717 * buildbot/master.py: change loadConfig() to return a Deferred
4718 that doesn't fire until the change has been fully implemented.
4719 This means any connected slaves have been updated with the new
4720 builddir. This change makes it easier to test the code which
4721 actually implements this builddir-updating.
4722 (BotPerspective.addBuilder): return Deferred
4723 (BotPerspective.removeBuilder): same
4724 (BotPerspective.attached): same
4725 (BotPerspective._attached): same. finish with remote_print before
4726 starting the getSlaveInfo, instead of doing them in parallel
4727 (BotPerspective.list_done): same
4728 (BotMaster.removeSlave): same. Fix the typo that meant we weren't
4729 actually calling slave.disconnect()
4730 (BotMaster.addBuilder): same
4731 (BotMaster.removeBuilder): same
4732 (BuildMaster.loadConfig): same
4733 (BuildMaster.loadConfig_Slaves): same
4734 (BuildMaster.loadConfig_Sources): same
4735 (BuildMaster.loadConfig_Builders): same
4736 (BuildMaster.loadConfig_status): same
4738 * buildbot/changes/changes.py (ChangeMaster.removeSource): return
4739 a Deferred that fires when the source is finally removed
4741 * buildbot/slave/commands.py (SourceBase.doClobber): when removing
4742 the previous tree on win32, where we have to do it synchronously,
4743 make sure we return a Deferred anyway.
4744 (SourceBase.doCopy): same
4746 * buildbot/scripts/runner.py (statusgui): use the text client for
4747 now, while I rewrite the Gtk one
4748 * buildbot/clients/base.py: strip out old code, leaving just the
4749 basic print-message-on-event functionality. I also remove the
4750 ReconnectingPBClientFactory, but it does at least quit when it
4751 loses the connection instead of going silent
4753 2005-04-21 Brian Warner <warner@lothar.com>
4755 * Makefile: minor tweaks
4757 * NEWS: point out deprecation warnings, new features for
4760 * buildbot/master.py (BuildMaster.loadConfig): emit
4761 DeprecationWarnings for Builders defined with tuples. Rearrange
4762 code to facility removal of deprecated configuration keys in the
4765 * buildbot/scripts/runner.py (createMaster,createSlave): rewrite
4766 'buildbot' command to put a little Makefile in the target that
4767 helps you re-create the buildbot.tap file, start or stop the
4768 master/slave, and reconfigure (i.e. SIGHUP) the master. Also chmod
4769 all the files 0600, since they contain passwords.
4770 (start): if there is a Makefile, and /usr/bin/make exists, use
4771 'make start' in preference to a raw twistd command. This lets
4772 slave admins put things like PYTHONPATH variables in their
4773 Makefiles and have them still work when the slave is started with
4774 'buildbot start ~/slave/foo'. The test is a bit clunky, it would
4775 be nice to first try the 'make' command and only fall back to
4776 twistd if it fails. TODO: the Makefile's "start" command does not
4777 add the --reactor=win32 argument when running under windows.
4778 (Options.debugclient, Options.statusgui): add sub-commands to launch
4779 the debug client (formerly in contrib/debugclient.py) and the
4780 Gtk status application (currently broken)
4781 * buildbot/clients/debug.py: move from contrib/debugclient.py
4782 * buildbot/clients/debug.glade: same
4784 * buildbot/test/test_trial.py: remove it. This requires some
4785 functionality out of Twisted that isn't there yet, and until then
4786 having it around just confuses things.
4788 * buildbot/test/test_slavecommand.py (Shell): test both with and
4789 without PTYs, and make sure that command output is properly
4790 interleaved in the with-PTY case. I think the without-PTY test
4791 should pass on windows, where we never use PTYs anyway.
4793 2005-04-20 Brian Warner <warner@lothar.com>
4795 * README (REQUIREMENTS): mention Twisted-2.0.0 compatibility
4797 * MANIFEST.in: add epyrun, gen-reference, buildbot.png
4799 * NEWS: start creating entries for the next release
4801 * buildbot/slave/commands.py (ShellCommand.__init__): use os.pathsep
4803 * buildbot/test/test_web.py (WebTest.test_webPortnum): add timeout
4804 (WebTest.test_webPathname): same
4805 (WebTest.test_webPathname_port): same
4806 (WebTest.test_waterfall): use the default favicon rather than
4807 rooting around the filesystem for it. Open the expected-icon file
4808 in binary mode, to make win32 tests happier (thanks to Nick Trout
4810 * buildbot/status/html.py (buildbot_icon): win32 portability
4812 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase.testShellZ):
4813 win32-compatibility fixes from Nick Trout, the "file not found" message
4814 is different under windows
4815 (FakeSlaveBuilder.__init__): clean up setup a bit
4816 * buildbot/test/test_vc.py (VCSupport.__init__): win32: use os.pathsep
4818 2005-04-19 Brian Warner <warner@lothar.com>
4820 * buildbot/test/test_vc.py (SetupMixin.setUpClass): fix the
4821 skip-if-repositories-are-unavailable test to not kill the trial
4822 that comes with Twisted-1.3.0
4824 * setup.py: install buildbot.png icon file when installing code
4826 * buildbot/slave/commands.py (ShellCommand._startCommand): log the
4827 environment used by the command, at least on the child side.
4829 * buildbot/status/html.py (TextLog.pauseProducing): add a note,
4830 this method needs to be added and implemented because it gets
4831 called under heavy load. I don't quite understand the
4832 producer/consumer API enough to write it.
4833 (StatusResource.getChild): add a resource for /favicon.ico
4834 (Waterfall.__init__): add favicon= argument
4835 * buildbot/test/test_web.py (WebTest.test_waterfall): test it
4836 (WebTest.test_webPortnum): stop using deprecated 'webPortnum'
4837 (WebTest.test_webPathname): same
4838 (WebTest.test_webPathname_port): same
4839 * docs/config.xhtml: mention favicon=
4840 * buildbot/buildbot.png: add a default icon, dorky as it is
4842 2005-04-18 Thomas Vander Stichele <thomas at apestaart dot org>
4844 * buildbot/master.py:
4845 * buildbot/process/base.py:
4846 * buildbot/process/builder.py:
4847 * buildbot/process/interlock.py:
4848 * buildbot/status/builder.py:
4849 * buildbot/status/html.py:
4850 * buildbot/status/mail.py:
4851 * buildbot/status/words.py:
4852 new documentation while digging through the code
4854 2005-04-17 Brian Warner <warner@lothar.com>
4856 * general: try to fix file modes on all .py files: a+r, a-x,
4857 but let buildbot/clients/*.py be +x since they're tools
4859 * docs/epyrun (addMod): when an import fails, say why
4861 * Makefile: Add a 'docs' target, hack on the PYTHONPATH stuff
4863 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4865 * buildbot/process/base.py:
4866 * buildbot/process/builder.py:
4867 * buildbot/status/builder.py:
4868 new documentation while digging through the code
4870 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4872 * buildbot/changes/changes.py:
4873 * buildbot/changes/p4poller.py:
4874 * buildbot/interfaces.py:
4875 * buildbot/process/base.py:
4876 * buildbot/process/builder.py:
4877 * buildbot/process/step.py:
4878 * buildbot/process/step_twisted.py:
4879 * buildbot/slave/bot.py:
4880 * buildbot/slave/commands.py:
4881 * buildbot/status/builder.py:
4882 fix all docstrings to make epydoc happy. In the process of fixing
4883 some, I also moved pieces of docs, and removed some deprecated
4886 2005-04-17 Thomas Vander Stichele <thomas at apestaart dot org>
4888 * buildbot/process/builder.py:
4889 * buildbot/process/interlock.py:
4890 * buildbot/process/process_twisted.py:
4891 * buildbot/process/step.py:
4892 BuildProcess -> Build, as it looks like that's what happened
4893 * buildbot/process/base.py:
4894 * buildbot/process/factory.py:
4897 2005-04-17 Brian Warner <warner@lothar.com>
4899 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
4900 update compile command to accomodate the Twisted split.. now
4901 instead of './setup.py build_ext -i', you do './setup.py all
4902 build_ext -i', to run build_ext over all sub-projects.
4903 (FullTwistedBuildFactory): same
4904 (TwistedReactorsBuildFactory): same
4906 * buildbot/status/html.py (TextLog.finished): null out self.req
4907 when we're done, otherwise the reference cycle of TextLog to .req
4908 to .notifications to a Deferred to TextLog.stop keeps them from
4909 being collected, and consumes a huge (610MB on pyramid at last
4910 check) amount of memory.
4912 2005-04-11 Brian Warner <warner@lothar.com>
4914 * buildbot/test/test_vc.py (VCSupport.__init__): use abspath() to
4915 normalize the VC-repository location.. makes SVN happier with
4916 certain test environments.
4918 * buildbot/process/step.py (RemoteShellCommand.__init__): let each
4919 RemoteShellCommand gets its own .env dictionary, so that code in
4920 start() doesn't mutate the original. I think this should fix the
4921 step_twisted.Trial problem where multiple identical components
4922 kept getting added to PYTHONPATH= over and over again.
4924 * general: merge org.apestaart@thomas/buildbot--doc--0--patch-3,
4925 adding epydoc-format docstrings to many classes. Thanks to Thomas
4926 Vander Stichele for the patches.
4927 * docs/epyrun, docs/gen-reference: add epydoc-generating tools
4928 * buildbot/status/mail.py, buildbot/process/step_twisted.py: same
4929 * buildbot/slave/bot.py, commands.py, registry.py: same
4931 2005-04-05 Brian Warner <warner@lothar.com>
4933 * buildbot/slave/commands.py (SourceBase.doCopy): use cp -p to
4934 preserve timestamps, helps incremental builds of large trees.
4935 Patch from Rene Rivera.
4937 * buildbot/slave/bot.py (SlaveBuilder.commandComplete): oops, log
4938 'failure' and not the non-existent 'why'. Thanks to Rene Rivera
4941 2005-04-03 Brian Warner <warner@lothar.com>
4943 * buildbot/master.py (BuildMaster.loadConfig): only call exec()
4944 with one dict, apparently exec has some scoping bugs when used
4945 with both global/local dicts. Thanks to Nathaniel Smith for the
4948 2005-04-02 Brian Warner <warner@lothar.com>
4950 * buildbot/process/step_twisted.py (countFailedTests): the new
4951 trial in Twisted-2.0 emits a slightly different status line than
4952 old trial ("PASSED.." instead of "OK.."). Handle it so we don't
4953 mistakenly think the test count is unparseable.
4954 (Trial.start): note that for some reason each build causes another
4955 copy of self.testpath to be prepended to PYTHONPATH. This needs to
4956 be fixed but I'm not sure quite where the problem is.
4958 2005-04-01 Brian Warner <warner@lothar.com>
4960 * buildbot/test/test_run.py (Run.testMaster): change some uses of
4961 deferredResult to avoid hangs/warnings under twisted-2.0
4962 (RunMixin.tearDown): same
4963 (RunMixin.shutdownSlave): same
4964 (Disconnect.testIdle1): same
4965 (Disconnect.testBuild2): same: wait one second after the build
4966 finishes for test to really be done.. this should be cleaned up to
4967 avoid wasting that second. Builder.detach uses a callLater(0),
4968 either that should be done in-line (something else needed that
4969 behavior), or it should return a Deferred that fires when the
4970 builder is really offline.
4971 (Disconnect.testBuild3): same
4972 (Disconnect.testDisappear): same
4974 * buildbot/test/test_web.py: rearrange server-setup and teardown
4975 code to remove unclean-reactor warnings from twisted-2.0
4977 * buildbot/test/test_vc.py: rearrange probe-for-VC-program routine
4978 so the tests don't hang under twisted-2.0
4980 2005-03-31 Brian Warner <warner@lothar.com>
4982 * buildbot/slave/bot.py (Bot.remote_setBuilderList): fix typo that
4983 caused a warning each time the master changed our set of builders
4985 * buildbot/status/builder.py (BuildStatus.saveYourself): under
4986 w32, don't unlink the file unless it already exists. Thanks to
4987 Baptiste Lepilleur for the catch.
4988 (BuilderStatus.saveYourself): same
4990 2005-02-01 Brian Warner <warner@lothar.com>
4992 * buildbot/status/html.py (TextLog.getChild): use a /text child
4993 URL, such as http://foo.com/svn-hello/builds/1/test/0/text instead
4994 of http://foo.com/svn-hello/builds/1/test/0 , to retrieve the
4995 logfile as text/plain (no markup, no headers). This replaces the
4996 previous scheme (which used an ?text=1 argument), and gets us back
4997 to a relative link (which works better when the buildbot lives
4998 behind another web server, such as Apache configured as a reverse
4999 proxy). Thanks to Gerald Combs for spotting the problem.
5001 * buildbot/__init__.py (version): bump to 0.6.2+ while between
5004 2004-12-13 Brian Warner <warner@lothar.com>
5006 * buildbot/__init__.py (version): Releasing buildbot-0.6.2
5008 * debian/changelog: update for 0.6.2
5009 * NEWS: finalize for 0.6.2
5011 2004-12-11 Brian Warner <warner@lothar.com>
5013 * NEWS: bring it up to date
5015 * buildbot/slave/bot.py (BotFactory): revamp keepalive/lost-master
5016 detection code. Require some sign of life from the buildmaster
5017 every BotFactory.keepaliveInterval seconds. Provoke this
5018 indication at BotFactory.keepaliveTimeout seconds before the
5019 deadline by sending a keepalive request. We don't actually care if
5020 that request is answered in a timely fashion, what we care about
5021 is that .activity() is called before the deadline. .activity() is
5022 triggered by any PB message from the master (including an ack to
5023 one of the slave's status-update messages). With this new scheme,
5024 large status messages over slow pipes are OK, as long as any given
5025 message can be sent (and thus acked) within .keepaliveTimeout
5026 seconds (which defaults to 30).
5027 (SlaveBuilder.remote_startCommand): record activity
5028 (SlaveBuilder.ackUpdate): same
5029 (SlaveBuilder.ackComplete): same
5030 (BotFactory.gotPerspective): same
5031 * buildbot/test/test_run.py (Disconnect.testSlaveTimeout): test it
5033 2004-12-09 Brian Warner <warner@lothar.com>
5035 * buildbot/status/html.py (StatusResourceBuilder.getChild): remove
5038 * buildbot/process/step_twisted.py (Trial._commandComplete):
5039 update self.cmd when we start the 'cat test.log' transfer. Without
5040 this, we cannot interrupt the correct RemoteCommand when we lose
5043 * buildbot/process/step.py (RemoteCommand.interrupt): don't bother
5044 trying to tell the slave to stop the command if we're already
5045 inactive, or if we no longer have a .remote
5047 * buildbot/process/builder.py (Builder._detached): don't let an
5048 exception in currentBuild.stopBuild() prevent the builder from
5049 being marked offline
5051 2004-12-07 Brian Warner <warner@lothar.com>
5053 * buildbot/status/words.py (IrcStatusBot.getBuilder): catch the
5054 KeyError that happens when you ask for a non-existent Builder, and
5055 translate it into a UsageError.
5057 * buildbot/test/test_run.py (Disconnect.testBuild4): validate that
5058 losing the slave in the middle of a remote step is handled too
5060 * buildbot/process/step.py (ShellCommand.interrupt): 'reason' can
5061 be a Failure, so be sure to stringify it before using it as the
5062 contents of the 'interrupt' logfile
5063 (RemoteCommand.interrupt): use stringified 'why' in
5064 remote_interruptCommand too, just in case
5066 2004-12-06 Brian Warner <warner@lothar.com>
5068 * buildbot/slave/commands.py (Arch.doVCUpdate): use 'tla replay'
5069 instead of 'tla update', which is more efficient in case we've
5070 missed a couple of patches since the last update.
5072 * debian/changelog: update for previous (0.6.1) release. Obviously
5073 this needs to be handled better.
5075 2004-12-05 Brian Warner <warner@lothar.com>
5077 * NEWS: update for stuff since last release
5079 * buildbot/master.py (DebugPerspective.attached): return 'self', to
5080 match the maybeDeferred change in Dispatcher.requestAvatar
5081 * buildbot/changes/pb.py (ChangePerspective.attached): same
5082 * buildbot/status/client.py (StatusClientPerspective.attached): same
5083 * buildbot/process/builder.py (Builder._attached3): same
5084 * buildbot/pbutil.py (NewCredPerspective.attached): same
5086 * buildbot/status/html.py (WaterfallStatusResource.phase2): Add
5087 the date to the top-most box, if it is not the same as today's
5090 * docs/slave.xhtml: provide a buildslave setup checklist
5092 * docs/source.xhtml (Arch): correct terminology
5094 2004-12-04 Brian Warner <warner@lothar.com>
5096 * buildbot/test/test_slavecommand.py: use sys.executable instead
5097 of hard-coding 'python' for child commands, might help portability
5099 * docs/examples/twisted_master.cfg: update to current usage
5101 * buildbot/status/words.py (IrcStatusBot.command_STOP): add a
5102 'stop build' command to the IRC bot
5104 * buildbot/master.py (Dispatcher.requestAvatar): remove debug
5105 message that broke PBChangeSource
5107 * buildbot/slave/bot.py: clean up shutdown/lose-master code
5108 (SlaveBuilder): make some attributes class-level, remove the old
5109 "update queue" which existed to support resuming a build after the
5110 master connection was lost. Try to reimplement that feature later.
5111 (SlaveBuilder.stopCommand): clear self.command when the
5112 SlaveCommand finishes, so that we don't try to kill a leftover one
5114 (SlaveBuilder.commandComplete): same, merge with commandFailed and
5117 * buildbot/slave/commands.py (SourceBase): set self.command for
5118 all VC commands, so they can be interrupted.
5120 2004-12-03 Brian Warner <warner@lothar.com>
5122 * buildbot/master.py: clean up slave-handling code, to handle
5123 slave-disconnect and multiple-connect better
5124 (BotPerspective): make these long-lasting, exactly one per bot
5125 listed in the config file.
5126 (BotPerspective.attached): if a slave connects while an existing
5127 one appears to still be connected, disconnect the old one first.
5128 (BotPerspective.disconnect): new method to forcibly disconnect a
5129 buildslave. Use some hacks to empty the transmit buffer quickly to
5130 avoid the long (20-min?) TCP timeout that could occur if the old
5131 slave has dropped off the net.
5132 (BotMaster): Keep persistent BotPerspectives in .slaves, let them
5133 own their own SlaveStatus objects. Remove .attached/.detached, add
5134 .addSlave/.removeSlave, treat slaves like Builders (config file
5135 parsing sends deltas to the BotMaster). Inform the slave
5136 instances, i.e. the BotPerspective, about addBuilder and
5138 (BotMaster.getPerspective): turns into a single dict lookup
5139 (Dispatcher.requestAvatar): allow .attached to return a Deferred,
5140 which gives BotPerspective.attached a chance to disconnect the old
5142 (BuildMaster.loadConfig): add code (disabled) to validate that all
5143 builders use known slaves (listed in c['bots']). The check won't
5144 work with tuple-specified builders, which are deprecated but not
5145 yet invalid, so the check is disabled for now.
5146 (BuildMaster.loadConfig_Slaves): move slave-config into a separate
5147 routine, do the add/changed/removed dance with them like we do
5149 (BuildMaster.loadConfig_Sources): move source-config into a
5150 separate routine too
5152 * buildbot/status/builder.py (Status.getSlave): get the
5153 SlaveStatus object from the BotPerspective, not the BotMaster.
5155 * buildbot/test/test_run.py: bunch of new tests for losing the
5156 buildslave at various points in the build, handling a slave that
5157 connects multiple times, and making sure we can interrupt a
5160 * buildbot/slave/bot.py (BuildSlave): make it possible to use
5161 something other than 'Bot' for the Bot object, to make certain
5162 test cases easier to write.
5163 (BuildSlave.waitUntilDisconnected): utility method for testing
5165 2004-11-30 Brian Warner <warner@lothar.com>
5167 * buildbot/test/test_run.py (RunMixin): refactor, remove debug msg
5169 * buildbot/interfaces.py (IBuilderControl.ping): add timeout=
5170 argument, return a Deferred that always fires with True or False.
5171 I don't use an errback to indicate 'ping failed' so that callers
5172 are free to ignore the deferred without causing spurious errors in
5174 * buildbot/process/builder.py (BuilderControl.ping): implement it
5176 * buildbot/test/test_run.py (Status.testDisappear): test ping
5177 (Status.disappearSlave): fix it
5179 2004-11-30 Brian Warner <warner@lothar.com>
5181 * buildbot/interfaces.py (IBuildControl): add .stopBuild
5182 (IBuilderControl): add .getBuild(num), only works for the current
5183 build, of course, although it might be interesting to offer
5184 something for builds in the .waiting or .interlocked state.
5186 * buildbot/process/base.py (Build): have .stopBuild just do the
5187 interrupt, then let the build die by itself.
5188 (BuildControl): add .stopBuild, and add a point-event named
5189 'interrupt' just after the build so status viewers can tell that
5191 (BuilderControl): add .getBuild
5193 * buildbot/process/step.py (Dummy): use haltOnFailure so it really
5194 stops when you kill it, good for testing
5195 (ShellCommand.interrupt): add a logfile named 'interrupt' which
5196 contains the 'reason' text.
5198 * buildbot/status/html.py: Add Stop Build button, if the build can
5199 still be stopped. Send a Redirect (to the top page) one second
5200 later, hopefully long enough for the interrupt to have an effect.
5201 Move make_row() up to top-level to share it between Stop Build and
5204 * buildbot/slave/commands.py: only kill the child process once
5206 * buildbot/test/test_run.py: add testInterrupt
5208 2004-11-29 Brian Warner <warner@lothar.com>
5210 * buildbot/process/base.py: Refactor command interruption. The
5211 Build is now responsible for noticing that the slave has gone
5212 away: Build.lostRemote() interrupts the current step and makes
5213 sure that no further ones will be started.
5215 * buildbot/process/builder.py: When the initial remote_startBuild
5216 message fails, log it: this usually indicates that the slave has
5217 gone away, but we don't really start paying attention until they
5218 fail to respond to the first step's command.
5220 * buildbot/process/step.py (RemoteCommand): Does *not* watch for
5221 slave disconnect. Now sports a new interrupt() method. Error
5222 handling was simplified a lot by chaining deferreds, so
5223 remoteFailed/remoteComplete were merged into a single
5224 remoteComplete method (which can now get a Failure object).
5225 Likewise failed/finished were merged into just _finished.
5226 (BuildStep): Add interrupt(why) method, and if why is a
5227 ConnectionLost Failure then the step is failed with some useful
5230 * buildbot/slave/bot.py: stop the current command when the remote
5231 Step reference is lost, and when the slave is shut down.
5232 (Bot): make it a MultiService, so it can have children. Use
5233 stopService to tell when the slave is shutting down.
5234 (SlaveBuilder): make it a Service, and a child of the Bot. Add
5235 remote_interruptCommand (which asks the current SlaveCommand to
5236 stop but allows it to keep emitting status messages), and
5237 stopCommand (which tells it to shut up and die).
5239 * buildbot/slave/commands.py: make commands interruptible
5240 (ShellCommand.kill): factor out os.kill logic
5241 (Command): factor out setup()
5242 (Command.sendStatus): don't send status if .running is false, this
5243 happens when the command has been halted.
5244 (Command.interrupt): new method, used to tell the command to die
5245 (SlaveShellCommand): implement .interrupt
5246 (DummyCommand): implement .interrupt
5247 (SourceBase, etc): factor out setup(), don't continue substeps if
5250 * buildbot/status/builder.py: fix all waitUntilFinished() methods
5251 so they can be called after finishing
5253 * buildbot/test/test_run.py: new tests for disconnect behavior,
5254 refactor slave-shutdown routines, add different kinds of
5257 2004-11-27 Brian Warner <warner@lothar.com>
5259 * buildbot/status/words.py (IrcStatusBot.convertTime): utility
5260 method to express ETA time like "2m45s" instead of "165 seconds"
5262 2004-11-24 Brian Warner <warner@lothar.com>
5264 * buildbot/test/test_vc.py (VC.testArch): unregister the test
5265 archive after the test completes, to avoid cluttering the user's
5266 'tla archives' listing with a bogus entry. Arch doesn't happen to
5267 provide any way to override the use of ~/.arch-params/, so there
5268 isn't a convenient way to avoid touching the setup of the user who
5270 (VC_HTTP.testArchHTTP): same
5272 2004-11-23 Brian Warner <warner@lothar.com>
5274 * buildbot/status/html.py (TextLog): split render() up into
5275 render_HEAD and render_GET. Use a Producer when sending log
5276 chunks, to reduce memory requirements and avoid sending huge
5277 non-Banana-able strings over web.distrib connections. Requires
5278 peeking under the covers of IStatusLog.
5279 (TextLog.resumeProducing): fix the "as text" link, handle client
5280 disconnects that occur while we're still sending old chunks.
5282 * buildbot/status/builder.py (HTMLLogFile.waitUntilFinished): oops,
5283 use defer.succeed, not the non-existent defer.success
5284 (LogFile.waitUntilFinished): same
5285 (LogFile.subscribe): don't add watchers to a finished logfile
5287 * buildbot/__init__.py (version): bump to 0.6.1+ while between
5290 2004-11-23 Brian Warner <warner@lothar.com>
5292 * buildbot/__init__.py (version): Releasing buildbot-0.6.1
5294 2004-11-23 Brian Warner <warner@lothar.com>
5296 * NEWS: update for the 0.6.1 release
5297 * MANIFEST.in: add new files
5299 * README (INSTALLATION): explain how to enable the extra VC tests
5301 * buildbot/status/builder.py (LogFile): add .runEntries at the class
5302 level to, so old pickled builds can be displayed ok
5304 2004-11-22 Brian Warner <warner@lothar.com>
5306 * NEWS: summarize updates since last release
5308 * README (SLAVE): fix usage of 'buildbot slave' command. Thanks to
5309 Yoz Grahame. Closes SF#1050138.
5311 * docs/changes.xhtml (FreshCVSSourceNewcred): fix typo. Closes
5314 * buildbot/process/step_twisted.py (Trial): update docs a bit
5316 * docs/factories.xhtml: fix Trial factory docs to match reality.
5319 * buildbot/process/factory.py (Trial.__init__): add args for
5320 randomly= and recurse=, making them available to instantiators
5321 instead of only to subclassers. Closes: SF#1049759.
5323 2004-11-15 Brian Warner <warner@lothar.com>
5325 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
5326 try to teach the Quick factory to use multiple versions of python
5328 2004-11-12 Brian Warner <warner@lothar.com>
5330 * buildbot/status/builder.py (BuilderStatus.saveYourself): use a
5331 safer w32-compatible approach, and only use it on windows
5332 (BuildStatus.saveYourself): same
5334 2004-11-11 Brian Warner <warner@lothar.com>
5336 * buildbot/status/builder.py (LogFile.addEntry): smarter way to do
5337 it: one string merge per chunk. There are now separate .entries
5338 and .runEntries lists: when enumerating over all chunks, make sure
5340 * buildbot/test/test_status.py (Log): more tests
5342 * buildbot/status/builder.py (LogFile.addEntry): Merge string
5343 chunks together, up to 10kb per chunk. This ought to cut down on
5344 the CPU-burning overhead of large log files. Thanks to Alexander
5345 Staubo for spotting the problem.
5346 * buildbot/test/test_status.py (Log): tests for same
5348 2004-11-10 Brian Warner <warner@lothar.com>
5350 * buildbot/status/mail.py (MailNotifier.buildMessage): add a Date
5351 header to outbound mail
5352 * buildbot/test/test_status.py (Mail.testBuild1): test for same
5354 2004-11-08 Brian Warner <warner@lothar.com>
5356 * buildbot/status/builder.py (BuilderStatus.saveYourself): w32
5357 can't do os.rename() onto an existing file, so catch the exception
5358 and unlink the target file first. This introduces a slight window
5359 where the existing file could be lost, but the main failure case
5360 (disk full) should still be handled safely.
5361 (BuildStatus.saveYourself): same
5363 * buildbot/changes/pb.py (ChangePerspective): use a configurable
5364 separator character instead of os.sep, because the filenames being
5365 split here are coming from the VC system, which can have a
5366 different pathname convention than the local host. This should
5367 help a buildmaster running on windows that uses a CVS repository
5368 which runs under unix.
5369 * buildbot/changes/mail.py (MaildirSource): same, for all parsers
5371 * buildbot/process/step_twisted.py (Trial.createSummary): survive
5372 when there are no test failures to be parsed
5374 * buildbot/scripts/runner.py (createMaster): use shutil.copy()
5375 instead of the unix-specific os.system("cp"), thanks to Elliot
5376 Murphy for this and the other buildbot-vs-windows catches.
5377 * buildbot/test/test_maildir.py (MaildirTest.deliverMail): same
5379 * contrib/windows/buildbot.bat: prefix a '@', apparently to not
5380 echo the command as it is run
5382 * setup.py: install sample.mk too, not just sample.cfg
5383 (scripts): install contrib/windows/buildbot.bat on windows
5385 2004-11-07 Brian Warner <warner@lothar.com>
5387 * buildbot/process/builder.py (Builder._detached): clear the
5388 self.currentBuild reference, otherwise the next build will be
5389 skipped because we think the Builder is already in use.
5391 * docs/examples/twisted_master.cfg: update to match current usage
5392 on the Twisted buildbot
5394 2004-10-29 Brian Warner <warner@lothar.com>
5396 * buildbot/status/mail.py (MailNotifier): fix typo in docs
5398 2004-10-28 Brian Warner <warner@lothar.com>
5400 * buildbot/slave/commands.py (SourceBase): refactor subclasses to
5401 have separate doVCUpdate/doVCFull methods. Catch an update failure
5402 and respond by clobbering the source directory and re-trying. This
5403 will handle local changes (like replacing a file with a directory)
5404 that will cause CVS and SVN updates to fail.
5405 * buildbot/test/test_vc.py (SetupMixin.do_vc): test the same
5407 * buildbot/process/step.py (LoggedRemoteCommand.__repr__): avoid a
5410 2004-10-19 Brian Warner <warner@lothar.com>
5412 * buildbot/process/step_twisted.py (Trial.createSummary): bugfixes
5414 * buildbot/status/html.py (StatusResourceTestResults): display any
5415 TestResults that the Build might have
5416 (StatusResourceTestResult): and the logs for each TestResult
5417 (StatusResourceBuild): add link from the per-build page
5419 2004-10-15 Brian Warner <warner@lothar.com>
5421 * buildbot/process/step_twisted.py (Trial.createSummary): parse
5422 the 'problems' portion of stdout, add TestResults to our build
5423 * buildbot/test/test_twisted.py (Parse.testParse): test it
5425 * buildbot/interfaces.py (IBuildStatus.getTestResults): new method
5426 to retrieve a dict of accumulated test results
5427 (ITestResult): define what a single test result can do
5428 * buildbot/status/builder.py (TestResult): implement ITestResult
5429 (BuildStatus.getTestResults): retrieve dict of TestResults
5430 (BuildStatus.addTestResult): add TestResults
5431 * buildbot/test/test_status.py (Results.testAddResults): test it
5433 2004-10-14 Brian Warner <warner@lothar.com>
5435 * buildbot/test/test_maildir.py (MaildirTest): use shutil.rmtree
5436 instead of os.system("rm -rf") for win32 portability
5438 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): use
5439 SignalMixin instead of starting/stopping the reactor, which is
5440 likely to cause problems with other tests
5442 * buildbot/slave/commands.py (SourceBase.doCopy): remove leftover
5443 self.copyComplete() call. Yoz Grahame makes the catch.
5445 * contrib/windows/buildbot.bat: helper script to deal with path
5446 issues. Thanks to Yoz Grahame.
5448 * buildbot/master.py (BuildMaster.startService): don't register a
5449 SIGHUP handler if the signal module has no SIGHUP attribute.
5450 Apparently win32 does this.
5452 * buildbot/scripts/runner.py (start): add --reactor=win32 on win32
5454 * buildbot/test/test_web.py (WebTest.test_webPathname): skip the
5455 test if the reactor can't offer UNIX sockets
5457 * buildbot/status/html.py (StatusResourceBuild.body): fix syntax
5458 error introduced in the last commit. We really need that
5461 2004-10-12 Brian Warner <warner@lothar.com>
5463 * buildbot/changes/mail.py (MaildirSource.describe): fix exception
5464 when describing a maildir source. Thanks to Stephen Davis.
5466 * buildbot/status/words.py (IrcStatusBot.command_WATCH): round off
5469 * buildbot/scripts/runner.py (createMaster): install Makefile too
5470 (start): add --no_save to 'start' command
5471 * buildbot/scripts/sample.mk: simple convenience Makefile with
5472 start/stop/reload targets
5474 * buildbot/__init__.py (version): bump to 0.6.0+ while between
5477 2004-09-30 Brian Warner <warner@lothar.com>
5479 * setup.py: Releasing buildbot-0.6.0
5481 2004-09-30 Brian Warner <warner@lothar.com>
5483 * MANIFEST.in: add debian/*, sample.cfg, more docs files. Remove
5484 test_trial.py from the source tarball until support is complete.
5486 * NEWS: update for 0.6.0 release
5487 * buildbot/__init__.py (version): same
5490 * buildbot/status/words.py (IrcStatusBot.command_SOURCE): add
5491 'source' command to tell users where to get the Buildbot source
5493 * docs/examples/*.cfg: update to modern standards
5495 * NEWS: update for release
5497 * buildbot/scripts/runner.py (createMaster): remove the
5498 -shutdown.tap stuff now that it isn't necessary
5500 (start): launch buildbot.tap, not buildbot-shutdown.tap
5503 * buildbot/status/mail.py (Domain): shorten class name
5504 (MailNotifier): if lookup= is a string, pass it to Domain()
5505 * buildbot/test/test_status.py (Mail.testBuild1): new class name
5506 (Mail.testBuild2): test the string-to-Domain shortcut
5507 (Mail.testMail): fix test
5510 * buildbot/scripts/sample.cfg: improve the build-the-buildbot
5513 * buildbot/status/builder.py (BuildStatus.__setstate__): re-set
5514 more attributes on load
5515 (BuilderStatus.stubBuildCacheSize): bump to 30, this was too low
5516 to accomodate the whole waterfall page at once, and the thrashing
5517 results in a lot of unnecessary loads
5518 (BuildStatus.saveYourself): use binary pickles, not fluffy text
5519 (BuilderStatus.saveYourself): same
5520 (BuilderStatus.eventGenerator): stop generating on the first missing
5521 build. We assume that saved builds are deleted oldest-first.
5522 (BuildStepStatus.__getstate__): .progress might not exist
5524 * buildbot/changes/changes.py (ChangeMaster): make it
5525 serializable, in $masterdir/changes.pck
5526 (ChangeMaster.stopService): save on shutdown
5527 * buildbot/master.py (BuildMaster.loadChanges): load at startup
5528 * buildbot/test/test_config.py: load Changes before config file
5531 * buildbot/slave/commands.py (ShellCommand.doTimeout): put the
5532 "Oh my god, you killed the command" header on a separate line
5534 * buildbot/status/builder.py (BuilderStatus.getStubBuildByNumber):
5535 skip over corrupted build pickles
5536 (BuilderStatus.getFullBuildByNumber): same
5537 (BuilderStatus.eventGenerator): skip over unavailable builds
5538 (BuildStatus.saveYourself): save builds to a .tmp file first, then
5539 do an atomic rename. This prevents a corrupted pickle when some
5540 internal serialization error occurs.
5541 (BuilderStatus.saveYourself): same
5543 * buildbot/slave/commands.py (SlaveShellCommand): oops, restore
5544 the timeout for shell commands, it got lost somehow
5546 * buildbot/status/builder.py (BuilderStatus.eventGenerator): if we
5547 run out of build steps, return the rest of the builder events
5549 * buildbot/interfaces.py (IBuilderControl.ping): add method
5551 * buildbot/process/builder.py (BuilderControl.ping): move
5552 slave-ping to BuilderControl, and fix the failure case in the
5553 process (Event.finish() is the verb, Event.finished is the noun).
5555 * buildbot/status/html.py (StatusResourceBuilder.ping): ping
5556 through the BuilderControl instead of the BuilderStatus
5557 (EventBox): add adapter for builder.Event, allowing builder events to
5558 be displayed in the waterfall display
5560 * buildbot/master.py (BotMaster.stopService): add a 'master
5561 shutdown' event to the builder's log
5562 (BuildMaster.startService): and a 'master started' on startup
5564 * buildbot/status/builder.py (BuilderStatus.eventGenerator): merge
5565 builder events into the BuildStep event stream
5566 (Status.builderAdded): add a 'builder created' event
5569 * buildbot/status/words.py (IrcStatusBot.command_WATCH): new
5570 command to announce the completion of a running build
5571 (IrcStatusBot.command_FORCE): announce when the build finishes
5573 * buildbot/status/builder.py (BuilderStatus.addFullBuildToCache):
5574 don't evict unfinished builds from the cache: they must stay in
5575 the full-cache until their logfiles have stopped changing. Make
5576 sure the eviction loop terminates if an unfinished build was hit.
5577 (HTMLLogFile.getTextWithHeaders): return HTML as if it were text.
5578 This lets exceptions be dumped in an email status message. Really
5579 we need LogFiles which contain both text and HTML, instead of two
5581 (BuildStatus.__getstate__): handle self.finished=False
5582 (Status.builderAdded): if the pickle is corrupted, abandon the
5583 history and create a new BuilderStatus object.
5585 * buildbot/process/base.py (Build.stopBuild): tolerate lack of a
5586 self.progress attribute, helped one test which doesn't fully set
5587 up the Build object.
5589 * buildbot/interfaces.py (IStatusLogStub): split out some of the
5590 IStatusLog methods into an Interface that is implemented by "stub"
5591 logs, for which all the actual text chunks are on disk (in the
5592 pickled Build instance). To show the log contents, you must first
5593 adapt the stub log to a full IStatusLog object.
5595 * buildbot/status/builder.py (LogFileStub): create separate stub
5596 log objects, which can be upgraded to a real one if necessary.
5597 (LogFile): make them persistable, and let them stubify themselves
5599 (BuildStepStatus): same
5601 (BuildStatus.saveYourself): save the whole build out to disk
5602 (BuilderStatus): make it persistable
5603 (BuilderStatus.saveYourself): save the builder to disk
5604 (BuilderStatus.addFullBuildToCache): implement two caches which
5605 hold Build objects: a small one which holds full Builds, and a
5606 larger one which holds "stubbed" Builds (ones with their LogFiles
5607 turned into LogFileStubs). This reduces memory usage by the
5608 buildmaster by not keeping more than a few (default is 2) whole
5609 build logs in RAM all the time.
5610 (BuilderStatus.getBuild): rewrite to pull from disk (through the
5612 (BuilderStatus.eventGenerator): rewrite since .builds went away
5613 (BuilderStatus.buildStarted): remove the .builds array. Add the
5614 build to the "full" cache when it starts.
5615 (BuilderStatus._buildFinished): save the build to disk when it
5617 (Status): give it a basedir (same as the BuildMaster's basedir)
5618 where the builder pickles can be saved
5619 (Status.builderAdded): create the BuilderStatus ourselves, by
5620 loading a pickle from disk (or creating a new instance if there
5621 was none on disk). Return the BuilderStatus so the master can glue
5622 it into the new Builder object.
5624 * buildbot/master.py (BotMaster.stopService): on shutdown, tell
5625 all BuilderStatuses to save themselves out to disk. This is in
5626 lieu of saving anything important in the main Application pickle
5627 (the -shutdown.tap file).
5628 (BuildMaster.__init__): give Status() a basedir for its files
5629 (BuildMaster.loadConfig_Builders): do status.builderAdded first,
5630 to get the BuilderStatus, then give it to the Builder (instead of
5631 doing it the other way around). It's ok if the status announces
5632 the new Builder before it's really ready, as the outside world can
5633 only see the BuilderStatus object anyway (and it is ready before
5634 builderAdded returns). Use the builder's "builddir" (which
5635 normally specifies where the slave will run the builder) as the
5636 master's basedir (for saving serialized builds).
5638 * buildbot/status/html.py (StatusResourceBuildStep.getChild):
5639 coerce the logfile to IStatusLog before trying to get the text
5640 chunks out of it. This will pull the full (non-stubified) Build in
5641 from disk if necessary.
5642 (TextLog): fix the adapter registration
5644 * buildbot/test/test_control.py (Force.setUp): create the basedir
5645 * buildbot/test/test_web.py: same
5646 * buildbot/test/test_vc.py (SetupMixin.setUp): same
5647 * buildbot/test/test_status.py (Mail.makeBuild): match new setup
5648 * buildbot/test/test_run.py (Run.testMaster): same
5649 (Status.setUp): same
5651 2004-09-29 Fred L. Drake, Jr. <fdrake@acm.org>
5653 * buildbot/status/html.py (Waterfall.__init__): store actual
5654 allowForce flag passed in rather than using True for everyone;
5655 make sure setting it to False doesn't cause a NameError
5657 (StatusResourceBuilder.__init__) add the builder name to the page
5659 (StatusResourceBuilder.body) move HTML generation for a name/value
5660 row into a helper method (StatusResourceBuilder.make_row); only
5661 generate the "Force Build" form if allowForce was True and the
5662 slave is connected. Use class attributes in the generated HTML to
5663 spread a little CSS-joy.
5665 2004-09-28 Brian Warner <warner@lothar.com>
5667 * buildbot/process/step_twisted.py (Trial.createSummary): fix
5668 warning-scanner to not ignore things like
5669 'ComponentsDeprecationWarning' and 'exceptions.RuntimeWarning'
5671 * buildbot/status/html.py (StatusResource.control): add some
5672 class-level values for .control in an attempt to make upgrading
5675 * buildbot/util.py (ComparableMixin): survive missing attributes,
5676 such as when a class is modified and we're comparing old instances
5679 * buildbot/status/words.py (IrcStatusBot.privmsg): clean up
5680 failure handling, remove a redundant try/except block. Don't
5681 return the full traceback to the IRC channel.
5682 (IrcStatusBot.command_FORCE): catch new exceptions, return useful
5683 error messages. Get ETA properly.
5685 * buildbot/status/html.py (StatusResourceBuild.body): html.escape
5686 the reason, since (at least) IRC message will have <> in them.
5687 (StatusResourceBuilder.__init__): take an IBuilderControl
5688 (StatusResourceBuilder.force): use the IBuilderControl we get in
5689 the constructor instead of trying to make our own. Catch the
5690 new exceptions and ignore them for now (until we make an
5691 intermediate web page where we could show the error message)
5692 (StatusResource): create with an IControl, use it to give an
5693 IBuilderControl to all children
5694 (Waterfall): take an allowForce= option, pass an IControl object
5695 to StatusResource if it is True
5697 * buildbot/test/test_web.py (ConfiguredMaster): handle IControl
5699 * buildbot/master.py (BotPerspective.perspective_forceBuild):
5700 catch new exceptions and return string forms
5702 * buildbot/interfaces.py: add NoSlaveError, BuilderInUseError
5703 * buildbot/process/builder.py (Builder.forceBuild): raise them
5704 * buildbot/test/test_control.py (Force.testNoSlave): new test
5705 (Force.testBuilderInUse): same
5708 * buildbot/status/words.py (IrcStatusBot): enable build-forcing
5710 * buildbot/test/test_run.py: use IControl
5711 * buildbot/test/test_vc.py: same
5713 * buildbot/status/html.py (StatusResourceBuilder.force): rewrite
5714 to use IControl. Still offline.
5715 * buildbot/status/words.py (IrcStatusBot.command_FORCE): same
5717 * buildbot/process/builder.py (Builder.doPeriodicBuild): set
5718 who=None so periodic builds don't send out status mail
5719 (Builder.forceBuild): include reason in the log message
5720 (BuilderControl.forceBuild): rename 'name' to 'who'
5722 * buildbot/master.py (BotPerspective.perspective_forceBuild): add
5723 'who' parameter, but make it None by default so builds forced by
5724 slave admins don't cause status mail to be sent to anybody
5725 (BotMaster.forceBuild): same. this method is deprecated.
5726 (DebugPerspective.perspective_forceBuild): same, use IControl.
5727 (DebugPerspective.perspective_fakeChange): use IControl..
5728 (Dispatcher.requestAvatar): .. so don't set .changemaster
5730 * buildbot/interfaces.py (IBuilderControl.forceBuild): rename 'who'
5731 parameter to avoid confusion with the name of the builder
5734 * buildbot/status/mail.py: refine comment about needing 2.3
5736 * buildbot/status/html.py: move all imports to the top
5738 * buildbot/test/test_control.py: test new interfaces
5739 * buildbot/test/test_run.py (Status): handle new interfaces
5740 * buildbot/test/test_vc.py (SetupMixin.doBuild): same
5742 * buildbot/process/base.py (BuildControl): implement IBuildControl
5743 and its lonely getStatus() method
5745 * buildbot/process/builder.py (BuilderControl): implement
5746 IBuilderControl, obtained by adapting the Builder instance
5747 (Builder.startBuild): return a BuilderControl instead of a
5748 Deferred. The caller can use bc.getStatus().waitUntilFinished() to
5749 accomplish the same thing.
5751 * buildbot/master.py: move all import statements to the top
5752 (Control): implement IControl, obtained by adapting the
5753 BuildMaster instance.
5755 * buildbot/interfaces.py: add IControl, IBuilderControl, and
5756 IBuildControl. These are used to force builds. Eventually they
5757 will provide ways to reconfigure the Builders, pause or abandon a
5758 Build, and perhaps control the BuildMaster itself.
5760 2004-09-26 Brian Warner <warner@lothar.com>
5762 * buildbot/util.py (ComparableMixin): survive twisted>1.3.0 which
5763 ends up comparing us against something without a .__class__
5765 2004-09-24 Brian Warner <warner@lothar.com>
5767 * buildbot/scripts/runner.py: rearrange option parsing a lot, to get
5770 * Makefile: add 'deb-snapshot' target, to create a timestamped
5773 * debian/rules (binary-indep): skip CVS/ files in dh_installexamples
5775 2004-09-23 Brian Warner <warner@lothar.com>
5777 * buildbot/__init__.py (version): move version string here
5778 * setup.py: get version string from buildbot.version
5779 * buildbot/status/html.py (WaterfallStatusResource.body): add
5780 buildbot version to the page footer
5781 * buildbot/status/words.py (IrcStatusBot.command_VERSION): provide
5784 * buildbot/master.py (BotMaster.getPerspective): detect duplicate
5785 slaves, let the second know where the first one is coming from
5786 (BuildMaster.__init__): turn on .unsafeTracebacks so the slave can
5787 see our exceptions. It would be nice if there were a way to just
5788 send them the exception type and value, not the full traceback.
5791 * buildbot/status/mail.py (MailNotifier): add a new argument
5792 sendToInterestedUsers=, which can be set to False to disable the
5793 usual send-to-blamelist behavior.
5794 (top): handle python-2.2 which has no email.MIMEMultipart
5795 (MailNotifier.buildMessage): don't send logs without MIMEMultipart
5796 (MailNotifier.disownServiceParent): unsubscribe on removal
5798 * buildbot/test/test_status.py (Mail.testBuild2): test it
5801 * buildbot/status/progress.py (Expectations.wavg): tolerate
5802 current=None, which happens when steps start failing badly
5803 * buildbot/test/test_status.py (Progress.testWavg): test for it
5805 * buildbot/process/step.py (SVN.startVC): when the (old) slave
5806 doesn't understand args['revision'], emit a warning instead of
5807 bailing completely. Updating to -rHEAD is probably close enough.
5809 * buildbot/process/step_twisted.py (Trial.start): fix sanity-check
5811 * buildbot/test/test_status.py: at least import bb.status.client
5812 even if we don't have any test coverage for it yet
5814 * contrib/svn_buildbot.py: don't require python2.3
5815 (main): wait, do require it (for sets.py), but explain how to
5816 make it work under python2.2
5818 2004-09-23 Brian Warner <warner@lothar.com>
5820 * contrib/svn_buildbot.py: include the revision number in the Change
5822 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): use when=,
5823 using util.now() because FreshCVS is a realtime service
5825 * buildbot/status/event.py: delete dead code
5826 * buildbot/process/step.py: don't import dead Event class
5827 * buildbot/process/step_twisted.py: same
5828 * buildbot/status/builder.py: same
5829 * buildbot/status/client.py: same
5831 * buildbot/test/test_process.py: kill buggy out-of-date disabled test
5833 * buildbot/changes/changes.py (Change): set .when from an __init__
5834 argument (which defaults to now()), rather than having
5835 ChangeMaster.addChange set it later.
5836 (ChangeMaster.addChange): same
5838 * buildbot/changes/mail.py (parseFreshCVSMail): pass in when=
5839 (parseSyncmail): same. Just use util.now() for now.
5840 (parseBonsaiMail): parse the timestamp field for when=
5842 * buildbot/test/test_vc.py (SourceStamp.addChange): page in when=
5843 instead of setting .when after the fact
5847 * buildbot/slave/trial.py: new SlaveCommand to machine-parse test
5848 results when the target project uses retrial. Still under
5850 * buildbot/test/test_trial.py: same
5852 2004-09-21 Brian Warner <warner@lothar.com>
5854 * buildbot/status/mail.py (MailNotifier.__init__): include
5855 success/warnings/failure in the Subject line
5856 (MailNotifier.buildMessage): add the buildbot's URL to the body,
5857 use step.logname for the addLogs=True attachment filenames
5858 * buildbot/test/test_status.py (Mail): test Subject lines
5859 (Mail.testLogs): test attachment filenames
5861 * buildbot/master.py (DebugPerspective.perspective_fakeChange):
5862 accept a 'who' argument from the debug tool
5863 * contrib/debugclient.py (DebugWidget.do_commit): send 'who'
5864 * contrib/debug.glade: add text box to set 'who'
5866 * buildbot/interfaces.py (IBuildStatus.getBuilder): replace
5867 .getBuilderName with .getBuilder().getName(), more flexible
5868 (IStatusLog.getName): logs have short names, but you can prefix
5869 them with log.getStep().getName() to make them more useful
5870 * buildbot/status/builder.py: same
5871 * buildbot/status/client.py: same
5872 * buildbot/status/html.py: same
5873 * buildbot/test/test_run.py (Status.testSlave): same
5874 * buildbot/process/step.py: tweak logfile names
5876 * buildbot/status/mail.py (MailNotifier): add lookup, change
5877 argument to extraRecipients. The notifier is now aimed at sending
5878 mail to the people involved in a particular build, with additional
5879 constant recipients as a secondary function.
5881 * buildbot/test/test_status.py: add coverage for IEmailLookup,
5882 including slow-lookup and failing-lookup. Make sure the blamelist
5883 members are included.
5885 * buildbot/interfaces.py: new interfaces IEmailSender+IEmailLookup
5886 (IBuildStatus.getResponsibleUsers): rename from getBlamelist
5887 (IBuildStatus.getInterestedUsers): new method
5888 * buildbot/status/builder.py (BuildStatus.getResponsibleUsers): same
5889 * buildbot/status/client.py (remote_getResponsibleUsers): same
5890 * buildbot/status/html.py (StatusResourceBuild.body): same
5891 * buildbot/test/test_run.py (Status.testSlave): same
5893 2004-09-20 Brian Warner <warner@lothar.com>
5895 * docs/users.xhtml: update concepts
5897 * Makefile: add a convenience makefile, for things like 'make
5898 test'. It is not included in the source tarball.
5900 2004-09-16 Brian Warner <warner@lothar.com>
5902 * NEWS: mention /usr/bin/buildbot, debian/*
5904 * debian/*: add preliminary debian packaging. Many thanks to
5905 Kirill Lapshin (and Kevin Turner) for the hard work. I've mangled
5906 it considerably since it left their hands, I am responsible for
5907 all breakage that's resulted.
5909 * bin/buildbot: create a top-level 'buildbot' command, to be
5910 installed in /usr/bin/buildbot . For now it's just a simple
5911 frontend to mktap/twistd/kill, but eventually it will be the entry
5912 point to the 'try' command and also a status client. It is also
5913 intended to support the upcoming debian-packaging init.d scripts.
5914 * buildbot/scripts/runner.py: the real work is done here
5915 * buildbot/scripts/__init__.py: need this too
5916 * buildbot/scripts/sample.cfg: this is installed in new
5917 buildmaster directories
5918 * setup.py: install new stuff
5920 2004-09-15 Brian Warner <warner@lothar.com>
5922 * buildbot/test/test_vc.py: skip SVN tests if svn can't handle the
5923 'file:' schema (the version shipped with OS-X was built without the
5925 (SetupMixin.tearDown): stop the goofy twisted.web timer which
5926 updates the log-timestamp, to make sure it isn't still running after
5929 * docs/config.xhtml: Add projectName, projectURL, buildbotURL
5930 values to the config file.
5931 * docs/examples/hello.cfg: add examples
5932 * buildbot/interfaces.py (IStatus.getBuildbotURL): define accessors
5933 * buildbot/status/builder.py (Status.getProjectURL): implement them
5934 * buildbot/master.py (BuildMaster.loadConfig): set them from config
5935 * buildbot/test/test_config.py (ConfigTest.testSimple): test them
5936 * buildbot/status/html.py (WaterfallStatusResource): display them
5939 * buildbot/test/test_vc.py (FakeBuilder.name): add attribute so
5940 certain error cases don't suffer a secondary exception.
5941 (top): Skip tests if the corresponding VC tool is not installed.
5943 * buildbot/process/factory.py (Trial): introduce separate
5944 'buildpython' and 'trialpython' lists, since trialpython=[] is
5945 what you want to invoke /usr/bin/python, whereas ./setup.py is
5946 less likely to be executable. Add env= parameter to pass options
5947 to test cases (which is how I usually write tests, I don't know if
5948 anyone else does it this way).
5950 * buildbot/process/step_twisted.py (Trial): handle python=None.
5951 Require 'testpath' be a string, not a list. Fix tests= typo.
5952 (Trial.start): sanity-check any PYTHONPATH value for stringness.
5954 * buildbot/process/step.py (RemoteCommand._remoteFailed): goofy
5955 way to deal with the possibility of removing the disconnect notify
5957 (CVS): add a 'login' parameter to give a password to 'cvs login',
5958 commonly used with pserver methods (where pw="" or pw="guest")
5960 * buildbot/slave/commands.py (SourceBase): move common args
5961 extraction and setup() to __init__, so everything is ready by the
5962 time setup() is called
5963 (CVS.start): call 'cvs login' if a password was supplied
5964 (ShellCommand): special-case PYTHONPATH: prepend the master's
5965 value to any existing slave-local value.
5967 * buildbot/process/builder.py (Builder.updateBigStatus): if we
5968 don't have a remote, mark the builder as Offline. This whole
5969 function should probably go away and be replaced by individual
5971 (Builder.buildFinished): return the results to the build-finished
5972 deferred callback, helps with testing
5974 2004-09-14 Brian Warner <warner@lothar.com>
5976 * buildbot/test/test_vc.py: put all the repositories needed to run
5977 the complete tests into a single small (1.3MB) tarball, so I can
5978 make that tarball available on the buildbot web site. Test HTTP
5979 access (for Arch and Darcs) by spawning a temporary web server
5980 while the test runs.
5982 * docs/users.xhtml: new document, describe Buildbot's limited
5983 understanding of different human users
5985 * buildbot/test/test_vc.py: rearrange test cases a bit
5987 * buildbot/process/step_twisted.py (Trial): handle testpath=
5988 * buildbot/process/factory.py (Trial): update to use step.Trial
5990 * buildbot/slave/commands.py (ShellCommandPP): fix fatal typo
5992 * buildbot/status/builder.py (BuildStatus.getText): add text2 to
5993 the overall build text (which gives you 'failed 2 tests' rather
5995 (BuildStepStatus.text2): default to [], not None
5997 * buildbot/process/step_twisted.py (Trial.commandComplete): text2
6000 2004-09-12 Brian Warner <warner@lothar.com>
6002 * buildbot/master.py (BotPerspective._commandsUnavailable): don't
6003 log the whole exception if it's just an AttributeError (old slave)
6005 * buildbot/process/step.py (ShellCommand.__init__): stash .workdir
6006 so (e.g.) sub-commands can be run in the right directory.
6007 (ShellCommand.start): accept an optional errorMessage= argument
6008 to make life easier for SVN.start
6009 (SVN.startVC): put the "can't do mode=export" warning in the LogFile
6011 (ShellCommand.start): move ['dir'] compatibility hack..
6012 (RemoteShellCommand.start): .. to here so everyone can use it
6014 * buildbot/process/step_twisted.py (Trial): use .workdir
6016 * buildbot/process/step_twisted.py (BuildDebs.getText): fix the
6017 text displayed when debuild fails completely
6018 (Trial): snarf _trial_temp/test.log from the slave and display it
6020 2004-09-11 Brian Warner <warner@lothar.com>
6022 * buildbot/process/step_twisted.py (ProcessDocs.getText): typo
6024 * buildbot/process/process_twisted.py (TwistedTrial.tests): oops,
6025 set to 'twisted', so --recurse can find twisted/web/test/*, etc
6027 * buildbot/process/step.py (ShellCommand): call .createSummary
6028 before .evaluateCommand instead of the other way around. This
6029 makes it slightly easier to count warnings and then use that to
6030 set results=WARNINGS
6031 * buildbot/process/step_twisted.py: cosmetic, swap the methods
6033 * buildbot/process/base.py (Build.buildFinished): update status
6034 before doing progress. It's embarrassing for the build to be stuck
6035 in the "building" state when an exceptions occurs elsewhere..
6037 * buildbot/status/progress.py (Expectations.expectedBuildTime):
6038 python2.2 doesn't have 'sum'
6040 * buildbot/status/builder.py (Status.getBuilderNames): return a copy,
6041 to prevent clients from accidentally sorting it
6043 * buildbot/master.py (Manhole): add username/password
6044 (BuildMaster.loadConfig): use c['manhole']=Manhole() rather than
6045 c['manholePort'], deprecate old usage
6046 * docs/config.xhtml: document c['manhole']
6047 * docs/examples/hello.cfg: show example of using a Manhole
6050 * buildbot/test/test_steps.py (FakeBuilder.getSlaveCommandVersion):
6051 pretend the slave is up to date
6053 * buildbot/status/builder.py (BuildStepStatus.stepFinished): 'log',
6054 the module, overlaps with 'log', the local variable
6056 * buildbot/status/html.py: oops, 2.2 needs __future__ for generators
6058 * buildbot/process/builder.py (Builder.getSlaveCommandVersion):
6059 new method to let Steps find out the version of their
6060 corresponding SlaveCommand.
6061 * buildbot/process/step.py (BuildStep.slaveVersion): utility method
6062 (ShellCommand.start): add 'dir' argument for <=0.5.0 slaves
6063 (CVS.startVC): backwards compatibility for <=0.5.0 slaves
6065 (Darcs.startVC): detect old slaves (missing the 'darcs' command)
6066 (Arch.startVC): same
6067 (P4Sync.startVC): same
6069 * buildbot/process/step.py (LoggedRemoteCommand.start): return the
6070 Deferred so we can catch errors in remote_startCommand
6071 (RemoteShellCommand.start): same
6073 * docs/examples/twisted_master.cfg: update sample config file
6075 * buildbot/slave/commands.py (ShellCommandPP): write to stdin
6076 after connectionMade() is called, not before. Close stdin at that
6079 * buildbot/process/process_twisted.py: update to use Trial, clean
6080 up argument passing (move to argv arrays instead of string
6083 * buildbot/process/step_twisted.py (Trial): new step to replace
6084 RunUnitTests, usable by any trial-using project (not just
6085 Twisted). Arguments have changed, see the docstring for details.
6087 * buildbot/process/base.py (Build.startBuild): this now returns a
6088 Deferred. Exceptions that occur during setupBuild are now
6089 caught better and lead to fewer build_status weirdnesses, like
6090 finishing a build that was never started.
6091 (Build.buildFinished): fire the Deferred instead of calling
6092 builder.buildFinished directly. The callback argument is this
6093 Build, everything else can be extracted from it, including the
6094 new build.results attribute.
6095 * buildbot/process/builder.py (Builder.startBuild): same
6096 (Builder.buildFinished): same, extract results from build
6098 * buildbot/process/step.py (ShellCommands): remove dead code
6100 2004-09-08 Brian Warner <warner@lothar.com>
6102 * buildbot/test/test_vc.py (VC.doPatch): verify that a new build
6103 doesn't try to use the leftover patched workdir
6104 (SourceStamp): test source-stamp computation for CVS and SVN
6106 * buildbot/slave/commands.py (SourceBase.doPatch): mark the
6107 patched workdir ('touch .buildbot-patched') so we don't try to
6109 (SourceBase.start): add ['revision'] for all Source steps
6110 (CVS): change args: use ['branch'] for -r, remove ['files']
6111 (CVS.buildVC): fix revision/branch stuff
6112 (SVN): add revision stuff
6114 * buildbot/process/step.py (BuildStep.__init__): reject unknown
6115 kwargs (except 'workdir') to avoid silent spelling errors
6116 (ShellCommand.__init__): same
6117 (Source): new base class for CVS/SVN/etc. Factor out everything
6118 common, add revision computation (perform the checkout with a -D
6119 DATE or -r REVISION that gets exactly the sources described by the
6120 last Change), overridable with step.alwaysUseLatest. Add patch
6121 handling (build.getSourceStamp can trigger the use of a base
6122 revision and a patch).
6123 (CVS, SVN, Darcs, Arch, P4Sync): refactor, remove leftover arguments
6124 * docs/steps.xhtml: update docs
6125 * docs/source.xhtml: mention .checkoutDelay
6126 * docs/examples/hello.cfg: show use of checkoutDelay, alwaysUseLatest
6128 * buildbot/process/base.py (Build.setSourceStamp): add a
6129 .sourceStamp attribute to each Build. If set, this indicates that
6130 the build should be done with something other than the most
6131 recent source tree. This will be used to implement "try" builds.
6132 (Build.allChanges): new support method
6133 (Build.lastChangeTime): remove, functionality moved to Source steps
6134 (Build.setupBuild): copy the Step args before adding ['workdir'],
6135 to avoid modifying the BuildFactory (and thus triggering spurious
6139 * buildbot/status/html.py: rename s/commits/changes/
6140 (StatusResourceChanges): same
6141 (CommitBox.getBox): same, update URL
6142 (WaterfallStatusResource): same
6143 (StatusResource.getChild): same
6145 * contrib/debugclient.py (DebugWidget.do_commit): send .revision
6146 * contrib/debug.glade: add optional 'revision' to the fakeChange
6148 * buildbot/changes/changes.py (html_tmpl): display .revision
6149 (ChangeMaster.addChange): note .revision in log
6150 * buildbot/changes/pb.py (ChangePerspective.perspective_addChange):
6151 accept a ['revision'] attribute
6153 * buildbot/process/factory.py (BuildFactory): use ComparableMixin
6155 * buildbot/master.py (BotMaster.getPerspective): update the
6156 .connected flag in SlaveStatus when it connects
6157 (BotMaster.detach): and when it disconnects
6158 (DebugPerspective.perspective_fakeChange): take a 'revision' attr
6159 (BuildMaster.loadConfig_Builders): walk old list correctly
6161 * buildbot/test/test_config.py: fix prefix= usage
6163 2004-09-06 Brian Warner <warner@lothar.com>
6167 * buildbot/changes/p4poller.py (P4Source): New ChangeSource to
6168 poll a P4 depot looking for recent changes. Thanks to Dave
6169 Peticolas for the contribution. Probably needs some testing after
6172 * buildbot/process/step.py (P4Sync): simple P4 source-updater,
6173 requires manual client setup for each buildslave. Rather
6174 experimental. Thanks again to Dave Peticolas.
6175 * buildbot/slave/commands.py (P4Sync): slave-side source-updater
6177 * buildbot/changes/changes.py (Change): add a .revision attribute,
6178 which will eventually be used to generate source-stamp values.
6180 * buildbot/process/step.py (RemoteCommand.start): use
6181 notifyOnDisconnect to notice when we lose the slave, then treat it
6182 like an exception. This allows LogFiles to be closed and the build
6183 to be wrapped up normally. Be sure to remove the disconnect
6184 notification when the step completes so we don't accumulate a
6185 bazillion such notifications which will fire weeks later (when the
6186 slave finally disconnects normally). Fixes SF#915807, thanks to
6187 spiv (Andrew Bennetts) for the report.
6188 (LoggedRemoteCommand): move __init__ code to RemoteCommand, since it
6189 really isn't Logged- specific
6190 (LoggedRemoteCommand.remoteFailed): Add an extra newline to the
6191 header, since it's almost always going to be appended to an
6193 * buildbot/test/test_steps.py (BuildStep.testShellCommand1):
6194 update test to handle use of notifyOnDisconnect
6196 * buildbot/status/builder.py (BuilderStatus.currentlyOffline):
6197 don't clear .ETA and .currentBuild when going offline, let the
6198 current build clean up after itself
6200 * buildbot/process/builder.py (Builder.detached): wait a moment
6201 before doing things like stopping the current build, because the
6202 current step will probably notice the disconnect and cleanup the
6204 * buildbot/test/test_run.py (Status.tearDown): update test to
6205 handle asynchronous build-detachment
6207 * buildbot/process/base.py (Build.stopBuild): minor shuffles
6209 * buildbot/status/html.py (WaterfallStatusResource.buildGrid):
6210 hush a debug message
6212 2004-09-05 Brian Warner <warner@lothar.com>
6214 * buildbot/changes/maildir.py (Maildir.start): catch an IOError
6215 when the dnotify fcntl() fails and fall back to polling. Linux 2.2
6216 kernels do this: the fcntl module has the F_NOTIFY constant, but
6217 the kernel itself doesn't support the operation. Thanks to Olly
6218 Betts for spotting the problem.
6220 * buildbot/process/step.py (Darcs): new source-checkout command
6221 (Arch): new source-checkout command
6222 (todo_P4): fix constructor syntax, still just a placeholder
6223 * buildbot/test/test_vc.py (VC.testDarcs): test it
6224 (VC.testDarcsHTTP): same, via localhost HTTP
6226 (VC.testArchHTTP): same
6227 * NEWS: mention new features
6229 * buildbot/slave/commands.py (ShellCommand): add .keepStdout,
6230 which tells the step to stash stdout text locally (in .stdout).
6231 Slave-side Commands can use this to make decisions based upon the
6232 output of the the ShellCommand (not just the exit code).
6233 (Darcs): New source-checkout command
6234 (Arch): New source-checkout command, uses .keepStdout in one place
6235 where it needs to discover the archive's default name.
6237 * docs/steps.xhtml: Document options taken by Darcs and Arch.
6238 * docs/source.xhtml: add brief descriptions of Darcs and Arch
6239 * docs/examples/hello.cfg: add examples of Darcs and Arch checkout
6241 * buildbot/process/step.py (ShellCommand.describe): add an
6242 alternate .descriptionDone attribute which provides descriptive
6243 text when the step is complete. .description can be ["compiling"],
6244 for use while the step is running, then .descriptionDone can be
6245 ["compile"], used alone when the step succeeds or with "failed" when
6246 it does not. Updated other steps to use the new text.
6247 * buildbot/process/step_twisted.py: same
6248 * buildbot/test/test_run.py: update tests to match
6250 2004-08-30 Brian Warner <warner@lothar.com>
6252 * buildbot/process/step.py (ShellCommand.createSummary): fix docs
6253 (CVS.__init__): send 'patch' argument to slave
6254 (CVS.start): don't create the LoggedRemoteCommand until start(),
6255 so we can catch a .patch added after __init__
6256 (SVN.__init__): add 'patch' to SVN too
6259 * buildbot/slave/commands.py (ShellCommand): add a 'stdin'
6260 argument, to let commands push data into the process' stdin pipe.
6261 Move usePTY to a per-instance attribute, and clear it if 'stdin'
6262 is in use, since closing a PTY doesn't really affect the process
6263 in the right way (in particular, I couldn't run /usr/bin/patch
6265 (SourceBase.doPatch): handle 'patch' argument
6267 * buildbot/test/test_vc.py (VC.doPatch): test 'patch' argument for
6270 * buildbot/slave/commands.py (cvs_ver): fix version-parsing goo
6271 * buildbot/slave/bot.py (Bot.remote_getCommands): send command
6273 * buildbot/master.py (BotPerspective.got_commands): get command
6274 versions from slave, give to each builder
6275 * buildbot/process/builder.py (Builder.attached): stash slave
6276 command versions in .remoteCommands
6278 * docs/steps.xhtml: bring docs in-line with reality
6280 * buildbot/process/step.py (CVS.__init__): more brutal
6281 compatibility code removal
6282 (SVN.__init__): same
6284 * buildbot/slave/commands.py (SlaveShellCommand): update docs
6285 (SlaveShellCommand.start): require ['workdir'] argument, remove
6286 the ['dir'] fallback (compatibility will come later)
6287 (SourceBase): update docs
6288 (SourceBase.start): remove ['directory'] fallback
6291 * buildbot/test/test_config.py (ConfigTest.testBuilders): update test
6292 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6293 * buildbot/test/test_slavecommand.py (SlaveCommandTestCase): same
6295 * buildbot/process/step.py (RemoteShellCommand.__init__): add
6296 want_stdout/want_stderr. remove old 'dir' keyword (to simplify the
6297 code.. I will figure out 0.5.0-compatibility hooks later)
6299 2004-08-30 Brian Warner <warner@lothar.com>
6301 * buildbot/process/process_twisted.py: rewrite in terms of new
6302 BuildFactory base class. It got significantly shorter. Yay
6305 * buildbot/process/step_twisted.py (HLint.start): fix to make it
6306 work with the new "self.build isn't nailed down until we call
6307 step.start()" scheme: specifically, __init__ is called before the
6308 build has decided on which Changes are going in, so we don't scan
6309 build.allFiles() for .xhtml files until start()
6310 (HLint.commandComplete): use getText(), not getStdout()
6311 (RunUnitTests.start): same: don't use .build until start()
6312 (RunUnitTests.describe): oops, don't report (None) when using
6314 (RunUnitTests.commandComplete): use getText()
6315 (RunUnitTests.createSummary): same
6316 (BuildDebs.commandComplete): same
6318 * buildbot/process/step.py (RemoteShellCommand.__init__): don't
6319 set args['command'] until start(), since our BuildStep is allowed
6320 to change their mind up until that point
6321 (TreeSize.commandComplete): use getText(), not getStdout()
6323 * docs/examples/twisted_master.cfg: update to current standards
6325 * docs/factories.xhtml: update
6326 * buildbot/process/factory.py: implement all the common factories
6327 described in the docs. The Trial factory doesn't work yet, and
6328 I've probably broken all the process_twisted.py factories in the
6329 process. There are compatibility classes left in for things like
6330 the old BasicBuildFactory, but subclasses of them are unlikely to
6332 * docs/examples/glib_master.cfg: use new BuildFactories
6333 * docs/examples/hello.cfg: same
6335 * buildbot/test/test_config.py (ConfigTest.testBuilders): remove
6336 explicit 'workdir' args
6338 * buildbot/process/base.py (BuildFactory): move factories to ..
6339 * buildbot/process/factory.py (BuildFactory): .. here
6340 * buildbot/process/process_twisted.py: handle move
6341 * buildbot/test/test_config.py: same
6342 * buildbot/test/test_run.py: same
6343 * buildbot/test/test_steps.py: same
6344 * buildbot/test/test_vc.py: same
6345 * docs/factories.xhtml: same
6347 * NEWS: mention config changes that require updating master.cfg
6349 * buildbot/process/base.py (Build.setupBuild): add a 'workdir'
6350 argument to all steps that weren't given one already, pointing at
6351 the "build/" directory.
6353 * docs/examples/hello.cfg: remove explicit 'workdir' args
6355 * docs/factories.xhtml: document standard BuildFactory clases,
6356 including a bunch which are have not yet been written
6358 2004-08-29 Brian Warner <warner@lothar.com>
6360 * buildbot/interfaces.py (IBuildStepStatus.getResults): move
6361 result constants (SUCCESS, WARNINGS, FAILURE, SKIPPED) to
6362 buildbot.status.builder so they aren't quite so internal
6363 * buildbot/process/base.py, buildbot/process/builder.py: same
6364 * buildbot/process/maxq.py, buildbot/process/step.py: same
6365 * buildbot/process/step_twisted.py, buildbot/status/builder.py: same
6366 * buildbot/status/mail.py, buildbot/test/test_run.py: same
6367 * buildbot/test/test_status.py, buildbot/test/test_vc.py: same
6369 * buildbot/status/html.py (StatusResourceBuildStep): oops, update
6370 to handle new getLogs()-returns-list behavior
6371 (StatusResourceBuildStep.getChild): same
6372 (StepBox.getBox): same
6373 (WaterfallStatusResource.phase0): same
6375 * docs/source.xhtml: document how Buildbot uses version-control
6376 systems (output side: how we get source trees)
6377 * docs/changes.xhtml: rename from sources.xhtml, documents VC
6378 systems (input side: how we learn about Changes)
6380 * buildbot/master.py (Manhole): use ComparableMixin
6381 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred): same
6382 * buildbot/changes/mail.py (MaildirSource): same
6383 * buildbot/status/client.py (PBListener): same
6384 * buildbot/status/html.py (Waterfall): same
6385 * buildbot/status/words.py (IRC): same
6387 * NEWS: start describing new features
6389 * buildbot/status/mail.py (MailNotifier): finish implementation.
6390 The message body is still a bit sparse.
6391 * buildbot/test/test_status.py (Mail): test it
6393 * buildbot/util.py (ComparableMixin): class to provide the __cmp__
6394 and __hash__ methods I wind up adding everywhere. Specifically
6395 intended to support the buildbot config-file update scheme where
6396 we compare, say, the old list of IStatusTargets against the new
6397 one and don't touch something which shows up on both lists.
6398 * buildbot/test/test_util.py (Compare): test case for it
6400 * buildbot/interfaces.py (IBuildStatus): change .getLogs() to
6401 return a list instead of a dict
6402 (IBuildStepStatus.getLogs): same. The idea is that steps create
6403 logs with vaguely unique names (although their uniqueness is not
6404 guaranteed). Thus a compilation step should create its sole
6405 logfile with the name 'compile', and contribute it to the
6406 BuildStatus. If a step has two logfiles, try to create them with
6407 different names (like 'test.log' and 'test.summary'), and only
6408 contribute the important ones to the overall BuildStatus.
6409 * buildbot/status/builder.py (Event.getLogs): same
6410 (BuildStepStatus): fix default .text and .results
6411 (BuildStepStatus.addLog): switch to list-like .getLogs()
6412 (BuildStepStatus.stepFinished): same
6413 (BuildStatus.text): fix default .text
6414 (BuildStatus.getLogs): temporary hack to return all logs (from all
6415 child BuildStepStatus objects). Needs to be fixed to only report
6416 the significant ones (as contributed by the steps themselves)
6417 * buildbot/test/test_run.py: handle list-like .getLogs()
6418 * buildbot/test/test_steps.py (BuildStep.testShellCommand1): same
6420 2004-08-28 Brian Warner <warner@lothar.com>
6422 * buildbot/process/builder.py (Builder.attached): serialize the
6423 attachment process, so the attach-watcher isn't called until the
6424 slave is really available. Add detached watchers too, which makes
6427 * buildbot/test/test_vc.py: test VC modes (clobber/update/etc)
6429 * buildbot/test/test_swap.py: remove dead code
6431 * buildbot/slave/commands.py (ShellCommandPP): add debug messages
6432 (ShellCommand.start): treat errors in _startCommand/spawnProcess
6433 sort of as if the command being run exited with a -1. There may
6434 still be some holes in this scheme.
6435 (CVSCommand): add 'revision' tag to the VC commands, make sure the
6436 -r option appears before the module list
6437 * buildbot/process/step.py (CVS): add 'revision' argument
6439 * buildbot/slave/bot.py (SlaveBuilder._ackFailed): catch failures
6440 when sending updates or stepComplete messages to the master, since
6441 we don't currently care whether they arrive or not. When we revamp
6442 the master/slave protocol to really resume interrupted builds,
6443 this will need revisiting.
6444 (lostRemote): remove spurious print
6446 * buildbot/master.py (BotPerspective.attached): serialize the
6447 new-builder interrogation process, to make testing easier
6448 (BotMaster.waitUntilBuilderDetached): convenience function
6450 * buildbot/status/builder.py (BuilderStatus): prune old builds
6451 (BuildStatus.pruneSteps): .. and steps
6452 (BuildStepStatus.pruneLogs): .. and logs
6453 (BuilderStatus.getBuild): handle missing builds
6454 * buildbot/status/html.py (StatusResourceBuild.body): display build
6455 status in the per-build page
6456 (BuildBox.getBox): color finished builds in the per-build box
6458 2004-08-27 Brian Warner <warner@lothar.com>
6460 * buildbot/status/mail.py (MailNotifier): new notification class,
6463 * buildbot/slave/commands.py (SourceBase): refactor SVN and CVS into
6464 variants of a common base class which handles all the mode= logic
6466 * buildbot/interfaces.py (IBuildStatus.getPreviousBuild): add
6468 * buildbot/status/builder.py (BuildStatus.getPreviousBuild): same
6470 2004-08-26 Brian Warner <warner@lothar.com>
6472 * buildbot/test/test_slavecommand.py: accomodate new slavecommand
6475 * buildbot/test/test_run.py: update to new Logfile interface, new
6476 buildbot.slave modules
6477 * buildbot/test/test_steps.py: same, remove Swappable, add timeouts
6479 * MANIFEST.in: new sample config file
6480 * docs/examples/hello.cfg: same
6482 * buildbot/process/step_twisted.py: remove dead import
6484 * buildbot/process/step.py (RemoteCommand.run): catch errors
6486 (RemoteCommand.remote_update): ignore updates that arrive after
6488 (RemoteCommand.remote_complete): ignore duplicate complete msgs
6489 (RemoteCommand._remoteComplete): cleanup failure handling, reduce
6490 the responsibilities of the subclass's methods
6491 (BuildStep.failed): catch errors during failure processing
6492 (BuildStep.addHTMLLog): provide all-HTML logfiles (from Failures)
6493 (CVS): move to a mode= argument (described in docstring), rather
6494 than the ungainly clobber=/export=/copydir= combination.
6495 (SVN): add mode= functionality to SVN too
6496 (todo_Darcs, todo_Arch, todo_P4): placeholders for future work
6498 * buildbot/process/base.py (Build.startNextStep): catch errors
6499 during s.startStep()
6501 * buildbot/clients/base.py: update to new PB client interface.
6502 gtkPanes is still broken
6504 * buildbot/bot.py, buildbot/slavecommand.py: move to..
6505 * buildbot/slave/bot.py, buildbot/slave/commands.py: .. new directory
6506 * setup.py: add buildbot.slave module
6507 * buildbot/bb_tap.py: handle move
6508 * buildbot/slave/registry.py: place to register commands, w/versions
6509 * buildbot/slave/bot.py: major simplifications
6510 (SlaveBuilder.remote_startCommand): use registry for slave commands,
6511 instead of a fixed table. Eventually this will make the slave more
6512 extensible. Use 'start' method on the command, not .startCommand.
6513 Fix unsafeTracebacks handling (I think).
6514 * buildbot/slave/commands.py: major cleanup. ShellCommand is now a
6515 helper class with a .start method that returns a Deferred.
6516 SlaveShellCommand is the form reached by the buildmaster. Commands
6517 which use multiple ShellCommands can just chain them as Deferreds,
6518 with some helper methods in Command (_abandonOnFailure and
6519 _checkAbandoned) to bail on rc!=0.
6520 (CVSCommand): prefer new mode= argument
6521 (SVNFetch): add mode= argument
6523 * buildbot/master.py (DebugPerspective.perspective_forceBuild):
6524 put a useful reason string on the build
6526 * buildbot/status/builder.py (LogFile): do LogFile right: move the
6527 core functionality into an IStatusLog object
6528 (BuildStatus.sendETAUpdate): don't send empty build-eta messages
6529 * buildbot/status/html.py (TextLog): HTML-rendering goes here
6530 (StatusResourceBuild.body): use proper accessor methods
6531 * buildbot/status/client.py (RemoteLog): PB-access goes here
6532 (StatusClientPerspective.perspective_subscribe): add "full" mode,
6533 which delivers log contents too
6534 (PBListener.__cmp__): make PBListeners comparable, thus removeable
6535 * buildbot/status/event.py: remove old Logfile completely
6537 * buildbot/interfaces.py (IStatusLog.subscribe): make the
6538 subscription interface for IStatusLog subscriptions just like all
6539 other the status subscriptions
6540 (IStatusReceiver.logChunk): method called on subscribers
6542 2004-08-24 Brian Warner <warner@lothar.com>
6544 * buildbot/process/builder.py (Builder._pong): oops, ping response
6545 includes a result (the implicit None returned by remote_print).
6546 Accept it so the _pong method handles the response correctly.
6548 2004-08-06 Brian Warner <warner@lothar.com>
6550 * buildbot/test/test_config.py: update IRC, PBListener tests
6552 * buildbot/status/client.py (StatusClientPerspective): total
6553 rewrite to match new IStatus interfaces. New subscription scheme.
6554 There are still a few optimizations to make (sending down extra
6555 information with event messages so the client doesn't have to do a
6556 round trip). The logfile-retrieval code is probably still broken.
6557 Moved the PB service into its own port, you can no longer share a
6558 TCP socket between a PBListener and, say, the slaveport (this
6559 should be fixed eventually).
6560 * buildbot/clients/base.py (Client): revamp to match. still needs
6561 a lot of work, but basic event reporting works fine. gtkPanes is
6564 * buildbot/status/words.py (IRC): move to c['status']. Each IRC
6565 instance talks to a single irc server. Threw out all the old
6566 multi-server handling code. Still need to add back in
6567 builder-control (i.e. "force build")
6569 * buildbot/status/html.py (StatusResourceBuildStep.body): add some
6570 more random text to the as-yet-unreachable per-step page
6572 * buildbot/status/builder.py (BuildStepStatus.sendETAUpdate):
6573 rename to stepETAUpdate
6574 (BuildStatus.subscribe): add build-wide ETA updates
6575 (BuilderStatus.getState): remove more cruft
6576 (BuilderStatus.getCurrentBuild): remove more cruft
6577 (BuilderStatus.buildStarted): really handle tuple-subscription
6578 * buildbot/test/test_run.py (Status.testSlave): handle the
6579 stepETAUpdate rename
6581 * buildbot/master.py (BuildMaster): don't add a default
6582 StatusClientService. Don't add a default IrcStatusFactory. Both
6583 are now added through c['status'] in the config file. c['irc'] is
6584 accepted for backwards compatibility, the only quirk is you cannot
6585 use c['irc'] to specify IRC servers on ports other than 6667.
6587 * buildbot/interfaces.py (IBuildStatus.getCurrentStep): add method
6588 (IStatusReceiver.buildStarted): allow update-interval on subscribe
6589 (IStatusReceiver.buildETAUpdate): send build-wide ETA updates
6590 (IStatusReceiver.stepETAUpdate): rename since it's step-specific
6593 * buildbot/master.py (BuildMaster.startService): SIGHUP now causes
6594 the buildmaster to re-read its config file
6597 * buildbot/test/test_web.py (test_webPortnum): need a new hack to
6598 find out the port our server is running on
6599 (WebTest.test_webPathname_port): same
6601 * buildbot/test/test_config.py (testWebPortnum): test it
6602 (testWebPathname): ditto
6604 * docs/config.xhtml: document new c['status'] configuration option
6606 * buildbot/status/html.py (Waterfall): new top-level class which
6607 can be added to c['status']. This creates the Site as well as the
6608 necessary TCPServer/UNIXServer. It goes through the BuildMaster,
6609 reachable as .parent, for everything.
6611 * buildbot/master.py (Manhole): make it a normal service Child
6612 (BuildMaster.loadConfig_status): c['status'] replaces webPortnum and
6613 webPathname. It will eventually replace c['irc'] and the implicit
6614 PB listener as well. c['webPortnum'] and c['webPathname'] are left
6615 in as (deprecated) backward compatibility hooks for now.
6618 * buildbot/process/builder.py (Builder.buildFinished): don't
6619 inform out builder_status about a finished build, as it finds out
6620 through its child BuildStatus object
6622 * buildbot/status/html.py: extensive revamp. Use adapters to make
6623 Boxes out of BuildStepStatus and friends. Acknowledge that Steps
6624 have both starting and finishing times and adjust the waterfall
6625 display accordingly, using spacers if necessary. Use SlaveStatus
6626 to get buildslave info.
6627 (StatusResourceBuildStep): new just-one-step resource, used to get
6628 logfiles. No actual href to it yet.
6630 * buildbot/status/event.py (Logfile.doSwap): disable Swappable for
6631 the time being, until I get the file-naming scheme right
6633 * buildbot/status/builder.py (Event): clean started/finished names
6634 (BuildStatus.isFinished): .finished is not None is the right test
6635 (BuildStatus.buildStarted): track started/finished times ourselves
6636 (BuilderStatus.getSlave): provide access to SlaveStatus object
6637 (BuilderStatus.getLastFinishedBuild): all builds are now in
6638 .builds, even the currently-running one. Accomodate this change.
6639 (BuilderStatus.eventGenerator): new per-builder event generator.
6640 Returns BuildStepStatus and BuildStatus objects, since they can
6641 both be adapted as necessary.
6642 (BuilderStatus.addEvent): clean up started/finished attributes
6643 (BuilderStatus.startBuild,finishBuild): remove dead code
6644 (SlaveStatus): new object to provide ISlaveStatus
6646 * buildbot/process/step.py (ShellCommand.getColor): actually
6647 return the color instead of setting it ourselves
6648 (CVS.__init__): pull .timeout and .workdir options out of
6649 **kwargs, since BuildStep will ignore them. Without this neither
6650 will be sent to the slave correctly.
6651 (SVN.__init__): same
6653 * buildbot/process/builder.py (Builder): move flags to class-level
6655 (Builder.attached): remove .remoteInfo, let the BotPerspective and
6656 SlaveStatus handle that
6658 * buildbot/process/base.py (Build.firstEvent): remove dead code
6659 (Build.stopBuild): bugfix
6661 * buildbot/changes/pb.py (PBChangeSource.describe): add method
6663 * buildbot/changes/changes.py (Change): add IStatusEvent methods
6664 (ChangeMaster.eventGenerator): yield Changes, since there are now
6665 Adapters to turn them into HTML boxes
6667 * buildbot/master.py (BotMaster): track SlaveStatus from BotMaster
6668 (BotPerspective.attached): feed a SlaveStatus object
6669 (BuildMaster.loadConfig): add a manhole port (debug over telnet)
6670 (BuildMaster.loadConfig_Builders): give BuilderStatus a parent
6672 * buildbot/interfaces.py: API additions
6673 (ISlaveStatus): place to get slave status
6675 2004-08-04 Brian Warner <warner@lothar.com>
6677 * buildbot/slavecommand.py (DummyCommand.finished): send rc=0 when
6678 the delay finishes, so the step is marked as SUCCESS
6680 * buildbot/test/test_run.py (Status.testSlave): cover more of
6681 IBuildStatus and IBuildStepStatus
6683 * buildbot/status/progress.py (StepProgress): move some flags to
6684 class-level attributes
6685 (StepProgress.remaining): if there are no other progress metrics
6686 to go by, fall back to elapsed time
6687 (StepProgress.setExpectations): take a dict of metrics instead of
6689 (BuildProgress.setExpectationsFrom): pull expectations from the
6690 Expectations, instead of having it push them to the BuildProgress
6691 (Expectations): move some flags to class-level attributes
6692 (Expectations.__init__): copy per-step times from the
6694 (Expectations.expectedBuildTime): new method for per-build ETA
6696 * buildbot/status/event.py (Logfile): move some flags to
6697 class-level attributes
6698 (Logfile.logProgressTo): better method name, let step set the
6699 progress axis name (instead of always being "output")
6701 * buildbot/status/builder.py (BuildStepStatus.getTimes): track the
6702 times directly, rather than depending upon the (possibly missing)
6703 .progress object. Use 'None' to indicate "not started/finished
6705 (BuildStepStatus.getExpectations): oops, return the full list of
6707 (BuilderStatus._buildFinished): append finished builds to .builds
6709 * buildbot/process/step.py (BuildStep): add separate .useProgress
6710 flag, since empty .progressMetrics[] still implies that time is a
6712 (CVS): set up the cmd in __init__, instead of waiting for start()
6714 * buildbot/process/base.py (Build.startBuild): disable the 'when'
6715 calculation, this will eventually turn into a proper sourceStamp
6716 (Build.setupBuild): tell the Progress to load from the Expectations,
6717 instead of having the Expectations stuff things into the Progress
6718 (Build.buildException): add a build-level errback to make sure the
6719 build's Deferred fires even in case of exceptions
6721 * buildbot/master.py (BotMaster.forceBuild): convey the reason into
6723 * buildbot/process/builder.py (Builder.forceBuild): convey the
6724 reason instead of creating a fake Change
6726 * docs/examples/twisted_master.cfg: update to match reality
6728 * buildbot/test/test_config.py, buildbot/test/test_process.py:
6729 * buildbot/test/test_run.py, buildbot/test/test_steps.py:
6730 fix or remove broken/breaking tests
6732 * buildbot/status/event.py (Logfile.__len__): remove evil method
6734 * buildbot/status/builder.py (BuildStepStatus.stepStarted): tolerate
6735 missing .build, for test convenience
6737 * buildbot/process/step_twisted.py: import fixes
6739 * buildbot/process/step.py (BuildStep.failed): exception is FAILURE
6741 * buildbot/master.py (BuildMaster.loadConfig_Builders): leftover
6742 .statusbag reference
6744 * buildbot/bot.py (BuildSlave.stopService): tear down the TCP
6745 connection at shutdown, and stop it from reconnecting
6747 * buildbot/test/test_run.py (Run.testSlave): use a RemoteDummy to
6748 chase down remote-execution bugs
6750 * buildbot/process/step.py: more fixes, remove
6751 BuildStep.setStatus()
6752 * buildbot/status/builder.py: move setStatus() functionality into
6754 * buildbot/status/event.py: minor fixes
6756 2004-08-03 Brian Warner <warner@lothar.com>
6758 * buildbot/process/base.py, buildbot/process/builder.py
6759 * buildbot/process/step.py, buildbot/status/builder.py
6760 * buildbot/status/event.py, buildbot/test/test_run.py:
6761 fix status delivery, get a basic test case working
6762 * buildbot/master.py: finish implementing basic status delivery,
6763 temporarily disable HTML/IRC/PB status sources
6765 * buildbot/bot.py (Bot.remote_setBuilderList): remove debug noise
6767 * buildbot/status/progress.py (BuildProgress): remove dead code
6769 * buildbot/interfaces.py
6770 * buildbot/process/base.py, buildbot/process/builder.py
6771 * buildbot/process/step.py, buildbot/process/step_twisted.py
6772 * buildbot/status/builder.py: Complete overhaul of the all
6773 status-delivery code, unifying all types of status clients (HTML,
6774 IRC, PB). See interfaces.IBuildStatus for an idea of what it will
6775 look like. This commit is a checkpointing of the work-in-progress:
6776 the input side is mostly done (Builders/Builds sending status
6777 to the BuilderStatus/BuildStatus objects), but the output side has
6778 not yet been started (HTML resources querying BuilderStatus
6779 objects). Things are probably very broken right now and may remain
6780 so for several weeks, I apologize for the disruption.
6782 * buildbot/status/event.py: add a setHTML method to use pre-rendered
6783 HTML as the log's contents. Currently used for exception tracebacks.
6784 * buildbot/status/progress.py: minor spelling changes
6786 2004-08-02 Brian Warner <warner@lothar.com>
6788 * docs/config.xhtml: XHTML fixes, makes raw .xhtml files viewable
6789 in mozilla. Also added stylesheets copied from Twisted's docs.
6790 Remember that these files are meant to be run through Lore first.
6791 Thanks to Philipp Frauenfelder for the fixes.
6792 * docs/factories.xhtml, docs/sources.xhtml, docs/steps.xhtml: same
6793 * docs/stylesheet-unprocessed.css, docs/stylesheet.css: same
6794 * docs/template.tpl: added a Lore template
6796 2004-07-29 Brian Warner <warner@lothar.com>
6798 * buildbot/interfaces.py: revamp status delivery. This is the
6799 preview: these are the Interfaces that will be provided by new
6800 Builder code, and to which the current HTML/IRC/PB status
6801 displayers will be adapted.
6803 * buildbot/slavecommand.py (ShellCommand.start): look for .usePTY
6804 on the SlaveBuilder, not the Bot.
6805 * buildbot/bot.py (Bot.remote_setBuilderList): copy Bot.usePTY to
6807 * buildbot/test/test_slavecommand.py (FakeSlaveBuilder.usePTY):
6808 set .usePTY on the FakeSlaveBuilder
6810 2004-07-25 Brian Warner <warner@lothar.com>
6812 * buildbot/changes/freshcvs.py: add some debug log messages
6813 (FreshCVSConnectionFactory.gotPerspective): pre-emptively fix the
6814 disabled 'setFilter' syntax
6815 (FreshCVSSourceNewcred.__init__): warn about prefix= values that
6816 don't end with a slash
6818 * buildbot/process/base.py (Builder._pong_failed): add TODO note
6820 * setup.py: bump to 0.5.0+ while between releases
6822 2004-07-23 Brian Warner <warner@lothar.com>
6824 * setup.py (version): Releasing buildbot-0.5.0
6826 2004-07-23 Brian Warner <warner@lothar.com>
6828 * README: update for 0.5.0 release
6830 * NEWS: update for 0.5.0 release
6832 2004-07-22 Brian Warner <warner@lothar.com>
6834 * buildbot/slavecommand.py (ShellCommand): make usePTY a
6835 mktap-time configuration flag (--usepty=1, --usepty=0)
6836 * buildbot/bot.py: same
6838 * buildbot/master.py (BotPerspective.got_dirs): don't complain about
6839 an 'info' directory being unwanted
6841 * buildbot/changes/freshcvs.py (FreshCVSSource): flip the
6842 newcred/oldcred switch. Newcred (for CVSToys-1.0.10 and later) is now
6843 the default. To communicate with an oldcred daemond (CVSToys-1.0.9
6844 and earlier), use a FreshCVSSourceOldcred instead.
6845 (test): simple test routine: connect to server, print changes
6847 * buildbot/changes/changes.py (Change.getTime): make it possible
6848 to print un-timestamped changes
6850 * buildbot/master.py (makeApp): delete ancient dead code
6851 (BuildMaster.loadTheConfigFile): make "master.cfg" name configurable
6852 * buildbot/test/test_config.py (testFindConfigFile): test it
6854 * docs/examples/twisted_master.cfg (b22w32): use iocp reactor
6855 instead of win32 one
6858 * buildbot/master.py (BuildMaster.loadConfig_Builders): config file
6859 now takes a dictionary instead of a tuple. See docs/config.xhtml for
6862 * buildbot/process/base.py (Builder.__init__): change constructor
6863 to accept a dictionary of config data, rather than discrete
6864 name/slave/builddir/factory arguments
6866 * docs/examples/twisted_master.cfg: update to new syntax
6867 * docs/examples/glib_master.cfg: same
6868 * buildbot/test/test_config.py (ConfigTest.testBuilders): some
6869 rough tests of the new syntax
6872 * buildbot/master.py (BuildMaster.loadConfig): allow webPathname
6873 to be an int, which means "run a web.distrib sub-server on a TCP
6874 port". This lets you publish the buildbot status page to a remote
6875 twisted.web server (using distrib.ResourceSubscription). Also
6876 rename the local attributes used to hold these web things so
6877 they're more in touch with reality.
6878 * buildbot/test/test_web.py: test webPortnum and webPathname
6879 * docs/config.xhtml: document this new use of webPathname
6881 * docs/config.xhtml: new document, slightly ahead of reality
6883 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.notify): fix
6884 'prefix' handling: treat it as a simple string to check with
6885 .startswith, instead of treating it as a directory. This allows
6886 sub-directories to be used. If you use prefix=, you should give it
6887 a string that starts just below the CVSROOT and ends with a slash.
6888 This prefix will be stripped from all filenames, and filenames
6889 which do not start with it will be ignored.
6891 2004-07-20 Cory Dodt <corydodt@twistedmatrix.com>
6893 * contrib/svn_buildbot.py: Add --include (synonym for --filter)
6894 and --exclude (inverse of --include). SVN post-commit hooks
6895 now have total control over which changes get sent to buildbot and which
6898 2004-07-10 Brian Warner <warner@lothar.com>
6900 * buildbot/test/test_twisted.py (Case1.testCountFailedTests): fix
6901 test case to match new API
6903 * buildbot/status/event.py (Logfile.getEntries): fix silly bug
6904 which crashed HTML display when self.entries=[] (needed to
6905 distinguish between [], which means "no entries yet", and None,
6906 which means "the entries have been swapped out to disk, go fetch
6909 2004-07-04 Brian Warner <warner@lothar.com>
6911 * buildbot/process/step_twisted.py (countFailedTests): Count
6912 skips, expectedFailures, and unexpectedSuccesses. Start scanning
6913 10kb from the end because any import errors are wedged there and
6914 they would make us think the test log was unparseable.
6915 (RunUnitTests.finishStatus): add skip/todo counts to the event box
6917 2004-06-26 Brian Warner <warner@lothar.com>
6919 * buildbot/process/step_twisted.py (RemovePYCs): turn the
6920 delete-*.pyc command into an actual BuildStep, so we can label it
6922 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
6923 (FullTwistedBuildFactory): same
6925 2004-06-25 Cory Dodt <corydodt@twistedmatrix.com>
6927 * contrib/fakechange.py: Add an errback when sending the fake
6928 change, so we know it didn't work.
6930 2004-06-25 Christopher Armstrong <radix@twistedmatrix.com>
6932 * buildbot/process/step_twisted.py: Delete *.pyc files before
6933 calling trial, so it doesn't catch any old .pyc files whose .py
6934 files have been moved or deleted.
6936 * buildbot/process/step_twisted.py (RunUnitTests): 1) Add a new
6937 parameter, 'recurse', that passes -R to trial. 2) have 'runAll'
6938 imply 'recurse'. 3) Make the default 'allTests' be ["twisted"]
6939 instead of ["twisted.test"], so that the end result is "trial -R
6942 * contrib/svn_buildbot.py: Add a --filter parameter that accepts a
6943 regular expression to match filenames that should be ignored when
6944 changed. Also add a --revision parameter that specifies the
6945 revision to examine, which is useful for debugging.
6947 2004-06-25 Brian Warner <warner@lothar.com>
6949 * buildbot/process/step_twisted.py (trialTextSummarizer): create a
6950 summary of warnings (like DeprecationWarnings), next to the
6953 2004-05-13 Brian Warner <warner@lothar.com>
6955 * docs/examples/twisted_master.cfg: enable the win32 builder, as
6956 we now have a w32 build slave courtesy of Mike Taylor.
6958 * buildbot/process/base.py (Build.checkInterlocks): OMG this was
6959 so broken. Fixed a race condition that tripped up interlocked
6960 builds and caused the status to be stuck at "Interlocked" forever.
6961 The twisted buildbot's one interlocked build just so happened to
6962 never hit this case until recently (the feeding builds both pass
6963 before the interlocked build is attempted.. usually it has to wait
6965 (Builder._pong_failed): fix method signature
6967 * setup.py: bump to 0.4.3+ while between releases
6969 2004-04-30 Brian Warner <warner@lothar.com>
6971 * setup.py (version): Releasing buildbot-0.4.3
6973 2004-04-30 Brian Warner <warner@lothar.com>
6975 * MANIFEST.in: add the doc fragments in docs/*.xhtml
6977 * README: update for 0.4.3 release
6979 * NEWS: update for 0.4.3 release
6981 * buildbot/master.py (BuildMaster.__getstate__): make sure
6982 Versioned.__getstate__ is invoked, for upgrade from 0.4.2
6984 * buildbot/process/step_twisted.py (RunUnitTests.trial): add
6985 .trial as a class attribute, for upgrade from 0.4.2
6987 * buildbot/changes/changes.py (Change.links): add .links for
6990 * buildbot/status/event.py (Logfile.__getstate__): get rid of both
6991 .textWatchers and .htmlWatchers at save time, since they are both
6992 volatile, should allow smooth 0.4.2 upgrade
6994 * buildbot/process/step.py (CVS.finishStatus): catch failed
6995 CVS/SVN commands so we can make the status box red
6997 2004-04-29 Brian Warner <warner@lothar.com>
6999 * buildbot/changes/freshcvs.py
7000 (FreshCVSConnectionFactory.gotPerspective): add (commented-out)
7001 code to do setFilter(), which tells the freshcvs daemon to not
7002 send us stuff that we're not interested in. I will uncomment it
7003 when a new version of CVSToys is available in which setFilter()
7004 actually works, and I get a chance to test it better.
7006 * docs/examples/twisted_master.cfg: start using a PBChangeSource
7008 * buildbot/master.py (Dispatcher): use a registration scheme
7009 instead of hardwired service names
7010 (BuildMaster): keep track of the Dispatcher to support
7013 * buildbot/changes/changes.py (ChangeMaster): create a distinct
7014 PBChangeSource class instead of having it be an undocumented
7015 internal feature of the ChangeMaster. Split out the code into a
7017 * buildbot/changes/pb.py (PBChangeSource): same
7018 * buildbot/test/test_changes.py: a few tests for PBChangeSource
7020 * docs/{factories|sources|steps}.xhtml: document some pieces
7022 * docs/examples/twisted_master.cfg: use SVN instead of CVS, stop
7023 using FCMaildirSource
7024 (f23osx): update OS-X builder to use python2.3, since the slave
7025 was updated to Panther (10.3.3)
7027 2004-03-21 Brian Warner <warner@lothar.com>
7029 * buildbot/process/process_twisted.py: factor out doCheckout, change
7030 to use SVN instead of CVS
7032 * buildbot/process/base.py (BasicBuildFactory): refactor to make
7033 an SVN subclass easier
7034 (BasicSVN): subclass which uses Subversion instead of CVS
7036 2004-03-15 Christopher Armstrong <radix@twistedmatrix.com>
7038 * buildbot/slavecommand.py (ShellCommand.start): use COMSPEC instead
7040 (CVSCommand.cvsComplete): don't assume chdir worked on win32
7042 2004-02-25 Brian Warner <warner@lothar.com>
7044 * buildbot/slavecommand.py (ShellCommand): ['commands'] argument
7045 is now either a list (which is passed to spawnProcess directly) or
7046 a string (which gets passed to /bin/sh -c). This removes the useSH
7047 flag and the ArgslistCommand class. Also send status header at the
7048 start and end of each command, instead of having the master-side
7050 (CVSCommand): fix the doUpdate command, it failed to do the 'cp
7051 -r'. Update to use list-based arguments.
7052 (SVNFetch): use list-based arguments, use ['dir'] argument to
7054 * buildbot/test/test_steps.py (Commands): match changes
7056 * buildbot/process/step.py (InternalShellCommand.words): handle
7058 (SVN): inherit from CVS, cleanup
7060 * buildbot/status/event.py (Logfile.content): render in HTML, with
7061 stderr in red and headers (like the name of the command we're
7062 about to run) in blue. Add link to a second URL (url + "?text=1")
7063 to get just stdout/stderr in text/plain without markup. There is
7064 still a problem with .entries=None causing a crash, it seems to occur
7065 when the logfile is read before it is finished.
7067 * buildbot/bot.py (BotFactory.doKeepalive): add a 30-second
7068 timeout to the keepalives, and use it to explicitly do a
7069 loseConnection instead of waiting for TCP to notice the loss. This
7070 ought to clear up the silent-lossage problem.
7071 (unsafeTracebacks): pass exception tracebacks back to the master,
7072 makes it much easier to debug problems
7074 2004-02-23 Brian Warner <warner@lothar.com>
7076 * buildbot/slavecommand.py (ShellCommand): add useSH flag to pass
7077 the whole command to /bin/sh instead of execve [Johan Dahlin]
7078 (CVSCommand): drop '-r BRANCH' if BRANCH==None instead of usiing
7079 '-r HEAD' [Johan Dahlin]
7080 (CVSCommand.start2): fix cvsdir calculation [Johan Dahlin]
7082 * buildbot/changes/changes.py (Change): add links= argument, add
7083 asHTML method [Johan Dahlin]. Modified to make a bit more
7084 XHTMLish. Still not sure how to best use links= .
7086 * buildbot/status/html.py (StatusResourceCommits.getChild): use
7087 Change.asHTML to display the change, not asText
7089 * buildbot/status/html.py (StatusResourceBuilder): web button to
7092 * buildbot/test/test_run.py: test to actually start a buildmaster
7095 * MANIFEST.in: bring back accidentally-dropped test helper files
7097 * buildbot/test/test_config.py (ConfigTest.testSources): skip tests
7098 that require cvstoys if it is not installed
7100 * buildbot/process/step_twisted.py (RunUnitTests): allow other
7101 values of "bin/trial" [Dave Peticolas]
7102 (RunUnitTests.finishStatus): say "no tests run" instead of "0
7103 tests passed" when we didn't happen to run any tests
7105 * buildbot/process/step.py (Compile): use haltOnFailure instead of
7106 flunkOnFailure [Johan Dahlin]
7108 * buildbot/process/base.py (ConfigurableBuild.setSteps): allow
7109 multiple instances of the same Step class by suffixing "_2", etc,
7110 to the name until it is unique. This name needs to be unique
7111 because it is used as a key in the dictionary that tracks build
7113 * buildbot/test/test_steps.py (Steps.testMultipleStepInstances):
7116 * buildbot/process/base.py (Builder.ping): add "ping slave" command
7118 2004-01-14 Brian Warner <warner@lothar.com>
7120 * buildbot/status/words.py (IrcStatusBot): when we leave or get
7121 kicked from a channel, log it
7123 * buildbot/master.py (Dispatcher): add "poke IRC" command to say
7124 something over whatever IRC channels the buildmaster is currently
7125 connected to. Added to try and track down a problem in which the
7126 master thinks it is still connected but the IRCd doesn't see it. I
7127 used a styles.Versioned this time, so hopefully users won't have
7128 to rebuild their .tap files this time.
7129 * contrib/debug.glade: add a "Poke IRC" button
7130 * contrib/debugclient.py: same
7132 * setup.py: bump to 0.4.2+ while between releases
7134 2004-01-08 Brian Warner <warner@lothar.com>
7136 * setup.py (version): Releasing buildbot-0.4.2
7138 2004-01-08 Brian Warner <warner@lothar.com>
7140 * NEWS: update for 0.4.2 release
7142 * README: document how to run the tests, now that they all pass
7144 * buildbot/changes/maildir.py (Maildir.poll): minor comment
7146 * buildbot/process/step.py (CVS): add a global_options= argument,
7147 which lets you set CVS global options for the command like "-r"
7148 for read-only checkout, or "-R" to avoid writing in the
7150 * buildbot/slavecommand.py (CVSCommand): same
7152 * buildbot/status/event.py (Logfile): add a .doSwap switch to make
7153 testing easier (it is turned off when testing, to avoid the
7156 * buildbot/process/step.py (InternalBuildStep): shuffle code a bit
7157 to make it easier to test: break generateStepID() out to a
7158 separate function, only update statusbag if it exists.
7159 (ShellCommands): create useful text for dict-based commands too.
7161 * test/*, buildbot/test/*: move unit tests under the buildbot/
7163 * setup.py (packages): install buildbot.test too
7165 * buildbot/test/test_slavecommand.py: fix it, tests pass now
7166 * buildbot/test/test_steps.py: fix it, tests pass now
7168 2004-01-06 Brian Warner <warner@lothar.com>
7170 * buildbot/changes/mail.py (parseFreshCVSMail): looks like new
7171 freshcvs mail uses a slightly different syntax for new
7172 directories. Update parser to handle either.
7173 * test/test_mailparse.py (Test1.testMsg9): test for same
7175 2003-12-21 Brian Warner <warner@lothar.com>
7177 * buildbot/process/process_twisted.py (TwistedDebsBuildFactory): set
7178 'warnOnWarnings' so that lintian errors mark the build orange
7180 2003-12-17 Brian Warner <warner@lothar.com>
7182 * buildbot/changes/mail.py (parseBonsaiMail): parser for commit
7183 messages emitted by Bonsai, contributed by Stephen Davis.
7185 * test/*: moved all tests to use trial instead of unittest. Some
7186 still fail (test_steps, test_slavecommand, and test_process).
7188 * setup.py (version): bump to 0.4.1+ while between releases
7190 2003-12-09 Brian Warner <warner@lothar.com>
7192 * setup.py (version): Releasing buildbot-0.4.1
7194 2003-12-09 Brian Warner <warner@lothar.com>
7196 * NEWS: update for 0.4.1 release
7198 * docs/examples/twisted_master.cfg: add netbsd builder, shuffle
7199 freebsd builder code a little bit
7201 * buildbot/changes/freshcvs.py (FreshCVSSourceNewcred.__cmp__):
7202 don't try to compare attributes of different classes
7203 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7204 (MaildirSource.messageReceived): fix Change delivery
7206 * buildbot/master.py (BuildMaster.loadConfig): insert 'basedir'
7207 into the config file's namespace before loading it, like the
7208 documentation claims it does
7209 * docs/examples/twisted_master.cfg: remove explicit 'basedir'
7210 (useFreshCVS): switch to using a maildir until Twisted's freshcvs
7211 daemon comes back online
7213 2003-12-08 Brian Warner <warner@lothar.com>
7215 * docs/examples/twisted_master.cfg: provide an explicit 'basedir'
7216 so the example will work with online=0 as well
7218 * buildbot/changes/mail.py (FCMaildirSource, SyncmailMaildirSource):
7219 fix the __implements__ line
7221 * buildbot/changes/maildirtwisted.py (MaildirTwisted): make this
7222 class a twisted.application.service.Service, use startService to
7225 * buildbot/changes/dnotify.py (DNotify): use os.open to get the
7226 directory fd instead of simple open(). I'm sure this used to work,
7227 but the current version of python refuses to open directories with
7230 2003-12-05 Brian Warner <warner@lothar.com>
7232 * setup.py (version): bump to 0.4.0+ while between releases
7234 2003-12-05 Brian Warner <warner@lothar.com>
7236 * setup.py (version): Releasing buildbot-0.4.0
7238 2003-12-05 Brian Warner <warner@lothar.com>
7240 * docs/examples/glib_master.cfg: replace old sample scripts with
7241 new-style config files
7242 * MANIFEST.in: include .cfg files in distribution tarball
7244 * buildbot/changes/freshcvs.py (FreshCVSListener.remote_goodbye):
7245 implement a dummy method to avoid the exception that occurs when
7246 freshcvs sends this to us.
7248 * buildbot/pbutil.py (ReconnectingPBClientFactory.stopFactory):
7249 removed the method, as it broke reconnection. Apparently
7250 stopFactory is called each time the connection attempt fails. Must
7252 (ReconnectingPBClientFactory.__getstate__): squash the _callID
7253 attribute before serialization, since without stopFactory the
7254 reconnect timer may still be active and they aren't serializable.
7256 * test/test_mailparse.py (ParseTest): test with 'self' argument
7258 * buildbot/changes/mail.py (parseFreshCVSMail): add (silly) 'self'
7259 argument, as these "functions" are invoked like methods from class
7260 attributes and therefore always get an instance as the first
7263 * buildbot/changes/maildir.py (Maildir.start): fix error in error
7264 message: thanks to Stephen Davis for the catch
7266 2003-12-04 Brian Warner <warner@lothar.com>
7268 * buildbot/pbutil.py: complete rewrite using PBClientFactory and
7269 twisted's standard ReconnectingClientFactory. Handles both oldcred
7270 and newcred connections. Also has a bug-workaround for
7271 ReconnectingClientFactory serializing its connector when it
7274 * buildbot/bot.py (BotFactory): rewrite connection layer with new
7275 pbutil. Replace makeApp stuff with proper newcred/mktap
7276 makeService(). Don't serialize Ephemerals on shutdown.
7278 * buildbot/changes/changes.py (ChangeMaster): make it a
7279 MultiService and add the sources as children, to get startService
7280 and stopService for free. This also gets rid of the .running flag.
7282 * buildbot/changes/freshcvs.py (FreshCVSSource): rewrite to use
7283 new pbutil, turn into a TCPClient at the same time (to get
7284 startService for free). Two variants exist: FreshCVSSourceOldcred
7285 and FreshCVSSourceNewcred (CVSToys doesn't actualy support newcred
7286 yet, but when it does, we'll be ready).
7287 (FreshCVSSource.notify): handle paths which are empty after the
7288 prefix is stripped. This only happens when the top-level (prefix)
7289 directory is added, at the very beginning of a Repository's life.
7291 * buildbot/clients/base.py: use new pbutil, clean up startup code.
7292 Now the only reconnecting code is in the factory where it belongs.
7293 (Builder.unsubscribe): unregister the disconnect callback when we
7294 delete the builder on command from the master (i.e. when the
7295 buildmaster is reconfigured and that builder goes away). This
7296 fixes a multiple-delete exception when the status client is shut
7298 * buildbot/clients/gtkPanes.py (GtkClient): cleanup, match the
7301 * buildbot/status/words.py (IrcStatusBot): add some more sillyness
7302 (IrcStatusBot.getBuilderStatus): fix minor exception in error message
7304 2003-10-20 Christopher Armstrong <radix@twistedmatrix.com>
7306 * contrib/run_maxq.py: Accept a testdir as an argument rather than
7307 a list of globs (ugh). The testdir will be searched for files
7308 named *.tests and run the tests in the order specified in each of
7309 those files. This allows for "dependancies" between tests to be
7312 * buildbot/process/maxq.py (MaxQ.__init__): Accept a testdir
7313 argument to pass to run_maxq.py, instead of a glob.
7315 2003-10-17 Brian Warner <warner@lothar.com>
7317 * buildbot/process/step_twisted.py (HLint.start): ignore .xhtml
7318 files that live in the sandbox
7320 2003-10-15 Brian Warner <warner@lothar.com>
7322 * buildbot/process/step_twisted.py (ProcessDocs.finished): fix
7323 spelling error in "docs" count-warnings output
7324 (HLint.start): stupid thinko meant .xhtml files were ignored
7326 * docs/examples/twisted_master.cfg (reactors): disable cReactor
7327 tests now that cReactor is banished to the sandbox
7329 2003-10-10 Brian Warner <warner@lothar.com>
7331 * buildbot/process/step_twisted.py (ProcessDocs, HLint): new Twisted
7332 scheme: now .xhtml are sources and .html are generated
7334 2003-10-08 Brian Warner <warner@lothar.com>
7336 * buildbot/process/step_twisted.py (RunUnitTests.__init__): oops,
7337 we were ignoring the 'randomly' parameter.
7339 2003-10-01 Brian Warner <warner@lothar.com>
7341 * buildbot/slavecommand.py (ShellCommand.start): set usePTY=1 on
7342 posix, to kill sub-children of aborted slavecommands.
7344 * buildbot/status/builder.py: rename Builder to BuilderStatus.
7345 Clean up initialization: lastBuildStatus remains None until the
7346 first build has been completed.
7348 * buildbot/status/html.py (WaterfallStatusResource.body): handle
7349 None as a lastBuildStatus
7350 * buildbot/clients/gtkPanes.py: same
7352 * buildbot/status/client.py (StatusClientService): keep
7353 BuilderStatus objects in self.statusbags . These objects now live
7354 here in the StatusClientService and are referenced by the Builder
7355 object, rather than the other way around.
7356 * buildbot/status/words.py (IrcStatusBot.getBuilderStatus): same
7357 * buildbot/process/base.py (Builder): same
7358 * test/test_config.py (ConfigTest.testBuilders): same
7360 * buildbot/master.py (BuildMaster.loadConfig_Builders): when modifying
7361 an existing builder, leave the statusbag alone. This will preserve the
7364 * buildbot/pbutil.py (ReconnectingPB.connect): add initial newcred
7365 hook. This will probably go away in favor of a class in upcoming
7368 * buildbot/changes/freshcvs.py (FreshCVSSource.start): Remove old
7369 serviceName from newcred FreshCVSNotifiee setup
7371 2003-09-29 Brian Warner <warner@lothar.com>
7373 * buildbot/process/process_twisted.py: switch to new reactor
7375 * docs/examples/twisted_master.cfg: same
7377 * README (REQUIREMENTS): mention twisted-1.0.8a3 requirement
7379 * buildbot/status/words.py (IrcStatusBot.getBuilder): use the
7380 botmaster reference instead of the oldapp service lookup
7382 * buildbot/master.py (BuildMaster.__init__): give the
7383 StatusClientService a reference to the botmaster to make it easier to
7386 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7388 * buildbot/status/html.py (Box.td): escape hreffy things so you
7389 can have spaces in things like builder names
7390 (StatusResourceBuilder.body)
7391 (WaterfallStatusResource.body)
7392 (WaterfallStatusResource.body0): same
7394 2003-09-25 Brian Warner <warner@lothar.com>
7396 * buildbot/master.py (BuildMaster.loadConfig_Builders): don't
7397 rearrange the builder list when adding or removing builders: keep
7398 them in the order the user requested.
7399 * test/test_config.py (ConfigTest.testBuilders): verify it
7401 * contrib/debug.glade: give the debug window a name
7403 * buildbot/process/base.py (Builder.buildTimerFired): builders can
7404 now wait on multiple interlocks. Fix code relating to that.
7405 (Builder.checkInterlocks): same
7406 * buildbot/status/builder.py (Builder.currentlyInterlocked): same
7408 * buildbot/master.py (BuildMaster.loadConfig): move from
7409 deprecated pb.BrokerFactory to new pb.PBServerFactory
7410 * test/test_config.py (ConfigTest.testWebPathname): same
7412 * docs/examples/twisted_master.cfg: fix interlock declaration
7414 * buildbot/master.py (BotMaster.addInterlock): move code to attach
7415 Interlocks to their Builders into interlock.py .
7416 (BuildMaster.loadConfig_Interlocks): fix interlock handling
7418 * test/test_config.py (ConfigTest.testInterlocks): validate
7421 * buildbot/process/base.py (Builder.__init__): better comments
7422 * buildbot/process/interlock.py (Interlock.__repr__): same
7423 (Interlock.deactivate): add .active flag, move the code that
7424 attaches/detaches builders into the Interlock
7426 2003-09-24 Christopher Armstrong <radix@twistedmatrix.com>
7428 * buildbot/process/maxq.py (MaxQ): support for running a set of MaxQ
7429 tests using the new run_maxq.py script, and reporting failures by
7432 * contrib/run_maxq.py: Hacky little script for running a set of maxq
7433 tests, reporting their success or failure in a buildbot-friendly
7436 2003-09-24 Brian Warner <warner@lothar.com>
7438 * docs/examples/twisted_master.cfg: example of a new-style config
7439 file. This lives in the buildmaster base directory as
7442 * contrib/debugclient.py (DebugWidget.do_rebuild): add 'reload'
7443 button to make the master re-read its config file
7445 * buildbot/master.py (BuildMaster.loadConfig): new code to load
7446 buildmaster configuration from a file. This file can be re-read
7447 later, and the buildmaster will update itself to match the new
7448 desired configuration. Also use new Twisted Application class.
7449 * test/Makefile, test/test_config.py: unit tests for same
7451 * buildbot/changes/freshcvs.py (FreshCVSSource.__cmp__): make
7452 FreshCVSSources comparable, to support reload.
7453 * buildbot/changes/mail.py (MaildirSource.__cmp__): same
7455 * buildbot/process/base.py (Builder): make them comparable, make
7456 Interlocks easier to attach, to support reload. Handle
7457 re-attachment of remote slaves.
7458 * buildbot/process/interlock.py (Interlock): same
7460 * buildbot/bot.py, bb_tap.py, changes/changes.py: move to
7461 Twisted's new Application class. Requires Twisted >= 1.0.8 .
7462 buildmaster taps are now constructed with mktap.
7463 * buildbot/status/client.py (StatusClientService): same
7465 * buildbot/status/words.py: move to new Services, add support to
7466 connect to multiple networks, add reload support, allow nickname
7467 to be configured on a per-network basis
7469 2003-09-20 Brian Warner <warner@lothar.com>
7471 * docs/examples/twisted_master.py (twisted_app): use python2.3 for
7472 the freebsd builder, now that the machine has been upgraded and no
7473 longer has python2.2
7475 * setup.py (version): bump to 0.3.5+ while between releases
7477 2003-09-19 Brian Warner <warner@lothar.com>
7479 * setup.py (version): Releasing buildbot-0.3.5
7481 2003-09-19 Brian Warner <warner@lothar.com>
7483 * NEWS: add post-0.3.4 notes
7485 * README (REQUIREMENTS): note twisted-1.0.7 requirement
7487 * MANIFEST.in: add contrib/*
7489 * docs/examples/twisted_master.py (twisted_app): all build slaves must
7490 use a remote root now: cvs.twistedmatrix.com
7492 * buildbot/changes/freshcvs.py (FreshCVSNotifiee.connect): update
7494 (FreshCVSNotifieeOldcred): but retain a class that uses oldcred for
7495 compatibility with old servers
7496 (FreshCVSSource.start): and provide a way to use it
7497 (FreshCVSNotifiee.disconnect): handle unconnected notifiee
7499 * docs/examples/twisted_master.py (twisted_app): update to new
7501 (twisted_app): listen on new ~buildbot socket
7502 (twisted_app): Twisted CVS has moved to cvs.twistedmatrix.com
7504 * buildbot/process/process_twisted.py: Use 'copydir' on CVS steps
7505 to reduce cvs bandwidth (update instead of full checkout)
7507 2003-09-11 Brian Warner <warner@lothar.com>
7509 * contrib/fakechange.py: demo how to connect to the changemaster
7510 port. You can use this technique to submit changes to the
7511 buildmaster from source control systems that offer a hook to run a
7512 script when changes are committed.
7514 * contrib/debugclient.py: tool to connect to the debug port. You
7515 can use it to force builds, submit fake changes, and wiggle the
7518 * buildbot/master.py: the Big NewCred Reorganization. Use a single
7519 'Dispatcher' realm to handle all the different kinds of
7520 connections and Perspectives: buildslaves, the changemaster port,
7521 the debug port, and the status client port. NewCredPerspectives
7522 now have .attached/.detached methods called with the remote 'mind'
7523 reference, much like old perspectives did. All the pb.Services
7524 turned into ordinary app.ApplicationServices .
7525 (DebugService): went away, DebugPerspectives are now created
7526 directly by the Dispatcher.
7527 (makeApp): changed interface a little bit
7529 * buildbot/changes/changes.py: newcred
7530 * buildbot/status/client.py: newcred
7532 * buildbot/clients/base.py: newcred client side changes
7533 * buildbot/bot.py: ditto
7535 * docs/examples/glib_master.py: handle new makeApp() interface
7536 * docs/examples/twisted_master.py: ditto
7538 * buildbot/pbutil.py (NewCredPerspective): add a helper class to
7539 base newcred Perspectives on. This should go away once Twisted
7540 itself provides something sensible.
7543 2003-09-11 Christopher Armstrong <radix@twistedmatrix.com>
7545 * contrib/svn_buildbot.py: A program that you can call from your
7546 SVNREPO/hooks/post-commit file that will notify a BuildBot master
7547 when a change in an SVN repository has happened. See the top of
7548 the file for some minimal usage info.
7550 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7552 * buildbot/slavecommand.py (ArglistCommand): Add new
7553 ArglistCommand that takes an argument list rather than a string as
7554 a parameter. Using a st.split() for argv is very bad.
7556 * buildbot/slavecommand.py (SVNFetch): Now has the ability to
7557 update to a particular revision rather than always checking out
7558 (still not very smart about it, there may be cases where the
7559 checkout becomes inconsistent).
7561 2003-09-10 Christopher Armstrong <radix@twistedmatrix.com>
7563 * buildbot/{bot.py,slavecommand.py,process/step.py}: Rudimentary
7564 SVN fetch support. It can checkout (not update!) a specified
7565 revision from a specified repository to a specified directory.
7567 * buildbot/status/progress.py (Expectations.update): Fix an
7568 obvious bug (apparently created by the change described in the
7569 previous ChangeLog message) by moving a check to *after* the
7570 variable it checks is defined.
7573 2003-09-08 Brian Warner <warner@lothar.com>
7575 * buildbot/status/progress.py (Expectations.update): hack to catch
7576 an exception TTimo sees: sometimes the update() method seems to
7577 get called before the step has actually finished, so the .stopTime
7578 is not set, so no totalTime() is available and we average None
7579 with the previous value. Catch this and just don't update the
7580 metrics, and emit a log message.
7582 2003-08-24 Brian Warner <warner@lothar.com>
7584 * buildbot/process/base.py (BasicBuildFactory): accept 'cvsCopy'
7585 parameter to set copydir='original' in CVS commands.
7587 * buildbot/process/step.py (CVS): accept 'copydir' parameter.
7589 * buildbot/slavecommand.py (CVSCommand): add 'copydir' parameter,
7590 which tells the command to maintain a separate original-source CVS
7591 workspace. For each build, this workspace will be updated, then
7592 the tree copied into a new workdir. This reduces CVS bandwidth
7593 (from a full checkout to a mere update) while doubling the local
7594 disk usage (to keep two copies of the tree).
7596 2003-08-21 Brian Warner <warner@lothar.com>
7598 * buildbot/status/event.py (Logfile.addEntry): if the master web
7599 server dies while we're serving a page, request.write raises
7600 pb.DeadReferenceError . Catch this and treat it like a
7601 notifyFinish event by dropping the request.
7603 2003-08-18 Brian Warner <warner@lothar.com>
7605 * buildbot/status/words.py (IrcStatusBot.command_FORCE): complain
7606 (instead of blowing up) if a force-build command is given without
7609 * buildbot/changes/changes.py (ChangeMaster.getChangeNumbered):
7610 don't blow up if there aren't yet any Changes in the list
7612 2003-08-02 Brian Warner <warner@lothar.com>
7614 * buildbot/bot.py (updateApplication): don't set the .tap name,
7615 since we shouldn't assume we own the whole .tap file
7617 * buildbot/bb_tap.py (updateApplication): clean up code, detect
7618 'mktap buildbot' (without a subcommand) better
7620 2003-07-29 Brian Warner <warner@lothar.com>
7622 * buildbot/status/words.py
7623 (IrcStatusFactory.clientConnectionLost): when we lose the
7624 connection to the IRC server, schedule a reconnection attempt.
7626 * buildbot/slavecommand.py (CVSCommand.doClobber): on non-posix,
7627 use shutil.rmtree instead of forking off an "rm -rf" command.
7628 rmtree may take a while and will block until it finishes, so we
7629 use "rm -rf" if available.
7631 * docs/examples/twisted_master.py: turn off kqreactor, it hangs
7632 freebsd buildslave badly
7634 * setup.py (version): bump to 0.3.4+ while between releases
7636 2003-07-28 Brian Warner <warner@lothar.com>
7638 * setup.py (version): Releasing buildbot-0.3.4
7640 2003-07-28 Brian Warner <warner@lothar.com>
7642 * NEWS: update in preparation for release
7644 * buildbot/slavecommand.py (ShellCommand.doTimeout): use
7645 process.signalProcess instead of os.kill, to improve w32
7648 * docs/examples/twisted_master.py (twisted_app): turn off
7649 win32eventreactor: the tests hang the buildslave badly
7651 * buildbot/process/base.py (Build.buildFinished): update ETA even on
7652 failed builds, since usually the failures are consistent
7654 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7655 add compileOpts/compileOpts2 to reactors build
7657 * docs/examples/twisted_master.py (twisted_app): add "-c mingw32"
7658 (twisted_app): use both default and win32eventreactor on w32 build.
7659 Use both default and kqreactor on freebsd build.
7661 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7662 add compileOpts2, which is put after the build_ext argument. w32
7663 needs "-c mingw32" here.
7665 * buildbot/status/html.py (StatusResourceBuilder.getChild): don't
7666 touch .acqpath, it goes away in recent Twisted releases
7668 * docs/examples/twisted_master.py (twisted_app): use "python" for
7669 the w32 buildslave, not "python2.2"
7671 * buildbot/bot.py (Bot.remote_getSlaveInfo): only look in info/ if
7672 the directory exists.. should hush an exception under w32
7674 * buildbot/slavecommand.py (ShellCommandPP.processEnded): use
7675 ProcessTerminated -provided values for signal and exitCode rather
7676 than parsing the unix status code directly. This should remove one
7677 more roadblock for a w32-hosted buildslave.
7679 * test/test_mailparse.py: add test cases for Syncmail parser
7681 * Buildbot/changes/freshcvsmail.py: remove leftover code, leave a
7682 temporary compatibility import. Note! Start importing
7683 FCMaildirSource from changes.mail instead of changes.freshcvsmail
7685 * buildbot/changes/mail.py (parseSyncmail): finish Syncmail parser
7687 2003-07-27 Brian Warner <warner@lothar.com>
7689 * NEWS: started adding new features
7691 * buildbot/changes/mail.py: start work on Syncmail parser, move
7692 mail sources into their own file
7694 * buildbot/changes/freshcvs.py (FreshCVSNotifiee): mark the class
7695 as implementing IChangeSource
7696 * buildbot/changes/freshcvsmail.py (FCMaildirSource): ditto
7698 * buildbot/interfaces.py: define the IChangeSource interface
7700 2003-07-26 Brian Warner <warner@lothar.com>
7702 * buildbot/master.py (makeApp): docstring (thanks to Kevin Turner)
7704 2003-06-25 Brian Warner <warner@lothar.com>
7706 * buildbot/status/words.py (IrcStatusBot.emit_last): round off
7709 2003-06-17 Brian Warner <warner@lothar.com>
7711 * buildbot/status/words.py: clean up method usage to avoid error
7712 in silly IRC command
7713 (IrcStatusBot.emit_status): round off seconds display
7715 * buildbot/process/base.py (Build): delete the timer when saving
7716 to the .tap file, and restore it (if it should still be running)
7717 upon restore. This should fix the "next build in -34 seconds"
7718 messages that result when the master is restarted while builds are
7719 sitting in the .waiting slot. If the time for the build has
7720 already passed, start it very soon (in 1 second).
7722 * buildbot/status/words.py: more silly commands
7724 * README (REQUIREMENTS): add URLs to all required software
7726 * buildbot/status/words.py ('last'): mention results of, and time
7729 2003-05-28 Brian Warner <warner@lothar.com>
7731 * buildbot/status/words.py: add 'last' command
7732 (IrcStatusBot.emit_status): add current-small text to 'status' output
7734 * docs/examples/twisted_master.py (twisted_app): turn on IRC bot
7735 (twisted_app): remove spaces from OS-X builder name
7737 * buildbot/master.py (makeApp): add knob to turn on IRC bot
7738 * buildbot/status/words.py: IRC bot should actually be useful now
7740 2003-05-23 Brian Warner <warner@lothar.com>
7742 * buildbot/bot.py (Bot.remote_getSlaveInfo): add routines to get
7743 "slave information" from $(slavedir)/info/* . These files are
7744 maintained by the slave administrator, and describe the
7745 machine/environment that is hosting the slave. Information from
7746 them is put into the "Builder" HTML page. Still need to establish
7747 a set of well-known filenames and meanings for this data: at the
7748 moment, *all* info/* files are sent to the master, but only
7749 'admin' and 'host' are used on that end.
7750 * buildbot/status/html.py (StatusResourceBuilder.body): ditto
7751 * buildbot/process/base.py (Builder.setRemoteInfo): ditto
7752 * buildbot/master.py (BotPerspective.got_info): ditto
7754 2003-05-22 Brian Warner <warner@lothar.com>
7756 * setup.py (version): bump version to 0.3.3+ while between releases
7758 2003-05-21 Brian Warner <warner@lothar.com>
7760 * setup.py: Releasing buildbot-0.3.3
7762 2003-05-21 Brian Warner <warner@lothar.com>
7764 * NEWS: 0.3.3 news items
7766 * README: describe --keepalive and life behind a NAT box
7768 * buildbot/bot.py (Bot.connected): implement application-level
7769 keepalives to deal with NAT timeouts, turn them on with
7770 --keepalive option or when SO_KEEPALIVE doesn't work.
7772 * buildbot/master.py (BotPerspective): accept keepalives silently
7774 * buildbot/process/base.py (Build.buildException): CopiedFailures
7775 don't carry as much information as local ones, so don't try to
7776 create a big HTMLized version of them.
7778 * buildbot/process/step.py (InternalShellCommand.stepFailed): close
7779 log file when step fails due to an exception, such as when the slave
7782 * buildbot/process/step_twisted.py (RunUnitTests): use trial's new
7783 --testmodule argument instead of grepping for test-case-name tags
7784 ourselves. Remove FindUnitTests code.
7785 * buildbot/slavecommand.py, buildbot/bot.py: remove old code
7787 * MANIFEST.in: Add docs/examples, files under test/ . Oops!
7789 2003-05-16 Brian Warner <warner@lothar.com>
7791 * buildbot/process/base.py (BasicBuildFactory): add 'configureEnv'
7792 argument to allow things like CFLAGS=-O0 to be passed without relying
7793 upon /bin/sh processing on the slave.
7795 * buildbot/process/step.py (InternalShellCommand.start): send
7797 * buildbot/slavecommand.py (ShellCommand.start): create argv with
7798 'split' instead of letting /bin/sh do it. This should also remove
7799 the need for /bin/sh on the buildslave, making it more likely to
7802 * buildbot/status/html.py: html-escape text in blamelist.
7803 Add "force build" button to the Builder page.
7805 * buildbot/process/step_twisted.py (countFailedTests): look at
7806 last 1000 characters for status line, as import errors can put it
7807 before the -200 point.
7809 2003-05-15 Brian Warner <warner@lothar.com>
7811 * docs/examples/twisted_master.py: use clobber=0 for remote builds
7813 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7814 make 'clobber' a parameter, so it is possible to have builds which
7815 do full tests but do a cvs update instead of hammering the CVS
7816 server with a full checkout each build
7818 * buildbot/process/step.py (InternalShellCommand): bump default
7819 timeout to 20 minutes
7821 * buildbot/bot.py (Bot.debug_forceBuild): utility method to ask
7822 the master to trigger a build. Run it via manhole.
7824 * buildbot/master.py (BotPerspective.perspective_forceBuild):
7825 allow slaves to trigger any build that they host, to make life
7826 easier for slave admins who are testing out new build processes
7828 * buildbot/process/process_twisted.py (TwistedReactorsBuildFactory):
7829 don't flunk cReactor or qtreactor on failure, since they fail alot
7830 these days. Do warnOnFailure instead.
7832 * buildbot/process/base.py: change Builder.buildable from a list
7833 into a single slot. When we don't have a slave, new builds (once
7834 they make it past the timeout) are now merged into an existing
7835 buildable one instead of being queued. With this change, a slave
7836 which has been away for a while doesn't get pounded with all the
7837 builds it missed, but instead just does a single build.
7839 2003-05-07 Brian Warner <warner@lothar.com>
7841 * setup.py (version): bump version to 0.3.2+ while between releases
7843 2003-05-07 Brian Warner <warner@lothar.com>
7845 * setup.py: Releasing buildbot-0.3.2
7847 2003-05-07 Brian Warner <warner@lothar.com>
7849 * setup.py: fix major packaging error: include subdirectories!
7851 * NEWS: add changes since last release
7853 * README (REQUIREMENTS): update twisted/python dependencies
7855 * buildbot/status/builder.py (Builder.startBuild): change
7856 BuildProcess API: now they should call startBuild/finishBuild
7857 instead of pushing firstEvent / setLastBuildStatus. Moving towards
7858 keeping a list of builds in the statusbag, to support other kinds of
7860 (Builder.addClient): send current-activity-small to new clients
7861 * buildbot/process/base.py (Build.startBuild, .buildFinished): use
7864 * buildbot/status/client.py: drop RemoteReferences at shutdown
7866 * buildbot/status/event.py (Event.stoppedObserving): oops, add it
7868 * buildbot/status/progress.py (BuildProgress.remote_subscribe):
7869 more debug messages for remote status client
7871 * buildbot/process/step.py (InternalBuildStep.stepComplete)
7872 (.stepFailed): only fire the Deferred once, even if both
7873 stepComplete and stepFailed are called. I think this can happen if
7874 an exception occurs at a weird time.
7876 * buildbot/status/words.py: work-in-progress: IRC status delivery
7878 2003-05-05 Brian Warner <warner@lothar.com>
7880 * docs/examples/twisted_master.py (twisted_app): hush internal
7881 python2.3 distutils deprecation warnings
7882 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7883 add compileOpts= argument which inserts extra args before the
7884 "setup.py build_ext" command. This can be used to give -Wignore
7885 warnings, to hush some internal python-2.3 deprecation messages.
7887 * buildbot/process/step_twisted.py (RunUnitTests): parameterize
7888 the ['twisted.test'] default test case to make it easier to change
7891 * buildbot/clients/base.py: switch to pb.Cacheable-style Events
7892 * buildbot/clients/gtkPanes.py: ditto
7894 * buildbot/process/step_twisted.py (RunUnitTests): use randomly=
7895 arg to collapse RunUnitTestsRandomly into RunUnitTests
7896 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
7897 use RunUnitTests(randomly=1) instead of RunUnitTestsRandomly
7899 * buildbot/status/html.py (StatusResource): shuffle Resources
7900 around to fix a bug: both 'http://foo:8080' and 'http://foo:8080/'
7901 would serve the waterfall display, but the internal links were
7902 only valid on the trailing-slash version. The correct behavior is
7903 for the non-slashed one to serve a Redirect to the slashed one.
7904 This only shows up when the buildbot page is hanging off another
7905 server, like a Twisted-Web distributed server.
7907 * buildbot/status/event.py (Event, RemoteEvent): make Events
7908 pb.Cacheable, with RemoteEvent as the cached version. This removes
7909 a lot of explicit send-an-update code.
7910 * buildbot/status/builder.py (Builder): remove send-update code
7911 * buildbot/status/client.py (ClientBuilder): remove send-update
7912 code, and log errors that occur during callRemote (mostly to catch
7913 InsecureJelly exceptions)
7915 * buildbot/process/process_twisted.py (QuickTwistedBuildFactory):
7916 run Lore with the same python used in the rest of the build
7918 * buildbot/process/step_twisted2.py (RunUnitTestsJelly): moved
7920 * buildbot/process/step_twisted.py (HLint): accept 'python'
7921 argument. Catch rc!=0 and mark the step as failed. This marks the
7922 build orange ("has warnings").
7923 (RunUnitTestsJelly): move out to step_twisted2.py
7925 * buildbot/util.py (ignoreStaleRefs): add utility function
7927 * buildbot/master.py (DebugPerspective.perspective_setCurrentState):
7928 don't fake ETA object, it's too hard to get right
7930 2003-05-02 Brian Warner <warner@lothar.com>
7932 * docs/examples/twisted_master.py (twisted_app): add FreeBSD builder
7934 2003-05-01 Brian Warner <warner@lothar.com>
7936 * buildbot/status/html.py (StatusResource.body): oops, I was
7937 missing a <tr>, causing the waterfall page to be misrendered in
7938 everything except Galeon.
7940 2003-04-29 Brian Warner <warner@lothar.com>
7942 * docs/examples/twisted_master.py: make debuild use python-2.2
7943 explicitly, now that Twisted stopped supporting 2.1
7945 * buildbot/process/step_twisted.py (BuildDebs.finishStatus): oops,
7946 handle tuple results too. I keep forgetting this, which suggests
7947 it needs to be rethought.
7949 * setup.py (setup): bump version to 0.3.1+ while between releases
7951 2003-04-29 Brian Warner <warner@lothar.com>
7953 * setup.py: Releasing buildbot-0.3.1
7955 2003-04-29 Brian Warner <warner@lothar.com>
7957 * README (SUPPORT): add plea to send questions to the mailing list
7959 * NEWS, MANIFEST.in: add description of recent changes
7961 * docs/examples/twisted_master.py: add the code used to create the
7962 Twisted buildmaster, with passwords and such removed out to a
7965 * buildbot/changes/changes.py, freshcvs.py, freshcvsmail.py: split
7966 out cvstoys-using bits from generic changes.py, to allow non-cvstoys
7967 buildmasters to not require CVSToys be installed.
7968 * README, docs/examples/glib_master: update to match the change
7970 * buildbot/clients/base.py, buildbot/bot.py,
7971 buildbot/changes/changes.py, buildbot/pbutil.py: copy
7972 ReconnectingPB from CVSToys distribution to remove CVSToys
7973 dependency for build slaves and status clients. Buildmasters which
7974 use FreshCVSSources still require cvstoys be installed, of course.
7976 2003-04-25 Brian Warner <warner@lothar.com>
7978 * buildbot/process/process_twisted.py (FullTwistedBuildFactory): add
7979 runTestsRandomly arg to turn on trial -z
7981 * buildbot/process/step_twisted.py (TwistedJellyTestResults):
7982 experimental code to use trial's machine-parseable output to get
7983 more detailed test results. Still has some major issues.
7984 (RunUnitTestsRandomly): subclass to add "-z 0" option, runs tests
7987 * buildbot/status/builder.py (Builder.setCurrentBuild):
7988 anticipating moving build history into statusbag, not used yet
7990 * buildbot/status/tests.py: code to centralize test results,
7991 doesn't work quite yet
7993 * buildbot/status/event.py (Event): use hasattr("setName") instead
7994 of isinstance for now.. need better long-term solution
7996 * buildbot/status/html.py: Remove old imports
7998 2003-04-24 Brian Warner <warner@lothar.com>
8000 * buildbot/process/process_twisted.py (TwistedBuild.isFileImportant):
8001 ignore changes under doc/fun/ and sandbox/
8003 * buildbot/process/step_twisted.py: update pushEvent and friends.
8005 * buildbot/status/html.py (Box.td): replace event.buildername with
8006 event.parent.getSwappableName(). Needs more thought.
8008 * buildbot/status/builder.py (Builder): Replace pushEvent and
8009 getLastEvent with {set|update|addFileTo|finish}CurrentActivity.
8010 Tell events they are being pruned with event.delete().
8012 * buildbot/process/base.py (Build): Remove Builder status-handling
8013 methods. s/pushEvent/setCurrentActivity/.
8015 * buildbot/process/step.py (BuildStep): clean up status delivery.
8016 Gouse builder.statusbag methods instead of intermediate builder
8017 methods. s/updateLastEvent/updateCurrentActivity/.
8018 s/finalizeLastEvent/finishCurrentActivity/. Use
8019 addFileToCurrentActivity for summaryFunction.
8021 * buildbot/status/event.py (Logfile): put data in a Swappable when
8023 (Event): add more setter methods. Remove .buildername, use .parent
8024 and getSwappableName instead (needs more thought).
8026 * buildbot/util.py (Swappable):
8027 * test/test_swap.py: don't bother setting filename at __init__
8028 time, do it later. Change setFilename args to take parent first,
8029 since it provides the most significant part of the filename.
8031 2003-04-23 Brian Warner <warner@lothar.com>
8033 * buildbot/status/event.py (Logfile.addEntry): append to previous
8036 * buildbot/process/step.py (BuildStep.finalizeLastEvent):
8037 anticipating Swappable
8038 (InternalShellCommand.remoteUpdate): split out various log-adding
8039 methods so subclasses can snarf stdout separately
8041 * buildbot/process/base.py (Builder.finalizeLastEvent): more code
8042 in anticipation of Swappable build logs
8043 (Builder.testsFinished): anticipating TestResults, still disabled
8045 * buildbot/status/builder.py (Builder.pruneEvents): only keep the
8048 * buildbot/status/event.py (Logfile): add (disabled) support for
8049 Swappable, not ready for use yet
8051 * buildbot/util.py (Swappable): object which is swapped out to
8052 disk after some period of no use.
8053 * test/test_swap.py: test buildbot.utils.Swappable
8055 2003-04-14 Brian Warner <warner@lothar.com>
8057 * buildbot/process/base.py (Builder.doPeriodicBuild): add simple
8058 periodic-build timer. Set the .periodicBuildTime on a builder
8059 instance to some number of seconds to activate it.
8061 * buildbot/master.py (BotMaster.forceBuild): change forceBuild API
8063 * buildbot/process/step.py (ShellCommand.finishStatus): use log.msg in
8064 a way that survives result tuples
8066 2003-04-12 Brian Warner <warner@lothar.com>
8068 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8069 return a dict instead of a tuple: allow summarizers to provide
8070 multiple summaries if they want
8071 * buildbot/process/step_twisted.py (trialTextSummarizer): return dict
8072 (debuildSummarizer): summarize lintian warnings/errors
8074 2003-04-10 Brian Warner <warner@lothar.com>
8076 * README (REQUIREMENTS): slave requires twisted-1.0.4a2
8078 2003-04-09 Brian Warner <warner@lothar.com>
8080 * buildbot/process/step_twisted.py (trialTextSummarizer): Don't create
8081 empty summaries: happens when the tests fail so hard they don't emit
8082 a parseable summary line.
8084 * buildbot/process/step.py (ShellCommand.finishStatusSummary):
8085 Allow summaryFunction to return None to indicate no summary should
8088 * buildbot/status/event.py (Logfile.removeHtmlWatcher): avoid
8089 writing to stale HTTP requests: notice when they disconnect and
8090 remove the request from the list. Also add CacheToFile from
8091 moshez, will be used later.
8093 2003-04-08 Brian Warner <warner@lothar.com>
8095 * buildbot/process/step_twisted.py (ProcessDocs.finished): warnings
8096 should be an int, not a list of strings
8098 * buildbot/changes/changes.py (FreshCVSSource.stop): don't disconnect
8099 if we weren't actually connected
8101 * buildbot/process/step_twisted.py (trialTextSummarizer): function
8102 to show the tail end of the trial text output
8104 * buildbot/process/step.py (ShellCommand.finishStatusSummary): add
8105 hook to summarize the results of a ShellCommand
8107 2003-04-07 Brian Warner <warner@lothar.com>
8109 * buildbot/process/step_twisted.py (RunUnitTests): consolidate all
8110 twisted test suite code into a single class.
8111 * buildbot/process/process_twisted.py: same
8113 2003-04-04 Brian Warner <warner@lothar.com>
8115 * setup.py, MANIFEST.in: hack to make sure plugins.tml gets installed
8117 * README (SLAVE): document use of mktap to create slave .tap file
8118 (REQUIREMENTS): describe dependencies
8120 * buildbot/bb_tap.py, buildbot/plugins.tml:
8121 * buildbot/bot.py (updateApplication): Add mktap support for creating
8122 buildslave .tap files
8124 2003-03-28 Brian Warner <warner@lothar.com>
8126 * buildbot/process/step.py (InternalShellCommand.finished): handle
8127 new tuple result values (fix embarrasing bug that appeared during
8130 2003-03-27 Brian Warner <warner@lothar.com>
8132 * docs/examples/glib_master.py, README: add sample buildmaster.tap
8135 2003-03-25 Brian Warner <warner@lothar.com>
8137 * buildbot/process/step.py (CVS, ShellCommand): add reason for failure
8138 to overall build status
8139 * buildbot/clients/base.py (Builder): improve event printing
8140 * buildbot/process/base.py (BasicBuildFactory): use specific steps
8141 instead of generic ShellCommand
8142 (Build): Add .stopBuild, use it when slave is detached
8144 * buildbot/process/step.py (Configure,Test): give the steps their
8145 own names and status strings
8147 * buildbot/status/html.py (StatusResource): add "show" argument,
8148 lets you limit the set of Builders being displayed.
8150 2003-03-20 Brian Warner <warner@lothar.com>
8152 * buildbot/process/basic.py: removed
8154 2003-03-19 Brian Warner <warner@lothar.com>
8156 * buildbot/process/process_twisted.py (FullTwistedBuildFactory):
8157 turn off process-docs by default
8159 * buildbot/process/base.py (Builder.getBuildNumbered): Don't blow up
8160 when displaying build information without anything in allBuilds[]
8162 * buildbot/bot.py (makeApp): really take password from sys.argv
8164 2003-03-18 Brian Warner <warner@lothar.com>
8166 * buildbot/bot.py (buildApp): take password from sys.argv
8168 * README: replace with more useful text
8170 * setup.py: add a real one
8171 * MANIFEST.in, .cvsignore: more distutils packaging stuff
8173 * docs/PyCon-2003/: added sources for PyCon paper.
8175 * buildbot/process/base.py, step.py: revamp. BuildProcess is gone,
8176 now Build objects control the process and Builder only handles
8177 slave stuff and distribution of changes/status. A new BuildFactory
8178 class creates Build objects on demand.
8180 Created ConfigurableBuild which takes a list of steps to run. This
8181 makes it a lot easier to set up a new kind of build and moves us
8182 closer to being able to configure a build from a web page.
8184 * buildbot/process/step_twisted.py, process_twisted.py: move to
8185 new model. A lot of code went away.
8187 * buildbot/status/progress.py (BuildProgress.newProgress): Don't
8188 send lots of empty progress messages to the client.
8190 * buildbot/master.py (makeApp): enforce builder-name uniqueness
8192 2003-02-20 Brian Warner <warner@lothar.com>
8194 * buildbot/process/step_twisted.py (BuildDebs): count lintian hits
8196 * buildbot/slavecommand.py (ShellCommand): back to usePTY=0. The
8197 Twisted bug that prevented non-pty processes from working just got
8198 fixed, and the bug that leaks ptys is still being investigated.
8200 * buildbot/process/step.py (CVS): send timeout arg to slave
8202 * buildbot/clients/gtkPanes.py: add connection-status row, handle
8203 builders coming and going
8204 * buildbot/clients/base.py: clean up protocol, move to ReconnectingPB
8205 from CVSToys, handle lost-buildmaster
8207 * buildbot/status/client.py (StatusClientService.removeBuilder):
8208 Clean up status client protocol: send builders (with references)
8209 as they are created, rather than sending a list and requiring the
8210 client to figure out which ones are new.
8211 * buildbot/master.py (BotMaster.forceBuild): Log debugclient
8212 attempts to force a build on an unknown builder
8214 2003-02-19 Brian Warner <warner@lothar.com>
8216 * buildbot/slavecommand.py (CVSCommand): add timeout to sub-commands
8217 * buildbot/slavecommand.py (ShellCommand.start): stop using PTYs until
8218 Twisted stops leaking them.
8219 * buildbot/clients/gtkPanes.py (CompactBuilder): forget ETA when the
8220 builder goes to an idle state.
8222 * buildbot/slavecommand.py (ShellCommand.start): bring back PTYs until
8223 I figure out why CVS commands hang without them, and/or I fix the
8224 hung-command timeout
8226 2003-02-16 Brian Warner <warner@lothar.com>
8228 * buildbot/process/step_twisted.py: bin/hlint went away, replace
8229 with 'bin/lore --output lint'. Use 'bin/trial -o' to remove
8230 ansi-color markup. Remove GenerateLore step. Count hlint warnings in
8231 GenerateDocs now that they are prefixed with WARNING:.
8233 * buildbot/status/html.py (StatusResource.body): Fix Builder link,
8234 use manual href target instead of request.childLink
8236 * buildbot/clients/gtkPanes.py: Fix progress countdown: update the
8237 display every second, but update the ETA every 5 seconds (or
8238 whenever) as remote_progress messages arrive.
8241 2003-02-12 Brian Warner <warner@lothar.com>
8243 * *: import current sources from home CVS repository
8247 # add-log-time-format: add-log-iso8601-time-string