| commit | e363f6ba095a646dd6634939a43b0db17f34577f | |
| author | Qu Wenruo <quwenruo@cn.fujitsu.com> | |
| Fri, 19 Dec 2014 06:13:09 +0000 (19 14:13 +0800) | ||
| committer | David Sterba <dsterba@suse.cz> | |
| Fri, 19 Dec 2014 14:04:50 +0000 (19 15:04 +0100) | ||
| tree | c4b3b619a6875b5db0e696ab4ce174d6fdc56df4 | treesnapshot (tar.gz zip) |
| parent | 040b3f11ba6b5555d793a9ef79ed4d9032d22370 | commitdiff |
btrfs-progs: Fix a clang dead-judgement warning in disk-io.c.
When compiled with clang, the following warning is outputted.
disk-io.c:1017:15: warning: comparison of unsigned expression < 0 is
always false [-Wtautological-compare]
if (dev_size < 0)
~~~~~~~~ ^ ~
1 warning generated.
This is because dev_size is defined as unsigned type, but lseek() will
return singed valued.
So the judgement will always to false.
Use temporary off_t return value to solve it.
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
When compiled with clang, the following warning is outputted.
disk-io.c:1017:15: warning: comparison of unsigned expression < 0 is
always false [-Wtautological-compare]
if (dev_size < 0)
~~~~~~~~ ^ ~
1 warning generated.
This is because dev_size is defined as unsigned type, but lseek() will
return singed valued.
So the judgement will always to false.
Use temporary off_t return value to solve it.
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
| disk-io.c | diffblobblamehistory |