From ce0ccbea81e3db32904502d9e2566ab27ed5ff00 Mon Sep 17 00:00:00 2001 From: Timur Iskhodzhanov Date: Wed, 18 Dec 2013 14:17:39 +0000 Subject: [PATCH] [Sanitizers] Rename Symbolizer::SymbolizeCode to Symbolizer::SymbolizePC git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@197569 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/lsan/lsan_common.cc | 2 +- lib/sanitizer_common/sanitizer_common.cc | 2 +- lib/sanitizer_common/sanitizer_stacktrace.cc | 2 +- lib/sanitizer_common/sanitizer_symbolizer.h | 3 +-- lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc | 2 +- lib/tsan/rtl/tsan_symbolize.cc | 2 +- lib/ubsan/ubsan_diag.cc | 2 +- 7 files changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/lsan/lsan_common.cc b/lib/lsan/lsan_common.cc index 732bdc7ab..f29897cd6 100644 --- a/lib/lsan/lsan_common.cc +++ b/lib/lsan/lsan_common.cc @@ -480,7 +480,7 @@ static Suppression *GetSuppressionForAddr(uptr addr) { static const uptr kMaxAddrFrames = 16; InternalScopedBuffer addr_frames(kMaxAddrFrames); for (uptr i = 0; i < kMaxAddrFrames; i++) new (&addr_frames[i]) AddressInfo(); - uptr addr_frames_num = Symbolizer::Get()->SymbolizeCode( + uptr addr_frames_num = Symbolizer::Get()->SymbolizePC( addr, addr_frames.data(), kMaxAddrFrames); for (uptr i = 0; i < addr_frames_num; i++) { Suppression* s; diff --git a/lib/sanitizer_common/sanitizer_common.cc b/lib/sanitizer_common/sanitizer_common.cc index c156989d9..77ffda34a 100644 --- a/lib/sanitizer_common/sanitizer_common.cc +++ b/lib/sanitizer_common/sanitizer_common.cc @@ -206,7 +206,7 @@ void ReportErrorSummary(const char *error_type, StackTrace *stack) { // Currently, we include the first stack frame into the report summary. // Maybe sometimes we need to choose another frame (e.g. skip memcpy/etc). uptr pc = StackTrace::GetPreviousInstructionPc(stack->trace[0]); - Symbolizer::Get()->SymbolizeCode(pc, &ai, 1); + Symbolizer::Get()->SymbolizePC(pc, &ai, 1); } #endif ReportErrorSummary(error_type, ai.file, ai.line, ai.function); diff --git a/lib/sanitizer_common/sanitizer_stacktrace.cc b/lib/sanitizer_common/sanitizer_stacktrace.cc index 7697ff9bb..c6c3c69f6 100644 --- a/lib/sanitizer_common/sanitizer_stacktrace.cc +++ b/lib/sanitizer_common/sanitizer_stacktrace.cc @@ -72,7 +72,7 @@ void StackTrace::PrintStack(const uptr *addr, uptr size, // Use our own (online) symbolizer, if necessary. if (Symbolizer *sym = Symbolizer::GetOrNull()) addr_frames_num = - sym->SymbolizeCode(pc, addr_frames.data(), addr_frames.size()); + sym->SymbolizePC(pc, addr_frames.data(), addr_frames.size()); for (uptr j = 0; j < addr_frames_num; j++) { AddressInfo &info = addr_frames[j]; frame_desc.clear(); diff --git a/lib/sanitizer_common/sanitizer_symbolizer.h b/lib/sanitizer_common/sanitizer_symbolizer.h index f2e8f4475..4271fa67f 100644 --- a/lib/sanitizer_common/sanitizer_symbolizer.h +++ b/lib/sanitizer_common/sanitizer_symbolizer.h @@ -82,8 +82,7 @@ class Symbolizer { // Fills at most "max_frames" elements of "frames" with descriptions // for a given address (in all inlined functions). Returns the number // of descriptions actually filled. - virtual uptr SymbolizeCode(uptr address, AddressInfo *frames, - uptr max_frames) { + virtual uptr SymbolizePC(uptr address, AddressInfo *frames, uptr max_frames) { return 0; } virtual bool SymbolizeData(uptr address, DataInfo *info) { diff --git a/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc b/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc index 69c62a644..f2840f65e 100644 --- a/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc +++ b/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc @@ -391,7 +391,7 @@ class POSIXSymbolizer : public Symbolizer { external_symbolizer_(external_symbolizer), internal_symbolizer_(internal_symbolizer) {} - uptr SymbolizeCode(uptr addr, AddressInfo *frames, uptr max_frames) { + uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) { BlockingMutexLock l(&mu_); if (max_frames == 0) return 0; diff --git a/lib/tsan/rtl/tsan_symbolize.cc b/lib/tsan/rtl/tsan_symbolize.cc index 75acf1d84..97163da6b 100644 --- a/lib/tsan/rtl/tsan_symbolize.cc +++ b/lib/tsan/rtl/tsan_symbolize.cc @@ -111,7 +111,7 @@ ReportStack *SymbolizeCode(uptr addr) { InternalScopedBuffer addr_frames(kMaxAddrFrames); for (uptr i = 0; i < kMaxAddrFrames; i++) new(&addr_frames[i]) AddressInfo(); - uptr addr_frames_num = Symbolizer::Get()->SymbolizeCode( + uptr addr_frames_num = Symbolizer::Get()->SymbolizePC( addr, addr_frames.data(), kMaxAddrFrames); if (addr_frames_num == 0) return NewReportStackEntry(addr); diff --git a/lib/ubsan/ubsan_diag.cc b/lib/ubsan/ubsan_diag.cc index fa643658e..4e5380bd6 100644 --- a/lib/ubsan/ubsan_diag.cc +++ b/lib/ubsan/ubsan_diag.cc @@ -34,7 +34,7 @@ Location __ubsan::getFunctionLocation(uptr Loc, const char **FName) { return Location(); AddressInfo Info; - if (!Symbolizer::GetOrInit()->SymbolizeCode(Loc, &Info, 1) || + if (!Symbolizer::GetOrInit()->SymbolizePC(Loc, &Info, 1) || !Info.module || !*Info.module) return Location(Loc); -- 2.11.4.GIT